From be30b3e96eb760bc0a04fff1a4e47e82487ac2f6 Mon Sep 17 00:00:00 2001 From: Cole Faust <colefaust@google.com> Date: Thu, 25 Jan 2024 02:41:58 +0000 Subject: [PATCH] Baseline NewApi issues NewApi is a lint check that you don't call framework methods that were introduced in versions later than your min_sdk_version. We want to make this an error, so we're baselineing all existing issues. This cl was generated automatically, by taking all the NewApi issues from the reference baselines, and all the non-NewApi issues from the existing checked in baselines. Bug: 268261262 Test: Presubmits (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4ecdedda379e4e9040eb87b01dc3d8efb89be810) Merged-In: I0393f24f101876abc458ca139eefdb279dcb2b03 Change-Id: I0393f24f101876abc458ca139eefdb279dcb2b03 --- Tethering/Android.bp | 9 +- Tethering/lint-baseline.xml | 4 +- framework/Android.bp | 12 - framework/lint-baseline.xml | 327 +++++++------ nearby/service/lint-baseline.xml | 4 +- service-t/Android.bp | 2 +- service-t/lint-baseline.xml | 255 ++++++---- service/Android.bp | 15 +- service/lint-baseline.xml | 795 ++++++++++++++++++++++--------- 9 files changed, 925 insertions(+), 498 deletions(-) diff --git a/Tethering/Android.bp b/Tethering/Android.bp index 73c11baae1..c30e25103d 100644 --- a/Tethering/Android.bp +++ b/Tethering/Android.bp @@ -104,6 +104,7 @@ android_library { lint: { strict_updatability_linting: true, baseline_filename: "lint-baseline.xml", + }, } @@ -122,6 +123,7 @@ android_library { lint: { strict_updatability_linting: true, baseline_filename: "lint-baseline.xml", + }, } @@ -215,7 +217,7 @@ android_app { apex_available: ["com.android.tethering"], lint: { strict_updatability_linting: true, - baseline_filename: "lint-baseline.xml", + }, } @@ -235,7 +237,7 @@ android_app { lint: { strict_updatability_linting: true, error_checks: ["NewApi"], - baseline_filename: "lint-baseline.xml", + }, } @@ -263,9 +265,6 @@ java_library_static { static_libs: ["tetheringprotos"], apex_available: ["com.android.tethering"], min_sdk_version: "30", - lint: { - baseline_filename: "lint-baseline.xml", - }, } genrule { diff --git a/Tethering/lint-baseline.xml b/Tethering/lint-baseline.xml index 37511c682e..4f92c9c2d4 100644 --- a/Tethering/lint-baseline.xml +++ b/Tethering/lint-baseline.xml @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<issues format="6" by="lint 8.0.0-dev" type="baseline" dependencies="true" variant="all" version="8.0.0-dev"> +<issues format="6" by="lint 8.4.0-alpha01" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha01"> <issue id="NewApi" @@ -8,7 +8,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/Tethering/src/com/android/networkstack/tethering/OffloadController.java" - line="293" + line="283" column="44"/> </issue> diff --git a/framework/Android.bp b/framework/Android.bp index 432cabf992..b7ff04fec1 100644 --- a/framework/Android.bp +++ b/framework/Android.bp @@ -139,9 +139,6 @@ java_library { "framework-wifi.stubs.module_lib", ], visibility: ["//packages/modules/Connectivity:__subpackages__"], - lint: { - baseline_filename: "lint-baseline.xml", - }, } java_defaults { @@ -259,9 +256,6 @@ java_library { apex_available: [ "com.android.tethering", ], - lint: { - baseline_filename: "lint-baseline.xml", - }, } java_genrule { @@ -322,9 +316,6 @@ droidstubs { java_library { name: "framework-connectivity-module-api-stubs-including-flagged", srcs: [":framework-connectivity-module-api-stubs-including-flagged-droidstubs"], - lint: { - baseline_filename: "lint-baseline.xml", - }, } // Library providing limited APIs within the connectivity module, so that R+ components like @@ -349,7 +340,4 @@ java_library { visibility: [ "//packages/modules/Connectivity/Tethering:__subpackages__", ], - lint: { - baseline_filename: "lint-baseline.xml", - }, } diff --git a/framework/lint-baseline.xml b/framework/lint-baseline.xml index f68aad734e..2c0b15fd32 100644 --- a/framework/lint-baseline.xml +++ b/framework/lint-baseline.xml @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<issues format="6" by="lint 8.0.0-dev" type="baseline" dependencies="true" variant="all" version="8.0.0-dev"> +<issues format="6" by="lint 8.4.0-alpha01" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha01"> <issue id="NewApi" @@ -8,63 +8,30 @@ errorLine2=" ~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/framework/src/android/net/ConnectivityManager.java" - line="2456" + line="2490" column="71"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.Proxy#setHttpProxyConfiguration`" - errorLine1=" Proxy.setHttpProxyConfiguration(getInstance().getDefaultProxy());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.provider.Settings#checkAndNoteWriteSettingsOperation`" + errorLine1=" return Settings.checkAndNoteWriteSettingsOperation(context, uid, callingPackage," + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/framework/src/android/net/ConnectivityManager.java" - line="5323" - column="23"/> - </issue> - - <issue - id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.Build#isDebuggable`" - errorLine1=" if (!Build.isDebuggable()) {" - errorLine2=" ~~~~~~~~~~~~"> - <location - file="packages/modules/Connectivity/framework/src/android/net/ConnectivitySettingsManager.java" - line="1072" - column="24"/> - </issue> - - <issue - id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.UserHandle#getUid`" - errorLine1=" final int end = nextUser.getUid(0 /* appId */) - 1;" - errorLine2=" ~~~~~~"> - <location - file="packages/modules/Connectivity/framework/src/android/net/UidRange.java" - line="50" - column="34"/> - </issue> - - <issue - id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.UserHandle#getUid`" - errorLine1=" final int start = user.getUid(0 /* appId */);" - errorLine2=" ~~~~~~"> - <location - file="packages/modules/Connectivity/framework/src/android/net/UidRange.java" - line="49" - column="32"/> + line="2853" + column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.provider.Settings#checkAndNoteWriteSettingsOperation`" - errorLine1=" return Settings.checkAndNoteWriteSettingsOperation(context, uid, callingPackage," - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.Proxy#setHttpProxyConfiguration`" + errorLine1=" Proxy.setHttpProxyConfiguration(getInstance().getDefaultProxy());" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/framework/src/android/net/ConnectivityManager.java" - line="2799" - column="25"/> + line="5422" + column="23"/> </issue> <issue @@ -74,139 +41,117 @@ errorLine2=" ~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/framework/src/android/net/ConnectivityManager.java" - line="5329" + line="5428" column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `java.net.InetAddress#getAllByNameOnNet`" - errorLine1=" return InetAddress.getAllByNameOnNet(host, getNetIdForResolv());" - errorLine2=" ~~~~~~~~~~~~~~~~~"> - <location - file="packages/modules/Connectivity/framework/src/android/net/Network.java" - line="145" - column="28"/> - </issue> - - <issue - id="NewApi" - message="Call requires API level 31 (current min is 30): `java.net.InetAddress#getByNameOnNet`" - errorLine1=" return InetAddress.getByNameOnNet(host, getNetIdForResolv());" - errorLine2=" ~~~~~~~~~~~~~~"> - <location - file="packages/modules/Connectivity/framework/src/android/net/Network.java" - line="158" - column="28"/> - </issue> - - <issue - id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(is);" - errorLine2=" ~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `libcore.net.event.NetworkEventDispatcher#dispatchNetworkConfigurationChange`" + errorLine1=" NetworkEventDispatcher.getInstance().dispatchNetworkConfigurationChange();" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="frameworks/base/core/java/com/android/internal/util/FileRotator.java" - line="168" - column="33"/> + file="packages/modules/Connectivity/framework/src/android/net/ConnectivityManager.java" + line="5431" + column="50"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" if (failed) IoUtils.closeQuietly(socket);" - errorLine2=" ~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `libcore.net.event.NetworkEventDispatcher#getInstance`" + errorLine1=" NetworkEventDispatcher.getInstance().dispatchNetworkConfigurationChange();" + errorLine2=" ~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/Network.java" - line="216" - column="45"/> + file="packages/modules/Connectivity/framework/src/android/net/ConnectivityManager.java" + line="5431" + column="36"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" if (failed) IoUtils.closeQuietly(socket);" - errorLine2=" ~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.os.Build#isDebuggable`" + errorLine1=" if (!Build.isDebuggable()) {" + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/Network.java" - line="241" - column="37"/> + file="packages/modules/Connectivity/framework/src/android/net/ConnectivitySettingsManager.java" + line="1095" + column="24"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" if (failed) IoUtils.closeQuietly(socket);" - errorLine2=" ~~~~~~~~~~~~"> + message="Field requires API level 31 (current min is 30): `android.system.OsConstants#ENONET`" + errorLine1=' new DnsException(ERROR_SYSTEM, new ErrnoException("resNetworkQuery", ENONET))));' + errorLine2=" ~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/Network.java" - line="254" - column="37"/> + file="packages/modules/Connectivity/framework/src/android/net/DnsResolver.java" + line="367" + column="90"/> </issue> <issue id="NewApi" message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" if (failed) IoUtils.closeQuietly(socket);" - errorLine2=" ~~~~~~~~~~~~"> + errorLine1=" IoUtils.closeQuietly(socket);" + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/Network.java" - line="272" - column="37"/> + file="packages/modules/Connectivity/framework/src/android/net/util/DnsUtils.java" + line="181" + column="21"/> </issue> <issue id="NewApi" message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(bis);" + errorLine1=" IoUtils.closeQuietly(socket);" errorLine2=" ~~~~~~~~~~~~"> <location - file="frameworks/base/core/java/com/android/internal/util/FileRotator.java" - line="391" + file="packages/modules/Connectivity/framework/src/android/net/util/DnsUtils.java" + line="373" column="21"/> </issue> <issue id="NewApi" message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(bos);" - errorLine2=" ~~~~~~~~~~~~"> + errorLine1=" IoUtils.closeQuietly(is);" + errorLine2=" ~~~~~~~~~~~~"> <location file="frameworks/base/core/java/com/android/internal/util/FileRotator.java" - line="406" - column="21"/> + line="171" + column="33"/> </issue> <issue id="NewApi" message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(socket);" + errorLine1=" IoUtils.closeQuietly(zos);" errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/util/DnsUtils.java" - line="181" + file="frameworks/base/core/java/com/android/internal/util/FileRotator.java" + line="178" column="21"/> </issue> <issue id="NewApi" message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(socket);" + errorLine1=" IoUtils.closeQuietly(bis);" errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/util/DnsUtils.java" - line="373" + file="frameworks/base/core/java/com/android/internal/util/FileRotator.java" + line="401" column="21"/> </issue> <issue id="NewApi" message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(zos);" + errorLine1=" IoUtils.closeQuietly(bos);" errorLine2=" ~~~~~~~~~~~~"> <location file="frameworks/base/core/java/com/android/internal/util/FileRotator.java" - line="175" + line="416" column="21"/> </issue> @@ -234,48 +179,81 @@ <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.net.event.NetworkEventDispatcher#dispatchNetworkConfigurationChange`" - errorLine1=" NetworkEventDispatcher.getInstance().dispatchNetworkConfigurationChange();" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `java.net.InetAddress#getAllByNameOnNet`" + errorLine1=" return InetAddress.getAllByNameOnNet(host, getNetIdForResolv());" + errorLine2=" ~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/ConnectivityManager.java" - line="5332" - column="50"/> + file="packages/modules/Connectivity/framework/src/android/net/Network.java" + line="145" + column="28"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.net.event.NetworkEventDispatcher#getInstance`" - errorLine1=" NetworkEventDispatcher.getInstance().dispatchNetworkConfigurationChange();" - errorLine2=" ~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `java.net.InetAddress#getByNameOnNet`" + errorLine1=" return InetAddress.getByNameOnNet(host, getNetIdForResolv());" + errorLine2=" ~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/ConnectivityManager.java" - line="5332" - column="36"/> + file="packages/modules/Connectivity/framework/src/android/net/Network.java" + line="158" + column="28"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.net.http.HttpURLConnectionFactory#createInstance`" - errorLine1=" HttpURLConnectionFactory urlConnectionFactory = HttpURLConnectionFactory.createInstance();" - errorLine2=" ~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" + errorLine1=" if (failed) IoUtils.closeQuietly(socket);" + errorLine2=" ~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/framework/src/android/net/Network.java" - line="302" - column="82"/> + line="216" + column="45"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.net.http.HttpURLConnectionFactory#openConnection`" - errorLine1=" return urlConnectionFactory.openConnection(url, socketFactory, proxy);" - errorLine2=" ~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" + errorLine1=" if (failed) IoUtils.closeQuietly(socket);" + errorLine2=" ~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/framework/src/android/net/Network.java" - line="372" + line="241" + column="37"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" + errorLine1=" if (failed) IoUtils.closeQuietly(socket);" + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/framework/src/android/net/Network.java" + line="254" column="37"/> </issue> + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" + errorLine1=" if (failed) IoUtils.closeQuietly(socket);" + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/framework/src/android/net/Network.java" + line="272" + column="37"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `libcore.net.http.HttpURLConnectionFactory#createInstance`" + errorLine1=" HttpURLConnectionFactory urlConnectionFactory = HttpURLConnectionFactory.createInstance();" + errorLine2=" ~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/framework/src/android/net/Network.java" + line="302" + column="82"/> + </issue> + <issue id="NewApi" message="Call requires API level 31 (current min is 30): `libcore.net.http.HttpURLConnectionFactory#setDns`" @@ -300,24 +278,24 @@ <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `new android.net.EthernetNetworkSpecifier`" - errorLine1=" return setNetworkSpecifier(new EthernetNetworkSpecifier(networkSpecifier));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `libcore.net.http.HttpURLConnectionFactory#openConnection`" + errorLine1=" return urlConnectionFactory.openConnection(url, socketFactory, proxy);" + errorLine2=" ~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/NetworkRequest.java" - line="525" - column="48"/> + file="packages/modules/Connectivity/framework/src/android/net/Network.java" + line="372" + column="37"/> </issue> <issue id="NewApi" - message="Cast from `EthernetNetworkSpecifier` to `NetworkSpecifier` requires API level 31 (current min is 30)" - errorLine1=" return setNetworkSpecifier(new EthernetNetworkSpecifier(networkSpecifier));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Class requires API level 31 (current min is 30): `android.telephony.data.EpsBearerQosSessionAttributes`" + errorLine1=" if (attributes instanceof EpsBearerQosSessionAttributes) {" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/NetworkRequest.java" - line="525" - column="48"/> + file="packages/modules/Connectivity/framework/src/android/net/NetworkAgent.java" + line="1462" + column="35"/> </issue> <issue @@ -327,19 +305,19 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/framework/src/android/net/NetworkAgent.java" - line="1421" + line="1465" column="22"/> </issue> <issue id="NewApi" - message="Class requires API level 31 (current min is 30): `android.telephony.data.EpsBearerQosSessionAttributes`" - errorLine1=" if (attributes instanceof EpsBearerQosSessionAttributes) {" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Class requires API level 31 (current min is 30): `android.telephony.data.NrQosSessionAttributes`" + errorLine1=" } else if (attributes instanceof NrQosSessionAttributes) {" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/framework/src/android/net/NetworkAgent.java" - line="1418" - column="35"/> + line="1466" + column="42"/> </issue> <issue @@ -349,19 +327,52 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/framework/src/android/net/NetworkAgent.java" - line="1425" + line="1469" column="22"/> </issue> <issue id="NewApi" - message="Class requires API level 31 (current min is 30): `android.telephony.data.NrQosSessionAttributes`" - errorLine1=" } else if (attributes instanceof NrQosSessionAttributes) {" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `new android.net.EthernetNetworkSpecifier`" + errorLine1=" return setNetworkSpecifier(new EthernetNetworkSpecifier(networkSpecifier));" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/framework/src/android/net/NetworkAgent.java" - line="1422" - column="42"/> + file="packages/modules/Connectivity/framework/src/android/net/NetworkRequest.java" + line="553" + column="48"/> + </issue> + + <issue + id="NewApi" + message="Cast from `EthernetNetworkSpecifier` to `NetworkSpecifier` requires API level 31 (current min is 30)" + errorLine1=" return setNetworkSpecifier(new EthernetNetworkSpecifier(networkSpecifier));" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/framework/src/android/net/NetworkRequest.java" + line="553" + column="48"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.os.UserHandle#getUid`" + errorLine1=" final int start = user.getUid(0 /* appId */);" + errorLine2=" ~~~~~~"> + <location + file="packages/modules/Connectivity/framework/src/android/net/UidRange.java" + line="49" + column="32"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.os.UserHandle#getUid`" + errorLine1=" final int end = nextUser.getUid(0 /* appId */) - 1;" + errorLine2=" ~~~~~~"> + <location + file="packages/modules/Connectivity/framework/src/android/net/UidRange.java" + line="50" + column="34"/> </issue> </issues> \ No newline at end of file diff --git a/nearby/service/lint-baseline.xml b/nearby/service/lint-baseline.xml index a4761abb61..3477594c70 100644 --- a/nearby/service/lint-baseline.xml +++ b/nearby/service/lint-baseline.xml @@ -1,5 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<issues format="6" by="lint 8.0.0-dev" type="baseline" dependencies="true" variant="all" version="8.0.0-dev"> +<issues format="6" by="lint 8.4.0-alpha01" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha01"> <issue id="NewApi" @@ -8,7 +8,7 @@ errorLine2=" ~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/nearby/service/java/com/android/server/nearby/provider/ChreCommunication.java" - line="263" + line="289" column="54"/> </issue> diff --git a/service-t/Android.bp b/service-t/Android.bp index de879f303e..78c7d35531 100644 --- a/service-t/Android.bp +++ b/service-t/Android.bp @@ -98,7 +98,7 @@ java_library { min_sdk_version: "21", lint: { error_checks: ["NewApi"], - baseline_filename: "lint-baseline.xml", + }, srcs: [ "src/com/android/server/connectivity/mdns/**/*.java", diff --git a/service-t/lint-baseline.xml b/service-t/lint-baseline.xml index 38d3ab0ce9..7f05b8c657 100644 --- a/service-t/lint-baseline.xml +++ b/service-t/lint-baseline.xml @@ -1,59 +1,92 @@ <?xml version="1.0" encoding="UTF-8"?> -<issues format="6" by="lint 8.0.0-dev" type="baseline" dependencies="true" variant="all" version="8.0.0-dev"> +<issues format="6" by="lint 8.4.0-alpha01" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha01"> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.EthernetNetworkSpecifier#getInterfaceName`" - errorLine1=" if (!((EthernetNetworkSpecifier) spec).getInterfaceName().matches(iface)) {" - errorLine2=" ~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `BpfMap`" + errorLine1=" return new BpfMap<>(IFACE_INDEX_NAME_MAP_PATH, BpfMap.BPF_F_RDWR," + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service-t/src/com/android/server/net/BpfInterfaceMapUpdater.java" + line="69" + column="24"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `new android.net.EthernetNetworkSpecifier`" + errorLine1=" .setNetworkSpecifier(new EthernetNetworkSpecifier(ifaceName))" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetNetworkFactory.java" + line="156" + column="38"/> + </issue> + + <issue + id="NewApi" + message="Cast from `EthernetNetworkSpecifier` to `NetworkSpecifier` requires API level 31 (current min is 30)" + errorLine1=" .setNetworkSpecifier(new EthernetNetworkSpecifier(ifaceName))" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetNetworkFactory.java" + line="156" + column="38"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `new android.net.EthernetNetworkSpecifier`" + errorLine1=" nc.setNetworkSpecifier(new EthernetNetworkSpecifier(iface));" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetServiceImpl.java" - line="224" - column="48"/> + line="218" + column="36"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.UnderlyingNetworkInfo#getInterface`" - errorLine1=" delta.migrateTun(info.getOwnerUid(), info.getInterface()," - errorLine2=" ~~~~~~~~~~~~"> + message="Cast from `EthernetNetworkSpecifier` to `NetworkSpecifier` requires API level 31 (current min is 30)" + errorLine1=" nc.setNetworkSpecifier(new EthernetNetworkSpecifier(iface));" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsFactory.java" - line="276" - column="55"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetServiceImpl.java" + line="218" + column="36"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.UnderlyingNetworkInfo#getOwnerUid`" - errorLine1=" delta.migrateTun(info.getOwnerUid(), info.getInterface()," - errorLine2=" ~~~~~~~~~~~"> + message="Class requires API level 31 (current min is 30): `android.net.EthernetNetworkSpecifier`" + errorLine1=" if (!(spec instanceof EthernetNetworkSpecifier)) {" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsFactory.java" - line="276" - column="35"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetServiceImpl.java" + line="221" + column="31"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.UnderlyingNetworkInfo#getUnderlyingInterfaces`" - errorLine1=" info.getUnderlyingInterfaces());" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.EthernetNetworkSpecifier#getInterfaceName`" + errorLine1=" if (!((EthernetNetworkSpecifier) spec).getInterfaceName().matches(iface)) {" + errorLine2=" ~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsFactory.java" - line="277" - column="26"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetServiceImpl.java" + line="224" + column="48"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `java.net.InetAddress#parseNumericAddress`" - errorLine1=" dnsAddresses.add(InetAddress.parseNumericAddress(address));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~"> + message="Class requires API level 31 (current min is 30): `android.net.EthernetNetworkSpecifier`" + errorLine1=" if (!((EthernetNetworkSpecifier) spec).getInterfaceName().matches(iface)) {" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetTracker.java" - line="875" - column="54"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetServiceImpl.java" + line="224" + column="16"/> </issue> <issue @@ -63,19 +96,30 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetTracker.java" - line="870" + line="885" column="66"/> </issue> + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `java.net.InetAddress#parseNumericAddress`" + errorLine1=" dnsAddresses.add(InetAddress.parseNumericAddress(address));" + errorLine2=" ~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetTracker.java" + line="890" + column="54"/> + </issue> + <issue id="NewApi" message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(os);" - errorLine2=" ~~~~~~~~~~~~"> + errorLine1=" IoUtils.closeQuietly(mSocket);" + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsRecorder.java" - line="556" - column="25"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/IpSecService.java" + line="1042" + column="21"/> </issue> <issue @@ -85,107 +129,140 @@ errorLine2=" ~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service-t/src/com/android/server/IpSecService.java" - line="1309" + line="1318" column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(mSocket);" - errorLine2=" ~~~~~~~~~~~~"> + message="Field requires API level 31 (current min is 30): `android.system.OsConstants#UDP_ENCAP`" + errorLine1=" OsConstants.UDP_ENCAP," + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service-t/src/com/android/server/IpSecService.java" - line="1034" + line="1326" column="21"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `new android.net.EthernetNetworkSpecifier`" - errorLine1=" .setNetworkSpecifier(new EthernetNetworkSpecifier(ifaceName))" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Field requires API level 31 (current min is 30): `android.system.OsConstants#UDP_ENCAP_ESPINUDP`" + errorLine1=" OsConstants.UDP_ENCAP_ESPINUDP);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetNetworkFactory.java" - line="156" - column="38"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/IpSecService.java" + line="1327" + column="21"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `new android.net.EthernetNetworkSpecifier`" - errorLine1=" nc.setNetworkSpecifier(new EthernetNetworkSpecifier(iface));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `BpfNetMaps`" + errorLine1=" return new BpfNetMaps(ctx);" + errorLine2=" ~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetServiceImpl.java" - line="218" - column="36"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsFactory.java" + line="111" + column="20"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `new android.util.AtomicFile`" - errorLine1=" mFile = new AtomicFile(new File(path), logger);" - errorLine2=" ~~~~~~~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `swapActiveStatsMap`" + errorLine1=" mBpfNetMaps.swapActiveStatsMap();" + errorLine2=" ~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/net/PersistentInt.java" - line="53" - column="17"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsFactory.java" + line="185" + column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `new java.net.InetSocketAddress`" - errorLine1=" super(handler, new RecvBuffer(buffer, new InetSocketAddress()));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.UnderlyingNetworkInfo#getInterface`" + errorLine1=" delta.migrateTun(info.getOwnerUid(), info.getInterface()," + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/connectivity/mdns/MulticastPacketReader.java" - line="66" - column="47"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsFactory.java" + line="240" + column="55"/> </issue> <issue id="NewApi" - message="Cast from `EthernetNetworkSpecifier` to `NetworkSpecifier` requires API level 31 (current min is 30)" - errorLine1=" .setNetworkSpecifier(new EthernetNetworkSpecifier(ifaceName))" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.UnderlyingNetworkInfo#getOwnerUid`" + errorLine1=" delta.migrateTun(info.getOwnerUid(), info.getInterface()," + errorLine2=" ~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetNetworkFactory.java" - line="156" - column="38"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsFactory.java" + line="240" + column="35"/> </issue> <issue id="NewApi" - message="Cast from `EthernetNetworkSpecifier` to `NetworkSpecifier` requires API level 31 (current min is 30)" - errorLine1=" nc.setNetworkSpecifier(new EthernetNetworkSpecifier(iface));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.UnderlyingNetworkInfo#getUnderlyingInterfaces`" + errorLine1=" info.getUnderlyingInterfaces());" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetServiceImpl.java" - line="218" - column="36"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsFactory.java" + line="241" + column="26"/> </issue> <issue id="NewApi" - message="Class requires API level 31 (current min is 30): `android.net.EthernetNetworkSpecifier`" - errorLine1=" if (!((EthernetNetworkSpecifier) spec).getInterfaceName().matches(iface)) {" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" + errorLine1=" IoUtils.closeQuietly(os);" + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetServiceImpl.java" - line="224" - column="16"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsRecorder.java" + line="580" + column="25"/> </issue> <issue id="NewApi" - message="Class requires API level 31 (current min is 30): `android.net.EthernetNetworkSpecifier`" - errorLine1=" if (!(spec instanceof EthernetNetworkSpecifier)) {" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 35 (current min is 34): `newInstance`" + errorLine1=" opts = BroadcastOptionsShimImpl.newInstance(" + errorLine2=" ~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service-t/src/com/android/server/ethernet/EthernetServiceImpl.java" - line="221" - column="31"/> + file="packages/modules/Connectivity/service-t/src/com/android/server/net/NetworkStatsService.java" + line="562" + column="61"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `new android.util.AtomicFile`" + errorLine1=" mFile = new AtomicFile(new File(path), logger);" + errorLine2=" ~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service-t/src/com/android/server/net/PersistentInt.java" + line="53" + column="17"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 33 (current min is 30): `addOrUpdateInterfaceAddress`" + errorLine1=" mCb.addOrUpdateInterfaceAddress(ifaddrMsg.index, la);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service-t/src/com/android/server/connectivity/mdns/internal/SocketNetlinkMonitor.java" + line="69" + column="25"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 33 (current min is 30): `deleteInterfaceAddress`" + errorLine1=" mCb.deleteInterfaceAddress(ifaddrMsg.index, la);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service-t/src/com/android/server/connectivity/mdns/internal/SocketNetlinkMonitor.java" + line="73" + column="21"/> </issue> </issues> \ No newline at end of file diff --git a/service/Android.bp b/service/Android.bp index 7c5da0ddaa..0d7e8d0a87 100644 --- a/service/Android.bp +++ b/service/Android.bp @@ -70,9 +70,6 @@ java_library { apex_available: [ "com.android.tethering", ], - lint: { - baseline_filename: "lint-baseline.xml", - }, } // The library name match the service-connectivity jarjar rules that put the JNI utils in the @@ -206,6 +203,7 @@ java_library { lint: { strict_updatability_linting: true, baseline_filename: "lint-baseline.xml", + }, visibility: [ "//packages/modules/Connectivity/service-t", @@ -231,7 +229,7 @@ java_library { ], lint: { strict_updatability_linting: true, - baseline_filename: "lint-baseline.xml", + }, } @@ -290,18 +288,12 @@ java_defaults { java_library { name: "service-connectivity-for-tests", defaults: ["service-connectivity-defaults"], - lint: { - baseline_filename: "lint-baseline.xml", - }, } java_library { name: "service-connectivity", defaults: ["service-connectivity-defaults"], installable: true, - lint: { - baseline_filename: "lint-baseline.xml", - }, } java_library_static { @@ -316,9 +308,6 @@ java_library_static { ], static_libs: ["ConnectivityServiceprotos"], apex_available: ["com.android.tethering"], - lint: { - baseline_filename: "lint-baseline.xml", - }, } genrule { diff --git a/service/lint-baseline.xml b/service/lint-baseline.xml index 5149e6d5d7..a091a2b01e 100644 --- a/service/lint-baseline.xml +++ b/service/lint-baseline.xml @@ -1,5 +1,137 @@ <?xml version="1.0" encoding="UTF-8"?> -<issues format="6" by="lint 8.0.0-dev" type="baseline" dependencies="true" variant="all" version="8.0.0-dev"> +<issues format="6" by="lint 8.4.0-alpha01" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha01"> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `BpfMap`" + errorLine1=" return new BpfMap<>(" + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/BpfNetMaps.java" + line="189" + column="20"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `BpfMap`" + errorLine1=" return new BpfMap<>(" + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/BpfNetMaps.java" + line="198" + column="20"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `BpfMap`" + errorLine1=" return new BpfMap<>(" + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/BpfNetMaps.java" + line="207" + column="20"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `BpfMap`" + errorLine1=" return new BpfMap<>(COOKIE_TAG_MAP_PATH, BpfMap.BPF_F_RDWR," + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/BpfNetMaps.java" + line="216" + column="20"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `BpfMap`" + errorLine1=" return new BpfMap<>(" + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/BpfNetMaps.java" + line="225" + column="20"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `BpfMap`" + errorLine1=" return new BpfMap<>(INGRESS_DISCARD_MAP_PATH, BpfMap.BPF_F_RDWR," + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/BpfNetMaps.java" + line="234" + column="20"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `BpfBitmap`" + errorLine1=" return new BpfBitmap(BLOCKED_PORTS_MAP_PATH);" + errorLine2=" ~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ConnectivityNativeService.java" + line="61" + column="24"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `set`" + errorLine1=" mBpfBlockedPortsMap.set(port);" + errorLine2=" ~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ConnectivityNativeService.java" + line="96" + column="33"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `unset`" + errorLine1=" mBpfBlockedPortsMap.unset(port);" + errorLine2=" ~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ConnectivityNativeService.java" + line="107" + column="33"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `clear`" + errorLine1=" mBpfBlockedPortsMap.clear();" + errorLine2=" ~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ConnectivityNativeService.java" + line="118" + column="33"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `get`" + errorLine1=" if (mBpfBlockedPortsMap.get(i)) portMap.add(i);" + errorLine2=" ~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ConnectivityNativeService.java" + line="131" + column="41"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.os.BatteryStatsManager#reportNetworkInterfaceForTransports`" + errorLine1=" batteryStats.reportNetworkInterfaceForTransports(iface, transportTypes);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="1447" + column="26"/> + </issue> <issue id="NewApi" @@ -8,74 +140,74 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="1358" + line="1458" column="22"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.app.usage.NetworkStatsManager#notifyNetworkStatus`" - errorLine1=" mStatsManager.notifyNetworkStatus(getDefaultNetworks()," - errorLine2=" ~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `getProgramId`" + errorLine1=" return BpfUtils.getProgramId(attachType);" + errorLine2=" ~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="9938" - column="27"/> + line="1572" + column="29"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.content.pm.ApplicationInfo#isOem`" - errorLine1=" return appInfo.isVendor() || appInfo.isOem() || appInfo.isProduct();" - errorLine2=" ~~~~~"> + message="Class requires API level 31 (current min is 30): `android.net.NetworkPolicyManager`" + errorLine1=" mPolicyManager = mContext.getSystemService(NetworkPolicyManager.class);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" - line="481" - column="46"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="1740" + column="52"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.content.pm.ApplicationInfo#isProduct`" - errorLine1=" return appInfo.isVendor() || appInfo.isOem() || appInfo.isProduct();" - errorLine2=" ~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.NetworkPolicyManager#registerNetworkPolicyCallback`" + errorLine1=" mPolicyManager.registerNetworkPolicyCallback(null, mPolicyCallback);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" - line="481" - column="65"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="1753" + column="24"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.content.pm.ApplicationInfo#isVendor`" - errorLine1=" return appInfo.isVendor() || appInfo.isOem() || appInfo.isProduct();" - errorLine2=" ~~~~~~~~"> + message="Cast to `UidFrozenStateChangedCallback` requires API level 34 (current min is 30)" + errorLine1=" new UidFrozenStateChangedCallback() {" + errorLine2=" ^"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" - line="481" - column="24"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="1888" + column="21"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.NetworkPolicyManager#getMultipathPreference`" - errorLine1=" networkPreference = netPolicyManager.getMultipathPreference(network);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> + message="Class requires API level 34 (current min is 30): `android.app.ActivityManager.UidFrozenStateChangedCallback`" + errorLine1=" new UidFrozenStateChangedCallback() {" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="5498" - column="50"/> + line="1888" + column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.NetworkPolicyManager#getRestrictBackgroundStatus`" - errorLine1=" return mPolicyManager.getRestrictBackgroundStatus(callerUid);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 34 (current min is 30): `android.app.ActivityManager#registerUidFrozenStateChangedCallback`" + errorLine1=" activityManager.registerUidFrozenStateChangedCallback(" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="2565" - column="35"/> + line="1907" + column="29"/> </issue> <issue @@ -85,30 +217,30 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="1914" + line="2162" column="35"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.NetworkPolicyManager#isUidRestrictedOnMeteredNetworks`" - errorLine1=" if (mPolicyManager.isUidRestrictedOnMeteredNetworks(uid)) {" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.NetworkPolicyManager#getRestrictBackgroundStatus`" + errorLine1=" return mPolicyManager.getRestrictBackgroundStatus(callerUid);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="7094" - column="32"/> + line="2947" + column="35"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.NetworkPolicyManager#registerNetworkPolicyCallback`" - errorLine1=" mPolicyManager.registerNetworkPolicyCallback(null, mPolicyCallback);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.NetworkStateSnapshot#getNetwork`" + errorLine1=" final NetworkAgentInfo nai = getNetworkAgentInfoForNetwork(snapshot.getNetwork());" + errorLine2=" ~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="1567" - column="24"/> + line="2963" + column="81"/> </issue> <issue @@ -118,7 +250,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="2584" + line="2966" column="34"/> </issue> @@ -129,7 +261,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="2584" + line="2966" column="64"/> </issue> @@ -140,21 +272,10 @@ errorLine2=" ~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="2585" + line="2967" column="34"/> </issue> - <issue - id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.NetworkStateSnapshot#getNetwork`" - errorLine1=" final NetworkAgentInfo nai = getNetworkAgentInfoForNetwork(snapshot.getNetwork());" - errorLine2=" ~~~~~~~~~~"> - <location - file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="2581" - column="81"/> - </issue> - <issue id="NewApi" message="Call requires API level 31 (current min is 30): `android.net.NetworkStateSnapshot#getSubscriberId`" @@ -162,85 +283,85 @@ errorLine2=" ~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="2585" + line="2967" column="57"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.NetworkWatchlistManager#getWatchlistConfigHash`" - errorLine1=" return nwm.getWatchlistConfigHash();" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> + message="Class requires API level 31 (current min is 30): `android.net.NetworkPolicyManager.NetworkPolicyCallback`" + errorLine1=" private final NetworkPolicyCallback mPolicyCallback = new NetworkPolicyCallback() {" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="10060" - column="20"/> + line="3210" + column="63"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.PacProxyManager#addPacProxyInstalledListener`" - errorLine1=" mPacProxyManager.addPacProxyInstalledListener(" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `dump`" + errorLine1=" mBpfNetMaps.dump(pw, fd, verbose);" + errorLine2=" ~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ProxyTracker.java" - line="111" - column="26"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="4155" + column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.PacProxyManager#setCurrentProxyScriptUrl`" - errorLine1=" () -> mPacProxyManager.setCurrentProxyScriptUrl(proxyProperties));" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.os.Build#isDebuggable`" + errorLine1=" if (!Build.isDebuggable()) {" + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ProxyTracker.java" - line="208" - column="48"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="5721" + column="20"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.net.PacProxyManager#setCurrentProxyScriptUrl`" - errorLine1=" mPacProxyManager.setCurrentProxyScriptUrl(proxyInfo);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Class requires API level 31 (current min is 30): `android.net.NetworkPolicyManager`" + errorLine1=" mContext.getSystemService(NetworkPolicyManager.class);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ProxyTracker.java" - line="252" - column="26"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="6174" + column="44"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.BatteryStatsManager#reportMobileRadioPowerState`" - errorLine1=" bs.reportMobileRadioPowerState(isActive, NO_UID);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.NetworkPolicyManager#getMultipathPreference`" + errorLine1=" networkPreference = netPolicyManager.getMultipathPreference(network);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="11006" - column="24"/> + line="6179" + column="50"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.BatteryStatsManager#reportNetworkInterfaceForTransports`" - errorLine1=" batteryStats.reportNetworkInterfaceForTransports(iface, transportTypes);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `new android.net.UnderlyingNetworkInfo`" + errorLine1=" return new UnderlyingNetworkInfo(nai.networkCapabilities.getOwnerUid()," + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="1347" - column="26"/> + line="6819" + column="16"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.BatteryStatsManager#reportWifiRadioPowerState`" - errorLine1=" bs.reportWifiRadioPowerState(isActive, NO_UID);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.NetworkPolicyManager#isUidRestrictedOnMeteredNetworks`" + errorLine1=" if (mPolicyManager.isUidRestrictedOnMeteredNetworks(uid)) {" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="11009" - column="24"/> + line="7822" + column="32"/> </issue> <issue @@ -250,175 +371,274 @@ errorLine2=" ~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="9074" + line="9943" column="23"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.Build#isDebuggable`" - errorLine1=" if (!Build.isDebuggable()) {" - errorLine2=" ~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.app.usage.NetworkStatsManager#notifyNetworkStatus`" + errorLine1=" mStatsManager.notifyNetworkStatus(getDefaultNetworks()," + errorLine2=" ~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="5039" - column="20"/> + line="10909" + column="27"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.SystemConfigManager#getSystemPermissionUids`" - errorLine1=" for (final int uid : mSystemConfigManager.getSystemPermissionUids(INTERNET)) {" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" + errorLine1=" IoUtils.closeQuietly(pfd);" + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" - line="396" - column="51"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="10962" + column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.SystemConfigManager#getSystemPermissionUids`" - errorLine1=" for (final int uid : mSystemConfigManager.getSystemPermissionUids(UPDATE_DEVICE_STATS)) {" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" + errorLine1=" IoUtils.closeQuietly(pfd);" + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" - line="404" - column="51"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="10979" + column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.os.UserHandle#getUid`" - errorLine1=" final int uid = handle.getUid(appId);" - errorLine2=" ~~~~~~"> + message="Class requires API level 31 (current min is 30): `android.net.NetworkWatchlistManager`" + errorLine1=" NetworkWatchlistManager nwm = mContext.getSystemService(NetworkWatchlistManager.class);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" - line="1069" - column="44"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="11035" + column="65"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.system.Os#getsockoptInt`" - errorLine1=" tcpDetails.tos = Os.getsockoptInt(fd, IPPROTO_IP, IP_TOS);" - errorLine2=" ~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.net.NetworkWatchlistManager#getWatchlistConfigHash`" + errorLine1=" return nwm.getWatchlistConfigHash();" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" - line="285" - column="37"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="11041" + column="20"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.system.Os#getsockoptInt`" - errorLine1=" tcpDetails.ttl = Os.getsockoptInt(fd, IPPROTO_IP, IP_TTL);" - errorLine2=" ~~~~~~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `getProgramId`" + errorLine1=" final int ret = BpfUtils.getProgramId(type);" + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" - line="287" - column="37"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="11180" + column="50"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.system.Os#getsockoptInt`" - errorLine1=" tcpDetails.ack = Os.getsockoptInt(fd, IPPROTO_TCP, TCP_QUEUE_SEQ);" - errorLine2=" ~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.os.BatteryStatsManager#reportMobileRadioPowerState`" + errorLine1=" bs.reportMobileRadioPowerState(isActive, uid);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" - line="265" - column="33"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="12254" + column="24"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.system.Os#getsockoptInt`" - errorLine1=" tcpDetails.seq = Os.getsockoptInt(fd, IPPROTO_TCP, TCP_QUEUE_SEQ);" - errorLine2=" ~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.os.BatteryStatsManager#reportWifiRadioPowerState`" + errorLine1=" bs.reportWifiRadioPowerState(isActive, uid);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" - line="262" - column="33"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="12257" + column="24"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.system.Os#ioctlInt`" - errorLine1=" final int result = Os.ioctlInt(fd, SIOCINQ);" - errorLine2=" ~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `addNiceApp`" + errorLine1=" mBpfNetMaps.addNiceApp(uid);" + errorLine2=" ~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" - line="392" - column="31"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="13079" + column="29"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `android.system.Os#ioctlInt`" - errorLine1=" final int result = Os.ioctlInt(fd, SIOCOUTQ);" - errorLine2=" ~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `removeNiceApp`" + errorLine1=" mBpfNetMaps.removeNiceApp(uid);" + errorLine2=" ~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" - line="402" - column="31"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="13081" + column="29"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `java.net.InetAddress#parseNumericAddress`" - errorLine1=' InetAddress.parseNumericAddress("::").getAddress();' - errorLine2=" ~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `addNaughtyApp`" + errorLine1=" mBpfNetMaps.addNaughtyApp(uid);" + errorLine2=" ~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/DscpPolicyValue.java" - line="99" - column="25"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="13094" + column="29"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `java.net.InetAddress#parseNumericAddress`" - errorLine1=' private static final InetAddress GOOGLE_DNS_4 = InetAddress.parseNumericAddress("8.8.8.8");' - errorLine2=" ~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `removeNaughtyApp`" + errorLine1=" mBpfNetMaps.removeNaughtyApp(uid);" + errorLine2=" ~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ClatCoordinator.java" - line="89" - column="65"/> + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="13096" + column="29"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(pfd);" - errorLine2=" ~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.os.UserHandle#getUid`" + errorLine1=" final int uid = uh.getUid(appId);" + errorLine2=" ~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="13112" + column="32"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 33 (current min is 30): `setUidRule`" + errorLine1=" mBpfNetMaps.setUidRule(chain, uid, firewallRule);" + errorLine2=" ~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="9991" + line="13130" column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(pfd);" - errorLine2=" ~~~~~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `setChildChain`" + errorLine1=" mBpfNetMaps.setChildChain(chain, enable);" + errorLine2=" ~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="10008" + line="13195" column="25"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" - errorLine1=" IoUtils.closeQuietly(mFileDescriptor);" - errorLine2=" ~~~~~~~~~~~~"> + message="Call requires API level 33 (current min is 30): `isChainEnabled`" + errorLine1=" return mBpfNetMaps.isChainEnabled(chain);" + errorLine2=" ~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/connectivity/NetworkDiagnostics.java" - line="481" + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="13213" + column="28"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 33 (current min is 30): `replaceUidChain`" + errorLine1=" mBpfNetMaps.replaceUidChain(chain, uids);" + errorLine2=" ~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" + line="13220" column="21"/> </issue> + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `BpfMap`" + errorLine1=" mBpfDscpIpv4Policies = new BpfMap<Struct.S32, DscpPolicyValue>(IPV4_POLICY_MAP_PATH," + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/DscpPolicyTracker.java" + line="88" + column="32"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `BpfMap`" + errorLine1=" mBpfDscpIpv6Policies = new BpfMap<Struct.S32, DscpPolicyValue>(IPV6_POLICY_MAP_PATH," + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/DscpPolicyTracker.java" + line="90" + column="32"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `insertOrReplaceEntry`" + errorLine1=" mBpfDscpIpv4Policies.insertOrReplaceEntry(" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/DscpPolicyTracker.java" + line="183" + column="38"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `insertOrReplaceEntry`" + errorLine1=" mBpfDscpIpv6Policies.insertOrReplaceEntry(" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/DscpPolicyTracker.java" + line="194" + column="38"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `replaceEntry`" + errorLine1=" mBpfDscpIpv4Policies.replaceEntry(new Struct.S32(index), DscpPolicyValue.NONE);" + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/DscpPolicyTracker.java" + line="261" + column="34"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `replaceEntry`" + errorLine1=" mBpfDscpIpv6Policies.replaceEntry(new Struct.S32(index), DscpPolicyValue.NONE);" + errorLine2=" ~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/DscpPolicyTracker.java" + line="262" + column="34"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `java.net.InetAddress#parseNumericAddress`" + errorLine1=' InetAddress.parseNumericAddress("::").getAddress();' + errorLine2=" ~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/DscpPolicyValue.java" + line="99" + column="25"/> + </issue> + <issue id="NewApi" message="Call requires API level 31 (current min is 30): `new android.net.NetworkStateSnapshot`" @@ -426,65 +646,109 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/connectivity/NetworkAgentInfo.java" - line="1269" + line="1353" column="20"/> </issue> <issue id="NewApi" - message="Call requires API level 31 (current min is 30): `new android.net.UnderlyingNetworkInfo`" - errorLine1=" return new UnderlyingNetworkInfo(nai.networkCapabilities.getOwnerUid()," - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `libcore.io.IoUtils#closeQuietly`" + errorLine1=" IoUtils.closeQuietly(mFileDescriptor);" + errorLine2=" ~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="6123" - column="16"/> + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/NetworkDiagnostics.java" + line="570" + column="21"/> </issue> <issue id="NewApi" - message="Class requires API level 31 (current min is 30): `android.net.NetworkPolicyManager.NetworkPolicyCallback`" - errorLine1=" private final NetworkPolicyCallback mPolicyCallback = new NetworkPolicyCallback() {" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> + message="Field requires API level 31 (current min is 30): `android.os.Build.VERSION#DEVICE_INITIAL_SDK_INT`" + errorLine1=" return Build.VERSION.DEVICE_INITIAL_SDK_INT;" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="2827" - column="63"/> + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" + line="212" + column="20"/> </issue> <issue id="NewApi" - message="Class requires API level 31 (current min is 30): `android.net.NetworkPolicyManager`" - errorLine1=" mContext.getSystemService(NetworkPolicyManager.class);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.os.SystemConfigManager#getSystemPermissionUids`" + errorLine1=" for (final int uid : mSystemConfigManager.getSystemPermissionUids(INTERNET)) {" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="5493" - column="44"/> + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" + line="396" + column="51"/> </issue> <issue id="NewApi" - message="Class requires API level 31 (current min is 30): `android.net.NetworkPolicyManager`" - errorLine1=" mPolicyManager = mContext.getSystemService(NetworkPolicyManager.class);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.os.SystemConfigManager#getSystemPermissionUids`" + errorLine1=" for (final int uid : mSystemConfigManager.getSystemPermissionUids(UPDATE_DEVICE_STATS)) {" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="1554" - column="52"/> + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" + line="404" + column="51"/> </issue> <issue id="NewApi" - message="Class requires API level 31 (current min is 30): `android.net.NetworkWatchlistManager`" - errorLine1=" NetworkWatchlistManager nwm = mContext.getSystemService(NetworkWatchlistManager.class);" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> + message="Call requires API level 31 (current min is 30): `android.content.pm.ApplicationInfo#isOem`" + errorLine1=" return appInfo.isVendor() || appInfo.isOem() || appInfo.isProduct();" + errorLine2=" ~~~~~"> <location - file="packages/modules/Connectivity/service/src/com/android/server/ConnectivityService.java" - line="10054" + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" + line="481" + column="46"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.content.pm.ApplicationInfo#isProduct`" + errorLine1=" return appInfo.isVendor() || appInfo.isOem() || appInfo.isProduct();" + errorLine2=" ~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" + line="481" column="65"/> </issue> + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.content.pm.ApplicationInfo#isVendor`" + errorLine1=" return appInfo.isVendor() || appInfo.isOem() || appInfo.isProduct();" + errorLine2=" ~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" + line="481" + column="24"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.os.UserHandle#getUid`" + errorLine1=" final int uid = handle.getUid(appId);" + errorLine2=" ~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" + line="1070" + column="44"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 33 (current min is 30): `updateUidLockdownRule`" + errorLine1=" mBpfNetMaps.updateUidLockdownRule(uid, add);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/PermissionMonitor.java" + line="1123" + column="25"/> + </issue> + <issue id="NewApi" message="Class requires API level 31 (current min is 30): `android.net.PacProxyManager.PacProxyInstalledListener`" @@ -492,7 +756,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ProxyTracker.java" - line="90" + line="92" column="56"/> </issue> @@ -503,8 +767,107 @@ errorLine2=" ~~~~~~~~~~~~~~~"> <location file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ProxyTracker.java" - line="108" + line="111" column="53"/> </issue> + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.net.PacProxyManager#addPacProxyInstalledListener`" + errorLine1=" mPacProxyManager.addPacProxyInstalledListener(" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ProxyTracker.java" + line="115" + column="30"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.net.PacProxyManager#setCurrentProxyScriptUrl`" + errorLine1=" () -> mPacProxyManager.setCurrentProxyScriptUrl(proxyProperties));" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ProxyTracker.java" + line="213" + column="48"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.net.PacProxyManager#setCurrentProxyScriptUrl`" + errorLine1=" mPacProxyManager.setCurrentProxyScriptUrl(proxyInfo);" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/ProxyTracker.java" + line="259" + column="30"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.system.Os#getsockoptInt`" + errorLine1=" tcpDetails.seq = Os.getsockoptInt(fd, IPPROTO_TCP, TCP_QUEUE_SEQ);" + errorLine2=" ~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" + line="269" + column="33"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.system.Os#getsockoptInt`" + errorLine1=" tcpDetails.ack = Os.getsockoptInt(fd, IPPROTO_TCP, TCP_QUEUE_SEQ);" + errorLine2=" ~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" + line="272" + column="33"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.system.Os#getsockoptInt`" + errorLine1=" tcpDetails.tos = Os.getsockoptInt(fd, IPPROTO_IP, IP_TOS);" + errorLine2=" ~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" + line="292" + column="37"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.system.Os#getsockoptInt`" + errorLine1=" tcpDetails.ttl = Os.getsockoptInt(fd, IPPROTO_IP, IP_TTL);" + errorLine2=" ~~~~~~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" + line="294" + column="37"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.system.Os#ioctlInt`" + errorLine1=" final int result = Os.ioctlInt(fd, SIOCINQ);" + errorLine2=" ~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" + line="401" + column="31"/> + </issue> + + <issue + id="NewApi" + message="Call requires API level 31 (current min is 30): `android.system.Os#ioctlInt`" + errorLine1=" final int result = Os.ioctlInt(fd, SIOCOUTQ);" + errorLine2=" ~~~~~~~~"> + <location + file="packages/modules/Connectivity/service/src/com/android/server/connectivity/TcpKeepaliveController.java" + line="411" + column="31"/> + </issue> + </issues> \ No newline at end of file -- GitLab