diff --git a/Tethering/tests/privileged/src/com/android/networkstack/tethering/ConntrackSocketTest.java b/Tethering/tests/privileged/src/com/android/networkstack/tethering/ConntrackSocketTest.java index 81d4fbe0bb40d1e996a9a52db149c396eb38d5ea..60f2d17b09b495c457c5186e79e54c604fa1bfa9 100644 --- a/Tethering/tests/privileged/src/com/android/networkstack/tethering/ConntrackSocketTest.java +++ b/Tethering/tests/privileged/src/com/android/networkstack/tethering/ConntrackSocketTest.java @@ -44,6 +44,7 @@ import com.android.net.module.util.netlink.NetlinkMessage; import com.android.net.module.util.netlink.NetlinkUtils; import com.android.net.module.util.netlink.StructNlMsgHdr; +import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -84,6 +85,14 @@ public class ConntrackSocketTest { mOffloadHw = new OffloadHardwareInterface(mHandler, mLog, mDeps); } + @After + public void tearDown() throws Exception { + if (mHandlerThread != null) { + mHandlerThread.quitSafely(); + mHandlerThread.join(); + } + } + void findConnectionOrThrow(FileDescriptor fd, InetSocketAddress local, InetSocketAddress remote) throws Exception { Log.d(TAG, "Looking for socket " + local + " -> " + remote); diff --git a/tests/unit/java/com/android/server/connectivity/mdns/MdnsMultinetworkSocketClientTest.java b/tests/unit/java/com/android/server/connectivity/mdns/MdnsMultinetworkSocketClientTest.java index 3701b0c3355ac453076ace9ac24dc2e212d78b56..8917ed3f996ad28b62f6fd6caf7cd082105a6ff8 100644 --- a/tests/unit/java/com/android/server/connectivity/mdns/MdnsMultinetworkSocketClientTest.java +++ b/tests/unit/java/com/android/server/connectivity/mdns/MdnsMultinetworkSocketClientTest.java @@ -42,6 +42,7 @@ import com.android.testutils.DevSdkIgnoreRule; import com.android.testutils.DevSdkIgnoreRunner; import com.android.testutils.HandlerUtils; +import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -69,6 +70,7 @@ public class MdnsMultinetworkSocketClientTest { @Mock private SocketCreationCallback mSocketCreationCallback; @Mock private SharedLog mSharedLog; private MdnsMultinetworkSocketClient mSocketClient; + private HandlerThread mHandlerThread; private Handler mHandler; private SocketKey mSocketKey; @@ -76,14 +78,23 @@ public class MdnsMultinetworkSocketClientTest { public void setUp() throws SocketException { MockitoAnnotations.initMocks(this); - final HandlerThread thread = new HandlerThread("MdnsMultinetworkSocketClientTest"); - thread.start(); - mHandler = new Handler(thread.getLooper()); + mHandlerThread = new HandlerThread("MdnsMultinetworkSocketClientTest"); + mHandlerThread.start(); + mHandler = new Handler(mHandlerThread.getLooper()); mSocketKey = new SocketKey(1000 /* interfaceIndex */); - mSocketClient = new MdnsMultinetworkSocketClient(thread.getLooper(), mProvider, mSharedLog); + mSocketClient = new MdnsMultinetworkSocketClient( + mHandlerThread.getLooper(), mProvider, mSharedLog); mHandler.post(() -> mSocketClient.setCallback(mCallback)); } + @After + public void tearDown() throws Exception { + if (mHandlerThread != null) { + mHandlerThread.quitSafely(); + mHandlerThread.join(); + } + } + private SocketCallback expectSocketCallback() { return expectSocketCallback(mListener, mNetwork); } diff --git a/tests/unit/java/com/android/server/net/NetworkStatsObserversTest.java b/tests/unit/java/com/android/server/net/NetworkStatsObserversTest.java index 292f77e9d5e17567f95d3889328cadaf153611c5..c477b2cdff6897f59d5055c37161118a8c02e578 100644 --- a/tests/unit/java/com/android/server/net/NetworkStatsObserversTest.java +++ b/tests/unit/java/com/android/server/net/NetworkStatsObserversTest.java @@ -59,6 +59,7 @@ import com.android.testutils.DevSdkIgnoreRule; import com.android.testutils.DevSdkIgnoreRunner; import com.android.testutils.HandlerUtils; +import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -139,6 +140,14 @@ public class NetworkStatsObserversTest { mUsageCallback = new TestableUsageCallback(mUsageCallbackBinder); } + @After + public void tearDown() throws Exception { + if (mObserverHandlerThread != null) { + mObserverHandlerThread.quitSafely(); + mObserverHandlerThread.join(); + } + } + @Test public void testRegister_thresholdTooLow_setsDefaultThreshold() throws Exception { final long thresholdTooLowBytes = 1L;