From 3a84a23f36f85f5a16503d3d220358175582f83b Mon Sep 17 00:00:00 2001
From: Yang Ni <yangni@google.com>
Date: Fri, 28 Apr 2017 08:45:40 -0700
Subject: [PATCH] Do not CloseGuard KernelID or FieldID
Bug: 28053584
Stop CloseGuarding for two reasons:
1) KernelID and FieldID objects are constructed in auto-generated
(RenderScript reflected) Java code. It would be impossible for a user to
explicitly call destroy() on them. Guarding them would leave a lot of
noisy warnings in logcat.
2) These KernelID and FieldID objects are not big compared to other
RenderScript objects, e.g. Allocations. They occupy almost no native
resources except for a native pointer. Leaving their destruction to Java
GC would be completely acceptable, since any delay in reclaiming them is
unlikely to cause memory pressure.
Test: CTS on x86_64 emulator
Change-Id: I587b5561a0b2bdbf0b2e95bf2995c20d5f5faf9d
---
rs/java/android/renderscript/Script.java | 2 --
1 file changed, 2 deletions(-)
diff --git a/rs/java/android/renderscript/Script.java b/rs/java/android/renderscript/Script.java
index 13d5fcd57446..d0d9a114bbae 100644
--- a/rs/java/android/renderscript/Script.java
+++ b/rs/java/android/renderscript/Script.java
@@ -41,7 +41,6 @@ public class Script extends BaseObj {
mScript = s;
mSlot = slot;
mSig = sig;
- guard.open("destroy");
}
}
@@ -119,7 +118,6 @@ public class Script extends BaseObj {
super(id, rs);
mScript = s;
mSlot = slot;
- guard.open("destroy");
}
}
--
GitLab