Skip to content
Snippets Groups Projects
Commit 45beedbd authored by Roy Chou's avatar Roy Chou
Browse files

fix(systemui): fix perfetto_ft_systemui-missed_app_frames-mean increased

The perfetto_ft_systemui-missed_app_frames-mean value increased after ag/24677444. Try debugging the issue then we find the major cause is the PhoneStatusBarViewController calls the PhoneStatusBarView#updateResources when onConfigChanged triggered. Besides, PhoneStatusBarView already has the method onConfigurationChanged to detect the configuration change then call updateResources. Therefore, as the quick workaround, in PhoneStatusBarViewController we remove the onConfigChanged method, and leave PhoneStatusBarView detecting onConfigurationChanged itself. Test on abtd and the perfetto_ft_systemui-missed_app_frames-mean seems to decrease to the previous good build value.

Bug: 300629388
Test: abtd to check the perfetto_ft_systemui-missed_app_frames-mean
Change-Id: Ib568165d73cc9b3fb8178b5b5854d09c4225adeb
parent 91886a16
No related branches found
No related tags found
No related merge requests found
......@@ -112,6 +112,9 @@ public class PhoneStatusBarView extends FrameLayout {
mDisplayCutout = null;
}
// Per b/300629388, we let the PhoneStatusBarView detect onConfigurationChanged to
// updateResources, instead of letting the PhoneStatusBarViewController detect onConfigChanged
// then notify PhoneStatusBarView.
@Override
protected void onConfigurationChanged(Configuration newConfig) {
super.onConfigurationChanged(newConfig);
......
......@@ -16,7 +16,6 @@
package com.android.systemui.statusbar.phone
import android.app.StatusBarManager.WINDOW_STATUS_BAR
import android.content.res.Configuration
import android.graphics.Point
import android.util.Log
import android.view.MotionEvent
......@@ -72,10 +71,6 @@ private constructor(
private val configurationListener =
object : ConfigurationController.ConfigurationListener {
override fun onConfigChanged(newConfig: Configuration?) {
mView.updateResources()
}
override fun onDensityOrFontScaleChanged() {
mView.onDensityOrFontScaleChanged()
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment