Skip to content
Snippets Groups Projects
Commit 9e4e9be6 authored by Hawkwood Glazier's avatar Hawkwood Glazier Committed by Android Build Coastguard Worker
Browse files

Partial revert of I113cf97bb63121b89857a2204625d15b254e5876

This very likely will regress the font size of clocks on secondary
displays, but a partial revert is easier than a full revert.

This also includes some minor cleanup of ClockEventController

Bug: 303798047
Test: Manually checked clock theming
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ddae7230c2819b2a1975eb8d344b6b78d01eae1c)
Merged-In: I2373ecef880c0671bbb418f95c5d3174e546306a
Change-Id: I2373ecef880c0671bbb418f95c5d3174e546306a
parent ae45c951
No related branches found
No related tags found
No related merge requests found
...@@ -34,7 +34,6 @@ import androidx.lifecycle.repeatOnLifecycle ...@@ -34,7 +34,6 @@ import androidx.lifecycle.repeatOnLifecycle
import com.android.systemui.customization.R import com.android.systemui.customization.R
import com.android.systemui.broadcast.BroadcastDispatcher import com.android.systemui.broadcast.BroadcastDispatcher
import com.android.systemui.dagger.qualifiers.Background import com.android.systemui.dagger.qualifiers.Background
import com.android.systemui.dagger.qualifiers.DisplaySpecific
import com.android.systemui.dagger.qualifiers.Main import com.android.systemui.dagger.qualifiers.Main
import com.android.systemui.flags.FeatureFlags import com.android.systemui.flags.FeatureFlags
import com.android.systemui.flags.Flags.DOZING_MIGRATION_1 import com.android.systemui.flags.Flags.DOZING_MIGRATION_1
...@@ -80,8 +79,8 @@ constructor( ...@@ -80,8 +79,8 @@ constructor(
private val batteryController: BatteryController, private val batteryController: BatteryController,
private val keyguardUpdateMonitor: KeyguardUpdateMonitor, private val keyguardUpdateMonitor: KeyguardUpdateMonitor,
private val configurationController: ConfigurationController, private val configurationController: ConfigurationController,
@DisplaySpecific private val resources: Resources, @Main private val resources: Resources,
@DisplaySpecific private val context: Context, private val context: Context,
@Main private val mainExecutor: DelayableExecutor, @Main private val mainExecutor: DelayableExecutor,
@Background private val bgExecutor: Executor, @Background private val bgExecutor: Executor,
@KeyguardSmallClockLog private val smallLogBuffer: LogBuffer?, @KeyguardSmallClockLog private val smallLogBuffer: LogBuffer?,
...@@ -212,13 +211,13 @@ constructor( ...@@ -212,13 +211,13 @@ constructor(
if (regionSamplingEnabled) { if (regionSamplingEnabled) {
clock?.let { clock -> clock?.let { clock ->
smallRegionSampler?.let { smallRegionSampler?.let {
smallClockIsDark = it.currentRegionDarkness().isDark val isRegionDark = it.currentRegionDarkness().isDark
clock.smallClock.events.onRegionDarknessChanged(smallClockIsDark) clock.smallClock.events.onRegionDarknessChanged(isRegionDark)
} }
largeRegionSampler?.let { largeRegionSampler?.let {
largeClockIsDark = it.currentRegionDarkness().isDark val isRegionDark = it.currentRegionDarkness().isDark
clock.largeClock.events.onRegionDarknessChanged(largeClockIsDark) clock.largeClock.events.onRegionDarknessChanged(isRegionDark)
} }
} }
return return
...@@ -226,12 +225,12 @@ constructor( ...@@ -226,12 +225,12 @@ constructor(
val isLightTheme = TypedValue() val isLightTheme = TypedValue()
context.theme.resolveAttribute(android.R.attr.isLightTheme, isLightTheme, true) context.theme.resolveAttribute(android.R.attr.isLightTheme, isLightTheme, true)
smallClockIsDark = isLightTheme.data == 0 val isRegionDark = isLightTheme.data == 0
largeClockIsDark = isLightTheme.data == 0
clock?.run { clock?.run {
smallClock.events.onRegionDarknessChanged(smallClockIsDark) Log.i(TAG, "Region isDark: $isRegionDark")
largeClock.events.onRegionDarknessChanged(largeClockIsDark) smallClock.events.onRegionDarknessChanged(isRegionDark)
largeClock.events.onRegionDarknessChanged(isRegionDark)
} }
} }
protected open fun createRegionSampler( protected open fun createRegionSampler(
...@@ -261,9 +260,6 @@ constructor( ...@@ -261,9 +260,6 @@ constructor(
get() = isKeyguardVisible && dozeAmount < DOZE_TICKRATE_THRESHOLD get() = isKeyguardVisible && dozeAmount < DOZE_TICKRATE_THRESHOLD
private var cachedWeatherData: WeatherData? = null private var cachedWeatherData: WeatherData? = null
private var smallClockIsDark = true
private var largeClockIsDark = true
private val configListener = private val configListener =
object : ConfigurationController.ConfigurationListener { object : ConfigurationController.ConfigurationListener {
override fun onThemeChanged() { override fun onThemeChanged() {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment