Skip to content
Snippets Groups Projects
Commit a9427152 authored by Michael Klimushyn's avatar Michael Klimushyn
Browse files

Downgrade InputMethodManager getFallbackIMM logs

Previously the IMM was logging error and warning logs every single time
it attempted to use an IMM method and ended up with the fallback IMM.
This is both extremely noisy since the IMM is accessed multiple times
per second in the case of the user typing and a little misleading since
this isn't truly an error condition on its own.

Downgrade the log to a VERBOSE log. This will still show up for apps
when in development but is less likely to wander into bug reports for
released apps.

Bug: 141884160
Fixes: 141884160
Test: Manually. Trigerred error condition and verified log level.

Change-Id: If25ef81c6b74679ebfa725f0c98e0bc633399e70
parent 87778b86
No related branches found
No related tags found
No related merge requests found
......@@ -525,16 +525,16 @@ public final class InputMethodManager {
final InputMethodManager fallbackImm =
viewRootImpl.mContext.getSystemService(InputMethodManager.class);
if (fallbackImm == null) {
Log.e(TAG, "b/117267690: Failed to get non-null fallback IMM. view=" + view);
Log.v(TAG, "b/117267690: Failed to get non-null fallback IMM. view=" + view);
return null;
}
if (fallbackImm.mDisplayId != viewRootDisplayId) {
Log.e(TAG, "b/117267690: Failed to get fallback IMM with expected displayId="
Log.v(TAG, "b/117267690: Failed to get fallback IMM with expected displayId="
+ viewRootDisplayId + " actual IMM#displayId=" + fallbackImm.mDisplayId
+ " view=" + view);
return null;
}
Log.w(TAG, "b/117267690: Display ID mismatch found."
Log.v(TAG, "b/117267690: Display ID mismatch found."
+ " ViewRootImpl displayId=" + viewRootDisplayId
+ " InputMethodManager displayId=" + mDisplayId
+ ". Use the right InputMethodManager instance to avoid performance overhead.",
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment