Skip to content
Snippets Groups Projects
Commit f62a0e11 authored by Jernej Virag's avatar Jernej Virag Committed by Android (Google) Code Review
Browse files

Merge "Fix @Nullability mismatch with PipTransition" into udc-qpr-dev

parents ca88ae4d c4619220
No related branches found
No related tags found
No related merge requests found
......@@ -16,7 +16,6 @@
package com.android.wm.shell.dagger.pip;
import android.annotation.Nullable;
import android.content.Context;
import android.os.Handler;
......@@ -229,7 +228,6 @@ public abstract class Pip1Module {
@WMSingleton
@Provides
@Nullable
static PipTransition providePipTransition(Context context,
ShellInit shellInit, ShellTaskOrganizer shellTaskOrganizer, Transitions transitions,
PipAnimationController pipAnimationController, PipBoundsAlgorithm pipBoundsAlgorithm,
......
......@@ -36,10 +36,13 @@ import dagger.Provides;
public abstract class PipModule {
@WMSingleton
@Provides
@Nullable
static PipTransitionController providePipTransitionController(
com.android.wm.shell.pip.PipTransition legacyPipTransition,
com.android.wm.shell.pip2.PipTransition newPipTransition) {
return PipUtils.isPip2ExperimentEnabled() ? newPipTransition : legacyPipTransition;
@Nullable com.android.wm.shell.pip2.PipTransition newPipTransition) {
if (PipUtils.isPip2ExperimentEnabled() && newPipTransition != null) {
return newPipTransition;
} else {
return legacyPipTransition;
}
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment