Revert submission 24444827-crashrecovery

Reason for revert: Since the module is not behind any flags, it is getting included in 24Q1 Beta release.

Reverted changes: /q/submissionid:24444827-crashrecovery
Bug: b/305826937
Change-Id: I5c65d85d50b214926f5473908694070b4e896201

This ensures they're consistently added to all droidstubs modules
for the non-updatable part.

Test: presubmit
Change-Id: Ia17808572b3fa8d75cdc71e7981d562ad0036afc

Bug: 307737035
Test: m combined-removed-dex
      # Check before and after to make sure there are no differences
Change-Id: I51e774e6a340d310b96c0291b04f66b4737aebda

Note that this is a re-cherry-pick of the original CL that is closer
to the original CL than the first CP, to minimize the number of
conflicts in Android.bp files.

Bug: 289776578
Test: presubmit
Merged-In: I721fc4ae5c62cf1eada9bb6b4e5b3f1a4c9db21a
Change-Id: Ibf98f37cb795bc7f627a485546b6ce8ec23b3a9e

(cherry pick of 7da1d255
 and 38dd161e)

Bug: 297362755
Test: make checkapi
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:36d19aea70de000f45f55e72b8c1ba86ae6e6629)
Merged-In: I4d384efac8a8d3b183d9b207b195ad5489db9e55
Change-Id: I4d384efac8a8d3b183d9b207b195ad5489db9e55

Provides SdkTestCore/test_core_current sdk_version for non-updatable
modules that have their test scope dependent on test apis from
framework-minus-apex.

Ignore-AOSP-First: Change in topic with internal-first projects
Bug: 289776578
Test: m checkapi

Merged-In: I855346c01bb609e81b14dbdc13330315badc339e
Change-Id: I855346c01bb609e81b14dbdc13330315badc339e

(cherry pick of 7da1d255
 and 38dd161e)

Bug: 297362755
Test: make checkapi
Merged-In: If7333ead86d9028ab0a1cc8f25fc534cb13a1858
Merged-In: I4d384efac8a8d3b183d9b207b195ad5489db9e55
Change-Id: I4d384efac8a8d3b183d9b207b195ad5489db9e55

The args attribute does not work well with defaults as it's just a
string, which cannot be extended. Migrate to the flags attribute.

Bug: 306806877
Test: diff ninja file before/after
Change-Id: Ifd1d503d2da29bf1cdf2664201f9c8276f9480a4

(cherry pick of 7da1d255
 and 38dd161e)

Bug: 297362755
Test: make checkapi
Merged-In: If7333ead86d9028ab0a1cc8f25fc534cb13a1858
Merged-In: I4d384efac8a8d3b183d9b207b195ad5489db9e55
Change-Id: I4d384efac8a8d3b183d9b207b195ad5489db9e55

The reason certain checks are disabled in doclava is that they have been
implemented in metalava instead. Clarify that.

Test: presubmit
Change-Id: I32c32783dea59a63d95d14b4ad636159536c2944

Just like all other android_*_stubs_current modules,
android_test_frameworks_core_stubs_current is added to classpath of the
javac compilation of its reverse dependencies, and its static libs is
dynamically switched between the ".from-source" suffixed from-source
stub compiling java_library module and the ".from-text" suffixed
from-text stub compiling java_api_library module.

Other than the origin of the stubs, the two modules are expected to
contain (mostly) identical APIs. However, the two static libs of
android_test_frameworks_core_stubs_current currently do not follow this
principle as the from-source java_library module does not add the
"private-stub-annotation-jar" as static lib, while the from-text
java_api_library does. This discrepancy lead to compilation error of the
reverse dependencies when defaulting build to from-text stub generation.

This change fixes the discrepancy between the two modules by removing
"private-stub-annotation-jar" from the static lib of the from-source
module and making the two modules behave more similarly.

Test: patch on internal main and run `m framework-location.stubs.test.from-source --build-from-text-stub`
Bug: 301522358
Change-Id: I821b7bb25a8f7ec7f9977a01ebdfbd5f1b25cf5e

Add bug links for the remaining issues, and write a comment about the
problematic @ChangeId docs.

Bug: 303184203
Test: presubmit
Change-Id: I2f301a6e1d8250745d179ee9a0326e6174d1da2d

Droidstubs now support using the api-versions.xml from another
droidstubs module, so reuse the one from `api_versions_system`
in `framework-doc-system-stubs`.

Test: m framework-docs-system-stubs
      # Diff stubs before and after
Change-Id: I0aa3a74664e2a9343e90d91b7520ce8bbcadfac5

Adding the module libraries to combined_apis for them to be added to
Android SDK.
Also adding bootclasspath-fragment to platform-bootclasspath.

Bug: b/289203818
Test: m

Change-Id: Ica9b0bddc2f9cb6621a01dcd3859c39357144b5f

The `droidstubs.extensions_info_file` property is only used when
`api_levels_annotations_enabled: true`. The `framwork-doc-stubs` uses
`api_levels_module` instead and so does not need `extensions_info_file`
any more.

Bug: 305688818
Test: m framework-doc-stubs
      # Before and after and check output to confirm that it does not change
Change-Id: I4ad3f5b24e998eb9d5d47fa2240d2281fa9d6fc6

Various issues here, but the most recurring one is referencing SystemApi
from public javadoc. Remove or rewrite such references.

Also common is trying to @link IntDefs. Usually this is not necessary,
as the presence of IntDef in the @param/@return auto-generates relevant
documentation.

Bug: 303184203
Test: m docs
Change-Id: Ie59e61881c45c73fbbe08250493bd35eca268ef6

The most common problem were references to SystemApi or @hide symbols
from public documentation. Replace such references with natural english
or {@code}. A few references were just incorrect before and have been
fixed.

Bug: 303184203
Test: m docs
Change-Id: I243e27d7ae6e0dafa2af4f3cc44aa7e8894025f1

java_api_library modules run validation to check the sanity of the API
text files by default when generating the stubs from txt files. However,
this leads to circular dependency issue when the validations are added
to the full api surface stub java_api_library modules as droidstubs may
set sdk_version property. Therefore, disable the validation for full api
surface java_api_library (e.g. android_*_stubs_current) modules.

Test: m nothing --build-from-text-stub
Bug: 288624417
Change-Id: Ib1b7b804736ef4e4cd2ea979aabea211af1927af

- Remove @links to SystemApi
- Escape @-symbols

Bug: 303184203
Test: m docs
Change-Id: Iafaaa2150d36cf36dadfefaa29f56e0dd0d756d9

- getInstance is SystemApi, so cannot be linked from public javadoc
- MidiDeviceService is not a member
- The documentation generation for @ChangeId constants is special
  and cannot resolve imports, so fully qualify all links there.

Bug: 303184203
Test: m docs
Change-Id: I5838dd3057e25d5c50f4b912d46c9805bb0378cf

Bug: 303184203
Test: m docs
Change-Id: I745ea2f582640ea10a81b6d0369bede3f243686c

Bug: 303184203
Test: m docs
Change-Id: I50cd982923c160452de2ee2ee7a982dab0f78a5c

Currently, hiddenapi_modular defines test api surface as a subset of
module lib api surface, causing hiddenapi check failure in from-text
stub build. In order to mitigate this and enable the hiddenapi check in
from-text stub build, this change introduces a java_api_library module
that generates the stub jar that contains both test and module lib
api contributions. The module will not be available for consumption, but
will only be used in hiddenapi check.

Test: m android_test_module_lib_stubs_current.from-text --build-from-text-stub
Bug: 191644675
Change-Id: I2b6c9f75d9ebcfd75fa5b509dbef14aa0f88ac97

- the *-check-docs target doesn't do anything the other targets don't
- online-* are, I think, the old d.a.c targets but the ds-* targets are
  what's currently used
- the hidden-* target isn't meaningfully different from others, either

Test: presubmit
Change-Id: Icab977d40917aa14c629629965c6126e20f4f3ee

They don't seem to do anything. All the docs compile without them
and I don't see any additional warnings/errors being printed.

If they actually do something, the list is almost certainly incomplete
anyway.

Test: m docs
Change-Id: I1bda7c4cc1d882d80cfe38ee734643c9eed030dc

This gives the docs build access to hidden symbols, which hides issues
in the documentation.

Baseline the newly discovered issues.

Bug: 217734059
Test: m docs
Merged-In: I357f5a341a170a37152d836861a330039a83886c
Change-Id: I357f5a341a170a37152d836861a330039a83886c

Previously the tool applied baseline entries to the whole file that
had an entry. The tool is being changed to take the message into account
when applying baseline entries. Add a few additional entries to make
the build pass with that change in effect.

Bug: 217734059
Test: m docs
Change-Id: I59fcc620b0e35f9cd64a9f83f6e66824751d2837

The javadoc for @ChangeId constants are generated differently to normal
docs into a compatchanges.html page. This page is kind of compiled
stand-alone, so can only resolve references to the public SDK.
CompatModePackages itself is not in the SDK, so the @link references
in this class fail to resolve.

Fix this by using manually defined links (<a>) instead. Note that
doclava generates headers with the id of the compat constant that we can
use for the href of our <a> tags.

Bug: 303570856
Bug: 303184203
Test: m offline-sdk-docs ; inspect compatchanges.html
Change-Id: I5785098554f65b377c8f862b6e3a50225703f742

Revert submission 2759049-framework-pdf

Reason for revert: it blocks us from enabling prebuilts in next target in main (go/stale-mainline-prebuilts for more info)

Reverted changes: /q/submissionid:2759049-framework-pdf

Change-Id: I53b3216ec43471789a6c23c6b620c8a153953cc9

Due to a bug in the build system, broken @see/@link references have not
failed to build for a while, so many errors have accumulated.

This is an attempt to patch up the telephony and telecomm docs. The
most common errors and fixes were:
- @link-ing IntDef constants from javadoc. IntDefs are not present
  in the docs, so rewrite those to natural english, or point to the
  constant prefixes
- Javadoc for public symbols referencing SystemApi symbols. Change those
  to @code instead of @link

There were various other fixes too, and I'm not sure they're all
perfect, but certainly an improvement over the brokenness we have
currently.

Bug: 303184203
Test: m docs
Change-Id: I5cefc72074ced29c0b046cf59deb7ee371e74bf0

This gives the docs build access to hidden symbols, which hides issues
in the documentation.

Baseline the newly discovered issues.

Bug: 217734059
Test: m docs
Change-Id: I357f5a341a170a37152d836861a330039a83886c

This is a list of allowed issues. The intention is to trim down this
list now that adding new issues is disallowed by the build.

Bug: 217734059
Test: m docs
Change-Id: I92b45730c175566fdb1e9632016fc96c1d9db412

This file is passed to doclava to baselining existing errors in the
documentation. The contents of this baseline will be added in follow up
changes (and will be different in AOSP and internal).

Bug: 217734059
Test: m docs
Change-Id: Ibb5571fd9e55fb4f04e79e015462812e01d1ca80

This is groundwork for allowlist v2, and ensures that rdeps of
merged_txt targets appropriately reflect that these targets exist.

Fixes: 302061007
Test: Unit test update
Change-Id: I1d64635bb3db50ee525f1a557fd4b73d50dba879

Test: N/A
Change-Id: I62ae9456a8f6a7d75acf874f4b3f555cc8a68362

The non-updatable stub depends on a prebuilt platform stub, so that it
can reference APIs defined in modules. Clean up the list of previously
needed prebuilts that are no longer necessary, and add a comment about
when it's suitable to add new prebuilts to this list.

Test: m
Change-Id: Idd5f57c774db4fc48abe4bab87c1b393079cae4d

This fixes IDE (e.g. intellij) cross referencing for the
frameworks/base/api soong plugin

Fixes: 302149570
Test: Manual
Change-Id: Idcf09756a43e8a65bc863a24fd3c4d572751fa5c

A previous CL added the auto-generated aconfig Flags.FLAG sources to
metalava's input when generating core/api/current.txt, so metalava would
expand the Flags.FLAG to their values.

Do the same for the build targets for the other (system, module-lib,
test) API signature files in core/api.

Also update the API signature files accordingly.

(cherry picked from commit 162ae2a1)

Bug: 301859633
Test: m checkapi
Merged-In: Id06d77e897ecfddeaa42f75cba4d6d37bee9d1b1
Change-Id: Id06d77e897ecfddeaa42f75cba4d6d37bee9d1b1

A previous CL added the auto-generated aconfig Flags.FLAG sources to
metalava's input when generating core/api/current.txt, so metalava would
expand the Flags.FLAG to their values.

Do the same for the build targets for the other (system, module-lib,
test) API signature files in core/api.

Also update the API signature files accordingly.

Bug: 301859633
Test: m checkapi
Change-Id: Id06d77e897ecfddeaa42f75cba4d6d37bee9d1b1

Fixes: 291213387

Test: atest com.android.cts.devicepolicy.ManagedProfileTest
Change-Id: Idcda372a9644f7860266506d94efa304bd6e38f6