Skip to content
Snippets Groups Projects
Select Git revision
  • fifteen-qpr1-march-asb
  • fifteen-qpr1-new
  • fifteen-qpr1
  • fifteen-qpr0-los
  • fifteen-qpr0-new-rebase
  • fifteen-qpr0-new
  • fifteen-qpr0-rebase
  • fifteen-qpr0
  • fifteen default
9 results
Search by author
  • Any Author
  • Dhina17 Dhina17 Dhina17
1 author
  1. Sep 24, 2023
    • Android Build Coastguard Worker's avatar
      Merge cherrypicks of ['googleplex-android-review.googlesource.com/24802168']... · 42066935
      Android Build Coastguard Worker authored 
      Merge cherrypicks of ['googleplex-android-review.googlesource.com/24802168'] into sparse-10845727-L01900000963173133.
SPARSE_CHANGE: Iaa019d6d0aabdf97af0cb6995ad81270f275f3e7

Change-Id: If5e1447149aad7edee124417932df144c7240872
      42066935
    • Jordan Demeulenaere's avatar
      Post ActivityLaunchAnimator timeout on Looper.mainLooper() · 652b1c70
      Jordan Demeulenaere authored 
      This CL fixes weird shade state bugs that can happen during Activity
launches animated by the ActivityLaunchAnimator.

Before this CL, if a WindowManager timeout happened (i.e. WM never
starts or cancels the remote animation) *and* that the launchContainer
(the ViewRootImpl where the launch started) was detached, then the
timeout would never be triggered, leaving our UI in an invalid state.
This bug is currently easily reproducible using the steps from
b/300056100#comment4, where we incorrectly animate an activity launch
from a dialog then instantly dismiss that dialog.

This CL fixes this bug by posting the timeout on Looper.getMainLooper()
instead of using launchContainer.postDelayed(). That way, the timeout is
always called after 1s if WM didn't start or cancel the remote
animation.

I suspect that this is somehow what is also happening with b/288507023,
but I was not able to confirm this theory yet.

Bug: b/300056100
Bug: b/288507023
Test: Manual, made sure that b/300056100#comment4 is not reproducible
 with this CL. Unfortunately ActivityLaunchAnimator is in a separate
 library so it can't use our DelayableExecutor (that is testable), so
 I don't think there is a good way to write a unit test for this.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:df830e17f80b4d1e1f9d2334aa164baa31c49f85)
Merged-In: Iaa019d6d0aabdf97af0cb6995ad81270f275f3e7
Change-Id: Iaa019d6d0aabdf97af0cb6995ad81270f275f3e7
      652b1c70
  3. Sep 22, 2023
  5. Sep 21, 2023