Skip to content
Snippets Groups Projects
  1. Sep 22, 2023
  2. Sep 21, 2023
  3. Sep 20, 2023
  4. Sep 15, 2023
    • Priyanka Advani's avatar
      Revert "Expand @FlaggedApi(FLAG) constants in API signature files" · 157d0c18
      Priyanka Advani authored
      This reverts commit 35eb10d9.
      
      Reason for revert: Probable culprit for b/300626881
      
      Change-Id: I5f1ca00ed83d4c41659bbdeb04c4ea296f08fa71
      157d0c18
    • Mårten Kongstad's avatar
      Expand @FlaggedApi(FLAG) constants in API signature files · 35eb10d9
      Mårten Kongstad authored
      The auto-generated Flags.FLAG_NAME constants are difficult to review in
      API tracking files. metalava will expand annotation arguments if
      
        (1) the field declaration is known to metalava, and
        (2) the constant is not part of the API surface.
      
      The auto-generated constants are hidden, so not part of any API surface.
      This satisfies (1).
      
      This CL adds the auto-generated sources to metalava's input. This
      satisfies (2).
      
      Example how how this CL modifies the API signature files:
      
      -    method @FlaggedApi(Flags.FLAG_SCROLL_FEEDBACK_API) public boolean isHapticScrollFeedbackEnabled(int, int, int);
      +    method @FlaggedApi("android.view.flags.scroll_feedback_api") public boolean isHapticScrollFeedbackEnabled(int, int, int);
      
      Bug: 297881670
      Test: m checkapi
      Change-Id: I3259a2f4a114eb8c6eaff0bdbe151f6caef414aa
      35eb10d9
  5. Sep 14, 2023
    • Cole Faust's avatar
      Remove --no-banner · 95aef061
      Cole Faust authored
      This flag was deprecated in metalava.
      
      Test: presubmits
      Change-Id: I0f9001a56104f157272c0d6a05de040305f3e7f1
      95aef061
  6. Sep 13, 2023
  7. Sep 08, 2023
  8. Sep 07, 2023
  9. Aug 23, 2023
  10. Aug 17, 2023
    • Jihoon Kang's avatar
      Revert "Revert "Move java_api_library modules to f/b/api/StubLib..." · 21f8b0e9
      Jihoon Kang authored
      Revert submission 2713677-revert-2655262-move_java_api_libraries-JTESUMBERD
      
      Reason for revert: Initial revert was created to resolve build breakage, but the breakage was caused because not all CLs included in the topic were being included in the build, and was not a problem of the CLs itself.
      
      Reverted changes: /q/submissionid:2713677-revert-2655262-move_java_api_libraries-JTESUMBERD
      
      Merged-In: I479ec3b1554dcc6630207c5f095c6f9d211b035b
      Change-Id: I62fe182a5bc4418ce077f0b648efb9d358c4e7ab
      21f8b0e9
    • Jihoon Kang's avatar
      Revert "Move java_api_library modules to f/b/api/StubLibraries.bp" · a2cd198b
      Jihoon Kang authored
      Revert submission 2655262-move_java_api_libraries
      
      Reason for revert: Breaking build
      
      Reverted changes: /q/submissionid:2655262-move_java_api_libraries
      
      Change-Id: I00afc043165f56b66f092f311ad8b51c07d3f775
      a2cd198b
  11. Aug 16, 2023
  12. Aug 15, 2023
    • Harshit Mahajan's avatar
      [CrashRecovery] Add module lib to Android SDK · e0168afe
      Harshit Mahajan authored
      Adding the module libraries to combined_apis for them to be added to
      Android SDK.
      Also adding bootclasspath-fragment to platform-bootclasspath.
      
      Bug: b/289203818
      Test: m
      
      Change-Id: Ica9b0bddc2f9cb6621a01dcd3859c39357144b5f
      e0168afe
    • Mark White's avatar
      SdkTestCore for non-updatable modules · b03c1fcd
      Mark White authored
      Provides SdkTestCore/test_core_current sdk_version for non-updatable
      modules that have their test scope dependent on test apis from
      framework-minus-apex.
      
      Ignore-AOSP-First: Change in topic with internal-first projects
      Bug: 289776578
      Test: m checkapi
      
      Change-Id: I855346c01bb609e81b14dbdc13330315badc339e
      b03c1fcd
  13. Aug 14, 2023
    • Paul Duffin's avatar
      Use new merge-signatures metalava subcommand · f3b1fc4e
      Paul Duffin authored
      Bug: 295737759
      Test: ./gradlew
      Change-Id: Ied167094b04492ca49ea2b0e9d7fd91d534e483d
      f3b1fc4e
    • Jihoon Kang's avatar
      Define previous_api in full api surface stubs java_api_library defaults · 471a05ba
      Jihoon Kang authored
      previous_api input is required to migrate nullness information in
      metalava and generate loosely equivalent from-text stubs. Since
      "android.api.public.latest" is the only input for previous_api in the
      tree, this is hardcoded for full api surface java_api_library modules
      defaults for now.
      
      Test: m && compare nullness annotations for from-text stubs and from-source stubs
      Bug: 293962901
      Change-Id: Ic07db8c3bd37fa41ff245952c94b5c5b4773af36
      471a05ba
  14. Jul 11, 2023
  15. Jun 29, 2023
    • Jihoon Kang's avatar
      Rename dep_api_srcs property · 12cddb32
      Jihoon Kang authored
      This change renames java_api_library.dep_api_srcs property to
      full_api_surface_stub, to reflect the change in aosp/2637669.
      
      Test: m nothing --build-from-text-stub
      Bug: 275570206
      Change-Id: I6fc31ba33b4c067f53bae00899920dc29e16e39f
      12cddb32
  16. Jun 15, 2023
    • Jihoon Kang's avatar
      Redefine android-non-updatable.stubs.* modules definition · 491c7081
      Jihoon Kang authored
      In order to prevent build graph of the reverse dependencies of
      android-non-updatable.stubs.* from being modified based on build
      configuration (via --build-from-text-stub flag),
      android-non-updatable.stubs.* modules can be renamed with ".from-source"
      suffic, and android-non-updatable.stubs.* can contain either
      android-non-updatable.stubs.*.from-source or
      android-non-updatable.stubs.*.from-text as static libs based on build
      configuration.
      
      Test: m && m --build-from-text-stub and verify no ninja path between android-non-updatable.stubs and android-non-updatable.stubs.from-source
      Bug: 287490642
      Change-Id: I9b409ce5965384ebaeb858e0bbb007dba970632a
      491c7081
  17. Jun 02, 2023
    • Jihoon Kang's avatar
      Create full API surface java_library in combined_apis · 1453baa8
      Jihoon Kang authored
      This change renames the full api surface stub jar generating
      java_library modules by adding ".from-source" suffix and creating the
      modules in combined_apis. Either the ".from-source" module or the
      ".from-text" module is added as static libs based on the build config.
      
      Bug: 284150060
      Bug: 284995489
      Bug: 285410821
      Test: m && m --build-from-text-stub and verify no ninja path between android_stubs_current and android_stubs_current.from-source
      Change-Id: I1419af0cd0ca2199e82e3337717b6391a51267c4
      1453baa8
  18. May 17, 2023
    • Jihoon Kang's avatar
      Add java_api_library equivalence of android-non-updatable.stubs · 0c101db5
      Jihoon Kang authored
      Currently, android-non-updatable.stubs modules, which have dependencies
      on from-source creating droidstubs modules, are on the ninja critical
      path during from-text stub build. This change creates a from-text stub
      generating java_api_library equivalence of the modules.
      
      Test: m android-non-updatable.stubs.from-text \
          android-non-updatable.stubs.system.from-text \
          android-non-updatable.stubs.test.from-text \
          android-non-updatable.stubs.module_lib.from-text
      Bug: 273403800
      Change-Id: If593d3b65a6d62484749cc3085c9333e44431248
      0c101db5
    • Anton Hansson's avatar
      Remove redundant private visibilities · 9150ae4a
      Anton Hansson authored
      After the file was moved into the api subdirectory, applying private
      visibility is redundant because the default visibility of modules in
      this directory is private.
      
      Test: m nothing
      Change-Id: I3e6602a384e352682bf366f1fe914d70dafe71ee
      9150ae4a
  19. May 10, 2023
  20. May 04, 2023
  21. Apr 07, 2023
    • Jihoon Kang's avatar
      Create java_defaults in api.go · 1e4ac1d6
      Jihoon Kang authored
      combined_apis.bootclasspath lists java_sdk_library modules that
      contribute to API surfaces. The api_contribution modules generated from
      these sdk_library modules (more specifically, from droidstubs module
      created from the sdk_library module) are used to generate full api
      surface java_api_library modules. Currently, the java_defaults modules
      are hardcoded, but this leads to a duplicate source of truth, adding
      difficulty in scaling the api domains that contributes to api surfaces.
      
      Generating the java_defaults dynamically in combined_apis instead of
      hardcoding resolves this problem, as well as the discrepancy in the list
      of api contributions in aosp and internal master.
      
      Test: m android_<API_SURFACE_NAME>_stubs_current.from-text
      Bug: 277378670
      Change-Id: I987c2c1d89535d2347cf14d084c9c9a47e1db5e0
      1e4ac1d6
  22. Mar 14, 2023
    • Cole Faust's avatar
      Remove trimmed api versions file · 7ffb4338
      Cole Faust authored
      The trimmed api versions file was used to remove updatable apis from
      the lint database. This non-updatable lint database was used with
      modules that compile against module-lib or system-server sdks.
      
      However, now we have proper module-lib and system-server lint sdk
      databases, that don't have the updatable apis inherently, and we
      can remove the api versions trimmer.
      
      Bug: 193460475
      Test: Presubmits
      Change-Id: Iac50c7647491ce3e4e85f75dd92d63c6ee1286b2
      7ffb4338
  23. Mar 08, 2023
  24. Mar 07, 2023
  25. Mar 05, 2023
  26. Feb 15, 2023
    • Anton Hansson's avatar
      Convert merged srcjar rule to Android.bp · a934428b
      Anton Hansson authored
      api.go was made to create modules that were hard to create in
      Android.bp. However since we now have a filegroup with all the
      public srcjars this rule can very easily be expressed in Android.bp.
      
      Test: build before & after (no diff)
      Change-Id: I1d6c6bdcd6b75693de1e80ced13efd1d10202171
      a934428b
  27. Feb 07, 2023
  28. Dec 07, 2022
    • Hassan Ali's avatar
      Add service configinfrastructure · f237063a
      Hassan Ali authored
      Test: m
      Bug: 261723346
      Change-Id: I25b84b8690f5bcb2efaac9cae7becfa6a9a7e22e
      f237063a
    • Seth Moore's avatar
      Add remote_provisioning system service · 0277b66f
      Seth Moore authored
      This service is callable by system components like keystore2. This
      service calls into a mainline module API to do all the work for remote
      provisioning.
      
      Also include new OWNERS for the RemoteProvisioning implementation.
      
      Bug: 254112668
      Test: Locally modify keystore to call the new service
      Change-Id: I6708d0b415798c78a4d66f279589d9def552ae78
      0277b66f
  29. Dec 05, 2022
    • Nikita Ioffe's avatar
      Allow non-updatable modules to contribute to @TestApi · 5593fbbc
      Nikita Ioffe authored
      java_sdk_libraries can be part of non-updatable modules. Those modules
      might have a need to expose @TestApis that are only used in CTS tests.
      
      This change adds an ability for them to do so by introducing
      all-non-updatable-modules-test-stubs, and adding it to the
      android_test_stubs_current.
      
      Note that this change doesn't allow updatable modules to contribute to
      test API stubs, since the list of the modules that can contribute to
      test APIs stubs is hardcoded in the non_updatable_modules constant.
      
      Bug: 261004711
      Test: m
      Change-Id: I9d17f49702bd64f5718b445f14b203c146bc6794
      5593fbbc
Loading