Skip to content
Snippets Groups Projects
  1. Sep 21, 2023
    • beatricemarch's avatar
      Add more BackupManagerMonitor events to PerformUnifiedRestoreTask. · 501eeee2
      beatricemarch authored
      In particular
      add events to cover
      -If this is KV or Full restore
      -For each package, when the restore started and when it ended
      -When a restore operation starts, if it is system restore or restore at install
      -Any errors
      
      Test: manual testing. Run `adb shell bmgr restore 1` and verify that the
      new restore events are added to the dumpsys
      atest CtsBackupHostTestCases, GtsBackupHostTestCases
      atest BackupManagerMonitorDumpsysUtilsTest,
      BackupManagerMonitorEventSenderTest, UserBackupManagerServiceTest,
      PerformUnifiedRestoreTaskTest, BmgrTest
      Bug: 290747920
      
      Change-Id: I0d221f10932fea3e8fb90a1827c7f1b5bf21d25d
      501eeee2
  2. Sep 12, 2023
  3. Sep 07, 2023
  4. Sep 06, 2023
  5. Sep 05, 2023
  6. Sep 01, 2023
  7. Aug 30, 2023
    • Yurii Zubrytskyi's avatar
      Clean up the attribute searching func · e7de40d9
      Yurii Zubrytskyi authored
      Don't convert each attribute name but instead only
      do it once for the string they're compared to
      
      Bug: 282215580
      Test: build + atest idmap2_tests
      Change-Id: I09f6d0f90f6c09632ceac8cdde7c20801f41524e
      e7de40d9
  8. Aug 28, 2023
  9. Aug 24, 2023
  10. Aug 23, 2023
  11. Aug 22, 2023
  12. Aug 18, 2023
  13. Aug 15, 2023
  14. Aug 11, 2023
  15. Aug 09, 2023
    • Jeremy Meyer's avatar
      Allow AssetFileDescriptors to be used to create FRROs · c04bcb39
      Jeremy Meyer authored
      Before this change, if a (system) app tried to use an image from its
      assets to create an FRRO it would succeed but no image would display.
      That is because when it is an asset we have an AssetFileDescriptor which
      internally has a file descriptor, offset, and size and the file
      descriptor would point at the apk itself. When this would get passed to
      the native layer to create the frro only the file descriptor would get
      passed so we would copy the whole apk, not just the image.
      
      This allows apps to pass in an AssetFileDescriptor directly which we can
      then use to also pass down the offset and size to the native layer and
      only copy the image part.
      
      Fixes: 289739832
      Test: atest FabricatedOverlayTest
      Change-Id: I80dceb19229a6a3c02851a5451ea6d46798981b3
      c04bcb39
    • Eric Biggers's avatar
      Make locksettings commands go through "cmd lock_settings" · 7d4a9fd5
      Eric Biggers authored
      This greatly improves the performance of locksettings commands, and it
      eliminates the need for LockSettingsCmd.java.
      
      Bug: 177985929
      Test: locksettings command still works
      Change-Id: I5881fa074681f6bf1ad2f5969a282d928121ddb2
      Merged-In: I5881fa074681f6bf1ad2f5969a282d928121ddb2
      (cherry picked from commit 4d38b0cd)
      7d4a9fd5
  16. Jul 31, 2023
    • jeimysantiago's avatar
      Update Error Status Check · 8ee92d11
      jeimysantiago authored
      Updating check for captureDisplay ID error status.
      
      Bug: 287081404
      Test: atest displayScreenshot
      Test: atest ScreenCaptureTest#captureDisplayWithUid
      Change-Id: Ic1cdf47a5e5044ac25ab6b7e420d29b8421c8b5d
      8ee92d11
  17. Jul 28, 2023
  18. Jul 27, 2023
    • Vova Sharaienko's avatar
      RESTRICT AUTOMERGE Make log reader thread a class member · 5a0f6c5b
      Vova Sharaienko authored
      pushedEventThread references class members after detaching. Making
      pushedEventThread as class member and joining in statsService
      destructor. Adding a method to stop readLogs thread.
      
      Ignore-AOSP-First: Bug is in still security triage and fuzzer is
      crashing on startup.
      Test: atest statsd_test
      Test: m statsd_service_fuzzer && adb sync data && adb shell
      /data/fuzz/arm64/statsd_service_fuzzer/statsd_service_fuzzer -runs=10000
      Bug: 285645039
      
      Change-Id: I1e886f9ccb7203714216da061c35e793b2a63d8a
      Merged-In: I1e886f9ccb7203714216da061c35e793b2a63d8a
      5a0f6c5b
    • Vova Sharaienko's avatar
      RESTRICT AUTOMERGE Make log reader thread a class member · 03de4e4f
      Vova Sharaienko authored
      pushedEventThread references class members after detaching. Making
      pushedEventThread as class member and joining in statsService
      destructor. Adding a method to stop readLogs thread.
      
      Ignore-AOSP-First: Bug is in still security triage and fuzzer is
      crashing on startup.
      Test: atest statsd_test
      Test: m statsd_service_fuzzer && adb sync data && adb shell
      /data/fuzz/arm64/statsd_service_fuzzer/statsd_service_fuzzer -runs=10000
      Bug: 285645039
      
      Change-Id: I1e886f9ccb7203714216da061c35e793b2a63d8a
      03de4e4f
  19. Jul 25, 2023
    • Lee George Thomas's avatar
      Change the bootanim time file location. · 7a2548b5
      Lee George Thomas authored
      This change moves the bootanim time file location from
      /data/bootanim/time to /data/misc/bootanim/time. This is to address the
      recommendation in b/232299581#comment8.
      
      Bug: 210757252
      Test: Boot animation can show time. No SELinux violations.
      Change-Id: I8fcf9943911f6f3f0af4d6c3ae391c5805bf7885
      7a2548b5
  20. Jul 24, 2023
    • Harry Cutts's avatar
      uinput: tidy up the README · 81383a7b
      Harry Cutts authored
      The main changes are:
      
      * Describe how multiple commands are passed to `uinput`
      * Split details about waiting after device registration into its own
        section
      * Add details on the JSON extensions `uinput` uses
      * Change example code blocks to JSON5 syntax to better accommodate the
        JSON extensions
      * Use absolute links to Android Codesearch instead of relative ones
      * Fix various Markdown issues and improve formatting
      
      Bug: 280604085
      Test: check rendering in Google Markdown
      Change-Id: Ic6d5f3e9d1415fcd9425b1afc767574a65556578
      81383a7b
  21. Jul 21, 2023
    • Thomas Stuart's avatar
      CTS to ensure telecom can bind to NonUiInCallService wo export prop. · e2e79d98
      Thomas Stuart authored
      This CL is a postmortem action which is detailed in the linked bug.
      In short, an OEM had the telecom stack outside of the system process
      and had a non-ui InCallService it wanted to bind.  However, the
      InCallService set the Exported property to false.  This combo caused
      a calling outage that prevented users from making/receiving calls.
      
      To prevent the above scenaro from occuring again, this new CTS test
      was created. It tests the Telecom stack of the OEM against a
      non-ui InCallService that has it's exported property set to false.
      
      Bug: 198715680
      
      Test: 1 new CTS test,
            NonUiInCallServiceWoExportTest
            #testTelecomCanBindToNonUiInCallServiceThatIsNotExported
      
      Change-Id: I5b99aa9c7e989a1c20a7b086f65782286a8be575
      e2e79d98
  22. Jul 18, 2023
  23. Jul 11, 2023
    • Yurii Zubrytskyi's avatar
      Reland "Use reference counted pointers for ApkAssets" · 1cf74939
      Yurii Zubrytskyi authored
      This reverts commit cf6e79f8
      
      Updates:
          Prepare the shared pointers for the whole operation at once
          instead of re-locking them on each iteration.
          Still a regression of about 5% for changing theme's
          AssetManager object, vs the original 40%
      
          + change the log message to a warning as it doesn't break
            the app
      
      Original comment:
      
          Use reference counted pointers for ApkAssets
      
          The primary reason for memory corruption is freed ApkAssets
          Java expected them to only be freed in the finalizers, but
          there are explicit close() calls now, destroying objects that
          are still in use in some AssetManager2 objects
      
          This CL makes sure those AssetManagers don't assume ApkAssets
          always exist, but instead tries to lock them in memory for any
          access
      
          It also adds logging in case of deleting an assets object with
          any weak pointers still existing. Those will get into the
          bugreports attached to related bugs to help with investigation.
      
          Benchmarks don't regress, and the device appears to be working.
          Given that the crashes used to be pretty rare, let's wait for
          any new reports or lack of those.
      
          + add a missing .clang-format file to the jni directory
          + enabled C++23 in the project that uses AssetManager headers
      
          Bug: 197260547
          Bug: 276922628
          Test: unit tests + boot + benchmarks
          Old change id: I495fd9e012fe370a1f725dbb0265b4ee1be8d805
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b3455190124b41e2deb1774d9c05b396b73b41a2)
      Merged-In: Id668fbcf07db17b09691a344c04e98df83006f97
      Change-Id: Id668fbcf07db17b09691a344c04e98df83006f97
      1cf74939
  24. Jul 10, 2023
    • Daniel Norman's avatar
      Prepares the main looper for UiAutomator shell command. · 5e92d2e2
      Daniel Norman authored
      The underlying UiAutomation object uses classes which expect
      the main looper to have been prepared.
      
      Fix: 289444999
      Test: adb shell uiautomator dump
      Test: Use go/hsv to take a snapshot
      Change-Id: I43fcc4e9b4c1ab6e09aacd73f638208094641554
      5e92d2e2
  25. Jul 05, 2023
  26. Jul 01, 2023
    • Oleg Lyovin's avatar
      bootanimation: do not create texture for parts with count=1 · 6a4b84d2
      Oleg Lyovin authored
      
      When bootanimation contains part that is played only once,
      there is no need to create a separate texture for its frames.
      
      Such an approach allows to reduce memory consumption for
      typical use case of such an animations, when a part
      consists of a lot of frames played only once.
      
      Actually, it was already implemented earlier, but part of it
      was lost in 'd711ac48'.
      Moreover, the remained part leads to memory leak in
      current implementation on BootAnimation.cpp:1712.
      
      Test: play bootanimation with part.count=1 and a lot of
      frames, and check memory consumption.
      
      Change-Id: If3a0fa890f6f9e7abc0db2fe96b5635a1663fb8a
      Signed-off-by: default avatarOleg Lyovin <ovlevin@sberdevices.ru>
      6a4b84d2
  27. Jun 20, 2023
    • Pawan Wagh's avatar
      Use readUniqueFileDescriptor in incidentd service · ba78ef27
      Pawan Wagh authored
      readFileDescriptor doesn't provide ownership of the fds. fdopen
      needs ownership of the fds. Fds read from parcel should be duped
      in this scenario and readUniqueFileDescriptor dups fds internally.
      
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Test: atest incidentd_test
      Bug: 286931110
      Bug: 283699145
      Change-Id: Ibe03a17dee91ac5bf25d123d4fd9c0bdd3c7d80e
      ba78ef27
  28. May 26, 2023
    • Dominik Laskowski's avatar
      screencap: Allow virtual display ID in -d switch · 622c4aef
      Dominik Laskowski authored
      Ibe3679d810602456205e157fe2cb8cc510062215 restricted the argument to
      PhysicalDisplayId, which prevents capture of virtual displays.
      
      Fixes: 280785757
      Test: screencap -d <id>
      Change-Id: I41a8d1adaa51c6804c03f1b3084ac04ff6b4f1fa
      622c4aef
  29. May 22, 2023
    • Devin Moore's avatar
      Change libidmap2_policies to static · 39fe2cc1
      Devin Moore authored
      The library only has headers so the shared library overhead is not worth
      it.
      
      Test: m
      Bug: 280829178
      Change-Id: Ie138d1be95aaad9b230407cf03a46d182dd2a307
      39fe2cc1
  30. May 19, 2023
    • Pawan Wagh's avatar
      Check for null ferr · 428871d0
      Pawan Wagh authored
      fout is double checked for nullptr instead of ferr which forces
      to call fclose on null ferr.
      
      Test: atest incidentd_test
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      with clusterfuzz testcase
      Bug: 283453191
      
      Change-Id: I3a4912cf70f4f32cb66fb870febbbfff1a7c6adc
      428871d0
  31. May 17, 2023
    • Yurii Zubrytskyi's avatar
      [idmap] Cache target apks as they are often reused · 70ded194
      Yurii Zubrytskyi authored
      idmap2d is being often called for the same targets, e.g. system
      apps. Caching those apks makes idmap verification and creation
      much faster e.g. for user switching
      
      Test: build + boot + UTs
      Bug: 271904589
      Change-Id: Ib6f7af385c2389b50d5c74aa08b4bab290580809
      70ded194
  32. May 16, 2023
    • Pawan Wagh's avatar
      Fix null-deref crash while fuzzing · 54826461
      Pawan Wagh authored
      When random parcel is sent to incidentd, AIDL service
      crashes with null pointer dereference.
      
      Test: atest incidentd_test
      Test: m incidentd_service_fuzzer && adb sync data && adb shell /data/fuzz/x86_64/incidentd_service_fuzzer/incidentd_service_fuzzer
      Bug: 282963041
      Change-Id: I0e0ebc479acbfd3f5e9f56b629380b5d90021f45
      54826461
Loading