Skip to content
Snippets Groups Projects
  1. Sep 25, 2023
    • wilsonshih's avatar
      Notify launch app over lockscreen to keyguard transition handler. · 5b7daf45
      wilsonshih authored
      Provide a short term workaround for shell transition, let Keyguard
      service notify KeyguardTransitionHandler that there has created a
      remote transition request for next launch app transition, so the
      transition doesn't needs to be handled by KeyguardTransitionHandler.
      
      Bug: 297859920
      Test: launch app from Keyguard, verify the KeyguardTransitionHandler
      can handle that open-app transition.
      
      Change-Id: If146900a0411a532679e930ca4e317cb1b7a7969
      5b7daf45
    • wilsonshih's avatar
      Ask remote transition handler to handle transiton in MixedHandler · df291c52
      wilsonshih authored
      When DefaultMixedHandler#handleRequest is going to handle a remote
      transition, also ask remote transition handler to handle the remote
      transition, so if the leftover handler cannot handle the transition,
      the remote transition handler can have chance to handle it.
      
      Bug: 301047305
      Test: create a split screen pair, then launch app from notification,
      verify remote transition handler can play the transition while split
      cannot handle it.
      Test: create a split screen pair with one of app is pip-able, then
      launch app from notification, verify the app can enter pip, and the
      remote transition handle can play the open transition animation.
      
      Change-Id: I84a4b7c26c57498d17baca58811db19f00aa2714
      df291c52
  2. Sep 22, 2023
    • Matt Buckley's avatar
      Mitigation for mass GC deletion · 237bb385
      Matt Buckley authored
      Delete sessions after 2 seconds from when CC::destroy() is called, to
      ensure they get the chance to be re-used without being destroyed but
      still get destroyed if they aren't re-used.
      
      This also adds several new unit tests around the functionality to ensure
      its thread-safety.
      
      Test: hwuitest
      Bug: 300360668
      Change-Id: Icc35293ff49e14dc3599fc12d153f70acd29042a
      Merged-In: Icc35293ff49e14dc3599fc12d153f70acd29042a
      (cherry picked from commit 0daae6aa)
      237bb385
    • Diego Vela's avatar
      Add raw configuration change listener updates. · 852dd9d8
      Diego Vela authored
      Add raw configuration change listener updates. Letterboxed Activities do
      not receive a configuration update when they are repositioned. Listening
      to all configuration changes will correctly update folding features.
      Change exceptions from hard exceptions to Log.wtf so that we do not
      crash on production apps.
      
      Bug: 295785410
      Test: Open Samples and open the slim (letterbox) Activities.
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1a7c2f292e7cc1fddfc9b0c64d1e5e4264f60144)
      Merged-In: Ia079d06a403a59bb0f1eafdaad6ce238749a2af2
      Change-Id: Ia079d06a403a59bb0f1eafdaad6ce238749a2af2
      852dd9d8
    • Matt Buckley's avatar
      Add unit tests for HintSessionWrapper · 87765575
      Matt Buckley authored
      This patch adds several unit tests for HintSessionWrapper, including
      one specifically for a recent race condition memory leak.
      
      It also refactors HintSessionWrapper to better support testing, and
      creates a macro to shorten the dlsym bindings.
      
      Bug: 299541959
      Test: hwuiunit
      
      Change-Id: I05ed15cdbd157b109667563d30627cfc4ae83777
      Merged-In: I05ed15cdbd157b109667563d30627cfc4ae83777
      (cherry picked from commit 0c668368)
      87765575
    • Diego Vela's avatar
      Report folding features to letterboxed apps. · e5295899
      Diego Vela authored
      Letterboxed apps lost support for Folding Features. We are enabling
      reporting folding features to letterboxed apps again.
      Report folding features if an Activity is embedded or not in
      PiP.
      
      Bug: 295785410
      Test: atest CtsWindowManagerJetpackTestCases
      (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b1deb55446c3b5a2d46cc2751ac0200ef5986fa2)
      Merged-In: Ib964b22278c31982a3d6bf66abaab3dac0c4093b
      Change-Id: Ib964b22278c31982a3d6bf66abaab3dac0c4093b
      e5295899
    • Diego Vela's avatar
      Add raw configuration change listener updates. · 1a7c2f29
      Diego Vela authored
      Add raw configuration change listener updates. Letterboxed Activities do
      not receive a configuration update when they are repositioned. Listening
      to all configuration changes will correctly update folding features.
      Change exceptions from hard exceptions to Log.wtf so that we do not
      crash on production apps.
      
      Bug: 295785410
      Test: Open Samples and open the slim (letterbox) Activities.
      Merged-In: Ia079d06a403a59bb0f1eafdaad6ce238749a2af2
      Change-Id: Ia079d06a403a59bb0f1eafdaad6ce238749a2af2
      1a7c2f29
    • Diego Vela's avatar
      Report folding features to letterboxed apps. · b1deb554
      Diego Vela authored
      Letterboxed apps lost support for Folding Features. We are enabling
      reporting folding features to letterboxed apps again.
      Report folding features if an Activity is embedded or not in
      PiP.
      
      Bug: 295785410
      Test: atest CtsWindowManagerJetpackTestCases
      Merged-In: Ib964b22278c31982a3d6bf66abaab3dac0c4093b
      Change-Id: Ib964b22278c31982a3d6bf66abaab3dac0c4093b
      b1deb554
    • Orhan Uysal's avatar
      Create RotateImmeriveAppInFullscreenTest · e3e759b5
      Orhan Uysal authored
      Introduce a new test for when immersive apps are rotated. This test
      makes sure that the rotation button appears on the screen after the
      rotatation and the app is in fullscreen mode. Note that this test works
      only on CF devices.
      
      Test: Manual
      Bug: 285849560
      Change-Id: I325b0e4e8dac075080a1b4d4cc43eb7f7b6be6a5
      e3e759b5
    • Mady Mellor's avatar
      Catch an exception when loading a bubble icon · a81b4a0d
      Mady Mellor authored
      If an app gives us a shortcut whose icon can't be looked up, an
      exception is thrown. This CL modifies the code to catch an
      exception and default to the app icon instead of the shortcut
      icon.
      
      Test: manual - modify icon loading code to throw an exception
                   - create a bubble
      	     => observe there is no crash and the bubble uses
      	        the app icon instead
      Bug: 300073572
      
      Change-Id: Iedc9825c42ec2f50bb9939e34acd9f1960dd229e
      (cherry picked from commit bf533694)
      a81b4a0d
    • Eghosa Ewansiha-Vlachavas's avatar
      [3/n] Optimize user aspect ratio button heuristic · e17d8734
      Eghosa Ewansiha-Vlachavas authored
      If `updateCompatInfo` is called while the user aspect ratio button is
      showing, the buton will be removed as we no longer consider the layout
      to have a button as it has already been shown.
      
      Update `getHasUserAspectRatioSettingsButton` so the layout is consider
      to have a button for the duration the button is visible and only once
      the button has been shown and timed out, will the layout be considered
      to not have a button.
      
      Test: atest WMShellUnitTests:UserAspectRatioSettingsWindowManagerTest
      Bug: 301323072
      Bug: 289356588
      Change-Id: Ie4be836d52b74e285a501a799094022be24870fe
      e17d8734
    • Bill Yi's avatar
      Import translations. DO NOT MERGE ANYWHERE · 59e3f1c2
      Bill Yi authored
      Auto-generated-cl: translation import
      Change-Id: I4aec97f247016d63d80e1b436de2254124741446
      59e3f1c2
    • Diego Vela's avatar
      Add raw configuration change listener updates. · 1582f483
      Diego Vela authored
      Add raw configuration change listener updates. Letterboxed Activities do
      not receive a configuration update when they are repositioned. Listening
      to all configuration changes will correctly update folding features.
      Change exceptions from hard exceptions to Log.wtf so that we do not
      crash on production apps.
      
      Bug: 295785410
      Test: Open Samples and open the slim (letterbox) Activities.
      Change-Id: Ia079d06a403a59bb0f1eafdaad6ce238749a2af2
      1582f483
    • Diego Vela's avatar
      Report folding features to letterboxed apps. · 213e577b
      Diego Vela authored
      Letterboxed apps lost support for Folding Features. We are enabling
      reporting folding features to letterboxed apps again.
      Report folding features if an Activity is embedded or not in
      PiP.
      
      Bug: 295785410
      Test: atest CtsWindowManagerJetpackTestCases
      Change-Id: Ib964b22278c31982a3d6bf66abaab3dac0c4093b
      213e577b
    • Bill Yi's avatar
      Import translations. DO NOT MERGE ANYWHERE · c73dbda3
      Bill Yi authored
      Auto-generated-cl: translation import
      Change-Id: Ifafc3cc9280e9a33ba0d4ae7cd6318220fe72eeb
      c73dbda3
    • Bill Yi's avatar
      Import translations. DO NOT MERGE ANYWHERE · beca32d2
      Bill Yi authored
      Auto-generated-cl: translation import
      Change-Id: I89fc1aaf1f8e30ce0d46be994018697d4a4b5755
      beca32d2
    • Bill Yi's avatar
      Import translations. DO NOT MERGE ANYWHERE · 800081d3
      Bill Yi authored
      Auto-generated-cl: translation import
      Change-Id: Ie4df7ab5d0224719970a92f02cd6675564225331
      800081d3
    • wilsonshih's avatar
      Monitor package change to update AttributeCache for non-system server. · 85dc2fd8
      wilsonshih authored
      So the corresponding resources can be load correctly after package
      update.
      
      Bug: 300655500
      Bug: 299877330
      Test: update app resources and re-install test app, verify there should
      load latest resources.
      
      Change-Id: I7753bfc58c9a30c9a21a76b175ae18742e6750d9
      85dc2fd8
  3. Sep 21, 2023
    • Sukesh Ram's avatar
      Update Window Header Text Font & Position · 4415394c
      Sukesh Ram authored
      Aligned the app name text, app icon, and expand icon positions to be consistent with window header spec. Set the app name text’s font to be “GM3/ Title / Small” (TextAppearance.Material.Title). Changed expand more icon’s drawable to be consistent with launcher’s (ic_expand_more.xml).
      
      Since Header background color and icon colors are still being decided
      upon, only the app name font and the app/text/icon alignment aspects of
      the spec above are addressed in this CL.
      
      Test: Manual
      Bug: 298199770
      Change-Id: I63fb223c39a754b3f67cc814a863152e484b3c7a
      4415394c
    • Mateusz Cicheński's avatar
      Remove the cast and use the override then() · 645ca825
      Mateusz Cicheński authored
      Change-Id: I137961a97c68f628fcc8b945f45665ce81e0e9b2
      Test: atest AutoEnterPipFromSplitScreenOnGoToHomeTest
      Bug: 301107915
      645ca825
    • Mady Mellor's avatar
      Add some tests for BubbleViewInfoTask · bfbbe9fa
      Mady Mellor authored
      - Test that populating icons & inflating views work
      - Test that exception loading shortcut icon doesn't doesn't crash
      
      Test: atest BubbleViewInfoTest
      Bug: 300073572
      Change-Id: I0c67cf78d344334b3968f9bc03df0d72e34a1082
      bfbbe9fa
    • Winson Chung's avatar
      Preemptively reset split reparenting flag when entering split · 9cd12c2a
      Winson Chung authored
      - Currently, this flag is not reset until we start the animation or when
        the stage visibilities officially change, but following a drop to
        initiate split and Shell actually receiving the transition,
        the app may launch a trampoline activity (ie. esp during create)
        which will trigger the task to be reparented back out of the
        split root (preventing split from succeeding).  Instead we preemptively
        reset this state when we know that we are about to enter split, and
        rely on the existing paths to update the flag when the split is next
        fully shown or hidden.
      
      Bug: 292454704
      Test: Drag app that launches a trampoline into split
      Change-Id: I17c8b7e92dfbf18a1bd1a9ca64b7ee7f3097f233
      9cd12c2a
    • Pablo Gamito's avatar
      Update expected scenario for DismissSplitScreenByDivider · 45f79af1
      Pablo Gamito authored
      In this case we don't seem to tag the SPLIT_SCREEN_EXIT cuj
      
      Bug: 300260196
      Test: atest com.android.wm.shell.flicker.service.splitscreen.flicker.DismissSplitScreenByDividerGesturalNavLandscape
      Change-Id: I3b507f5cab638376c170255df9e93d0ca496bb06
      45f79af1
    • Pablo Gamito's avatar
      Disable rotation check to enter overview · 5f101dcf
      Pablo Gamito authored
      If we are on the launcher on a phone we are likely to be in portrait which will fail the switchToOverview action.
      
      Bug: 300065764
      Test: atest com.android.wm.shell.flicker.service.splitscreen.flicker.EnterSplitScreenFromOverviewGesturalNavLandscape
      Change-Id: I9542409f2c28b1996ad958d8c572e53ca7ea2537
      5f101dcf
    • Eghosa Ewansiha-Vlachavas's avatar
      [2/n] Optimize user aspect ratio button heuristic · 92210feb
      Eghosa Ewansiha-Vlachavas authored
      Don't show the user aspect ratio settings button after a transparent
      activity has been dismissed if it was previously shown for the previous
      activity.
      
      Test: atest WMShellUnitTests:CompatUIControllerTest
      Fix: 299080123
      Bug: 289356588
      Change-Id: Iab00c25cb0c105696bdd40dd4ebc35c5f34ed1b0
      92210feb
    • Eghosa Ewansiha-Vlachavas's avatar
      [1/n] Optimize user aspect ratio button heuristic · 6fb5384a
      Eghosa Ewansiha-Vlachavas authored
      Don't allow the user aspect ratio settings button to be shown more than
      once for the current application visible to the user.
      
      Test: `atest WMShellUnitTests:UserAspectRatioSettingsWindowManagerTest`
            `atest WMShellUnitTests:UserAspectRatioSettingsLayoutTest`
            `atest WMShellUnitTests:CompatUIControllerTest`
      Fix: 300226988
      Bug: 299078364
      Bug: 289356588
      Change-Id: Ib32df6b2ac6aaf7a7446f7b5be5cd684b9f7ebde
      6fb5384a
    • John Reck's avatar
      Add some flags · 37b52d42
      John Reck authored
      Test: make
      Change-Id: I9f74b8145e5b97498088d5d09e00286439f547ab
      37b52d42
    • Massimo Carli's avatar
      Add package information to user aspect ratio intent · a589a858
      Massimo Carli authored
      Bug: 296564769
      Test: Manual
      
      Change-Id: I53248042c2907e29f7fd13859e2879e8e79a18ff
      a589a858
    • Pablo Gamito's avatar
      Update expected scenarios for EnterSplitScreenByDragFromAllApps · 586611a9
      Pablo Gamito authored
      We don't seem to tag this scenario with anything right now.
      
      Bug: 301093332
      Test: atest com.android.wm.shell.flicker.service.splitscreen.flicker.EnterSplitScreenByDragFromAllAppsGesturalNavLandscape on tablet
      Change-Id: I8168061b396d02c54b0de1b96dcc27535e75681a
      586611a9
    • Pablo Gamito's avatar
      Add FlickerServiceRule to splitscreen platinum tests · 339244f5
      Pablo Gamito authored
      Bug: 295337691
      
      Test: ABTD
      Change-Id: I79afb557e7fc5d4149e65eb2537bda1686bb67f6
      339244f5
  4. Sep 20, 2023
    • Sukesh Ram's avatar
      Fix Handle Menu Color & Enable NightMode Toggle · 94247f95
      Sukesh Ram authored
      Implemented new themes for handle menu of OnSurface (text) and onSurfaceBright (background).
      
      Also implemented theme toggling for menu when night mode is toggled as per spec, by triggering relayout whenever night mode is changed.
      
      Tested by changing night mode setting manually (swipe down and enable Dark Theme). Manually validated new and existing windows’ handle menus as well as the handle menu with close button visible (on full screen)
      
      Test: Manual
      Bug: 276785394
      Change-Id: I5604eb12325acc1f6d109dbc369a0f62949448ab
      94247f95
    • Evan Rosky's avatar
      Revert "Keep z-order of tasks when merged into recents transition" · 8a4a2efa
      Evan Rosky authored
      This reverts commit 5742d6b0.
      
      Reason for revert: Messes up the order for restoration at end.
      
      Change-Id: I391aa73da259652b4200040bcecb8fd1cf4a7106
      8a4a2efa
    • Mateusz Cicheński's avatar
      Fix assertion for entering PiP from landscape split screen · 89ddea90
      Mateusz Cicheński authored
      Test: atest AutoEnterPipFromSplitScreenOnGoToHomeTest
      Bug: 301107915
      
      Change-Id: I99aea254ec3f87b0b3dfebcc50f0461067718ad6
      89ddea90
    • Maryam Dehaini's avatar
      Change fullscreen caption height to 36dp · 62d56487
      Maryam Dehaini authored
      Change the fullscreen caption height so that it matches the status bar
      height.
      
      Bug: 297559120
      Test: Open fullscreen task. Status bar icons should be vertically
      centered in the caption.
      
      Change-Id: Ia2208514b85680405989cb8034cf293f96bd660b
      62d56487
    • Jorge Gil's avatar
      Convert DesktopModeWindowDecorViewModelTests to kt · 6ffe36f5
      Jorge Gil authored
      Bug: None
      Test: atest DesktopModeWindowDecorViewModelTests
      Change-Id: Ic37afd362fef68bfd393a494057d45e1e4fe71e1
      6ffe36f5
    • Jorge Gil's avatar
      Use TestableLooper.RunWithLooper in unit tests · 78ecb6ef
      Jorge Gil authored
      These tests must run on a looper thread because they're UI related.
      TestableLooper takes care of running the class/tests on a looper thread
      without manually posting and awaiting a CountDownLatch.
      
      Bug: None
      Test: atest DesktopModeWindowDecorViewModelTests
      Change-Id: I37127a0f98c25d52f75746f4915e6cba552838f6
      78ecb6ef
    • Pablo Gamito's avatar
      Fix tapl unexpected rotation errors · 1ffa69e1
      Pablo Gamito authored
      Bug: 300065764
      Test: atest WMShellFlickerServiceTests
      Change-Id: I179614bf64ff3171879303e24827ba340368c6a9
      1ffa69e1
    • Pablo Gamito's avatar
      Update expected CUJ for DismissSplitScreenByGoHome · 69147f18
      Pablo Gamito authored
      We don't seem to trigger a SPLIT_SCREEN_EXIT in this case yet.
      
      Bug: 301222449
      Test: atest com.android.wm.shell.flicker.service.splitscreen.flicker.DismissSplitScreenByGoHomeGesturalNavPortrait
      Change-Id: I478f00db59a30188ac7038fac8172a6397294b2e
      69147f18
    • Pablo Gamito's avatar
      Disable AutoEnterPipFromSplitScreenOnGoToHomeTest in landscape · e320f2a1
      Pablo Gamito authored
      Bug: 301107915
      
      Test: abtd
      Change-Id: Ib9a9be836c2c4b26fa9e6696ab5f2a0be30ef0d3
      e320f2a1
    • Jorge Gil's avatar
      Use immutable window decor Configuration in RelayoutParams · bbe3d7d2
      Jorge Gil authored
      Previously, the Context's Configuration was passed in as the
      mWindowDecorConfig in relayout params to perfom diff checks against the
      previous relayout's Configuration (e.g. to check for densityDpi changes).
      However, the Configuration was passed in as a reference which meant that
      when the context's config changed (e.g. density value), the reference
      held by the window decoration set from the params was mutating immediately
      and when diff checks were made both the old and the new Configurations
      were actually the same object with the density being current on both.
      This resulted in false-negatives as oldDensity==newDensity comparisons
      always evaluated to true even if the density had just changed.
      To actually compare the old vs new Configuration, a copy needs to be
      passed in to relayout params that won't be mutated when the context
      configuration changes.
      
      Bug: 301119301
      Test: `adb shell wm density 300`, then 400 - verify oldDensityDpi and
      newDensityDpi reflect 300 and 400 respectively, causing the views to be
      released and reinflated.
      
      Change-Id: Id29feb5567cc7f865aa4c158a200d5079f674b31
      bbe3d7d2
Loading