Skip to content
Snippets Groups Projects
Select Git revision
  • fifteen-qpr1-march-asb
  • fifteen-qpr1-new
  • fifteen-qpr1
  • fifteen-qpr0-los
  • fifteen-qpr0-new-rebase
  • fifteen-qpr0-new
  • fifteen-qpr0-rebase
  • fifteen-qpr0
  • fifteen default
9 results
Search by author
  • Any Author
  • Dhina17 Dhina17 Dhina17
1 author
  1. Oct 23, 2023
  3. Oct 21, 2023
  5. Oct 20, 2023
    • Roshan Pius's avatar
      Merge "services: Dont statically include classes in bootclasspath" into main am: ce9b8fa2 · 058b2555
      Roshan Pius authored 
      Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2798518



Change-Id: If051ec54db5b6f34b574272ac74f8a9112d0067b
Signed-off-by: default avatarAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
      058b2555
    • Sumedh Sen's avatar
      Recycle the original bitmap after scaling down · 99396a46
      Sumedh Sen authored 
      This will free the memory used by the original bitmap

Bug: 290862169
Bug: 304567418
Test: Manual. Install the APK attached in b/290862169#comment18
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:74d9576bec1fd0f0ef25936eb672b9e733b0e3e7)
Merged-In: I94f5a9a4313c13375062fdade0e672d51eb5dc55
Change-Id: I94f5a9a4313c13375062fdade0e672d51eb5dc55

NOTE FOR REVIEWERS - errors occurred while applying the patch.
PLEASE REVIEW CAREFULLY.
Errors:
Error applying patch in packages/PackageInstaller/src/com/android/packageinstaller/PackageUtil.java, hunk HunkHeader[172,7->172,7]: Hunk cannot be applied

Original patch:
 From 74d9576b Mon Sep 17 00:00:00 2001
From: Sumedh Sen <sumedhsen@google.com>
Date: Thu, 12 Oct 2023 10:13:35 -0700
Subject: [PATCH] Recycle the original bitmap after scaling down

This will free the memory used by the original bitmap

Bug: 290862169
Bug: 304567418
Test: Manual. Install the APK attached in b/290862169#comment18
Change-Id: I94f5a9a4313c13375062fdade0e672d51eb5dc55
---
      99396a46
    • Sumedh Sen's avatar
      Resize large app icons before adding them in a parcel · df3af7fd
      Sumedh Sen authored 
      If an app icon is too large, scale the icon down so that it can be
parcelled and sent in an intent.

Bug: 290862169
Bug: 304567418
Test: Manual. Install the APK attached in b/290862169#comment18
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:2fc482f6fd8ba4217a4f9c956dfdb45c6494974e)
Merged-In: I5feafea491208c8fd6bbdc6b2b655d46b6964d95
Change-Id: I5feafea491208c8fd6bbdc6b2b655d46b6964d95


Original patch:
 From 2fc482f6 Mon Sep 17 00:00:00 2001
From: Sumedh Sen <sumedhsen@google.com>
Date: Wed, 11 Oct 2023 12:19:50 -0700
Subject: [PATCH] Resize large app icons before adding them in a parcel

If an app icon is too large, scale the icon down so that it can be
parcelled and sent in an intent.

Bug: 290862169
Bug: 304567418
Test: Manual. Install the APK attached in b/290862169#comment18
Change-Id: I5feafea491208c8fd6bbdc6b2b655d46b6964d95
---
      df3af7fd
    • Roshan Pius's avatar
      Merge "services: Dont statically include classes in bootclasspath" into main · ce9b8fa2
      Roshan Pius authored
      ce9b8fa2
    • Sumedh Sen's avatar
      Make AppSnippet parcelable · c1647930
      Sumedh Sen authored 
      AppSnippet is used in Pia in 4 activities. Each time, it is expensive to
parse the app's logo and label from PackageManager and the APK file of
the app being installed. Thus, lets compute the AppSnippet once and pass
it as an intent extra to whichever activity needs it.

This also solves the bug where InstallSuccess showed an activity's name
in place of the app label since the temporary directory used to create
AppSnippet is already destroyed after app installation.

Bug: 290862169
Test: Manually install an APK and observe the app install / update
dialog
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:719d00a979005e1b5919694305b015e1970992d9)
Merged-In: I2095b092e1a7b3186ff4cdc4c81effce51377b19
Change-Id: I2095b092e1a7b3186ff4cdc4c81effce51377b19

Original patch:
 From 719d00a9 Mon Sep 17 00:00:00 2001
From: Sumedh Sen <sumedhsen@google.com>
Date: Tue, 18 Jul 2023 15:00:59 -0700
Subject: [PATCH] Make AppSnippet parcelable

AppSnippet is used in Pia in 4 activities. Each time, it is expensive to
parse the app's logo and label from PackageManager and the APK file of
the app being installed. Thus, lets compute the AppSnippet once and pass
it as an intent extra to whichever activity needs it.

This also solves the bug where InstallSuccess showed an activity's name
in place of the app label since the temporary directory used to create
AppSnippet is already destroyed after app installation.

Bug: 290862169
Test: Manually install an APK and observe the app install / update
dialog

Change-Id: I2095b092e1a7b3186ff4cdc4c81effce51377b19
---
      c1647930