- Aug 15, 2019
-
-
Po-Chien Hsueh authored
libgiftranscode.so is a jni lib for Messaging app, which is usually overridden by proprietary apps on shipping devices. We have moved Messaging to /product. Now this CL move libgiftranscode.so too. Bug: 138282284 Test: Open gif files with Messaging on aosp_crosshatch Change-Id: Ic104ba8ec5c2258a28c8d19151a00f6c601b5f80
-
- Aug 14, 2019
-
-
Treehugger Robot authored
-
Po-Chien Hsueh authored
-
- Aug 13, 2019
-
-
Po-Chien Hsueh authored
Move Messaging to /product as we usually override it by proprietary apps on shipping devices. Bug: 138283161 Test: Run this app on aosp_crosshatch Change-Id: I30e1f291f249e15b0d9131cfa72cc9e9f4a37234
-
Taesu Lee authored
Added new "Translucent" style for SmsStorageLowWarningActivity instead. Test: am start com.android.messaging/.ui.SmsStorageLowWarningActivity Change-Id: Ie8b0df64ac046343c93ca8b4ffa93c5e49cc73ad Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- Aug 12, 2019
-
-
Treehugger Robot authored
-
- Aug 02, 2019
-
-
Taesu Lee authored
Unexpected ACTION_DOWN raises setColorFilter() for SIM avatar icons in the SIM switcher. However, other actions to clear the filter cannot be received due to no clickable attribute. Test: Click SIM icon in SimSelectorView. Change-Id: Ic5972522a3442e3087c474b65add38a6d00511a5 Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- Aug 01, 2019
-
-
Taesu Lee authored
getSelfParticipants() returns the ParticipantData list arranged in ascending order of the slot id to show SIM UIs from lowest to highest id consistently. Test: Verify SettingsFragment and SimSelector order in multi-sim device Change-Id: I0f5f27c6467cb21a6d11271d1a0a6beef36630a6 Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- Jul 08, 2019
-
-
Raman Tenneti authored
TODO: Need to run translation to fix across all languages. Bug: 135617299 Test: manual - Did a "make -j40" and verified that there are no warnings in strings.xml. Change-Id: I3f993fcea42c041d609e0f714cf3b0a2a6383816
-
- Jul 03, 2019
-
-
Treehugger Robot authored
-
- Jun 26, 2019
-
-
Colin Cross authored
-
- Jun 25, 2019
-
-
Taesu Lee authored
Test: atest messagingtests Change-Id: I62a30f50a64a6e6e3f7ce21c0919cb2873654bc2 Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
Taesu Lee authored
Use '-1' for no error instead of '0' since the '0' has been one of the valid error codes in 3GPP2. Test: Manual Change-Id: I02ba391a5cd178491868565c10bb3a35ba88e19a Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- Jun 21, 2019
-
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Colin Cross authored
This module produces warnings that are treated as errors if --legacy is not passed. --legacy is no longer being passed by default, so add it here. Bug: 135617299 Test: m java Change-Id: Ic001d8f4f9afdee3528929d3ba62a6bbade80ab6
-
- Jun 14, 2019
-
-
Taesu Lee authored
The X-Mms-Transaction-ID of the M-Notification.ind identifies each M-Notification.ind message. New duplication detection logic compares the new X-Mms-Transaction-ID with the stored value to identify the Network duplicate M-Notification.ind message when it receives a new M-Notification.ind message. Following SQL WHERE clause is used to query from the DB. ((m_type=NOTIFICATION_IND) OR (m_type=RETRIEVE_CONF)) AND (exp>NOW)) AND (t_id=xxxxxx) For this, when the M-Retrieve.conf is received, updates the t_id and the exp from the corresponding M-Notification.ind so that new logic would work even after the M-Notification.ind is deleted. Test: Manual Change-Id: I86e1eee62ea612d96ca16e5384b044cb6541ff6a Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- Jun 12, 2019
-
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
- May 31, 2019
-
-
Taesu Lee authored
Test: Manual Change-Id: I3008c596e5559e51613ed2da43793187c79381f5 Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- May 30, 2019
-
-
Taesu Lee authored
onAttachFragment() with ReportFragment instance is called first since Support Library 26.1.0 has been applied. Remove assert() and check instance to fix crash caused by the ReportFragement. Test: Manual Change-Id: I5a4d6bdd00ac94c5892527f5fe784b8f19701214 Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- May 23, 2019
-
-
Raman Tenneti authored
-
- Apr 30, 2019
-
-
Taesu Lee authored
Fix - Wrong order of args for update(). - Wrong and missing configs in keyType map. And remove MMS config keys from the key list if the keyType map doesn't include them. Test: Manual Change-Id: Ib1876072625187baf15ce6e64f90785ed0ba3df8 Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- Apr 25, 2019
-
-
Raman Tenneti authored
Merge "AOSP/Messaging - Moved LOCAL_COMPATIBILITY_SUITE to tests/Android.mk. + Deleted the unnecessary blankId check. Updated the TODO comment for NUM_TEST_CONVERSATIONS+4. + Added AndroidTest.xml + Added "LOCAL_PROGUARD_ENABLED := disabled" for tests to pass on cf." am: 90079b43 Change-Id: I44e82b085ca5d8ac45b41e3649d8fa985e76eeb5
-
Raman Tenneti authored
Merge "AOSP/Messaging - Moved LOCAL_COMPATIBILITY_SUITE to tests/Android.mk. + Deleted the unnecessary blankId check. Updated the TODO comment for NUM_TEST_CONVERSATIONS+4. + Added AndroidTest.xml + Added "LOCAL_PROGUARD_ENABLED := disabled" for tests to pass on cf."
-
- Apr 24, 2019
-
-
Raman Tenneti authored
+ Deleted the unnecessary blankId check. Updated the TODO comment for NUM_TEST_CONVERSATIONS+4. + Added AndroidTest.xml + Added "LOCAL_PROGUARD_ENABLED := disabled" for tests to pass on cf. Bug: 126516784 Test: make messagingtests and tested the messaging UI manually. Ran the following CTS tests on Pixel phone. $ make -j 40 -rw-r--r-- 1 rtenneti primarygroup 8529760 Mar 8 16:46 out/target/product/marlin/system/app/messaging/messaging.apk $ make messagingtests -j -rw-r--r-- 1 rtenneti primarygroup 729713 Mar 13 14:22 out/target/product/marlin/testcases/messagingtests/messagingtests.apk $ adb install -r -d out/target/product/marlin/system/app/messaging/messaging.apk $ adb install -r -d out/target/product/marlin/testcases/messagingtests/messagingtests.apk atest ----- $ cd .../packages/apps/Messaging $ atest ... Results from tests that require device: Summary ------- messagingtests: Passed: 113, Failed: 0, Ignored: 0 All tests passed! acloud test ----------- $ lunch aosp_cf_x86_phone-userdebug $ make -j 40 -rw-r--r-- 1 rtenneti primarygroup 10585182 Mar 15 15:19 ./target/product/vsoc_x86/system/app/messaging/messaging.apk $ make messagingtests -j -rw-r--r-- 1 rtenneti primarygroup 643697 Mar 15 15:57 ./target/product/vsoc_x86/system/app/messagingtests/messagingtests.apk $ acloud reconnect $ adb devices List of devices attached 127.0.0.1:52761 device $ adb install -r -d out/target/product/vsoc_x86/system/app/messaging/messaging.apk $ adb install -r -d out/target/product/vsoc_x86/system/app/messagingtests/messagingtests.apk $ cd packages/apps/Messaging $ atest messagingtests -- --abi x86 --serial 127.0.0.1:52761 Change-Id: I6b1143db6c596805f3c48f310323e0e02d344d00
-
- Apr 17, 2019
-
-
Raman Tenneti authored
AOSP/Messaging - Remove TEST_MAPPING because presubmit tests fail on build_target: aosp_cf_x86_phone-userdebug am: c10a188d Change-Id: Ie2e02b3f52c5b6fd6b8cf4a37ece4ac63c8b0fef
-
Raman Tenneti authored
AOSP/Messaging - Remove TEST_MAPPING because presubmit tests fail on build_target: aosp_cf_x86_phone-userdebug BUG: 126516784 Test: No impact. TEST_MAPPING wasn't enabled before, thus removing the file shouldn't have an impact. Change-Id: Ib206cb6d921b59a032e6557352c6961310b08272
-
- Apr 16, 2019
-
-
Colin Cross authored
am: 485b0196 Change-Id: I39ed624add43b2c1d0a2ecb6d75fad7c091bd7b2
-
Colin Cross authored
CharMatcher.ASCII has been replaced with CharMatcher.ascii(). Bug: 130306229 Test: m checkbuild Change-Id: I21473e2aa5e432b135fac7f1ecf0a85f52f3951e Merged-In: I21473e2aa5e432b135fac7f1ecf0a85f52f3951e Exempt-From-Owner-Approval: cherry pick (cherry picked from commit 63cffd02)
-
- Apr 07, 2019
-
-
Raman Tenneti authored
AOSP/Messaging - Update the Messaging version to 24 until notification related logic changes are made. Fixes the error "Developer warning for package com.android. messaging failed to post notification on channel null". am: 8e71d1b7 Change-Id: Iaca20ad962131fa5629b77789e9e853c6f0b39ce
-
- Apr 06, 2019
-
-
Raman Tenneti authored
AOSP/Messaging - Update the Messaging version to 24 until notification related logic changes are made. Fixes the error "Developer warning for package com.android. messaging failed to post notification on channel null". Bug: 130046636 Test: manual - Tested the messaging UI. Ran the following CTS tests on Pixel phone. $ make -j 40 $ make messagingtests -j $ find out -name "messaging*.apk" -print -exec ls -l {} \; -rw-r--r-- 1 rtenneti primarygroup 8529760 Apr 5 18:50 out/target/product/marlin/system/app/messaging/messaging.apk -rw-r--r-- 1 rtenneti primarygroup 729713 Apr 5 18:54 out/target/product/marlin/testcases/messagingtests/arm64/messagingtests.apk $ adb install -r -d out/target/product/marlin/system/app/messaging/messaging.apk $ adb install -r -d out/target/product/marlin/testcases/messagingtests/arm64/messagingtests.apk $ adb shell am instrument -w com.android.messaging.test Time: 12.766 OK (113 tests) CTS tests for Mesaging app --------------------------- $ ./development/testrunner/runtest.py --path cts/tests/app/src/android/app/cts/NotificationTest.java adb shell am instrument -e class 'android.app.cts.NotificationTest' -w 'android.app.cts/androidx.test.runner.AndroidJUnitRunner' android.app.cts.NotificationTest:........................... Time: 0.2 OK (27 tests) atest ----- $ cd packages/apps/Messaging $ atest Summary ------- messagingtests: Passed: 113, Failed: 0, Ignored: 0 Change-Id: Ic263e2c63d675c40a2cfa1ca0a8776c8e2b510b9
-
- Mar 22, 2019
-
-
Raman Tenneti authored
Revert "AOSP/Messaging - Added LOCAL_COMPATIBILITY_SUITE := device-tests to fix "Missing test_suite setting for test"." am: 7d08344e Change-Id: I718abce9535d773fb02bf23e63b555e47a31c410
-
Raman Tenneti authored
Revert "AOSP/Messaging - Added LOCAL_COMPATIBILITY_SUITE := device-tests to fix "Missing test_suite setting for test"." This reverts commit bada9f9b. Reason for revert: <INSERT REASONING HERE> Change-Id: I17281de5c14e7c285d263729167f208cbea4f7d5
-
- Mar 21, 2019
-
-
Taesu Lee authored
Use correct format to - Parse SMS delivery report. - Dump/Load SMS to/from the dump file. TODO: Update message text state during composing. Test: Manual Change-Id: I7e53bed86130484a634c9305b276e2586db31796 Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- Mar 15, 2019
-
-
Taesu Lee authored
Simple matching up CDMA status with GSM TP-Status for common handling. And fix bugleStatusForSMS() for all the permanent error cases. Note: Need to check SC operation for ERROR_TEMPORARY. Test: Manual Change-Id: Ic8136d273dc0c25a4f0690f951d4d8aca20579ff Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- Mar 13, 2019
-
-
Taesu Lee authored
X-Mms-Transaction-ID of M-Acknowledge.ind should be set as the corresponding M-Retrieve.conf's transaction ID instead of M-Notification.ind's one. (OMA-TS-MMS_ENC-V1_3-20110913-A) Test: Manual Change-Id: I250f32b93cdfbed815206543df5486efa4df18eb Signed-off-by:
Taesu Lee <taesu82.lee@samsung.com>
-
- Mar 03, 2019
-
-
Michael Bestas authored
Fixes: res/layout/apn_preference_layout.xml:40: warn: generated id 'android:id/title' for external package 'android'. res/layout/apn_preference_layout.xml:48: warn: generated id 'android:id/summary' for external package 'android'. Change-Id: Ia096fa2e072ba4391e3adad52d3f9c9abed0e976
-
- Feb 27, 2019
-
-
Raman Tenneti authored
AOSP/Messaging - Added LOCAL_COMPATIBILITY_SUITE := device-tests to fix "Missing test_suite setting for test". am: bada9f9b Change-Id: I9e4443ddc278dd1f5bb3cd42dac451578538e2f8
-