Commits · 9312ecb2998409f4d0ea57660ccfc087c2190911 · LMODroid / platform_packages_apps_Messaging

Jul 10, 2020

AOSP/Messaging - Changes to make unit tests to run and pass. am: ... · 9312ecb2

Raman Tenneti authored 4 years ago

AOSP/Messaging - Changes to make unit tests to run and pass. am: b1aa213c am: 4c12eb47 am: 0875a142 am: 4671bcc5

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1360018

Change-Id: I2801bfaba651e69bb6a3034c781d53c784cba2f7

9312ecb2

AOSP/Messaging - Changes to make unit tests to run and pass. am: ... · 4671bcc5

Raman Tenneti authored 4 years ago

AOSP/Messaging - Changes to make unit tests to run and pass. am: b1aa213c am: 4c12eb47 am: 0875a142

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1360018

Change-Id: Id69fd14fdd4fbda403978ac7502966fa96f309d0

4671bcc5

AOSP/Messaging - Changes to make unit tests to run and pass. am: am: · 0875a142

Raman Tenneti authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1360018

Change-Id: Ie84f1ff41433b8d07cf1306723e772dd598b3ccf

0875a142

AOSP/Messaging - Changes to make unit tests to run and pass. am: · 4c12eb47

Raman Tenneti authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1360018

Change-Id: I5dad8a738ccecbb85c8788fcd867f7b3631c8deb

4c12eb47

AOSP/Messaging - Changes to make unit tests to run and pass. · b1aa213c

Raman Tenneti authored 4 years ago

+ Added missing androix libraries to LOCAL_STATIC_ANDROID_LIBRARIES.
+ Added keep class statements for androidx and messaging classes.
+ Deleted Assert.isEngBuild call (this package is the last user of that method).
+ Added import statements for androidx classes.

Test: manual - Tested the messaging UI. Ran the following tests on Pixel phone.

$ make -j 40
$ make messagingtests -j
$ find out -name "messaging*.apk" -print -exec ls -l {} \;
-rw-r----- 1 rtenneti primarygroup 733809 Jul  9 17:42 out/target/product/bonito/testcases/messagingtests/arm64/messagingtests.apk
-rw-r----- 1 rtenneti primarygroup 10799132 Jul  9 18:34 out/target/product/bonito/product/app/messaging/messaging.apk

$ adb install -r -d -t  out/target/product/bonito/product/app/messaging/messaging.apk
$ adb install -r -d -t  out/target/product/bonito/testcases/messagingtests/arm64/messagingtests.apk
$ adb shell am instrument -w com.android.messaging.test

com.android.messaging.datamodel.BindingTest:.......
com.android.messaging.datamodel.BitmapPoolTest:....
com.android.messaging.datamodel.ConversationListTest:.
com.android.messaging.datamodel.DataModelTest:...
com.android.messaging.datamodel.FrequentContactsCursorBuilderTest:...
com.android.messaging.datamodel.MemoryCacheManagerTest:.
com.android.messaging.datamodel.ParticipantRefreshTest:..........
com.android.messaging.datamodel.action.ActionServiceSystemTest:.....
com.android.messaging.datamodel.action.ActionServiceTest:..
com.android.messaging.datamodel.action.ActionTest:.....
com.android.messaging.datamodel.action.GetOrCreateConversationActionTest:.
com.android.messaging.datamodel.action.ReadWriteDraftMessageActionTest:......
com.android.messaging.datamodel.data.ConversationMessageDataTest:...
com.android.messaging.datamodel.data.ConversationParticipantsDataTest:.
com.android.messaging.datamodel.media.ImageRequestTest:..
com.android.messaging.datamodel.media.MediaResourceManagerTest:.....
com.android.messaging.ui.CustomHeaderViewPagerTest:.
com.android.messaging.ui.MultiAttachmentLayoutTest:...
com.android.messaging.ui.attachmentchooser.AttachmentChooserFragmentTest:.
com.android.messaging.ui.contact.ContactListItemViewTest:....
com.android.messaging.ui.contact.ContactPickerFragmentTest:......
com.android.messaging.ui.conversation.ComposeMessageViewTest:..
com.android.messaging.ui.conversation.ConversationActivityUiStateTest:....
com.android.messaging.ui.conversation.ConversationFragmentTest:..
com.android.messaging.ui.conversation.ConversationInputManagerTest:.....
com.android.messaging.ui.conversation.ConversationMessageViewTest:...
com.android.messaging.ui.conversationlist.ConversationListFragmentTest:...
com.android.messaging.ui.conversationlist.ConversationListItemViewTest:....
com.android.messaging.ui.mediapicker.AudioRecordViewTest:.
com.android.messaging.ui.mediapicker.CameraManagerTest:......
com.android.messaging.ui.mediapicker.GalleryGridItemViewTest:.....
com.android.messaging.ui.mediapicker.MediaPickerTest:..
com.android.messaging.util.BugleGservicesTest:.
com.android.messaging.util.YouTubeUtilTest:.
Test results for InstrumentationTestRunner=.........................................
.........................................
...............................
Time: 9.903

OK (113 tests)

Change-Id: If8fd8036791027739eb9bbb1d3849a46211a5137

b1aa213c

Jun 29, 2020

Merge "Fix NoSuchMethodError for getTypeInfo()" am: am: ... · 72c3eae5

Treehugger Robot authored 4 years ago

Merge "Fix NoSuchMethodError for getTypeInfo()" am: 919cb6af am: d67e1db1 am: 55aa308f am: c2c670d1

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1352082

Change-Id: I8a6b0c35ca65aae547c1d6289c313a134c5e30dc

72c3eae5

Merge "Fix NoSuchMethodError for getTypeInfo()" am: am: am: · c2c670d1

Treehugger Robot authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1352082

Change-Id: I4a03b98f431b696afacbb842426db3fcf9ed7421

c2c670d1

Merge "Fix NoSuchMethodError for getTypeInfo()" am: am: · 55aa308f

Treehugger Robot authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1352082

Change-Id: I323966094ad9d4c62f0a744de762dfb25d4c7c09

55aa308f

Merge "Fix NoSuchMethodError for getTypeInfo()" am: · d67e1db1

Treehugger Robot authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1352082

Change-Id: I3c817f847749649e3540e3827263cc8f7184f2b3

d67e1db1

Merge "Fix NoSuchMethodError for getTypeInfo()" · 919cb6af
Treehugger Robot authored 4 years ago

919cb6af

[automerger skipped] Import translations. DO NOT MERGE am: -s ours... · 840c4ab6

Bill Yi authored 4 years ago

[automerger skipped] Import translations. DO NOT MERGE am: 8e0d3e91 -s ours am: a3c59da0 -s ours am: 9d8f501d -s ours am: d9620cc1 -s ours

am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1350824

Change-Id: Iddec1cbd4ad1f9b6b7c41420bba5c118b8ba74f5

840c4ab6

[automerger skipped] Import translations. DO NOT MERGE am: -s ours... · d9620cc1

Bill Yi authored 4 years ago

[automerger skipped] Import translations. DO NOT MERGE am: 8e0d3e91 -s ours am: a3c59da0 -s ours am: 9d8f501d -s ours

am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1350824

Change-Id: Idef9dffb1f089ae74cc46274fd81e5cd9feb5dbd

d9620cc1

[automerger skipped] Import translations. DO NOT MERGE am: -s ours... · 9d8f501d

Bill Yi authored 4 years ago

[automerger skipped] Import translations. DO NOT MERGE am: 8e0d3e91 -s ours am: a3c59da0 -s ours

am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1350824

Change-Id: I3116a3be591a59ec30711dc3554e62a7745f2928

9d8f501d

[automerger skipped] Import translations. DO NOT MERGE am: -s ours · a3c59da0

Bill Yi authored 4 years ago

am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1350824

Change-Id: Iaa813c8fc1b91f8270670b9f0f59dfab655432f0

a3c59da0

Fix NoSuchMethodError for getTypeInfo() · f2d9199b

Taesu Lee authored 4 years ago


Load an icon image for audio files from app resources instead because
ContentResolver#getTypeInfo() is for API level >= 29.
And it includes size-fit ic_photo_library_light images also.

Bug: 159987488
Test: Manual

Change-Id: Ie8f766f148a30e105e598e4b7e6b1b22bccda6ae
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>

f2d9199b

Jun 28, 2020

Import translations. DO NOT MERGE · 8e0d3e91

Bill Yi authored 5 years ago

BUG:148403740

TEST: m messaging

Merged-In: I4b74a267c0ed7cffe04d97ca465f2aa90ae1847a
Change-Id: Ie6f26f2a9e207adeee475e347f17dd8e0da78d9b
Auto-generated-cl: translation import
(cherry picked from commit 3bd7b79d)

8e0d3e91

Jun 26, 2020

Remove advanced category if no preference am: am: am:... · bc5055fc

Taesu Lee authored 4 years ago

Remove advanced category if no preference am: 392850a8 am: 34ebed2b am: 45cd97ea am: 5538d472

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: Ia4902eaf2d7b8c94c113fb662680cfe270c73b78

bc5055fc

Remove advanced category if no preference am: am: am: · 5538d472

Taesu Lee authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: Ic6105759c8b90ffcce82c12e70e962e19b50bbd5

5538d472

Remove advanced category if no preference am: am: · 45cd97ea

Taesu Lee authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: I40e97e119cfefaf90e14efad2760e9e31a46a9b8

45cd97ea

Remove advanced category if no preference am: · 34ebed2b

Taesu Lee authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1351522

Change-Id: Icbed01452b088198a11436aad233c281b4068067

34ebed2b

Remove advanced category if no preference · 392850a8

Taesu Lee authored 4 years ago


Test: In debug mode, turn off all the configs for advanced category

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I52ea0905b9d4f03a57b4849e5b575bc5e508dd2d

392850a8

Jun 24, 2020

AOSP/Messaging - Changed minSdkVersion to 19. am: am: ... · 7e7ccf8e

Raman Tenneti authored 4 years ago

AOSP/Messaging - Changed minSdkVersion to 19. am: 8926653a am: 58d5681e am: cc4904c8 am: 3debc351

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1348203

Change-Id: I8e067fec2e6b9991952767006c123943d7fb7c68

7e7ccf8e

Jun 23, 2020

AOSP/Messaging - Changed minSdkVersion to 19. am: am: am: · 3debc351

Raman Tenneti authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1348203

Change-Id: I7e52857f5f9f31222eb425c8ccd969643051732e

3debc351

AOSP/Messaging - Changed minSdkVersion to 19. am: am: · cc4904c8

Raman Tenneti authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1348203

Change-Id: I31114ab0e25fc0c2352a42ec2202459730c4bf0a

cc4904c8

AOSP/Messaging - Changed minSdkVersion to 19. am: · 58d5681e

Raman Tenneti authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1348203

Change-Id: Icbbf5bf2bfa0e59e75fb0a0e87a928ee1fe93bf8

58d5681e

AOSP/Messaging - Changed minSdkVersion to 19. · 8926653a

Raman Tenneti authored 4 years ago

Bug: 159055957

Test: manual - Tested the messaging UI.

$ make -j 40

Change-Id: I6f89161d7c841e88fcd8496417ae1ab8e964961a

8926653a

Jun 22, 2020

Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O"... · 4d31d33b

Treehugger Robot authored 4 years ago

Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O" am: be4c2698 am: 92b38533 am: d43f2fd2 am: 945d572d

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345449

Change-Id: Ia85b7c76ffe2c6355ce4e39347d10ad09f6b3e26

4d31d33b

Fix app initialization issue if no permissions am: am: ... · 81c0058f

Taesu Lee authored 4 years ago

Fix app initialization issue if no permissions am: 297a6f70 am: ba59a36f am: 5c393695 am: 43f98b38

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: I6c9bdd5493abc298c784d1164030d0d6b63685d2

81c0058f

Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O"... · 945d572d

Treehugger Robot authored 4 years ago

Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O" am: be4c2698 am: 92b38533 am: d43f2fd2

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345449

Change-Id: I861686e60742c88d1cc9dc93c0bdc2d1cc01d862

945d572d

Fix app initialization issue if no permissions am: am: am: · 43f98b38

Taesu Lee authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: Ia252373a2a6109a881feee44a5d20be6e5aec464

43f98b38

Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O"... · d43f2fd2

Treehugger Robot authored 4 years ago

Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O" am: be4c2698 am: 92b38533

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345449

Change-Id: I32963ac99c68803399349b0c4e1f54b9621ba76c

d43f2fd2

Fix app initialization issue if no permissions am: am: · 5c393695

Taesu Lee authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: I2dd1a3cc46f51f2ca743674bab363c6e90f5f0ad

5c393695

Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O" am: · 92b38533

Treehugger Robot authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345449

Change-Id: If661b26336c80e6c4928afd9adc2111eb2a255ee

92b38533

Fix app initialization issue if no permissions am: · ba59a36f

Taesu Lee authored 4 years ago

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1345448

Change-Id: If592a8e5431035c8a369917f24dbdd73e28bae4d

ba59a36f

Merge "Fix SecurityException at getActiveSubscriptionInfoList() on N and O" · be4c2698
Treehugger Robot authored 4 years ago

be4c2698

Fix SecurityException at getActiveSubscriptionInfoList() on N and O · 615ebb9d

Taesu Lee authored 4 years ago


Creating ConnectivityUtil instances after checking the minimum set of
permissions since SubscriptionManager#getActiveSubscriptionInfoList()
requires READ_PHONE_STATE and users can revoke the permission.
On P and beyond, the subscription list will be filtered instead when no
permission.

Bug: 159421050
Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: Iafc3c57060e1893a91e629b1b3e3ba9ad78967cb

615ebb9d

Fix app initialization issue if no permissions · 297a6f70

Taesu Lee authored 4 years ago


Call onRequiredPermissionsAcquired() before calling redirect() so that
BugleApplication initialization can be done completed always even
PermissionCheckActivity#onResume() case.

Test: Manual

Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Change-Id: I01bb681442e0b391238bc162ce139ff40d947eaf

297a6f70

Jun 20, 2020

AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using... · 3de135d6

Raman Tenneti authored 4 years ago

AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using Telephony.Carriers.CONTENT_URI instead of Telephony.Carriers.SIM_APN_URI. am: 7f4bb54e am: f556ac71 am: 5850cee2 am: b3a5b916

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1344864

Change-Id: I87905227440d763901b4b7334e023b291ea97ffe

3de135d6

AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using... · b3a5b916

Raman Tenneti authored 4 years ago

AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using Telephony.Carriers.CONTENT_URI instead of Telephony.Carriers.SIM_APN_URI. am: 7f4bb54e am: f556ac71 am: 5850cee2

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1344864

Change-Id: I29dbf1772abf8f94fee7dd27bebc4b0de2b753ce

b3a5b916

Jun 19, 2020

AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using... · 5850cee2

Raman Tenneti authored 4 years ago

AOSP/Messaging - Changed midSdkVersion to 14 and reverted to using Telephony.Carriers.CONTENT_URI instead of Telephony.Carriers.SIM_APN_URI. am: 7f4bb54e am: f556ac71

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Messaging/+/1344864

Change-Id: Id215ca02976858312f465f78e70eedb7d371317f

5850cee2