Skip to content
Snippets Groups Projects
  1. May 15, 2023
  2. May 11, 2023
  3. May 10, 2023
  4. May 09, 2023
  5. Nov 04, 2022
  6. Oct 17, 2022
  7. Oct 16, 2022
    • Cole Faust's avatar
      Fix errorprone warnings that should be errors · 50b73ca5
      Cole Faust authored
      This commit is part of a large scale change to fix errorprone
      errors that have been downgraded to warnings in the android
      source tree, so that they can be promoted to errors again.
      The full list of changes include the following, but not all
      will be present in any one individual commit:
      
      BadAnnotationImplementation
      BadShiftAmount
      BanJNDI
      BoxedPrimitiveEquality
      ComparableType
      ComplexBooleanConstant
      CollectionToArraySafeParameter
      ConditionalExpressionNumericPromotion
      DangerousLiteralNull
      DoubleBraceInitialization
      DurationFrom
      DurationTemporalUnit
      EmptyTopLevelDeclaration
      EqualsNull
      EqualsReference
      FormatString
      FromTemporalAccessor
      GetClassOnAnnotation
      GetClassOnClass
      HashtableContains
      IdentityBinaryExpression
      IdentityHashMapBoxing
      InstantTemporalUnit
      InvalidTimeZoneID
      InvalidZoneId
      IsInstanceIncompatibleType
      JUnitParameterMethodNotFound
      LockOnBoxedPrimitive
      MathRoundIntLong
      MislabeledAndroidString
      MisusedDayOfYear
      MissingSuperCall
      MisusedWeekYear
      ModifyingCollectionWithItself
      NoCanIgnoreReturnValueOnClasses
      NonRuntimeAnnotation
      NullableOnContainingClass
      NullTernary
      OverridesJavaxInjectableMethod
      ParcelableCreator
      PeriodFrom
      PreconditionsInvalidPlaceholder
      ProtoBuilderReturnValueIgnored
      ProtoFieldNullComparison
      RandomModInteger
      RectIntersectReturnValueIgnored
      ReturnValueIgnored
      SelfAssignment
      SelfComparison
      SelfEquals
      SizeGreaterThanOrEqualsZero
      StringBuilderInitWithChar
      TreeToString
      TryFailThrowable
      UnnecessaryCheckNotNull
      UnusedCollectionModifiedInPlace
      XorPower
      
      See https://errorprone.info/bugpatterns for more
      information on the checks.
      
      Bug: 253827323
      Test: m RUN_ERROR_PRONE=true javac-check
      Change-Id: I8b1533cbea835343dcf589cbaa57c63794be58bd
      50b73ca5
  8. Oct 04, 2022
    • Michael Groover's avatar
      Add unaudited exported flag to exposed runtime receivers · 4b17ed7f
      Michael Groover authored
      Android T allows apps to declare a runtime receiver as not exported
      by invoking registerReceiver with a new RECEIVER_NOT_EXPORTED flag;
      receivers registered with this flag will only receive broadcasts from
      the platform and the app itself. However to ensure developers can
      properly protect their receivers, all apps targeting U or later
      registering a receiver for non-system broadcasts must specify either
      the exported or not exported flag when invoking #registerReceiver;
      if one of these flags is not provided, the platform will throw a
      SecurityException. This commit updates all the exposed receivers
      with a new RECEIVER_EXPORTED_UNAUDITED flag to maintain the existing
      behavior of exporting the receiver while also flagging the receiver
      for audit before the U release.
      
      Bug: 234659204
      Test: Build
      Change-Id: I15aba10fe12dfcd2e67330ca844491341ef6d920
      4b17ed7f
  9. Sep 22, 2022
  10. Sep 15, 2022
  11. Aug 31, 2022
  12. Aug 26, 2022
  13. Aug 24, 2022
  14. Aug 23, 2022
    • Cole Faust's avatar
      Fix array-related errorprone warnings · 1aba0b04
      Cole Faust authored
      The ArrayEquals, ArrayHashCode, ArrayToString, and
      ArraysAsListPrimitiveArray errorprone findings were
      demoted from errors to warnings. Fix existing
      occurrences of them so they can be made errors again.
      
      Bug: 242630963
      Test: RUN_ERROR_PRONE=true m javac-check
      Change-Id: I8a507da97e99a7e86577fda91960dd477c0a6af4
      1aba0b04
  15. Aug 17, 2022
  16. Aug 16, 2022
  17. Jul 13, 2022
Loading