Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
0 authors
  1. Mar 20, 2023
  3. Mar 19, 2023
    • Jing Mike's avatar
      Remove unused variables · 03eef94a
      Jing Mike authored 
      
Since some variables with module LatinIME are defined but not used,
when compiled with build combination "sdk_pc_x86_64-userdebug" and
build command "mmm packages/inputmethods/LatinIME", the following
code lines will be reported that "variable 'XXX' set but not used".
(should be similar for all the other build combinations)

Repeated 10 times for each:
terminal_position_lookup_table.cpp:74:9 removedEntryCount
terminal_position_lookup_table.cpp:85:9 removedEntryCount
proximity_info_state_utils.cpp:493:9 tempTime
trie_map.cpp:56:9 unusedRegionSize
suggestion_results.cpp:100:9 index

Repeated 80+ times:
proximity_info_utils.h:75:25 proximityChar

With this patch we are removing some of the unused variables and
putting the C++ 17 attribute [[maybe_unused]] to the others which
are used for logging. Then all the related build warnings have been
eliminated.

Test: mmm packages/inputmethods/LatinIME, presubmit check.

Change-Id: Ia66766322d6ae8a010b1cb55cc22993fbc6d012c
Signed-off-by: default avatarJing Mike <jingyangliu@eswincomputing.com>
      03eef94a
  5. Mar 14, 2023
  7. Mar 09, 2023
    • Cole Faust's avatar
      Baseline NewApi issues · f5c1b4cc
      Cole Faust authored 
      NewApi was recently updated to support linting methods in
the system, module_lib, and system_server sdks, and was
demoted to a warning due to the new issues it finds.
Baseline all the new issues that NewApi can be made an error
again.

These cls were generated automatically by a script that
copied the NewApi issues from the reference baselines.

Bug: 268261262
Test: m lint-check
Change-Id: I99bb901018da30f39cf799ac6c939863266cee34
      f5c1b4cc
    • Michael Groover's avatar
      Add required flag to receivers in LatinIME · 3932195a
      Michael Groover authored 
      Android T allows apps to declare a runtime receiver as not exported
by invoking registerReceiver with a new RECEIVER_NOT_EXPORTED flag;
receivers registered with this flag will only receive broadcasts from
the platform and the app itself. However to ensure developers can
properly protect their receivers, all apps targeting U
and registering a receiver for non-system broadcasts must
specify either the exported or not exported flag when invoking
registerReceiver; if one of these flags is not provided, the
platform will throw a SecurityException. This commit updates
the dictionary receivers with the RECEIVER_NOT_EXPORTED flag since
these are only sent from the local app. The HIDE_SOFT_INPUT
receiver is flagged with the RECEIVER_EXPORTED flag since it
can be sent by any app with the corresponding permission.

Bug: 234659204
Test: Build
Change-Id: I2b9a1360e0eb1c1965c07cc71dca9f11eb153517
      3932195a
  9. Dec 12, 2022
  11. Oct 17, 2022
  13. Sep 21, 2022
  15. Aug 24, 2022
  17. Aug 17, 2022
  19. Aug 16, 2022
  21. Aug 10, 2022
    • Wilson Wu's avatar
      Make DownloadOverMeteredDialog not exported · 54d44219
      Wilson Wu authored 
      The DownloadOverMeteredDialog is exported which may
allow a app to prompt this dialog to ask the user to
download dictionary.

Since the app can control the download dictionary size
and may show an incorrect size for user to make security
concern. Make the activity not exported for apps to launch.

Bug: 236688064
Test: Manual test as follow steps:
      1. lunch aosp_bramble-userdebug and flash
      2. Verify the AOSP keyboard work properly
      3. Launch the PoC test app
      4. Verify the DownloadOverMeteredDialog cannot be launched
Change-Id: I9be92ba2813e7aaad0ef10555f585c5c8a25361f
      54d44219
  23. Jun 30, 2022
  25. Jun 29, 2022
  27. Jun 27, 2022
  29. Apr 21, 2022