Skip to content
Snippets Groups Projects
Commit de2248e5 authored by Android Build Coastguard Worker's avatar Android Build Coastguard Worker
Browse files

Merge cherrypicks of ['googleplex-android-review.googlesource.com/27213891'] into 24Q2-release.

Change-Id: Id479e9adf8ec0a30faaf4fe6d19d58e66ddbdcb5
parents 8786b78c 29a8f8ba
No related branches found
No related tags found
No related merge requests found
......@@ -548,10 +548,10 @@ public final class Utils {
}
// STOPSHIP(b/188391719): enable this security enforcement
// attributionSource.enforceCallingUid();
AttributionSource currentAttribution = new AttributionSource
.Builder(context.getAttributionSource())
.setNext(attributionSource)
.build();
AttributionSource currentAttribution =
new AttributionSource.Builder(context.getAttributionSource())
.setNext(Objects.requireNonNull(attributionSource))
.build();
PermissionManager pm = context.getSystemService(PermissionManager.class);
if (pm == null) {
return false;
......@@ -823,10 +823,10 @@ public final class Utils {
Log.e(TAG, "Permission denial: Location is off.");
return false;
}
AttributionSource currentAttribution = new AttributionSource
.Builder(context.getAttributionSource())
.setNext(attributionSource)
.build();
AttributionSource currentAttribution =
new AttributionSource.Builder(context.getAttributionSource())
.setNext(Objects.requireNonNull(attributionSource))
.build();
// STOPSHIP(b/188391719): enable this security enforcement
// attributionSource.enforceCallingUid();
PermissionManager pm = context.getSystemService(PermissionManager.class);
......@@ -857,10 +857,10 @@ public final class Utils {
return false;
}
final AttributionSource currentAttribution = new AttributionSource
.Builder(context.getAttributionSource())
.setNext(attributionSource)
.build();
final AttributionSource currentAttribution =
new AttributionSource.Builder(context.getAttributionSource())
.setNext(Objects.requireNonNull(attributionSource))
.build();
// STOPSHIP(b/188391719): enable this security enforcement
// attributionSource.enforceCallingUid();
PermissionManager pm = context.getSystemService(PermissionManager.class);
......@@ -895,10 +895,10 @@ public final class Utils {
return false;
}
AttributionSource currentAttribution = new AttributionSource
.Builder(context.getAttributionSource())
.setNext(attributionSource)
.build();
AttributionSource currentAttribution =
new AttributionSource.Builder(context.getAttributionSource())
.setNext(Objects.requireNonNull(attributionSource))
.build();
// STOPSHIP(b/188391719): enable this security enforcement
// attributionSource.enforceCallingUid();
PermissionManager pm = context.getSystemService(PermissionManager.class);
......
......@@ -120,10 +120,12 @@ public class UtilsTest {
boolean enabledStatus = locationManager.isLocationEnabledForUser(userHandle);
locationManager.setLocationEnabledForUser(false, userHandle);
assertThat(Utils.checkCallerHasCoarseLocation(context, null, userHandle)).isFalse();
assertThat(Utils.checkCallerHasCoarseLocation(
context, context.getAttributionSource(), userHandle))
.isFalse();
locationManager.setLocationEnabledForUser(true, userHandle);
Utils.checkCallerHasCoarseLocation(context, null, userHandle);
Utils.checkCallerHasCoarseLocation(context, context.getAttributionSource(), userHandle);
if (!enabledStatus) {
locationManager.setLocationEnabledForUser(false, userHandle);
}
......@@ -137,10 +139,13 @@ public class UtilsTest {
boolean enabledStatus = locationManager.isLocationEnabledForUser(userHandle);
locationManager.setLocationEnabledForUser(false, userHandle);
assertThat(Utils.checkCallerHasCoarseOrFineLocation(context, null, userHandle)).isFalse();
assertThat(Utils.checkCallerHasCoarseOrFineLocation(
context, context.getAttributionSource(), userHandle))
.isFalse();
locationManager.setLocationEnabledForUser(true, userHandle);
Utils.checkCallerHasCoarseOrFineLocation(context, null, userHandle);
Utils.checkCallerHasCoarseOrFineLocation(
context, context.getAttributionSource(), userHandle);
if (!enabledStatus) {
locationManager.setLocationEnabledForUser(false, userHandle);
}
......
......@@ -86,7 +86,9 @@ class BtPermissionUtils {
String message) {
final String permission = BLUETOOTH_CONNECT;
AttributionSource currentSource =
new AttributionSource.Builder(ctx.getAttributionSource()).setNext(source).build();
new AttributionSource.Builder(ctx.getAttributionSource())
.setNext(Objects.requireNonNull(source))
.build();
final int result =
permissionManager.checkPermissionForDataDeliveryFromDataSource(
permission, currentSource, message);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment