RFCOMM: Improve logging and readability
Debug Improvements: * Add more error logging in the following methods: - rfc_mx_sm_state_idle for L2CA_ConnectReq failure - rfc_mx_sm_state_configure for RFC_EVENT_TIMEOUT - rfc_mx_conf_cnf for L2CAP configuration failures - RFCOMM_RemoveServer Readability Improvements: * Refactored logic in the following methods to be more readable - L2CA_ErtmConnectReq - RFCOMM_CreateConnection - port_open_continue - PORT_StartCnf - port_allocate_port - rfc_send_buf_uih - bta_ag_get_other_idle_scb * Rename RFCOMM_ParNegReq to RFCOMM_ParameterNegotiationRequest * Rename RFCOMM_ParNegRsp to RFCOMM_ParameterNegotiationResponse * Rename RFCOMM_PortNegReq to RFCOMM_PortParameterNegotiationRequest * Rename RFCOMM_PortNegRsp to RFCOMM_PortParameterNegotiationResponse Rename using IDE: * Rename tRFCOMM_CB.last_port to tRFCOMM_CB.last_port_index * Rename tPORT.inx to tPORT.handle as inx is ready the port handle indexed from 1 * Rename tRFC_MCB.port_inx to tRFC_MCB.port_handles NPE Prevention: * Add error checking in rfc_save_lcid_mcb to avoid accessing beyond array boundary Bug: 77224743 Test: StackRfcommTest, connect and disconnect to multiple devices with PBAP, MAP, PAN, PTS HFP tests testplans/details/158641/3975 Change-Id: I8de89dfc0cee48fed6ad4e1d4a8cdcde2f960aab
Showing
- system/bta/ag/bta_ag_act.cc 18 additions, 29 deletionssystem/bta/ag/bta_ag_act.cc
- system/bta/ag/bta_ag_main.cc 6 additions, 11 deletionssystem/bta/ag/bta_ag_main.cc
- system/bta/av/bta_av_aact.cc 5 additions, 4 deletionssystem/bta/av/bta_av_aact.cc
- system/bta/hf_client/bta_hf_client_act.cc 7 additions, 11 deletionssystem/bta/hf_client/bta_hf_client_act.cc
- system/bta/hf_client/bta_hf_client_rfc.cc 6 additions, 3 deletionssystem/bta/hf_client/bta_hf_client_rfc.cc
- system/bta/jv/bta_jv_act.cc 17 additions, 8 deletionssystem/bta/jv/bta_jv_act.cc
- system/stack/include/port_api.h 2 additions, 2 deletionssystem/stack/include/port_api.h
- system/stack/l2cap/l2c_api.cc 27 additions, 33 deletionssystem/stack/l2cap/l2c_api.cc
- system/stack/rfcomm/port_api.cc 57 additions, 67 deletionssystem/stack/rfcomm/port_api.cc
- system/stack/rfcomm/port_int.h 3 additions, 3 deletionssystem/stack/rfcomm/port_int.h
- system/stack/rfcomm/port_rfc.cc 83 additions, 84 deletionssystem/stack/rfcomm/port_rfc.cc
- system/stack/rfcomm/port_utils.cc 35 additions, 35 deletionssystem/stack/rfcomm/port_utils.cc
- system/stack/rfcomm/rfc_int.h 13 additions, 8 deletionssystem/stack/rfcomm/rfc_int.h
- system/stack/rfcomm/rfc_l2cap_if.cc 27 additions, 19 deletionssystem/stack/rfcomm/rfc_l2cap_if.cc
- system/stack/rfcomm/rfc_mx_fsm.cc 29 additions, 23 deletionssystem/stack/rfcomm/rfc_mx_fsm.cc
- system/stack/rfcomm/rfc_port_fsm.cc 24 additions, 15 deletionssystem/stack/rfcomm/rfc_port_fsm.cc
- system/stack/rfcomm/rfc_port_if.cc 13 additions, 10 deletionssystem/stack/rfcomm/rfc_port_if.cc
- system/stack/rfcomm/rfc_ts_frames.cc 19 additions, 13 deletionssystem/stack/rfcomm/rfc_ts_frames.cc
- system/stack/rfcomm/rfc_utils.cc 2 additions, 2 deletionssystem/stack/rfcomm/rfc_utils.cc
Loading
Please register or sign in to comment