Skip to content
Snippets Groups Projects
  1. Sep 01, 2023
    • Hui Peng's avatar
      Fix an OOB bug in parse_gap_data · 0d7e3d8f
      Hui Peng authored
      Bug: 277590580
      bug: 275553827
      Test: atest net_test_main_shim
      Ignore-AOSP-First: security
      Tag: #security
      Merged-In: I7fcb7c46f668f48560a72399a3c5087c6da3827f
      Change-Id: I7fcb7c46f668f48560a72399a3c5087c6da3827f
      0d7e3d8f
    • Hui Peng's avatar
      Factor out duplicate code for parsing gap data · 08690d66
      Hui Peng authored
      This change is intended to be used to factor out
      dup code for parsing GapData in StartAdvertisingSet
      and make it easier to be tested.
      
      Backport of Ia39886c415218353b6f9d59d7d3f6d1160477d6c
      
      Bug: 296291440
      Test: atest net_test_main_shim
      Merged-In: Ia39886c415218353b6f9d59d7d3f6d1160477d6c
      Change-Id: Ia39886c415218353b6f9d59d7d3f6d1160477d6c
      08690d66
  2. Aug 31, 2023
  3. Aug 24, 2023
  4. Aug 07, 2023
  5. Aug 05, 2023
  6. Aug 04, 2023
  7. Jun 27, 2023
    • Hui Peng's avatar
      Fix multiple OOB bugs in btm_ble_gap.cc · 3bb913ee
      Hui Peng authored
      Bug: 275057843
      Bug: 275057678
      Test: manual
      Tag: #security
      Ignore-AOSP-First: security
      Merged-In: I4c8ec50c15e2727839a49da0e582164557bcd38a
      Change-Id: I4c8ec50c15e2727839a49da0e582164557bcd38a
      3bb913ee
  8. Jun 02, 2023
  9. May 24, 2023
  10. May 19, 2023
    • Hui Peng's avatar
      Fix an integer underflow in build_read_multi_rsp · 85f4d53c
      Hui Peng authored
      When p_buf->len is mtu - 1 and p_cmd->multi_req.variable_len
      evaluates to true, integer underflow is triggered
      in the following line, resulting OOB access.
      
      ```
       len = p_rsp->attr_value.len - (total_len - mtu);
      ```
      
      Bug: 273874525
      Test: manual
      Ignore-AOSP-First: security
      Tag: #security
      
      Merged-In: Ia60dd829ff9152c083de1f4c1265bb3ad595dcc4
      Change-Id: Ia60dd829ff9152c083de1f4c1265bb3ad595dcc4
      85f4d53c
    • Hui Peng's avatar
      Fix an OOB Write bug in avrc_vendor_msg · d5de235b
      Hui Peng authored
      Plus some cleanup
      
      Bug: 271962784
      Test: manual
      Ignore-AOSP-First: security
      Tag: #security
      Merged-In: Ice5ad780ac0b177c73d84ed37960b4540df1ec86
      Change-Id: Ice5ad780ac0b177c73d84ed37960b4540df1ec86
      d5de235b
  11. May 18, 2023
  12. May 16, 2023
    • Hui Peng's avatar
      Fix an integer overflow bug in avdt_msg_asmbl · bf9449a7
      Hui Peng authored
      Bug: 280633699
      Test: manual
      Ignore-AOSP-First: security
      Tag: #security
      Change-Id: Iaa4d603921fc4ffb8cfb5783f99ec0963affd6a2
      bf9449a7
    • Brian Delwiche's avatar
      Fix integer overflow in build_read_multi_rsp · badb8ffc
      Brian Delwiche authored
      Local variables tracking structure size in build_read_multi_rsp are of
      uint16 type but accept a full uint16 range from function arguments while
      appending a fixed-length offset.  This can lead to an integer overflow
      and unexpected behavior.
      
      Change the locals to size_t, and add a check during reasssignment.
      
      Bug: 273966636
      Test: atest bluetooth_test_gd_unit, net_test_stack_btm
      Tag: #security
      Ignore-AOSP-First: Security
      Change-Id: I3a74bdb0d003cb6bf4f282615be8c68836676715
      (cherry picked from commit 70a4d628)
      badb8ffc
  13. May 15, 2023
  14. May 12, 2023
    • Hui Peng's avatar
      Fix multiple OOB bugs resulted from tx mtu in EATT · ea76b7d9
      Hui Peng authored
      The tx mtu in EATT can be controlled by remote device. With malicious
      mtu values, it is possible to trigger integer overflow and
      OOB write at multiple places (see the bug below).
      
      This fix enforces a max tx mtu in EATT.
      
      Bug: 271335899
      Test: manual
      Ignore-AOSP-First: security
      Tag: #security
      Merged-In: Ia06c9a17f2daa5ce4c32cffa536777f47774cf31
      Change-Id: Ia06c9a17f2daa5ce4c32cffa536777f47774cf31
      ea76b7d9
  15. May 10, 2023
  16. May 09, 2023
  17. May 06, 2023
  18. May 03, 2023
  19. Apr 30, 2023
    • Hui Peng's avatar
      Fix a type confusion bug in bta_av_setconfig_rej · bbd88e88
      Hui Peng authored
      tBTA_AV_CI_SETCONFIG is treated as tBTA_AV_STR_MSG
      in bta_av_setconfig_rej, resulting OOB access.
      
      Bug: 260230151
      Test: manual
      Ignore-AOSP-First: security
      Tag: #security
      Merged-In: I78a1ee50dea0113381e51f8521711d758dc759cf
      Change-Id: I78a1ee50dea0113381e51f8521711d758dc759cf
      bbd88e88
  20. Apr 29, 2023
  21. Apr 25, 2023
  22. Apr 18, 2023
    • Hui Peng's avatar
      Fix an OOB bug in set_data · 58802164
      Hui Peng authored
      Plus move macros used in struct bt_oob_data_s
      to bluetooth.h
      
      Bug: 274722185
      Test: manual
      Ignore-AOSP-First: security
      Tag: #security
      Change-Id: Ie12feb4090a1eb88f5c9e097546f55a076839fb0
      58802164
    • Hui Peng's avatar
      Fix an OOB write bug in gatt_process_notification · fdaaa82d
      Hui Peng authored
      Bug: 276975913
      Test: manual
      Ignore-AOSP-First: security
      Tag: security
      Change-Id: I38353a573168e18f06b2b311e532a937044fd92f
      fdaaa82d
    • Hui Peng's avatar
      Fix an OOB bug in set_data · 0592ed17
      Hui Peng authored
      Bug: 274722163
      Test: manual
      Ignore-AOSP-First: security
      Tag: #security
      Change-Id: Ie4b30bbc19ba0bd191839af35880a4831d8005b1
      0592ed17
  23. Apr 14, 2023
  24. Apr 13, 2023
  25. Apr 11, 2023
    • Brian Delwiche's avatar
      Fix UAF in gatt_cl.cc · cbaa8362
      Brian Delwiche authored
      gatt_cl.cc accesses a header field after the buffer holding it may have
      been freed.
      
      Track the relevant state as a local variable instead.
      
      Bug: 274617156
      Test: atest: bluetooth, validated against fuzzer
      Tag: #security
      Ignore-AOSP-First: Security
      Change-Id: I085ecfa1a9ba098ecbfecbd3cb3e263ae13f9724
      cbaa8362
  26. Apr 04, 2023
  27. Apr 03, 2023
  28. Mar 31, 2023
  29. Mar 29, 2023
    • Brian Delwiche's avatar
      Fix OOB read in btm_ble_periodic_av_sync_lost · c077ffbe
      Brian Delwiche authored
      btm_ble_periodic_av_sync_lost internally calls the function
      btm_ble_get_psync_index_from_handle, which polls the internal periodic
      sync buffer and returns a matching index if one exists.  If no matching
      handle is found, it returns MAX_SYNC_TRANSACTION.
      
      However, here the calling function lacks the check for this case present
      in similar functions.  If no handle is matched, it will attempt to index
      the buffer with MAX_SYNC_TRANSACTION, which will overrun it by a single
      width and lead to OOB access.
      
      Add handling for this case.
      
      Bug: 273502002
      Test: atest bluetooth_test_gd_unit, atest net_test_stack_btm, validated
      against researcher POC
      Tag: #security
      Ignore-AOSP-First: Security
      
      Change-Id: I2e1e95b277f81b2668f721a7693df50841968ec5
      c077ffbe
Loading