- Apr 14, 2023
-
-
William Escande authored
-
- Apr 13, 2023
-
- Apr 04, 2023
-
-
Timothy Yiu authored
-
- Apr 03, 2023
-
-
Brian Delwiche authored
-
Brian Delwiche authored
-
- Mar 31, 2023
-
-
Brian Delwiche authored
-
- Mar 29, 2023
-
-
Brian Delwiche authored
btm_ble_periodic_av_sync_lost internally calls the function btm_ble_get_psync_index_from_handle, which polls the internal periodic sync buffer and returns a matching index if one exists. If no matching handle is found, it returns MAX_SYNC_TRANSACTION. However, here the calling function lacks the check for this case present in similar functions. If no handle is matched, it will attempt to index the buffer with MAX_SYNC_TRANSACTION, which will overrun it by a single width and lead to OOB access. Add handling for this case. Bug: 273502002 Test: atest bluetooth_test_gd_unit, atest net_test_stack_btm, validated against researcher POC Tag: #security Ignore-AOSP-First: Security Change-Id: I2e1e95b277f81b2668f721a7693df50841968ec5
-
- Mar 28, 2023
-
-
tyiu authored
Added boundary check for gatt_end_operation to prevent writing out of boundary. Since response of the GATT server is handled in gatt_client_handle_server_rsp() and gatt_process_read_rsp(), the maximum lenth that can be passed into the handlers is bounded by GATT_MAX_MTU_SIZE, which is set to 517, which is greater than GATT_MAX_ATTR_LEN which is set to 512. The fact that there is no spec that gaurentees MTU response to be less than or equal to 512 bytes can cause a buffer overflow when performing memcpy without length check. Bug: 261068592 Test: No test since not affecting behavior Tag: #security Ignore-AOSP-First: security Change-Id: I49e2797cd9300ee4cd69f2c7fa5f0073db78b873
-
- Mar 24, 2023
-
-
Hui Peng authored
Fix to the regression reported in b/264708304 and b/266585826 added: The root cause of the regression, the sensor HAL layer expects the HID feature reports to contain 40 bytes, even less bytes are contained in the data field. This updated fix restores the length of data fields with the len arg. Bug: 259675705 Test: manual verification with a Pixel 6 and LinkBuds Ignore-AOSP-First: security Tag: security Change-Id: I02f16c360965b049fc6c8fdfa0132b7aa54bc1d3
-
- Mar 21, 2023
-
-
Brian Delwiche authored
This reverts commit e6cf2700. Reason for revert: Reinstate original change for QPR Change-Id: I3e039f1b8f8ffbcc4875b663d417462451fb76a0
-
- Mar 13, 2023
-
-
Brian Delwiche authored
-
- Mar 11, 2023
-
-
Brian Delwiche authored
This reverts commit 367ed057. Reason for revert: Reverting from May QPR, will reinstate unchanged for a later release Change-Id: I36ae57ec7e81ac0357fa1c6fb98dff219ee6dade
-
- Mar 06, 2023
-
-
Brian Delwiche authored
-
- Feb 16, 2023
-
-
Brian Delwiche authored
Structure length is checked in pan_api.cc after the structure may be freed, leading to a potential use after free. Save the buffer length to a local instead. Note that BNEP_WriteBuf may alter the length being written internally; this does not appear to be an issue in this use case because the octet count being tracked is used only for logging purposes within PAN. Bug: 259939435 Test: atest bluetooth_test_gd_unit, validate against researcher POC Tag: #security Ignore-AOSP-First: Security Change-Id: I613b3dd3684182bdc725f9e1512061484448d367
-
- Feb 15, 2023
-
-
Brian Delwiche authored
sdpu_build_uuid_seq accepts a UUID sequence of arbitrary length but does not validate against the boundaries of the buffer it's filling. This can lead to an OOB write. Add validation. Bug: 239414876 Test: atest: bluetooth, validated against POC Tag: #security Ignore-AOSP-First: Security Change-Id: I6c0b91428bd37d73ae707b8a1843338998fb9562
-
- Feb 09, 2023
-
-
Hui Peng authored
-
- Feb 07, 2023
-
-
Hui Peng authored
-
Hui Peng authored
-
Brian Delwiche authored
For NCIS certification, we need to drop the connection or reestablish encryption after receiving a command to disable link layer encryption on an encrypted link. However, dropping the connection for all devices breaks compatibility during role switch with devices running Bluetooth 2.1 or earlier, a category including many cars still in the field. Add a check forcing connections to drop in this case, conditioned on Common Criteria mode.. Bug: 251436534 Test: atest: bluetooth, lab validation forthcoming Tag: #security Ignore-AOSP-First: Security Change-Id: I94654ebeb16774643107ee41473725cfae3764ab
-
Hui Peng authored
-
Hui Peng authored
-
Hui Peng authored
-
Hui Peng authored
Bug: 261857395 Test: manual Tag: #security Ignore-AOSP-First: security Change-Id: I1ba4d1f1e62b1d77ac635cfb6b16cf175bfbf254
-
Hui Peng authored
-
Hui Peng authored
Bug: 254445961 Test: manual Ignore-AOSP-First: security Change-Id: I1d3c208a5281b88ed25c0028f1a0000d6957637c
-
- Feb 06, 2023
-
-
Hui Peng authored
-
Hui Peng authored
-
Hui Peng authored
Bug: 245517503 Test: manual Ignore-AOSP-First: security Change-Id: If768b0b2e11bbc4444835fda28e246e285a7e8ab
-
Hui Peng authored
Bug: 251427561 Test: manual Ignore-AOSP-First: security Change-Id: I2db2339631d521515cb34536e358ae72ebeaaa8b
-
Hui Peng authored
Bug: 233879420 Test: manual Ignore-AOSP-First: security Change-Id: Ic740e5ff3ceabf3df1e78431f7d31adf356479f0
-
- Jan 31, 2023
-
-
Hui Peng authored
Bug: 236688764 Test: manul Ignore-AOSP-First: security Tag: #security Change-Id: I0ef4855e715be8fa9a69916e35d3a6c97498a9cc
-
- Jan 25, 2023
-
-
David Duarte authored
-
- Jan 19, 2023
-
-
Hui Peng authored
Bug: 260079141 Test: manual Ignore-AOSP-First: security Change-Id: If8be70e134fdf1f6edb43d0360c524fffed6045b
-
- Jan 14, 2023
-
-
Hui Peng authored
Bug: 245916076 Test: manual Ignore-AOSP-First: security Change-Id: I901d973a736678d7f3cc816ddf0cbbcbbd1fe93f
-
- Jan 12, 2023
-
-
Hui Peng authored
Bug: 263545186 Test: manual Ignore-AOSP-First: security Change-Id: I0abbb67842850cc2f1298b43dc49a89445b40a43
-
Brian Delwiche authored
-
- Jan 11, 2023