Skip to content
Snippets Groups Projects
  1. Mar 25, 2016
  2. Mar 24, 2016
  3. Mar 23, 2016
    • Ying Wang's avatar
      Tell the build system this is a host module. · a4069fdd
      Ying Wang authored
      We need to tell the build system this is a host module before calling
      local-generated-sources-dir.
      
      Change-Id: Ie36ad938c0c7124865148f20fcb70d5187f158b8
      (cherry-pick from commit df515a46dd4fe27040c39d35b14b3e071319156d)
      a4069fdd
  4. Mar 22, 2016
    • Jakub Pawlowski's avatar
      Use handles to identify GATT attributes (1/4) · f9eee5ef
      Jakub Pawlowski authored
      Bug: 27778668
      Change-Id: Id7454450c1ce2164001a1f9ca0b91f18d84e3fd6
      f9eee5ef
    • Jakub Pawlowski's avatar
      HID service discovery refactor · 2ffd0555
      Jakub Pawlowski authored
      This patch changes how HID is initialized.
      Up till now, HID discovery was intricately chained,
      to make sure two operations are not scheduled at same time.
      From now on, all discovery is done and all operations are
      scheduled for execution right away. There is separate set
      of functions making sure all operations will be executed
      without collisions.
      
      This patch also removes BTA_HH_SCPP_INST_DEF, which was
      used as hardcoded service id.
      
      Bug: 27698756
      Change-Id: I30a7388e129844c5e4727b2ed2b7c05867cc73a8
      2ffd0555
    • Jakub Pawlowski's avatar
      Restructure GATTC · 19e7ef24
      Jakub Pawlowski authored
      This patch changes how GATTC is structured. Up till now, it
      contained tBTA_GATTC_CACHE and tBTA_GATTC_CACHE_ATTR. Those
      structures were so ugly, someone hide them inside internal
      header, to make sure noone would ever access them from outside
      GATTC. They are now replaced with:
      tBTA_GATTC_SERVICE,
      tBTA_GATTC_CHARACTERISTIC,
      tBTA_GATTC_DESCRIPTOR and
      tBTA_GATTC_INCLUDED_SVC.
      
      Those looks much better, and were made globally avaliable.
      Thanks to way they're build, we no longer need set of access
      methods, which were also very ugly:
      BTA_GATTC_GetFirstChar
      BTA_GATTC_GetNextChar
      BTA_GATTC_GetFirstIncludedService
      etc.
      
      This patch breaks HID, DO NOT SUBMIT without HID refactor.
      
      Bug: 27455533
      Change-Id: Ic42cfff175e0cc1a0d8e1a1216e2b4b756cbf77d
      19e7ef24
    • Andre Eisenbach's avatar
      Merge changes from topic 'bug-27455533-to-nyc-dev-merge-1' into nyc-dev · 72d12524
      Andre Eisenbach authored
      * changes:
        Remove bta_gattc_id2handle
        Use attribute handle instead of id in GATT cache
        HID multi-device refactoring
        GATT cache storage refactoring
        Remove dead methods and callbacks
        Simplify UUID handling in GATT cache
      72d12524
    • Pavlin Radoslavov's avatar
      Cleanup after p_mcb if L2CA_ConnectReq() failed · cf199a99
      Pavlin Radoslavov authored
      If L2CA_ConnectReq() failed, make sure that
      we cleanup the lcid cache state after the
      affected p_mcb.
      
      Also, extra check and a log message inside function
      rfc_check_send_cmd().
      
      Bug: 27334916
      Change-Id: Ib2950d12ce456d74355f4bcc0e3c4d87603f8f91
      cf199a99
    • Pavlin Radoslavov's avatar
      Add missing initialization of queue btm_cb.sec_pending_q · b7bca803
      Pavlin Radoslavov authored
      Bug: 27763878
      Change-Id: I93001a679e22b744c3feafda1997e5f7e707db4e
      b7bca803
  5. Mar 21, 2016
    • Ajay Panicker's avatar
      Add config source to dumpsys output · 2d018b8c
      Ajay Panicker authored
      This logs where the config file was loaded from in the Bluetooth
      Manager dumpsys output.
      
      Bug: 27354612
      Change-Id: I50d4aaa0be4f4d1d890580b03742713f4345c80f
      2d018b8c
    • Andre Eisenbach's avatar
      Do not leak eventfd's for RFCOMM/AVDT/L2CAP · c59c56ed
      Andre Eisenbach authored
      Various users of fixed_queue's do not free the lists properly after
      using them. As a result two event fd's leak for each fixed_queue that
      is not free'd, as fixed_queue contains two semaphores.
      
      This can lead to run-away file descriptor allocation and an eventual
      hard limit leading to various undefined behaviours.
      
      Bug: 27731859
      Change-Id: If9ce64b711083bf474d217aa537220065722ad3a
      c59c56ed
  6. Mar 17, 2016
  7. Mar 16, 2016
  8. Mar 14, 2016
    • Srinu Jella's avatar
      Free allocation tracker hash map entries to reduce memory pressure · 02e73872
      Srinu Jella authored
      Use case:
      A2DP playback becomes choppy after long hours of testing.
      
      Steps:
      1. installed 3rd party app that performs recurring LE scans.
      2. Leave phone to run overnight.
      3. After 24h+, connect a Bluetooth headset and music is very choppy.
      
      Root cause:
      The memory allocation tracker has support for double free check
      where it stores all allocations in hash map but it never get
      removed to track double free issue, A2DP memory allocation is
      taking more time and leading to choppyness.
      
      Fix:
      Free the hash map entry to avoid memory leak from
      allocation tracker.
      
      Bug: 27621407
      Change-Id: If57bd0b89c1d9b99c4f066c537a9e0fa49bc093f
      02e73872
  9. Mar 11, 2016
    • Ajay Panicker's avatar
      Add pair event device class and fix timestamp · 4012eff3
      Ajay Panicker authored
      Added a function to get the device class to use with pair events.
      Also update check_cod_hid as it was only being used with COD_HID_MAJOR.
      Also fixed an issue with pair event timestamps where they were
      using the wrong clock.
      
      Bug: 27499938
      Change-Id: I0805d7a3f82b28e7d7e73d80818948843f51a82b
      4012eff3
  10. Mar 09, 2016
    • Glenn Kasten's avatar
      Use audio_session_t consistently · 48dbd2ac
      Glenn Kasten authored
      Bug: 27562099
      Change-Id: I10780c8bfc84af568795a2c15557020fbe89a1c4
      48dbd2ac
    • Jakub Pawlowski's avatar
      Remove bta_gattc_id2handle · 2f283223
      Jakub Pawlowski authored
      Now that the instance id is equal to handle, we no longer need this
      mapping function.
      
      Bug: 27455533
      Change-Id: I6760f8fc81460df8520d4ebf1899ed256ce5ad1e
      2f283223
    • Jakub Pawlowski's avatar
      Use attribute handle instead of id in GATT cache · 3ad93bf4
      Jakub Pawlowski authored
      Currently we generate an id for each GATT attribute. Those ids
      are used to differentiate between attributes that have the same
      UUID. We need to get rid of those ids because it won't work with
      partial GATT database updates due to "service change"
      notifications. Instead, attribute handles, which are unique
      across the whole GATT database will be used.
      
      This is first patch in series to achieve that. It gets rid
      of id generation, and just assigns handle in place of ids inside
      of gatt cache. Upcoming patches will change the GATT cache API
      and eventually get rid of "id" completly.
      
      Bug: 27455533
      Change-Id: I74c10872ecc223329b8ac7fef4085963bf272624
      3ad93bf4
    • Jakub Pawlowski's avatar
      HID multi-device refactoring · 238190d0
      Jakub Pawlowski authored
      We don't really support multiple HID services in same device.
      We shouldn't use default value 0 for service id.
      We shouldn't merge service id and characteristic id into one field,
      as it's done not right right now.
      
      Bug: 27455533
      Change-Id: I46cc1b62bb2c7393e62f3b1a8e4650706954a066
      238190d0
    • Jakub Pawlowski's avatar
      GATT cache storage refactoring · 9ad7163f
      Jakub Pawlowski authored
      Currently when storing GATT cache into file, we save it piece
      after piece, max 10 elements at once. This is not necessary,
      we have enough space to just save all at once.
      Also the logic doesn't need to be so complicated - no need
      to state machine for such simple task.
      
      Bug: 27455533
      Change-Id: I82923dbedfb317835e45e13e0ea28151eb524d37
      9ad7163f
    • Jakub Pawlowski's avatar
      Remove dead methods and callbacks · 2115c75e
      Jakub Pawlowski authored
      Bug: 27455533
      Change-Id: Ie5661577320810468dd635022027a1e1a2f70a3e
      2115c75e
    • Jakub Pawlowski's avatar
      Simplify UUID handling in GATT cache · 6ee9d90a
      Jakub Pawlowski authored
      Bug: 27455533
      Change-Id: I653b563d3b3c233ffe31b0a35d396a66db363459
      6ee9d90a
  11. Mar 08, 2016
    • Dimitry Ivanov's avatar
      Fix the build · 1222c10f
      Dimitry Ivanov authored
      Change-Id: Ib226f087a76ddd426e40f4d6d94f2ed758660c36
      1222c10f
    • Sanket Agarwal's avatar
      Move focus handling entirely to component calling fluoride. · cc9daa7a
      Sanket Agarwal authored
      Audio focus handling for A2DP sink currently split between Fluoride and
      the component sitting on top of it. Since this is not the best place to
      decide policies, we move all such decisions to the upper layer.
      
      Bug: b/26928143
      
      Change-Id: I67a1a2a50782289e7e31447b01ee29a21bc8dac2
      cc9daa7a
    • Pavlin Radoslavov's avatar
      Ignore LCB entries that migth have been released while queued · cb782072
      Pavlin Radoslavov authored
      Function btm_send_pending_direct_conn() dequeues tL2C_LCB
      entries from the conn_pending_q queue and calls the processing
      function.
      However, there is the possilility of a race condition
      and releasing the entry by l2cu_release_lcb() before it is processed.
      Now tL2C_LCB that are not in_use are ignored.
      
      Bug: 27418154
      Change-Id: I4b5fda605a60c8aebbf5587bb12dd74ac5d28f68
      cb782072
  12. Mar 04, 2016
  13. Mar 03, 2016
    • Chaojing Sun's avatar
      Fix Dell LE keyboard connection issue · 8de8705a
      Chaojing Sun authored
      Fixes a connection issue where Dell keyboards do not remain connected
      immediately after pairing by removing the gatt_config_ccc_complete()
      call in gatt_cl_op_cmpl_cback().
      
      Bug: 27385897
      Change-Id: Iee342975dce9fdcd5dcf8f9d459f74fe13d02531
      8de8705a
    • Prashant Malani's avatar
      Fix miscellaneous compilation errors · 062581ce
      Prashant Malani authored
      - Move variables within #defines to avoid unused errors.
      - Place #define's correctly to avoid unused function errors.
      - Correct parameter passed into a function.
      
      Bug: 27336841
      Change-Id: I7c2ab24b3bd3725d126c90483473af83b88687a2
      062581ce
  14. Mar 02, 2016
    • Ajay Panicker's avatar
      Btsnooz doesn't find snooplog sometimes · 72078893
      Ajay Panicker authored
      In the bugreport in b/27274486 comment #11, the line indicating the
      beginning of BTSNOOP LOGS was slightly indented thus causing btsnooz
      to not find the beginning of the log.
      
      Bug: 27419027
      Change-Id: I3b88e6a3f6f2d6c4d3cbbadb0a93cbd7965f56c8
      72078893
    • Pavlin Radoslavov's avatar
      Fix l2cu_initialize_fixed_ccb() to return only initialized entries · 08e57f7c
      Pavlin Radoslavov authored
      Update the l2cu_initialize_fixed_ccb() implementation so
      it returns only entries that are properly initialized.
      In some complex scenarios, the p_lcb->p_fixed_ccbs[] array
      might contain an entry that has been released by l2cu_release_ccb(),
      and such entry cannot be reused as-is.
      
      Bug: 26927945
      Change-Id: I42d42926cc6da6b8be662781545753c36b75968e
      08e57f7c
  15. Mar 01, 2016
  16. Feb 27, 2016
    • Andre Eisenbach's avatar
      Ensure inquiry is always stopped before service discovery · 28debd4e
      Andre Eisenbach authored
      Service discovery cannot be initiated when the dm search state machine
      is not in idle state. This patch ensures that service discovery is
      always cancelled regardless of the current state of inquiry.
      
      Bug: 27368986
      Change-Id: Ib83d4c8d389e50a1c65e52b343f4996455747836
      28debd4e
  17. Feb 26, 2016
  18. Feb 25, 2016
    • Pavlin Radoslavov's avatar
      Fix a crash triggered when firmware config takes too long · 5be60417
      Pavlin Radoslavov authored
      Fix a crash condition that is triggered when the firmware
      configuration takes too long:
       1. The startup_timer expires, and it resets startup_future to NULL
       2. The delayed firmware_config_callback is received, and it
          tries to use the startup_future pointer (already set to NULL).
      
      [Cherry-pick from AOSP]
      
      Bug: 27336555
      Change-Id: I4b04ca08a32c947f6f1eaabec7c4b099f96aab59
      5be60417
Loading