Change-Id: I9e10e7ef4e56a103bfd2c916b27920487e2ab173
Test: atest BluetoothDeviceConfigChangeTrackerTest
Bug: 242348618

Bug: 247470852
Test: statsd_testdrive 521
Change-Id: I2e1a8747027ec5e645f34d93c4ada8a1a53c01ca

Bug: 247470852
Test: statsd_testdrive 521
Change-Id: Ie9d27426578e0605965b8f35eed4a51c9a7e2196

This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: I9408872c39c30cd2c9c1038b4a56d0d412344bde

Bug: 244224847
Test: manual
Ignore-AOSP-First: merge internal first
Change-Id: I04195ef1e1c8d7eb629c9e68bb12e91267be922a
Merged-In: I04195ef1e1c8d7eb629c9e68bb12e91267be922a

The Bluetooth apex name is now called com.android.btservices

Bug: 243054261
Test: Build
Change-Id: Ib79eed8e441b8897f2a7d336c26addf02af345e2

Bug: 243054261
Test: build + TH
Change-Id: I75cecfcd432e6446687134489bb66527bb32eeb4

Update Settings.Global flags with Device Config flag values on
initialization

Bug: 239983569
Test: manual
Change-Id: I777582ae8b21c3dc93142c7681a2e9b21e19cd8a
Merged-In: I777582ae8b21c3dc93142c7681a2e9b21e19cd8a

Bug: 242963176
Tag: #feature
Test: manual
Change-Id: I5954d22647dca07d5bfd55aea263a79d70ad0f7c

BluetoothOppLauncherActivity & BluetoothOppBtEnableActivity
'enabled' state should be updated wether Bluetooth is ON or
OFF. Previously, the state of these Activities was set with
resource config, but since Bluetooth started replacing them
by sysprops, we had to enable / disable these Activities in
BluetoothOppService. However, the bt sharing tile should be
available even when Bluetooth is OFF, and as their state is
already updated in BluetoothManagerService when there is an
user change, we can use that instead but with the condition
that BluetoothOppBtEnableActivity is enabled too. All other
Bluetooth OPP Activities enabled / disabled state are still
handled in BluetoothOppService as they require Bluetooth to
be ON to work anyway, and don't impact UI tiles. This fixes
both an issue where the bt sharing tile doesn't appear when
Bluetooth has been turned OFF, and an issue where Bluetooth
would crash if it hadn't been turned ON before using the bt
sharing tile.

Test: manual
Tag: #feature
Bug: 242963176
Merged-In: I67840dbd9f4cfc42026a14a1fc467fc95aa3a587
Change-Id: I67840dbd9f4cfc42026a14a1fc467fc95aa3a587

This fixes the bluetooth package detection functionality in the case
when *all* components are disabled. This occurs in the CTS test, but did
not occur in manual testing of ag/19219300.

Also did manual testing to make sure we don't regress (toggled the no_bluetooth_sharing option, verified that it appeared/disappeared)

Bug: 239372439
Test: atest CtsDevicePolicyManagerTestCases:DeviceOwnerTest
Tag: #stability
Merged-In: Ib9530a8829a946ea00a21111e459d697086f2ef8
Change-Id: Ib9530a8829a946ea00a21111e459d697086f2ef8

This is an extremely partial fix for a mostly-broken feature. For
fully-managed devices, this fixes the toggle for the file sharing
option, by detecting which Bluetooth package should be used rather than
just guessing.

However, on work profiles, the file sharing option does not really work
anyway, it just infinitely loads. In addition, it is not correctly
disabled when Bluetooth stops, so the icon just remains but doesn't
do anything.

A full fix would add the enable/disable sequence for *work* UserHandles
to BluetoothOppManager, so the LAUNCHER_ACTIVITY is properly enabled and
disabled. In addition, it would fix the issue described in the linked
bug to prevent infinite loading (dedicated bug: b/112625123).

Tag: #stability
Bug: 237389774
Test: Manual, verifying the *badged* BT file sharing icon appears/disappears as needed
Merged-In: I070987bc884947246c372c65691c4866ebd1e7c7
Change-Id: I070987bc884947246c372c65691c4866ebd1e7c7

Bug: 239983569
Test: atest ServiceBluetoothTests
Change-Id: Ia01b3b88a56a528484d6cb8dc0f217c3f400258e
Merged-In: Ia01b3b88a56a528484d6cb8dc0f217c3f400258e

Bug: 229914434
Test: Build + start bt + connect a device
Change-Id: Ie47cce2bfb9c00cf41c093baba726ea1c0421701

Otherwise we keep restarting it randomly, especially for dogfooders, and
not everything likes it when Bluetooth restarts (especially if they're
doing LE stuff in the background).

Test: atest BluetoothDeviceConfigChangeTrackerTest and manually changing
flags with adb
Tag: #stability
Bug: 242348618

Change-Id: Ia955e5ed92c51ec65e0ac0dc42e0998b9c9845ae

Bluetooth/service and Bluetooth/framework test suites were
broken after the migration of the files from frameworks.
The Bluetooth/framework test suite is split between stress
tests that require a physical Bluetooth device to run and
the unit tests that test the framework hidden APIs.
Both framework unit tests and service tests are signed
and can be added to the MTS.

Test: atest FrameworkBluetoothTests
Test: atest ServiceBluetoothTests
Bug: 232577476
Tag: #feature
Change-Id: Ibdb20c650db2483c4569d979da5e024e0e95284c
Merged-In: Ibdb20c650db2483c4569d979da5e024e0e95284c

Bug: 239983569
Test: atest ServiceBluetoothTests
Ignore-AOSP-First: resolve merge conflict on internal first

Change-Id: Id16cb1e0a89d66d9d5cb250ca5de987ef558e447
Merged-In: Id16cb1e0a89d66d9d5cb250ca5de987ef558e447

Bug: 239983569
Test: atest ServiceBluetoothTests
Ignore-AOSP-First: feature merged internally first to avoid merge
conflicts in AOSP

Change-Id: I4c73840f8c6e3a983a3c1f065733e26cf7140bf9
Merged-In: I4c73840f8c6e3a983a3c1f065733e26cf7140bf9

The Bluetooth apex name is now called com.android.btservices

Bug: 243054261
Test: Build
Change-Id: I4d48b875c254b8381c982a633e3132b6de6178aa

Merge conflicts should be gone now that mainline is part of AOSP.

Bug: 239983569
Test: manual
Change-Id: I2092880e047a1a9d50a47e4724e5fb2815d04f2d
Merged-In: I2092880e047a1a9d50a47e4724e5fb2815d04f2d

This is an extremely partial fix for a mostly-broken feature. For
fully-managed devices, this fixes the toggle for the file sharing
option, by detecting which Bluetooth package should be used rather than
just guessing.

However, on work profiles, the file sharing option does not really work
anyway, it just infinitely loads. In addition, it is not correctly
disabled when Bluetooth stops, so the icon just remains but doesn't
do anything.

A full fix would add the enable/disable sequence for *work* UserHandles
to BluetoothOppManager, so the LAUNCHER_ACTIVITY is properly enabled and
disabled. In addition, it would fix the issue described in the linked
bug to prevent infinite loading (dedicated bug: b/112625123).

Tag: #stability
Ignore-AOSP-First: For T?
Bug: 237389774
Test: Manual, verifying the *badged* BT file sharing icon appears/disappears as needed

Change-Id: I070987bc884947246c372c65691c4866ebd1e7c7
(cherry picked from commit 36362f25)
Merged-In: I070987bc884947246c372c65691c4866ebd1e7c7

Bug: 232351962
Tag: #feature
Test: atest CtsBluetoothTests
Ignore-AOSP-First: change only in internal
Change-Id: I66c0a83554d81f8a6a6956ec0a8a324be6b11033
(cherry picked from commit a82b0872)
Merged-In: I66c0a83554d81f8a6a6956ec0a8a324be6b11033

Bug: 237175319
Tag: #refactor
Test: build
Change-Id: I7d7ef16387756a53115701c461fa735f214c3f25
(cherry picked from commit aed442ee)
(cherry picked from commit b94bfd91)
Merged-In: I7d7ef16387756a53115701c461fa735f214c3f25

This reverts commit dd85e91c.

Bug: 217366135
Reason for revert: Need this to fix a crash bug in tm-dev

Change-Id: I2a94c278edc0681c5b8af6ea0a0171b71d72c650
(cherry picked from commit dbaf406ccb0ed887d4e93057c9ec0d3457f14457)
Merged-In: I2a94c278edc0681c5b8af6ea0a0171b71d72c650

Bug: 237175319
Tag: #refactor
Test: build
Change-Id: I7d7ef16387756a53115701c461fa735f214c3f25

This reverts commit 02dcbe72.

Reason for revert: Causing builds to fail b/237471430

Change-Id: I6165d838abf312085050359377f67a68a5f8b51a
(cherry picked from commit f5dd42bbd05e68f7763ccaa9fae5642acc4ceba1)
Merged-In: I6165d838abf312085050359377f67a68a5f8b51a

Bug: 217366135
Tag: #feature
Test: manual
Ignore-AOSP-First: to be chery-picked
Change-Id: If8ae530a284151888a3f89a51d2c58f2a5cd3644
(cherry picked from commit 02dcbe72)
Merged-In: If8ae530a284151888a3f89a51d2c58f2a5cd3644

Test: No test
Change-Id: I153f9e8d6812b1597ccd51138a6945da47610d0d

Bug: 217366135
Tag: #feature
Test: manual
Ignore-AOSP-First: to be chery-picked
Change-Id: If8ae530a284151888a3f89a51d2c58f2a5cd3644

Cleanup usage of depfile in gensrcs to deprecate the property (aosp/2120835). The concept of depfile isn't transferable to Bazel, which requires listing the deps explicitly. The end goal of this change is to ensure all remaining gensrcs modules are convertible to Bazel by bp2build.

Test: m service-bluetooth
Bug: 179452413
Change-Id: I58d45d26ba4c9205e8020810319724479f21285e
Ignore-AOSP-First: The fixed modules don't exist in AOSP

TbsService and HeadsetService were missing one check
before BluetoothManagerService would try to bond to them.

Bug: 236196227
Tag: #feature
Test: manual
Ignore-AOSP-First: will be cherry-picked
Change-Id: Iceb6c437216092a7dccc238f396f4d95e341af1d
(cherry picked from commit ff0896db)
Merged-In: Iceb6c437216092a7dccc238f396f4d95e341af1d

TbsService and HeadsetService were missing one check
before BluetoothManagerService would try to bond to them.

Bug: 236196227
Tag: #feature
Test: manual
Ignore-AOSP-First: will be cherry-picked
Change-Id: Iceb6c437216092a7dccc238f396f4d95e341af1d

Bug: 235495968
Tag: #refactor
Test: manual
Change-Id: Icfe55340b26c40111df0b2babbdfc40bf026dac0
(cherry picked from commit 00294a78)

Bug: 235495968
Tag: #refactor
Test: manual
Change-Id: Icfe55340b26c40111df0b2babbdfc40bf026dac0

Bug: 228849846
Test: atest ManagedProfileTest
Tag: #feature
Ignore-AOSP-First: cherry-pick
Change-Id: I010cf384a8b18a776d8052e87551b8af6fb348cb

If bluetooth is started too early, it will need to be restarted to
change its gid.
By delaying the bluetooth start after the OnUserStarting we ensure the
permissions are already set

Fix: 232740613
Test: build & flash with wipe. Check log at first startup
Tag: #refactor
Merged-In: Ifde1348baad5802276679ecc24bc8ae458d02fe6
Change-Id: Ifde1348baad5802276679ecc24bc8ae458d02fe6

If bluetooth is started too early, it will need to be restarted to
change its gid.
By delaying the bluetooth start after the OnUserStarting we ensure the
permissions are already set

Fix: 232740613
Test: build & flash with wipe. Check log at first startup
Tag: #refactor
Ignore-AOSP-First: will be push on aosp next
Change-Id: Ifde1348baad5802276679ecc24bc8ae458d02fe6

updateOppLauncherComponentState was using the old Bluetooth
package name, now we call PackageManager to get it
at runtime.

Bug: 227078439
Test: atest testOppDisabledWhenRestrictionSet
Tag: #stability
Ignore-AOSP-First: rename in internal only
Change-Id: I79c100673e98d4eb64652881428435f0ac6ba501

instead of using the SystemService#onUserSwitching method

Tag: #feature
Bug: 228920751
Test: Manual
Ignore-AOSP-First: Change only present in tm-dev
Change-Id: Ic8c32c29662389bd62fa1684de9679c369545874
(cherry picked from commit 320618b1)
Merged-In: Ic8c32c29662389bd62fa1684de9679c369545874

This reverts commit eda5120b.

Reason for revert: The issue in the bug is still reproducible after this change was landed

Tag: #feature
Bug: 228920751
Test: Manual
Ignore-AOSP-First: Change only present in tm-dev
Change-Id: I8d818370bcd6694b17c77545538f25fa2bbe2e34
(cherry picked from commit 2fece970)
Merged-In: I8d818370bcd6694b17c77545538f25fa2bbe2e34