- Apr 24, 2023
-
-
David Duarte authored
Test: TreeHugger Bug: 279502784 Change-Id: I1a726a4a0b7e7fd7786580337a3845701bdf3317
-
Sal Savage authored
-
Treehugger Robot authored
-
William Escande authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Sal Savage authored
Problem: It was found that several AVRCP Controller functions would allocate transaction labels without setting transaction timeouts. This would cause labels to leak if something went wrong, either in lower levels of code, or on the remote device. Once our device leaked enough labels, we could no longer allocate labels for operations, which would render the connection effectively useless Solution: We previously added debugging to check which transaction types were leaking labels. We've used those results with careful code review to refactor the transaction label code so its much harder to leak labels. First, context was added to get_transaction, which enables us to better track which transactions have which labels. Second, the various build_and_send_* commands now *all* start transaction timers for their outgoing commands. This means Vendor, Passthrough, and Browsing all have command timeouts, instead of just Vendor commands. Third, the transaction timer/timeout code path has been unified into one timer. Callbacks for browse timeout events have been added as well, so that upper layers know when something has gone wrong. Bug: 272585347 Test: Connect a recent device and browse, look at transaction labels in logs and dumpsys Change-Id: Ieb73aee5532c06f79265e204e739d8e15c153ae2
-
Sal Savage authored
-
William Escande authored
Bug: 269973219 Test: manual testing Change-Id: I744da162270838f3d5329170c0006ed67854b4f0
-
William Escande authored
Factorise code to have only one place to delay critical callback Bug: 269973219 Test: manual testing Change-Id: Ic4f89b6444a1f6c245e2b3f8f4d5de5e33327ad2
-
Henri Chataing authored
* changes: RootCanal: Remove the legacy authentication code RootCanal: Cleanup build declarations in CMakeLists.txt
-
Myles Watson authored
-
Josh Wu authored
This test shouldn't fail so that we can test the downstream flow and deployement. Test: avatar run Bug: 278848225 Change-Id: Ib33b6d4d82f9cbb86c887e226beacf6cd3811a9c
-
Hieu Dang authored
-
- Apr 23, 2023
-
-
JS Huang authored
it should pass "size" and then "rank", instead of "rank" and then "size" when calling OnDeviceAvailable(). Bug: 279270913 Test: Manual Change-Id: Ia642d01f6e78757318e2c1730a6c23286068033d
-
- Apr 22, 2023
-
-
Treehugger Robot authored
-
Thomas Girardier authored
-
- Apr 21, 2023
-
-
Myles Watson authored
When Bluetooth is turning off, there's no guarantee that dump will finish. Let it finish instead of causing a crash. Bug: 235762947 Test: toggle Bluetooth quickly and run adb shell dumpsys Change-Id: I3fd4131684869120673986902ec966eb6b6ce597
-
William Escande authored
Bug: 278823133 Test: net_test_device64 --gtest_repeat=100000 --gtest_break_on_failure Change-Id: I6c6e38e2f87fc6fe64523b644eee057006f48a23
-
Sal Savage authored
Bug: 272585347 Test: Connect an AVRCP Target device and check logs/dumpsys Change-Id: I63432b5bc6e37dbc55577341bab22b10d7b895c9
-
Henri Chataing authored
All clients of RootCanal have now switched to the rust lmp implementation, and the legacy version can be removed. Test: m root-canal Test: ./android/rebuild.sh Bug: 279169336 Change-Id: I86185fef7dd8c1596f5f27265c720507dac092a7
-
Henri Chataing authored
Inline intermediate libraries and remove unused declarations. Bug: 279169336 Test: ./android/rebuild.sh Change-Id: Ic1b365f43f04e4d674dad576a70c062bd596fb42
-
Treehugger Robot authored
-
Sarvesh Kalwit authored
-
Treehugger Robot authored
-
Yuyang Huang authored
-
Jayden Kim authored
-
Roopa Sattiraju authored
-
Rahul Arya authored
This reverts commit c3bfd219. Reason for revert: b/278813388 Change-Id: Ieaa20f122b8b850e0d5ce3e7e25f7e0b37eb629d
-
Henri Chataing authored
Revert submission 2555453-revert-2549337-rootcanal-cmake-XPMVJPEKUD Reason for revert: A fix was already merged for the mac build. https://android- review.git.corp.google.com/c/platform/tools/netsim/+/2555390 Please insert more information to justify the revert. Reverted changes: /q/submissionid:2555453-revert-2549337-rootcanal-cmake-XPMVJPEKUD Change-Id: I7a25b51d6818d57bab9c84493deb9f24833117e9
-
Bo Hu authored
-
Bo Hu authored
Revert submission 2549337-rootcanal-cmake Reason for revert: broke mac build Reverted changes: /q/submissionid:2549337-rootcanal-cmake Change-Id: Idebfaa6f1a9a9b071c3810446494e1bb73c3707e
-
Sarvesh authored
Previously, an incorrect variable was used to provide the address of a disconnecting peripheral, producing a garbage value for the peripheral's address. This change uses the correct variable to fetch the actual address of a disconnecting peripheral. Bug:264969525 Test: Ensure disconnecting state address is correct when turning off \ a Bluetooth connected peripheral Change-Id: I7e80d637c69f8ae838ebef4db6f0d4936e210085
-
Treehugger Robot authored
-
Henri Chataing authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Łukasz Rymanowski authored
At this point group should exist. If not, let's catch the log and just set device as disconnected Bug: 279046914 Tag: #feature Test: manual Change-Id: I22bd53b4e36533df54eee1a44f3890613795c40e
-
Grzegorz Kolodziejczyk authored
-