Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ia3a8c7e18de52d1b4b2b73ea76ce57586c954a4e

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I65bac30e7060f0cc156676c1f78d2f3482b16835

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ide1a5faa7afbed347a77d5c484a633479bf641ef

Bug: 170342881
Tag: #refactor
Test: atest --host bluetooth_test_gd

Change-Id: I64f5be7d2aa38a62091fde43b1926479021c10a6

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Id19aa6c9dd0c5bb010345e8706a55be05b04fcc0

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I8daa6e06248eb28463b1ef552bbfe3ff547f6d3a

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Ib916439e3d5c0580ce299ee2b5b3b2c07161a78b

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I474142526f861161f5a95c3214a43ea2794afa5c

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Icade424100d8ca269166b8f3f9179245abb88963

Towards readable code. Classic power mode is a mess

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: Idd88f6b53eb722a2b7477d9b244ae9ab94d63df2

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I063ab292f54a9ae6e1ab488030fb82f0a4576e49

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I94620f506d0fc5ee32f1fe8a5dc75dc5915dd6af

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I1a43557474ede94add88fe98bece0dda81520315

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I1b8e4555ab6754d74f0058b4909a6e06718af035

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I0c28b56845e4d0c37931842ee882a4c55c5ab98a

Previous arch had l2cap driving the btm layer.
The new legacy acl/btm layer sits between the l2cap
layer and the hci layer.  The call path has
already been exercised by this time and is called twice

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I8e83a79020f0c9cdfaab0916af1a8e2028e130ca

Don't use callbacks for registered service (we as server).  This could
confuse user (shim).

Tag: #gd-refactor
Test: CtsVerifier
Bug: 141555841
Change-Id: Icde090fa609043a61301c18782874dad9ade99d1

* changes:
  rusty-gd: refine stack ffi a bit
  Apply rustfmt to keep checkin hook happy

This reverts commit 53883624.

Reason for revert: The CL that fixed the test landed
Bug: 175033589
Test: cert/run SecurityTest
Tag: #gd-refactor
Change-Id: I4dd577f53a45abb2e0f6c52fc3d577ed6ab8e3ce

Tag: #gd-refactor
Bug: 169125803
Test: cert/run --host
Test: atest --host bluetooth_test_gd
Change-Id: I2fa3ddf5b50764e5dde5a613de473405824c4948

* changes:
  rusty-gd: expose rust enums for enums
  rusty-gd: add builder structs
  rusty-gd: call children write_to()s

* changes:
  rusty-gd: update visibilities, put parse & to bytes on pub api
  rusty-gd: refine specialization
  rusty-gd: start specialzation frontend
  rusty-gd: add packet accessors
  rusty-gd: Add child & into for pub access packet structs
  rusty-gd: separate data storage from packet view

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: If1e078bdb64a41ee0a77e352617f39a0ab3155d5

Bug: 171749953
Tag: #gd-refactor
Test: gd/cert/run --rhost SimpleHalTest
Change-Id: I8ee5baf6fcfabcaefe08a7792e655e41cf502df1

Waiting on another CL to fix the underlying issue before re-enabling

Bug: 175033589
Test: cert/run SecurityTest
Tag: #gd-refactor
Change-Id: If24dfb92d987d2dc147ed396b9f6b9d4d249347d

For classic SSP numeric comparison we must wait at the
UserConfirmationRequest in order to get the name before
we display it to the user.  However, in the Out of Band
data flow we never get a UserConfirmationRequest.

Thus, we must wait in the link key notification if we
have not yet received a name response.

Remove setting to std::nullopt as the operator= in
std::optional causes the underlying pointer to be reset
and thus freed, but still accessed by the pointer we passed.

Bug: 175033589
Test: cert/run SecurityTest:test_successful_dut_initiated_ssp_oob --repeat=20
Tag: #gd-refactor
Change-Id: Ic3f424e22a0c596b21969d4882d0a9b06f7433ab

* changes:
  enum-ify bta/include/bta_api::SSR_
  btm_history: Add acl power mode state
  Properly retrieve acl_conn stack/acl/btm_acl::BTM_IsBleConnection

* changes:
  rusty-gd: mark vector field writing as unimplemented
  rusty-gd: add support for struct fields in write_to()
  rusty-gd: start writing scalar fields in write_to()

Towards readable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I5bc0330c7e9fbf902b0b1f000017f5d733c7dcce

Towards loggable code

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I7d68ca082c683f663024309e577041ba5ff5d02e

Towards encapsulation

Bug: 163134718
Tag: #refactor
Test: gd/cert/run --host

Change-Id: I3f5bba04de53378dad998c5471f9ca20cd6be2d6

* changes:
  GD-Cert: Symbolize ASAN triggered crashes
  GD-Facade: Enable ASAN but disable container overflow check