- Oct 19, 2022
-
-
Archie Pusaka authored
This can be used to tell the upper layers that connection fails, therefore they can provide better feedback to the user. Additionally floss will also use it for metrics. Bug: 240782154 Tag: #floss Test: Verify btadapter print warn "Connection to <address> failed" when connection failed. Change-Id: Id2ec0d71bf5392fdc8314349296d71a6af1e76ba
-
Hyundo Moon authored
-
Sungsoo Lim authored
-
Sungsoo Lim authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Sungsoo Lim authored
Bug: 243053736 Tag: #refactor Test: atest BluetoothInstrumentationTests:ActiveDeviceManagerTest Change-Id: Ie911ba613aa36978f728e591611be5fe516404e1
-
Sungsoo Lim authored
When BT1 connected -> BT2 connected -> BT2 disconnected, then the sound came from phone speaker before this CL. With the CL, now the sound comes from BT1. Bug: 243053736 Tag: #refactor Test: atest BluetoothInstrumentationTests:ActiveDeviceManagerTest Change-Id: I1d019bfd117f7e9f13618dfa989c331b33be3f42
-
Sungsoo Lim authored
Bug: 243053736 Tag: #refactor Test: atest BluetoothInstrumentationTests:ActiveDeviceManagerTest Change-Id: I0b706b0bdae72d62469a6fa85353f4dcfa9e296b
-
- Oct 18, 2022
-
-
Sungsoo Lim authored
Bug: 243053736 Tag: #refactor Test: atest BluetoothInstrumentationTests:ActiveDeviceManagerTest Change-Id: I7f05f0bca01db146dcbb687f01e11e9be173fa4f
-
William Escande authored
-
William Escande authored
Bug: 226572369 Test: No impact Change-Id: Ib855884a42b1f548e62061b6eb69bb92896cb241
-
Treehugger Robot authored
-
Henri Chataing authored
Revert submission 2234606 Reason for revert: Breaks pts-bot presubmit, resolution takes longer than expected Reverted Changes: I83d2bbad3:RootCanal: Refactor legacy LE advertising commands... Ice2e2e46b:RootCanal: Refactor LE scanning commands Test: pts-bot presubmits Change-Id: I3cdee05ee868d38bae411767d898f3f213cf93e0
-
Henri Chataing authored
Revert submission 2234606 Reason for revert: Breaks pts-bot presubmit, resolution takes longer than expected Reverted Changes: I83d2bbad3:RootCanal: Refactor legacy LE advertising commands... Ice2e2e46b:RootCanal: Refactor LE scanning commands Test: pts-bot presubmits Change-Id: I5378389a4713627d1216e7f8f36b75870669c68a
-
Henri Chataing authored
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Yun-hao Chung authored
* changes: Floss: Implement admin callback client in btclient Floss: Implement admin policy callbacks Floss: Implement service allowlist persistentcy Floss: Change UUID print format to lower cases Floss: Export BluetoothAdmin to DBUS Floss: Implement set allowed services in BluetoothAdmin Floss: Implement APIs in topshim profiles to make them togglable Floss: Implement basic bluetoothAdmin interface
-
Ömer Faruk Yılmaz authored
-
Sungsoo Lim authored
In order to avoid a strictMode policy violation, we decide not to compare image pixels Bug: 247784807 Tag: #refactor Test: atest BluetoothInstrumentationTests Change-Id: I0c368a6f2c3095ac57a018140edce5bf21e26d6c
-
howardchung authored
This registers a super basic callbacks when entering btclient which just print what it gets in debug format. Bug: 239470860 Test: test it with the following procedures. 1. start btclient. Pair with a Classic KBD, and Classic headset. 2. set allowlist to A2DP+HFP+AVRCP. Check btclient gets notification of new allowlist and the policy effect of devices are correct. 3. start scan in btclient and check if it gets notifications of policy effect change of new devices. Change-Id: I0d26c70b67393a92d05f6c9598fa97db83cfa2b8
-
howardchung authored
Implement the following callbacks for client. - OnServiceAllowlistChanged: Get the updated service allowlist - OnDevicePolicyEffectChanged: Get the updated policy effect, which includes (1) list of services that are disallowed by the current policy (2) boolean value to indicate if the device has an adapter-supported profile that is blocked by the policy. Bug: 239470493 Test: test it along with the next patch Tag: #floss Change-Id: Idb770f9a7a34401d2d58421fb18b07013330cb09
-
howardchung authored
Admin policy will be stored in /var/lib/bluetooth/admin_policy.json It will be updated upon a successful SetServiceAllowedlist call, and it will be loaded upon btadapterd starts. Bug: 239470589 Test: tested it with the following steps Set allowed list via gdbus check /var/lib/bluetooth/admin_policy.json is updated correctly restart btadapterd Get allowed list via gdbus and check if it's persistent Tag: #floss Change-Id: I141f60a618e905c8cfc4c58fd3966faa2c5de273 Change-Id: I158e90e9ac2eff95eda0d19bd18e4355ce5bd144
-
howardchung authored
Per spec: https://www.rfc-editor.org/rfc/rfc4122#section-3 UUID output format should be in lower case. Bug: 239470589 Test: run ./build.py --target test Change-Id: Ib8efd87af105117189b9ebbfe230362294fec497
-
howardchung authored
Export the folloing APIs to org.chromium.bluetooth node /org/chromium/bluetooth/hci0/admin { interface org.chromium.bluetooth.BluetoothAdmin { methods: GetAllowedServices(out aay out); GetDevicePolicyEffect(in a{sv} device, out a{sv} out); IsServiceAllowed(in ay uuid, out b out); SetAllowedServices(in aay services, out b out); signals: properties: }; Bug: 239470589 Test: test it with the following procedures. service allowed list was set by gdbus call. 1. check classic HS, Classic KB and LE Mouse can function. 2. set allowed list to a single random UUID, and check none of the above device can function. 3. set allowed list to A2DP+HFP, and check audio is functioning but the other two stay non-functioning. 4. set allowed list to HID, and check HID devices are functioning but no audio from the HS. 5. set allowed list to empty, and check all of the above devices are functioning. Tag: #floss Change-Id: Id6e04193666a51883a4f32920df28cf0ab3cbb3f
-
howardchung authored
This API disables the services that is not in the allowed list. A profile is disabled by calling |disable| in topshim layer which should call |cleanup| to the libbluetooth interface. Similarly, a profile is re-enabled by calling |enable| in topshim and |init| of the libbluetooth interface will be called subsequently. However, the cleanup function of HFP and A2DP in topshim-cpp layer haven't been implemented. By testing locally, the consequence is that when a2dp and hfp are disabled by policy, the audio headset can still be connected and stay connected, but there is no audio stream to the headset nor the chromebook. Additionally, the headset could adjust the volumn via HFP. Bug: 239470589 Test: test it along with the top of this chain Tag: #floss Change-Id: Id4eba16f298599dad8d469bf719bc5ef2211c639
-
howardchung authored
Implements the following APIs for topshim profiles - enable - disable - is_enabled The original logic of |initialize| is splitted into setting the dispachers and enabling the internal interface. The new |initialize| do the former part and |enable| do the latter part. Bug: 239434117 Test: test along with the top of this chain Tag: #floss Change-Id: Ie604d38fb7e961c2b2c86817336db6f6e78c0069
-
howardchung authored
Implement proto type of bluetoothAdmin and implement some basic functions. Bug: 239470589 Test: run build.py --target test and test it along with the top of this chain Tag: #floss Change-Id: I74a880cbe59c96308d1e5fa69c911dd0c4b6d73f
-
Jesse Melhuish authored
-
Ömer Faruk Yılmaz authored
Bug: 237467631 Test: atest AdvtFilterOnFoundOnLostInfoTest Change-Id: Ia7bada78fa0ba186631755eb35f679e7d60a11bc
-
- Oct 17, 2022
-
-
Treehugger Robot authored
-
Jesse Melhuish authored
Register BAS as a BatteryProvider, switch BatteryManager to source from BatteryProviderManager. Bug: 242217799 Tag: #floss Test: Tested manually using dbus-send Change-Id: If27779744aab0af358cd3f0df78c1e0407de2755
-
Myles Watson authored
-
Cole Faust authored
This commit is part of a large scale change to fix errorprone errors that have been downgraded to warnings in the android source tree, so that they can be promoted to errors again. The full list of changes include the following, but not all will be present in any one individual commit: BadAnnotationImplementation BadShiftAmount BanJNDI BoxedPrimitiveEquality ComparableType ComplexBooleanConstant CollectionToArraySafeParameter ConditionalExpressionNumericPromotion DangerousLiteralNull DoubleBraceInitialization DurationFrom DurationTemporalUnit EmptyTopLevelDeclaration EqualsNull EqualsReference FormatString FromTemporalAccessor GetClassOnAnnotation GetClassOnClass HashtableContains IdentityBinaryExpression IdentityHashMapBoxing InstantTemporalUnit InvalidTimeZoneID InvalidZoneId IsInstanceIncompatibleType JUnitParameterMethodNotFound LockOnBoxedPrimitive MathRoundIntLong MislabeledAndroidString MisusedDayOfYear MissingSuperCall MisusedWeekYear ModifyingCollectionWithItself NoCanIgnoreReturnValueOnClasses NonRuntimeAnnotation NullableOnContainingClass NullTernary OverridesJavaxInjectableMethod ParcelableCreator PeriodFrom PreconditionsInvalidPlaceholder ProtoBuilderReturnValueIgnored ProtoFieldNullComparison RandomModInteger RectIntersectReturnValueIgnored ReturnValueIgnored SelfAssignment SelfComparison SelfEquals SizeGreaterThanOrEqualsZero StringBuilderInitWithChar TreeToString TryFailThrowable UnnecessaryCheckNotNull UnusedCollectionModifiedInPlace XorPower See https://errorprone.info/bugpatterns for more information on the checks. Bug: 253827323 Test: m RUN_ERROR_PRONE=true javac-check Change-Id: I9408872c39c30cd2c9c1038b4a56d0d412344bde
-
Abhishek Pandit-Subedi authored
Switch build.py to use release builds by default for Rust. This saves us ~5gb in generated files in the build output folder. Bug: 254085165 Tag: #floss Test: ./build.py && ./build.py --target test Change-Id: I5abc239afe97dfb7e0e80d8df75325451b1aaa49
-
Henri Chataing authored
- Add tests with min and max scalar values - Add tests for array with a size field and dynamically sized elements (real life example TLV buffers) - Fix python generation bug with said arrays Test: atest --host pdl_python_generator_test Change-Id: Iad255cc452399967e24e212a82aff747fca3b37e
-
Chris Manton authored
Bug: 253533304 Test: gd/cert/run Tag: #refactor BYPASS_LONG_LINES_REASON: Bluetooth likes 120 lines Change-Id: Icc74895d7e4baeb034bc04f47dd2dd7c93c66c34
-
Hyundo Moon authored
Bug: 244534014 Test: atest BluetoothPbapActivityTest Change-Id: I5c6c788c2580b490b5004fbbceeaa9098e7bceb3
-
Patty Huang authored
-