Skip to content
Snippets Groups Projects
  1. Mar 17, 2017
  2. Mar 16, 2017
    • Jakub Pawlowski's avatar
      Fix net_test_stack_multi_adv · 05e6d76e
      Jakub Pawlowski authored
      Change-Id: Ic28aa4a120d973bbf3f05d8022bc2c2e619562e2
      05e6d76e
    • Pavlin Radoslavov's avatar
      Fix an HCI race condition when transmitting a packet · 6822ce80
      Pavlin Radoslavov authored
      There is a race condition when calling
      event_command_ready() -> transmit_fragment() -> hci_transmit()
      
      If right after hci_transmit() there is thread context switch
      and another thread executes filter_incoming_event() for the same
      command, the corresponding packet/command will be taken off the
      commands_pending_response list and free()-ed.
      
      However, after the execution on the first thread continues
      within transmit_fragment(), the execution logic will continue using
      the "packet" that was already free()-ed by the other thread.
      
      To prevent this from happening, the "commands_pending_response_mutex"
      within event_command_ready() has to protect the transmit_fragment()
      execution and the update_command_response_timer() function right after it.
      
      Also:
       * Changed the "commands_pending_response_mutex" to recursive_mutex
       * Added "commands_pending_response_mutex" protection in few other
         places where "commands_pending_response" itself is used.
      
      Bug: 36205494
      Test: Running ASAN build
      Change-Id: I63677ad1f2b28683c321631e9e29e4f01628d269
      6822ce80
  3. Mar 15, 2017
  4. Mar 14, 2017
  5. Mar 13, 2017
  6. Mar 11, 2017
  7. Mar 10, 2017
  8. Mar 08, 2017
  9. Mar 06, 2017
  10. Mar 02, 2017
    • Jack He's avatar
      Fix for dual-mode devices advertising with a single address · ce833a3c
      Jack He authored
      * BTM_ReadRemoteDeviceName checks if a device is connectable over LE before
        making a connection. However, when it is not connectable over LE, it could
        be connectable over BR/EDR.
      * For Dual Mode device, the device type should be 0x3 and is not equal to
        BT_DEVICE_TYPE_BREDR, hence we cannot check equality to determine whether
        a device is BR/EDR, but need to AND them and check the result.
      * btm_ble_read_remote_name() already checks if device is connectable in LE,
        and we do not need to do it in BTM_ReadRemoteDeviceName().
      * This fix removes the check from BTM_ReadRemoteDeviceName
      * This fix also adds error checking to return values of BTM_ReadRemoteDeviceName
      * This fix moves inquiry database query to respective remote name
        request procedures, as the result of the query is used in those
        procedures instead of in BTM_ReadRemoteDeviceName()
      
      Bug: 35348392
      Test: make, pair with device that advertise on both LE and BR/EDR
      Change-Id: I10d1aa9dd6e2447f9b9d40b1fea9370b5088a57d
      ce833a3c
    • Treehugger Robot's avatar
      4485bd16
  11. Mar 01, 2017
  12. Feb 28, 2017
    • Treehugger Robot's avatar
    • Myles Watson's avatar
      btif_sock_thread: Set thread_id = -1 after join · 8d318125
      Myles Watson authored
      Bug: 35690239
      Test: Switch users with Bluetooth enabled
           (Disables/Enables Bluetooth under high load)
      Change-Id: I6e09547cc8ffa3f01bc523ce4c18fdabfe08df99
      8d318125
    • Marie Janssen's avatar
      cleanup: no assigns in conditionals · 1a5a3b0c
      Marie Janssen authored
      Some assigns snuck into our conditionals, making the code harder to
      read / follow.
      
      Also remove some unnecessary null checks after osi_malloc that are
      nearby.
      
      Test: compiles, sanity check with device
      Change-Id: Ia544da44060d9fc4363af9fbcb4112f3190f75ab
      1a5a3b0c
    • Myles Watson's avatar
      btif: Remove redundant thread_{stop|join} · 06ccda6e
      Myles Watson authored
      Test: Switch users with Bluetooth enabled
           (Disables/Enables Bluetooth under high load)
      Change-Id: I2414fd26a0380644700d66a8fdec1fc54a1cd2f6
      06ccda6e
    • Myles Watson's avatar
      btif_sock: Use atomic operations for thread_handle · e33527bb
      Myles Watson authored
      Test: Switch users with Bluetooth enabled
           (Disables/Enables Bluetooth under high load)
      Change-Id: I9039f97c090f693e798b8082fbb027e2028c8b40
      e33527bb
    • Myles Watson's avatar
      osi: Use atomic_exchange to protect is_joined · 81800ad3
      Myles Watson authored
      Test: Switch users with Bluetooth enabled
           (Disables/Enables Bluetooth under high load)
      Change-Id: I34c5579b75620970f756fff28ccc07cf76599a94
      81800ad3
    • Venkata Jagadeesh Garaga's avatar
      Increase max remote ext feature pages to 3 · b0540d2b
      Venkata Jagadeesh Garaga authored
      Use Case: DUT unable to pair with Xbox HID device
      
      Steps:
      1. Turn on BT
      2. Start Inquiry
      3. Pair with device with three extended feature pages
      
      Failure: Unable to pair with HID device
      
      Root Cause: DUT not responding for btm_read_remote_ext_features_complete
      as we are not supporting three extended pages. So Security procedure also
      not getting started.
      
      Fix: Increase max remote ext feature pages to three from
      2 as some latest remotes supporting three extended pages.
      As per spec we can support 255 extended pages.
      
      Test: Pair with device with three extended feature pages
      
      Bug: 32999575
      
      Change-Id: I061c78a7aaa1ab58a2fc554d026305a0124eee77
      b0540d2b
    • Jakub Pawlowski's avatar
      Fix libldac build on Linux · cffd7112
      Jakub Pawlowski authored
      In build/BUILD.gn we set EXPORT_SYMBOL value, and it's used across the
      whole stack. However, third party libraries require this value to be
      cleared - otherwise the symbols are not exported properly.
      
      Test: manual
      cffd7112
  13. Feb 27, 2017
    • Jakub Pawlowski's avatar
      Fix initial advertising command order · 01d2fcb6
      Jakub Pawlowski authored
      Set the address during SetParameters, for VSC implementation, and right
      after setting parameters for BT5 implementation.
      
      Test: sl4a ConcurrentBleAdvertisingTest
      Bug: 33922058
      Bug: 34962013
      Change-Id: Idcc60a36884607de191066d8be1ee3bc459e86fc
      01d2fcb6
    • Jakub Pawlowski's avatar
      btsnd_hcic_ble_rand refactor · 64b2fa73
      Jakub Pawlowski authored
      Make btsnd_hcic_ble_rand accept base::Callback instead of function
      pointer. This will result in great code simplifications in further
      patches.
      
      Test: sl4a ConcurrentBleAdvertisingTest
      Change-Id: I9933caa78b20d0011ce3e17fd72d5740bcc4ae6d
      64b2fa73
Loading