Commits · df590f128a4f6fb9e9e36601a380bd6ad4162219 · LMODroid / platform_packages_modules_Bluetooth

Aug 10, 2020

Remove unnecessary type definition tBTA_DM_BLE_RX_TIME_MS · df590f12

Chris Manton authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Icfd17bc766ee61bb93f4e69d68b33ad1cdebf7fd

df590f12

Remove unnecessary type definition tBTA_DM_BLE_TX_TIME_MS · 1cf6dfff

Chris Manton authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ib8d50fe5db618e8738b66ee065d9d64fd1960335

1cf6dfff

Aug 09, 2020

Remove unnecessary type definition tBTA_DM_BLE_SEC_ACT · b6cf87ed

Chris Manton authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ib865235a8c0f7645fc9df0dde06e1dc29bead590

b6cf87ed

Remove unnecessary type definition tBTA_OOB_DATA · 7c651ec0

Chris Manton authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ib34521cb929fd95ed91e5142994dd7282d5b12e8

7c651ec0

Remove unnecessary type definition tBTA_LE_AUTH_REQ · 5de1531c

Chris Manton authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I664102783cd0fb0eedfc003955f64e453a7ac3f7

5de1531c

Remove unnecessary type definitions tBTA_DM_BLE_ENERGY_USED · 34e37678

Chris Manton authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I79598380407b445f4c000aaaed39d3f4d9ea5533

34e37678

Remove unnecessary type definitions tBTA_AUTH_REQ · 14e5073e

Chris Manton authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working

Change-Id: I25ea66a32fc3358b5b7b4b3c55e6256777563fa1

14e5073e

Remove unnecessary type definitions tBTA_IO_CAP · 99b3fbce

Chris Manton authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working

Change-Id: I3a3f6326ba77265bfb384002f7d9456021f1d893

99b3fbce

Remove unnecessary type definitions tBTA_LE_* · 26fd57f5

Chris Manton authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working

Change-Id: I224fac2dd70035ccfdf74381b3b0b70d20cb23be

26fd57f5

Remove notion of multiple hardware modules · 33335433

Zach Johnson authored 4 years ago

BT is the only one

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I600b0d3db8221b88aec4b8f9f695497260e84aa0

33335433

Remove BTM_SP_COMPLT_EVT, it's not used · 32a40f0f

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iec97d1aaa81c7618a9dded3a19e5e2f8c55faf57

32a40f0f

Remove btm_keypress_notif_evt · 1fdb43fb

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iceadd2a8ee214b8d32b333b8de84cc10716aff97

1fdb43fb

Remove BTM_SP_KEYPRESS_EVT & associated code · fd190c29

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I3c5a78c4f4136dc81111ad7bf189f130a0fc411b

fd190c29

Remove BTA_DM_SP_KEYPRESS_EVT, it's not used · bc585280

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: If98f08aad1363ac0dc37d7fdb0aa50255293bdb9

bc585280

Remove BTA_DM_SP_RMT_OOB_EVT, it's not used · 565ddbfa

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I84248858e39e373e6774d06bb7b80eb17c2e75c7

565ddbfa

Remove BTA_DM_SIG_STRENGTH_EVT, it's not used · 001521f2

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I94a1038d6d83b86607954bceae5edb745ec7227a

001521f2

Remove unused parameters from bta_dm_authorize_cback · 40d9807e

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ic94ed2183ba2828158d68d57bdfbd5c80df6905e

40d9807e

Remove BTA_DM_AUTHORIZE_EVT, it's not used · 9bf41e7f

Zach Johnson authored 4 years ago

reported to btif but dropped on the floor

bye

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I548e7d5dcc9511d2d5f232ce6f5faefcb27876ee

9bf41e7f

Remove BTM_RegBusyLevelNotif & friends · 951e3ccf

Zach Johnson authored 4 years ago

We now no longer need the "busy level" concept at all.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I13111ca217de8655e52f450278a4e776923ae5da

951e3ccf

call bta_sys_notify_collision directly · 4206e410

Zach Johnson authored 4 years ago

it's always registered, so go ahead and remove the bool
return type from btm_acl_notif_conn_collision

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ibbb3c10dc6ef87d01156369b880ec7eafa79fb5d

4206e410

Skip the message passing and call BTA_dm_report_role_change directly · df0d30a1

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I1571799a8f3e5a261fa8451964a8b929abeec065

df0d30a1

stop reporting role change to btif · b43f5677

Zach Johnson authored 4 years ago

it ignores it

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ia10dc1910df81ac3c25e628cf8267cfb6053358f

b43f5677

Skip the message passing and call BTA_dm_acl_down directly · a81e1c68

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Iffcc8875152215cec0dbe0ffb0d3e710d4ffb002

a81e1c68

Provide more suitable API to query acl role · 2722b73a

Chris Manton authored 4 years ago

Add: stack/acl/btm_acl.cc::acl_is_role_master()
to:
stack/gatt/gatt_db.cc::gatts_db_read_attr_value_by_type()

Working towards encapsulation of tACL_CONN

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I2462c1bde4e91fe5daec4031362755cd75a91fa5

2722b73a

Move lmp_version_below() into acl api · a233fcf2

Chris Manton authored 4 years ago

Working towards encapsulation of tACL_CONN

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I2fa4cfc5f906387bd3fd4bb6859b015478cb4c23

a233fcf2

Provide more suitable API to set packet types · 6110cf25

Chris Manton authored 4 years ago

btm_set_packet_types() => btm_set_packet_types_from_address()

Working towards encapsulation of tACL_CONN

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I3d2702da3ce04301985bfe94153c3387d9a2dbfb

6110cf25

Skip the message passing & call to BTA_dm_acl_up directly · 01db1d7c

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I5199fdb4696dd80bb06c06047c70d7e5ebde6b1a

01db1d7c

bta_dm_acl_down doesn't use the handle parameter · 2b393702

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Icfdd98259eade50def860ad72d051feec2ec8f91

2b393702

split bta_dm_acl_change into an up and a down variant · 84ec6ff8

Zach Johnson authored 4 years ago

The code share between the two was very little, no need to
complicate things with a boolean parameter.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ia346858f61167009e1190e17214a76ad101b2203

84ec6ff8

BTA_DM_LINK_UP_EVT doesn't care about link type · 9f68d949

Zach Johnson authored 4 years ago

It's never accessed.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I9685dbaeda887edaf01ea35410d6516c2d3d3027

9f68d949

Reduce duplicate device deletion code · feeb61a9

Zach Johnson authored 4 years ago

Same three calls, over and over.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I238f48ada7c1f71e737f9492a4a5b0b6209aa401

feeb61a9

Remove link_down.status, is_removed, and link_type · 31a8b53a

Zach Johnson authored 4 years ago

They're set but never used externally.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ica247c21e8375840184a9bbc918f4e12469b5201

31a8b53a

Move device allocation out of bta_dm_acl_change · 64b19ce3

Zach Johnson authored 4 years ago

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: Ib480385266c5665a5dc96ecc41a7599143211757

64b19ce3

More simplification to bta_dm_acl_change · 828092b7

Zach Johnson authored 4 years ago

Instead of constantly referencing the array by index, grab a pointer
to the object and use that.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I5d9549bab81ea3ff4a83ded7a4cb3eb62734ec8f

828092b7

Simplify bta_dm_acl_change a bit · 7b75ffe4

Zach Johnson authored 4 years ago

Instead of constantly referencing the array by index, grab a pointer
to the object and use that.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I8b8cad92d806666ff96a6a8026124c7c4e24b3bf

7b75ffe4

l2c_link_processs_num_bufs -> l2c_link_init · e7bd827c

Zach Johnson authored 4 years ago

have link fetch its own values from the controller

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I13eef873faffa0acb0596e6a7de49da6f0796d0d

e7bd827c

Remove return type from l2c_link_hci_conn_req · 45103187

Zach Johnson authored 4 years ago

It's not used at all.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I3c3ea3d12adca1a65e49a9a0f737c5998c3af680

45103187

Rename busy level updates to inquiry status updates · 20d9c736

Zach Johnson authored 4 years ago

Now that we've cleaned up the function, it's true purpose has been
unmasked.

It would have gotten away with it too, if it weren't for these
meddling kids.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I04eab90be8bb9fda32143230a923c987a7e9a9a1

20d9c736

Telescope busy level update events · 903b7be1

Zach Johnson authored 4 years ago

they were on the hci thread, posted to the main thread, and immediately
moved to the jni thread.

go directly to the jni thread, and drop the extra ceremony & structs.

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working
Change-Id: I20d786eca436cc8ad08c9b5620ca0b361750474e

903b7be1

Aug 08, 2020

Enforce stack/acl/btm_acl internal linkage · a4f713d7

Chris Manton authored 4 years ago

and remove from stack/btm/btm_int.h

btm_acl_chk_peer_pkt_type_support
btm_read_automatic_flush_timeout_timeout
btm_read_failed_contact_counter_timeout
btm_read_rssi_timeout
btm_read_tx_power_timeout

Bug: 159815595
Tag: #refactor
Test: compile & verify basic functions working

Change-Id: I18a06149bbf3a0e5257bef2a41b598d7f87a5083

a4f713d7