This reverts commit 29b0d287.

Reason for revert: Change breaks multiple tests, see b/257340301

Change-Id: I4a5d7ac69b32a6dc1b782e5d4643ca4529108c22

Bug: 249235823
Test: atest CtsBluetoothTestCases:android.bluetooth.cts.BluetoothHapClientTest
Tag: #feature
Change-Id: Ia3746bc8abad05182158df936ce80324bb8daf6f

Add Javadoc to keep track of permissions required to
call these APIs in older API levels.

Bug: 255592702
Tag: #feature
Test: manual
Change-Id: I771a756f2674b34ce429ddccdc29bd96decd8c17

Test: build
Fix: 255822179
Change-Id: I2607f14ecb122990af0470a3061c1a4eaa31501b

An update to UUID.java prevents creating UUID with
more than 26 characters.

Bug: 255993456
Tag: #feature
Test: atest FrameworkBluetoothTests
Change-Id: I1f4ff698ed2c39516970a68c491358dcb653a253

Android T allows apps to declare a runtime receiver as not exported
by invoking registerReceiver with a new RECEIVER_NOT_EXPORTED flag;
receivers registered with this flag will only receive broadcasts from
the platform and the app itself. However to ensure developers can
properly protect their receivers, all apps targeting a future
platform release and registering a receiver for non-system
broadcasts must specify either the exported or not exported flag
when invoking #registerReceiver; if one of these flags is not
provided, the platform will throw a SecurityException. This commit
updates all the exposed receivers with the RECEIVER_EXPORTED flag
to maintain the existing behavior for these tests.

Bug: 234659204
Tag: #compatibility
Test: atest BassClientServiceTest
Test: atest HapClientTest
Change-Id: Ib832007a0c80755e9a50d029eca45a69b4011ea6

Bug: 241827236
Tag: #refactor
Test: atest CtsBluetoothTestCases
Change-Id: I27970e71ad440fd8829d387b296b12ef1236b542

Continuation of the work started in Android T of making
Bluetooth codec configuration available via public APIs.

BluetoothA2dp#setCodecConfigPreference, BluetoothA2dp#
getCodecStatus & BluetoothA2dp#ACTION_CODEC_CONFIG_CHANGED
are made public instead of system APIs.
setCodecConfigPreference requires a CDM association between
the calling application and the Bluetooth device.

Bug: 170678351
Tag: #feature
Test: atest FrameworkBluetoothTests
Change-Id: I40597060127cf2499548d1906d3d5743f157e131

This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: I9408872c39c30cd2c9c1038b4a56d0d412344bde

This way, we can prevent an infinite loop made by apps calling
BluetoothAdapter.getProfileProxy() in the onServiceDisconnected.

Tag: #refactor
Bug: 249213217
Test: atest CtsBluetoothTestCases
Change-Id: I7342befd9a8fc69c778d20140558afb148a4232e

Going forward targetSdkVersion would be set by build system.
It would be by default set to 10000 before SDK finalization,
and updated to the new API level after finalization.

Effectively it would mean:
1. '10000' in aosp and internal master
2. Finalized number in development branches like "33" in "tm-dev"
3. As sdk hasn't been finalised in "udc-dev", it would be "10000"
which would be automatically updated to finalized version after sdk finalization.

Removing the target sdk version declaration from the blueprint and manifest files.
More details can be found here go/mainline-modules-target-sdk-version-fix

Bug: 242296003
Tag: #refactor
Test: croot; sdks=`find ./out -name 'Bluetooth.apk' | grep -v .intermediates`; echo $sdks; for sdk in $sdks;do aapt2 dump badging `echo $sdk` | grep targetSdkVersion:; done
1. outputs 33 in tm-mainline-prod
2. outputs 10000 in master
Change-Id: I1eb75adf878761b55e8589dba098732849c6f304

Test: No op change. Build
Change-Id: Ieac606fea54535cac1cd0476a7880b8a9fa564b9

FYI, ServiceConnection.onServiceDisconnected is not called when
Context.unbindService is called.

Bug: 233690300
Tag: #refactor
Test: atest CtsBluetoothTestCases DeviceHealthChecks
Change-Id: I51ad4e0ecf6b81bce32ccc7e8b4b9550e3695e9c

This reverts commit 594198b9.

Reason for revert: DroidMonitor-triggered revert due to b/245864423
Test: N/A

Bug: 245864423
Change-Id: Iddc765940dc338939282a7cefc078f70e0f2d29a

Adding changes to slice only the first 16 bytes of
the mIrk field when serializing. When deserializing
we only get the first 16 bytes when reading, therefore
it is not necessary to serialize the entire array when
writing

Bug: 244569009
Test: Sample Android App mentioned in the bug
Change-Id: I99154fa3fd2f75a24232ef8df517e4d97839140b

Both BluetoothDevice and BluetoothAdapter maintain a reference to a
IBluetooth proxy object (sService) and each class uses a lock object
to serialize access to their own reference. These references are updated
by BluetoothManagerService with registered callbacks (IBlueoothManagerCallback).

In the current implentaion, when an app thread uses BluetoothDevice#getService
to access its reference to service proxy, with the BluetoothManager updating it
at the same time, as the order of taking the locks is different, deadlock is possible
under certain circumstances (triggered in bug 241212710).

This patch fixes the deadlock issue by removing the reference to service
proxy object in BluetoothDevice class, and accesses are via
the reference in BluetoothAdapter class instead.

Test: existing unit tests
Bug: 241212710
Tag: #stability
Change-Id: I15cd2707acf5caa04d97c6ede3bd5bedd6475c65

All BluetoothCodecConfig error are fixed

Test: checkstyle + build. No functionnal changes
Bug: 244876154
Merged-In: I2f94ffd62ae76c10ae6a835c81335fb0eae5a97f
Change-Id: I2f94ffd62ae76c10ae6a835c81335fb0eae5a97f

All frameworks error are fixed except the Copyright header
Excpet BluetoothCodecConfig due to merge conflict

Test: checkstyle + build. No functionnal changes
Bug: 244876154
Change-Id: I073878d776b4757f93533c3430194c672438ca00

Reverts due to belog bug

Bug: 243847810
Test: atest BluetoothInstrumentationTests
Tag: #feature

This reverts commit 6d9c5c1e.

Change-Id: Ib92032523af621792929c94a1dd8b294ffc45628

Non-data apps that have a sharedUserId shared with a privileged app and
use privileged permissions need to testOnly.

BUG: 243738091
Fixes: 243738091
BUG: 236173905
Test: atest GoogleBluetoothInstrumentationTests
Change-Id: I33ed22b844a07a4964e8da21ae83f7a71fd6dad8

Bug: 229914434
Test: Build + start bt + connect a device
Change-Id: Ie47cce2bfb9c00cf41c093baba726ea1c0421701

Whith a non static cache, we are creating a cache every time a new
BluetoothDevice is created, and then we have to rely on the GC.
The number of cache can sometimes reach 10 000.

Fix: 235637412
Test: basic bt functionnality
Test: adb shell dumpsys cacheinfo com.android.bluetooth
Change-Id: I6659dd9050b42bb57d0640df8117150cd67cb026

Bluetooth/service and Bluetooth/framework test suites were
broken after the migration of the files from frameworks.
The Bluetooth/framework test suite is split between stress
tests that require a physical Bluetooth device to run and
the unit tests that test the framework hidden APIs.
Both framework unit tests and service tests are signed
and can be added to the MTS.

Test: atest FrameworkBluetoothTests
Test: atest ServiceBluetoothTests
Bug: 232577476
Tag: #feature
Change-Id: Ibdb20c650db2483c4569d979da5e024e0e95284c
Merged-In: Ibdb20c650db2483c4569d979da5e024e0e95284c

The Bluetooth apex name is now called com.android.btservices

Bug: 243054261
Test: Build
Change-Id: I4d48b875c254b8381c982a633e3132b6de6178aa

The ArrayEquals, ArrayHashCode, ArrayToString, and
ArraysAsListPrimitiveArray errorprone findings were
demoted from errors to warnings. Fix existing
occurrences of them so they can be made errors again.

Bug: 242630963
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: Ie9d62731bef7e282d0909697963fce681c356d05

The previous value and naming is dismatch with the publiched assigned
number, and the stack definition as well.

The patch includes the following modification
1. Correct the context type value
2. Align the naming and comment
3. Change the order based on the context type value

Bug: 240145498
Test: PTS test case and check the context type picker is the same
between bt stack and framework

Change-Id: Ib18d07a64a323791786ad60aa00bcfc0af712552

Bug: 239486150
Tag: #refactor
Test: atest CtsBluetoothTestCases
Ignore-AOSP-First: Merge conflict
Change-Id: I56e6e14bc4b809617afebba34c9942c4761ee8eb
Merged-In: I56e6e14bc4b809617afebba34c9942c4761ee8eb
(cherry picked from commit 6d9c5c1e)

Bug: 239486150
Tag: #refactor
Test: atest CtsBluetoothTestCases
Ignore-AOSP-First: Merge conflict
Change-Id: I56e6e14bc4b809617afebba34c9942c4761ee8eb

Pandora need to call some hidden api from bluetooth
Tested after cherry-picking the aosp/2151894 CL

Test: atest pts-bot:HFP/AG/DIS/BV-01-I -v
Ignore-AOSP-First: framework-bluetooth.impl is only on internal for now
Bug: 237447510
Change-Id: Ie558fb21b56018297bcf24c40dae0825e81f26f3

This reverts commit 448c2830.

Reason for revert: b/238847789

Test: Clean revert of CL

Change-Id: I30941e8b9344e9dbaacaec5ca2c2046d149ed839
(cherry picked from commit bf9246b0)
Merged-In: I30941e8b9344e9dbaacaec5ca2c2046d149ed839

returns the mAddress field of the device instead of null when the
identity address is not known.

Tag: #feature
Bug: 238353063
Test: atest AdapterServiceTest#testAddressConsolidate
Ignore-AOSP-First: Change needs to land in TM release
Change-Id: I577843c9e2cc279915d0632ff25bde66aa949e94
(cherry picked from commit 448c2830)
Merged-In: I577843c9e2cc279915d0632ff25bde66aa949e94

This reverts commit dd85e91c.

Bug: 217366135
Reason for revert: Need this to fix a crash bug in tm-dev

Change-Id: I2a94c278edc0681c5b8af6ea0a0171b71d72c650
(cherry picked from commit dbaf406ccb0ed887d4e93057c9ec0d3457f14457)
Merged-In: I2a94c278edc0681c5b8af6ea0a0171b71d72c650

This reverts commit 02dcbe72.

Reason for revert: Causing builds to fail b/237471430

Change-Id: I6165d838abf312085050359377f67a68a5f8b51a
(cherry picked from commit f5dd42bbd05e68f7763ccaa9fae5642acc4ceba1)
Merged-In: I6165d838abf312085050359377f67a68a5f8b51a

Bug: 217366135
Tag: #feature
Test: manual
Ignore-AOSP-First: to be chery-picked
Change-Id: If8ae530a284151888a3f89a51d2c58f2a5cd3644
(cherry picked from commit 02dcbe72)
Merged-In: If8ae530a284151888a3f89a51d2c58f2a5cd3644

The path provided in framework/tests isn't always accessible and can
fail code-owners validation.  It should just inherit OWNERS from
framework/ instead.

Bug: 237278264
Tag: #floss
Test: git push
Change-Id: I6d29fc38807f5c108d74fb4e4d31688a1755e22b

isDirect was !mAutoConnect when it was first connected
(in mBluetoothCallback#onClientRegistered)
but it was always false in reconnect

Tag: #stability
Bug: 233292528
Test: atest BluetoothInstrumentationTests
Change-Id: Ic7913d6612fc292d3e9d48c6b49faffe1f6a3034

Test: No test
Change-Id: I153f9e8d6812b1597ccd51138a6945da47610d0d

Bug: 217366135
Tag: #feature
Test: manual
Ignore-AOSP-First: to be chery-picked
Change-Id: If8ae530a284151888a3f89a51d2c58f2a5cd3644

```
ObexServerSockets.java:228: warning:
BluetoothSocket is final and does not override Object.toString
            Log.d(mTag, "onConnect() socket: " + conSocket);
                                                 ^
BluetoothPbapService.java:767: warning:
 BluetoothSocket is final and does not override Object.toString
                    + " socket=" + socket);
                                   ^

AvrcpCoverArtService.java:256: warning:
 BluetoothSocket is final and does not override Object.toString
         debug("onConnect() - device=" + device + ", socket=" + socket);
                                                                   ^
PbapClientConnectionHandler.java:377: warning:
 BluetoothSocket is final and does not override Object.toString
                    Log.d(TAG, "Closing socket" + mSocket);
                                                  ^
 [...]
    (see https://errorprone.info/bugpattern/ObjectToString)
```

Bug: 236759221
Test: m RUN_ERROR_PRONE=true Bluetooth
Change-Id: I6a49a8ef8c6b380547cbb817468fa33bf89347a3

getUuids was wrongly returning an empty array of Uuids when
fetchUuidsWithSdp had not been called. It now returns null
again.

Test: atest CtsBluetoothTestCases
Bug: 235456437
Tag: #feature
Merged-In: If8aafc1b0ab4e253fdacc827726d76825b3bd1e4
Change-Id: I5757bebec004605b901f2f031c25b2036e2c139e