Do not send socket destroyed on unregistration
When a SocketCallback is unregistered from MdnsSocketProvider, do not send socket destroyed callbacks. Callers may not expect getting callbacks after unregistration, and the current callbacks are also broken when an unrequested socket is still in use by another requester. MdnsAdvertiser already does not depend on getting this callback, as it only unregisters the SocketCallback after it is done using the socket. This change fixes MdnsMultinetworkSocketClient to destroy the socket by itself when unrequesting. Bug: 276177548 Test: atest (cherry picked from https://android-review.googlesource.com/q/commit:5fe9bacc63c1b6a77878f23d5f53a07fc482f354) Merged-In: If95f833e293f3aab91128aab1c9852ebfd41995d Change-Id: If95f833e293f3aab91128aab1c9852ebfd41995d
Showing
- service-t/src/com/android/server/connectivity/mdns/MdnsMultinetworkSocketClient.java 49 additions, 8 deletions...erver/connectivity/mdns/MdnsMultinetworkSocketClient.java
- service-t/src/com/android/server/connectivity/mdns/MdnsSocketProvider.java 0 additions, 4 deletions.../android/server/connectivity/mdns/MdnsSocketProvider.java
- tests/unit/java/com/android/server/connectivity/mdns/MdnsMultinetworkSocketClientTest.java 88 additions, 2 deletions...r/connectivity/mdns/MdnsMultinetworkSocketClientTest.java
- tests/unit/java/com/android/server/connectivity/mdns/MdnsSocketProviderTest.java 4 additions, 3 deletions...roid/server/connectivity/mdns/MdnsSocketProviderTest.java
Loading
Please register or sign in to comment