Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
P
platform_packages_modules_Connectivity
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
LMODroid
platform_packages_modules_Connectivity
Commits
783035bd
Commit
783035bd
authored
1 year ago
by
Lorenzo Colitti
Committed by
Gerrit Code Review
1 year ago
Browse files
Options
Downloads
Plain Diff
Merge "Revert "Include both eth%d and usb%d ethernet interfaces on U+"" into main
parents
38415082
ac6ff00b
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
service-t/src/com/android/server/ethernet/EthernetTracker.java
+1
-13
1 addition, 13 deletions
...ce-t/src/com/android/server/ethernet/EthernetTracker.java
service/ServiceConnectivityResources/res/values/config.xml
+2
-5
2 additions, 5 deletions
service/ServiceConnectivityResources/res/values/config.xml
with
3 additions
and
18 deletions
service-t/src/com/android/server/ethernet/EthernetTracker.java
+
1
−
13
View file @
783035bd
...
...
@@ -48,7 +48,6 @@ import android.util.Log;
import
com.android.internal.annotations.VisibleForTesting
;
import
com.android.internal.util.IndentingPrintWriter
;
import
com.android.modules.utils.build.SdkLevel
;
import
com.android.net.module.util.NetdUtils
;
import
com.android.net.module.util.PermissionUtils
;
import
com.android.net.module.util.SharedLog
;
...
...
@@ -238,18 +237,7 @@ public class EthernetTracker {
mDeps
=
deps
;
// Interface match regex.
String
ifaceMatchRegex
=
mDeps
.
getInterfaceRegexFromResource
(
mContext
);
// "*" is a magic string to indicate "pick the default".
if
(
ifaceMatchRegex
.
equals
(
"*"
))
{
if
(
SdkLevel
.
isAtLeastU
())
{
// On U+, include both usb%d and eth%d interfaces.
ifaceMatchRegex
=
"(usb|eth)\\d+"
;
}
else
{
// On T, include only eth%d interfaces.
ifaceMatchRegex
=
"eth\\d+"
;
}
}
mIfaceMatch
=
ifaceMatchRegex
;
mIfaceMatch
=
mDeps
.
getInterfaceRegexFromResource
(
mContext
);
// Read default Ethernet interface configuration from resources
final
String
[]
interfaceConfigs
=
mDeps
.
getInterfaceConfigFromResource
(
context
);
...
...
This diff is collapsed.
Click to expand it.
service/ServiceConnectivityResources/res/values/config.xml
+
2
−
5
View file @
783035bd
...
...
@@ -194,11 +194,8 @@
-->
</string-array>
<!-- Regex of wired ethernet ifaces. Network interfaces that match this regex will be tracked
by ethernet service.
If set to "*", ethernet service uses "(eth|usb)\\d+" on Android U+ and eth\\d+ on
Android T. -->
<string
translatable=
"false"
name=
"config_ethernet_iface_regex"
>
*
</string>
<!-- Regex of wired ethernet ifaces -->
<string
translatable=
"false"
name=
"config_ethernet_iface_regex"
>
eth\\d
</string>
<!-- Ignores Wi-Fi validation failures after roam.
If validation fails on a Wi-Fi network after a roam to a new BSSID,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment