Skip to content
Snippets Groups Projects
  1. Mar 16, 2020
  2. Mar 15, 2020
  3. Mar 13, 2020
    • Remi NGUYEN VAN's avatar
      Cleanup the TetheredClients API · dfdf7504
      Remi NGUYEN VAN authored
      Add comments to getters as requested in API review, and remove the
      expirationTime private field that was planned to be replaced with
      LinkAddress expiration.
      
      Test: atest TetheringTests
      Fixes: 150878126
      Change-Id: Iecf65859cdeeaac2fa7b817b4f505c510424ac89
      dfdf7504
    • markchien's avatar
      Give tethering bluetooth privilege permission · db2a16b8
      markchien authored
      Permisssion of PanService#setBluetoothTethering is change from
      BLUETOOTH_ADMIN to BLUETOOTH_PRIVILEGED.
      Tethering service need bluetooth privilege permission to enable
      bluetooth tethering.
      
      Bug: 146045934
      Test: on/off bluetooth tethering
      Change-Id: Ib87a5d5a5bb49390aa55e52713bb3539d4a52348
      db2a16b8
  4. Mar 12, 2020
  5. Mar 09, 2020
    • Paul Hu's avatar
      ccf62395
    • Mark Chien's avatar
      Merge "Send offload status changed callback" · a24b1884
      Mark Chien authored
      a24b1884
    • markchien's avatar
      Send offload status changed callback · 05bee802
      markchien authored
      The callback would be fired when offload started, stopped, or failed.
      If offload is not supported, "failed" callback would be fired when user
      enable tethering. Enabling multiple tethering would not have multiple
      offload status callbacks because offload should already be started or
      failed.
      
      Bug: 130596697
      Test: -build, flash, boot
            -atest TetheringTests
            -ON/OFF hotspot
      Change-Id: Ia0398601144b0e5f61dc0c5771eacf13e7cfbb59
      05bee802
    • paulhu's avatar
      [TNU01] Add Tethering notification updater · 08294f9c
      paulhu authored
      There are lots of Carrier/OEM requests for tethering
      notification customization. So add a new tethering notification
      updater class which can let OEM customize the behavior they
      wanted.
      
      Bug: 122085773
      Test: atest TetheringTests
      Change-Id: I7faacde7ac84e93ea0dfe03dd33d2cc41c589225
      08294f9c
  6. Mar 03, 2020
    • markchien's avatar
      Tethering: add isTetheringSupported with callerPkg parameter · 06ea03a6
      markchien authored
      BT tethering need to know whether tethering is supported for its caller
      that call isTetheringSupported in binder thread under BT's process.
      Current isTetheringSupported API is getting callerPkg inside
      TetheringManager that would be BT's package name for bt tethering case.
      Provide isTetheringSupported(String callerPkg) for caller to pass its
      caller's package name if the use case is under binder IPC.
      
      Bug: 146915889
      Test: -boot, flash, boot
      Change-Id: I2a35e1b6851e7a799c343be0dd60da23514768ba
      06ea03a6
  7. Feb 29, 2020
    • Jiyong Park's avatar
      Merge "Mark updatable APEXes" · 067c45b1
      Jiyong Park authored
      067c45b1
    • Jiyong Park's avatar
      Mark updatable APEXes · 5c72ad41
      Jiyong Park authored
      Mark updatable APEXes as updatable: true so that they are opted-out from
      optimizations that make sense only for non-updatable modules; such as
      symlinking to the libs in the system partition.
      
      Bug: 149805758
      Test: m and check that there is no symlink from the APEX to the system
      partition.
      
      Exempt-From-Owner-Approval: cherry-pick from internal
      
      Merged-In: Idb55300a60a261c7bb6359439ed220ff51fcf06c
      (cherry picked from commit 8201bdfab070fb2b93a997947095fad003060da9)
      Change-Id: Idb55300a60a261c7bb6359439ed220ff51fcf06c
      5c72ad41
  8. Feb 28, 2020
  9. Feb 27, 2020
    • markchien's avatar
      Fix crash and duplicated ethernet tethering request · 3849d891
      markchien authored
      This change fix two things:
      1. Handle ethernet callback in internal thread to avoid crash. IpServer
      should be created from tethering thread, otherwise mIpNeighborMonitor of
      IpServer would throw
         IllegalStateException("start() called from off-thread")
      2. Ethernet tethering request may be duplicated if multiple
      startTethering is called but no stopTethering
      
      Bug: 130840861
      Bug: 148824036
      Test: ON/OFF ethernet tehtering manually
            atest TetheringTests
      
      Change-Id: I7c5127e96d80d077735010d2e62c7227805ccb10
      3849d891
  10. Feb 25, 2020
  11. Feb 24, 2020
  12. Feb 23, 2020
  13. Feb 21, 2020
    • Colin Cross's avatar
      Remove liblog from Tethering jni_libs · 131380ff
      Colin Cross authored
      Tethering's JNI libraries use the NDK version of liblog, it should
      not package the platform version of liblog into the APK.
      
      Bug: 149591340
      Test: m checkbuild
      Change-Id: If208c1078d2755907f57d7853a5c545bf12458c2
      131380ff
    • Lorenzo Colitti's avatar
      Support losing the upstream in IpServerTest. · 03a734f3
      Lorenzo Colitti authored
      Allow dispatchTetherConnectionChanged to pass in a null
      upstream interface and/or null LinkProperties. This will allow
      future tests to check what happens when the upstream interface
      goes away.
      
      Test: test-only change
      Change-Id: I7cfc32d072f23644159d33700d6cd830c426ea19
      03a734f3
    • Chiachang Wang's avatar
      Use exposed permission defintion in Tethering · 1784f25d
      Chiachang Wang authored
      The permissions are checked by Tethering; mainline modules should be
      able to do permission checks based on these permissions.
      
      Bug: 135411507
      Test: m
      Change-Id: Ib7f2aedfaaa909bbc356196114c62af9345f2593
      1784f25d
  14. Feb 20, 2020
  15. Feb 19, 2020
    • Peter Collingbourne's avatar
      Tethering: Don't crash if wifi unavailable. · 9969e5df
      Peter Collingbourne authored
      r.android.com/1213016 seems to have caused the following crash on devices
      without wifi:
      
      FATAL EXCEPTION: main
      Process: com.android.networkstack.process, PID: 1041
      java.lang.RuntimeException: Unable to create service com.android.server.connectivity.tethering.TetheringService: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.net.wifi.WifiManager.registerSoftApCallback(java.util.concurrent.Executor, android.net.wifi.WifiManager$SoftApCallback)' on a null object reference
      	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4005)
      	at android.app.ActivityThread.access$1500(ActivityThread.java:220)
      	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1891)
      	at android.os.Handler.dispatchMessage(Handler.java:106)
      	at android.os.Looper.loop(Looper.java:216)
      	at android.app.ActivityThread.main(ActivityThread.java:7396)
      	at java.lang.reflect.Method.invoke(Native Method)
      	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
      	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:949)
      Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.net.wifi.WifiManager.registerSoftApCallback(java.util.concurrent.Executor, android.net.wifi.WifiManager$SoftApCallback)' on a null object reference
      	at com.android.server.connectivity.tethering.Tethering.<init>(Tethering.java:317)
      	at com.android.server.connectivity.tethering.TetheringService.makeTethering(TetheringService.java:90)
      	at com.android.server.connectivity.tethering.TetheringService.onCreate(TetheringService.java:81)
      	at android.app.ActivityThread.handleCreateService(ActivityThread.java:3993)
      
      Fix it by null checking wifiManager before calling a method on it.
      
      Bug: 142352330
      Change-Id: I46e2f3053a59d3dba6a186a9eed34fa63b45d03e
      9969e5df
    • Anton Hansson's avatar
      Stop exposing generated AIDL from Tethering · c82ea10e
      Anton Hansson authored
      We don't want new modules exposing stable aidl directly. APIs should
      be defined as java @SystemApi. It also seems like nothing actually
      depend on these interfaces, except one simple exception.
      
      Bug: 147200698
      Test: m
      Change-Id: Ia4222fa35a9a2f3c75cebb12f75c536f27e2fe16
      Merged-In: Ia4222fa35a9a2f3c75cebb12f75c536f27e2fe16
      c82ea10e
    • Lorenzo Colitti's avatar
    • Lorenzo Colitti's avatar
    • Lorenzo Colitti's avatar
      Tethering offload: add/remove IPv6 forwarding rules on ND events. · 5e15d7b0
      Lorenzo Colitti authored
      Use IpNeighborMonitor to listen for ND cache events on the
      downstream interface, and push downstream IPv6 fowarding rules
      to netd.
      
      Rules are pushed when:
      - IPv6 neighbours appear/disappear on the downstream interface.
      - The upstream changes.
      
      Test: new unit test
      Change-Id: I7b01ba179a4d6bb248fd6c4994e48800613a4efa
      5e15d7b0
    • Treehugger Robot's avatar
    • Maciej Żenczykowski's avatar
      Reduce advertised ipv6 mtu by 16 to fit ethernet header · da0fb1bc
      Maciej Żenczykowski authored
      
      This is a temporary hack to workaround the inability of current
      kernel's ebpf bpf_skb_change_mode() function to prefix a 14-byte
      ethernet header on to a packet without going over the upstream
      (source, rawip) interface's mtu *before* we bpf_redirect() to
      the downstream (destination, ethernet) interface.
      
      Test: build, atest, atest TetheringTests
      Bug: 149816401
      Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
      Change-Id: I646148ebfd978a2489c0cd065e4b671b01150add
      da0fb1bc
Loading