- May 22, 2021
-
-
TreeHugger Robot authored
-
TreeHugger Robot authored
-
- May 21, 2021
-
-
Cody Kesting authored
This CL updates ConnectivityService to check location permissions for ConnectivityDiagnostics callbacks last in the permission check process. This minimizes misattribution of location access for networks that an app is not administering. This CL also updates ConnectivityDiagnosticsManager documentation to clearly state that location permissions are required in order to receive callbacks. Bug: 187310575 Test: atest ConnectivityDiagnosticsManagerTest Test: atest ConnectivityServiceTest Change-Id: I2dbeddac6273e2392ccaeae51a1c7776d6d3da75 Merged-In: I2dbeddac6273e2392ccaeae51a1c7776d6d3da75 (cherry picked from commit f3d0fc49)
-
Treehugger Robot authored
When apps try to call factoryReset to do networking reset, it will result in updating the setting in SettingsProvider. ContentProvider will verify if the package name of the caller that initiated the request being processed on the current thread. The package should belong to the calling UID. The setting update started from the ConnectivityService context, so the package will be android but the calling UID will be the calling app. It will cause a SecurityException. The behavior is fine previously as its known caller(Settings) shares system UID. But it will be a problem for other callers, such as CTS. Thus, clear the identity since the necessary permission check should be examined at the top of the method. The following actions should be fine to be proceed from the system itself. Also replace the user restriction check via hasUserRestrictionForUser with the UserHandle created from the calling uid to ensure it's verified with correct user. Bug: 186061922 Test: Factory reset from Settings Merged-In: If2dd69f702a1eafff331f9e71f6b92aeadfb715d Change-Id: If2dd69f702a1eafff331f9e71f6b92aeadfb715d (cherry picked from commit 10ba4b77)
-
Chiachang Wang authored
Bug: 186061922 Test: atest CtsNetTestCases:android.net.NetworkCapabilitiesTest Merged-In: I369e71dd6ae85da78e114ea8377967ab0bde787b Change-Id: I369e71dd6ae85da78e114ea8377967ab0bde787b (cherry picked from commit 0aa0790d)
-
- May 20, 2021
-
-
TreeHugger Robot authored
-
Les Lee authored
-
Paul Hu authored
-
Paul Hu authored
-
TreeHugger Robot authored
-
Remi NGUYEN VAN authored
-
- May 19, 2021
-
-
Junyu Lai authored
Ignore-AOSP-First: Avoid merge conflict Test: atest android.net.ConnectivityManagerTest Bug: 188657173 Change-Id: I33612650eb89486a14fcfc440ba0c357f4bb513c
-
Les Lee authored
-
Junyu Lai authored
* changes: [FUI29] Migrate ConnectivityService to use getAllNetworkStateSnapshots [FUI27] Fix internal naming of notifyNetworkStatus
-
Junyu Lai authored
-
junyulai authored
Test: atest NetworkRequestTest#testBypassingVcn Fix: 176939355 Fix: 188597540 Merged-In: I98dd3f4652dc067eb5c4666e952db6c854bcbb10 Change-Id: I98dd3f4652dc067eb5c4666e952db6c854bcbb10 (cherry-picked from aosp/1705390)
-
Remi NGUYEN VAN authored
-
Remi NGUYEN VAN authored
Stop reading legacy resources as fallback, and only use resources in ServiceConnectivityResources. Bug: 185850634 Test: atest CtsNetTestCases FrameworksNetTests Change-Id: I224f1ef9a1a8d6e636c7e9550845ab3e1394d7f3
-
lesl authored
This CL modifies NetworkTemplate#buildTemplateCarrier to force on metered carrier network and rename to buildTemplateCarrierMetered. This method was introduced recently and has no callers. This method will be used in Settings and NetworkPolicyManagerService to display and manage data usage on carrier metered networks. Settings/NetworkPolicyManagerService will use it instead of the existing method buildTemplateMobileAll method, which only matches metered networks. That code will change from matching metered mobile networks to matching metered carrier networks. Note: The carrier metered network includes metered mobile network and metered "merged carrier wifi network" that is a specific cerrier wifi network which provides the same user experience as mobile. Bug: 176396812 Test: atest -c NetworkTemplateTest Change-Id: I7196d62bb60844458a6c4b1d94e2baccb71e15cd Merged-In: I7196d62bb60844458a6c4b1d94e2baccb71e15cd
-
lesl authored
Previous the API ignores subscriberId when network type is WIFI. Allow caller to call querySummaryXXXX with TYPE: WIFI + subscriberId: IMSI to get carrier merged wifi usage which matches the wifi network with the given IMSI. Bug: 176396812 Test: atest -c NetworkStatsServiceTest Change-Id: Ia033521a24e2bb56182d74a41bb2b39710571782 Merged-In: Ia033521a24e2bb56182d74a41bb2b39710571782
-
Remi NGUYEN VAN authored
The resources are only read by NetworkStack through their respective ApfCapabilities SystemApi methods. As the resources are being migrated out of frameworks/base resources anyway, move them directly to NetworkStack instead of moving them to ServiceConnectivityResources. Also test that the framework resources are not overlaid or modified. This should avoid OEM integration errors where the overlays are kept as in R, without overlaying the resource in the NetworkStack package. Bug: 185850634 Test: atest CtsNetTestCases BYPASS_INCLUSIVE_LANGUAGE_REASON=Need to mention legacy APIs Merged-In: I7a15ddcad5af11fa307d9dbe3a77b31a1179e5b3 (clean cherry-pick) Change-Id: I7a15ddcad5af11fa307d9dbe3a77b31a1179e5b3
-
- May 18, 2021
-
-
Paul Hu authored
PermissionMonitor register APPS_ALLOWED_ON_RESTRICTED_NETWORKS setting observer to listen setting changed callback. Then update or revoke permission for those apps. Bug: 185149952 Test: atest FrameworksNetTests Merged-In: I4b6a21bd3f47b7bcaac36fcabf1202a5a84a4520 (clean cherry-pick) Change-Id: I4b6a21bd3f47b7bcaac36fcabf1202a5a84a4520
-
Paul Hu authored
Let PermissionMonitor read APPS_ALLOWED_ON_RESTRICTED_NETWORKS setting and grant netd system permission to uids whose package name is listed in setting. Bug: 185149952 Test: atest FrameworksNetTests Merged-In: I856b545c0339a262abbe9d432cfda125bc82dc12 (clean cherry-pick) Change-Id: I856b545c0339a262abbe9d432cfda125bc82dc12
-
Chiachang Wang authored
-
Lorenzo Colitti authored
Currently, unprivileged apps can call getAllNetworks() to see all networks on the system, even networks that do not apply to them. Allow them to do this via NetworkCallbacks as well. This is the last piece of information that was only available through getAllNetworks, so this CL deprecates that API. Bug: 187921303 Test: new unit tests Test: CTS test in other CL in topic Change-Id: I30f1021927d3c8eae6525116c61ff4a4acecff6d
-
Chiachang Wang authored
The legacy design of "dumpsys connectivity" will only dump information with NORMAL priority. It was updated to provide both NORMAL and HIGH priority information in order to support dump in bugreport. However, it will also affect the result using dumpsys connectivity. Update design to dump NORMAL priority only to align with legacy design. Bug: 188387185 Test: adb shell dumpsys connectivity Test: adb bugreport and check the result in bugreport Change-Id: I6825c5038e48e3060c0c3ad1512bd584ef6d10a7 Merged-In: I6825c5038e48e3060c0c3ad1512bd584ef6d10a7
-
- May 17, 2021
-
-
Aaron Huang authored
-
junyulai authored
This is declared in the API surface, but the implementation does not match. Ignore-AOSP-First: Needs cherry-picks Test: atest CtsNetTestCases:android.net.cts.ConnectivityManagerTest#testGetAllNetworkStateSnapshots Bug: 188140631 Change-Id: I97aa69651461ebe5c323ec669372f9a61b84e6a6
-
junyulai authored
Test: atest FrameworksNetTests Bug: 174123988 Merged-In: I3ba50cbd8a7f60779c69ba85e10dc3cc8a52f8b1 Change-Id: I3ba50cbd8a7f60779c69ba85e10dc3cc8a52f8b1 (cherry-picked from aosp/1620859)
-
junyulai authored
Test: TH Bug: 174123988 Merged-In: I970ee365ca221956ee85788005d331374b5fa71a Change-Id: I970ee365ca221956ee85788005d331374b5fa71a (cherry-picked from aosp/1620539)
-
- May 14, 2021
-
-
Jayachandran Chinnakkannu authored
Merge "QOS filter matching support based on remote address and port number for connected sockets" am: 6c5553aa am: f84276bd am: 9896622b Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1687813 Change-Id: I04ada71bdea2c3851fd6925126f6ff2bfdecad2c
-
Jayachandran Chinnakkannu authored
Merge "QOS filter matching support based on remote address and port number for connected sockets" am: 6c5553aa am: f84276bd Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1687813 Change-Id: I6f1d972f822b022995cfdc99942f1167a4f8ef0d
-
Jayachandran Chinnakkannu authored
Merge "QOS filter matching support based on remote address and port number for connected sockets" am: 6c5553aa Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1687813 Change-Id: Ibd70a86d82d4810425288694f2e3904d471a2d24
-
Jayachandran Chinnakkannu authored
-
Junyu Lai authored
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1618845 Change-Id: I8c62d218953027ee2fb5426ddacae5a6f8bb6c73
-
Junyu Lai authored
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1618845 Change-Id: If6b9da9ce754f33868305075013b0f82ff64fedb
-
Junyu Lai authored
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1618845 Change-Id: Idde0e161d6241a5c45c0b751e1fca912ed10c7a8
-
Junyu Lai authored
-
Paul Hu authored
Merge "Address [set|get]RestrictedAllowedApps API review feedback" am: 16c34f0d am: 38544887 am: 95f5f547 Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1708327 Change-Id: Ia8e395132226d23fdfb8cd4c93c004c459386104
-
Paul Hu authored
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1708327 Change-Id: Iedd6429e956f77ba595f5dd6029c48a487ddbf0c
-