Skip to content
Snippets Groups Projects
  1. May 22, 2021
  2. May 21, 2021
    • Cody Kesting's avatar
      Check location permission for ConnDiags last. · 0b4be020
      Cody Kesting authored
      This CL updates ConnectivityService to check location permissions for
      ConnectivityDiagnostics callbacks last in the permission check process.
      This minimizes misattribution of location access for networks that an
      app is not administering.
      
      This CL also updates ConnectivityDiagnosticsManager documentation to
      clearly state that location permissions are required in order to receive
      callbacks.
      
      Bug: 187310575
      Test: atest ConnectivityDiagnosticsManagerTest
      Test: atest ConnectivityServiceTest
      Change-Id: I2dbeddac6273e2392ccaeae51a1c7776d6d3da75
      Merged-In: I2dbeddac6273e2392ccaeae51a1c7776d6d3da75
      (cherry picked from commit f3d0fc49)
      0b4be020
    • Treehugger Robot's avatar
      Use CS identity to update setting while performing factory reset · fac2a725
      Treehugger Robot authored
      When apps try to call factoryReset to do networking reset, it
      will result in updating the setting in SettingsProvider.
      ContentProvider will verify if the package name of the caller
      that initiated the request being processed on the current thread.
      The package should belong to the calling UID. The setting update
      started from the ConnectivityService context, so the package will
      be android but the calling UID will be the calling app. It will
      cause a SecurityException. The behavior is fine previously as its
      known caller(Settings) shares system UID. But it will be a
      problem for other callers, such as CTS. Thus, clear the identity
      since the necessary permission check should be examined at the
      top of the method. The following actions should be fine to be
      proceed from the system itself. Also replace the user restriction
      check via hasUserRestrictionForUser with the UserHandle created
      from the calling uid to ensure it's verified with correct user.
      
      Bug: 186061922
      Test: Factory reset from Settings
      Merged-In: If2dd69f702a1eafff331f9e71f6b92aeadfb715d
      Change-Id: If2dd69f702a1eafff331f9e71f6b92aeadfb715d
      (cherry picked from commit 10ba4b77)
      fac2a725
    • Chiachang Wang's avatar
      Add test for NetworkCapabilities.Builder.withoutDefaultCapabilities · 0aa413eb
      Chiachang Wang authored
      Bug: 186061922
      Test: atest CtsNetTestCases:android.net.NetworkCapabilitiesTest
      Merged-In: I369e71dd6ae85da78e114ea8377967ab0bde787b
      Change-Id: I369e71dd6ae85da78e114ea8377967ab0bde787b
      (cherry picked from commit 0aa0790d)
      0aa413eb
  3. May 20, 2021
  4. May 19, 2021
    • Junyu Lai's avatar
      Add more unit tests for ConnectivityManager S APIs · ffda3053
      Junyu Lai authored
      Ignore-AOSP-First: Avoid merge conflict
      Test: atest android.net.ConnectivityManagerTest
      Bug: 188657173
      Change-Id: I33612650eb89486a14fcfc440ba0c357f4bb513c
      ffda3053
    • Les Lee's avatar
    • Junyu Lai's avatar
      Merge changes I3ba50cbd,I970ee365 into sc-dev · 458a60da
      Junyu Lai authored
      * changes:
        [FUI29] Migrate ConnectivityService to use getAllNetworkStateSnapshots
        [FUI27] Fix internal naming of notifyNetworkStatus
      458a60da
    • Junyu Lai's avatar
    • junyulai's avatar
      [VCN21] Do not add NOT_VCN_MANAGED capability if specifier is present · 35687f59
      junyulai authored
      Test: atest NetworkRequestTest#testBypassingVcn
      Fix: 176939355
      Fix: 188597540
      Merged-In: I98dd3f4652dc067eb5c4666e952db6c854bcbb10
      Change-Id: I98dd3f4652dc067eb5c4666e952db6c854bcbb10
        (cherry-picked from aosp/1705390)
      35687f59
    • Remi NGUYEN VAN's avatar
    • Remi NGUYEN VAN's avatar
      Remove legacy resources fallback from Connectivity · 14233479
      Remi NGUYEN VAN authored
      Stop reading legacy resources as fallback, and only use resources in
      ServiceConnectivityResources.
      
      Bug: 185850634
      Test: atest CtsNetTestCases FrameworksNetTests
      Change-Id: I224f1ef9a1a8d6e636c7e9550845ab3e1394d7f3
      14233479
    • lesl's avatar
      Add metered filter for API: buildTemplateCarrier · f96f0270
      lesl authored
      This CL modifies NetworkTemplate#buildTemplateCarrier to force on
      metered carrier network and rename to buildTemplateCarrierMetered.
      This method was introduced recently and has no callers.
      
      This method will be used in Settings and NetworkPolicyManagerService
      to display and manage data usage on carrier metered networks.
      
      Settings/NetworkPolicyManagerService will use it instead of the existing
      method buildTemplateMobileAll method, which only matches metered networks.
      That code will change from matching metered mobile networks to matching
      metered carrier networks.
      
      Note: The carrier metered network includes metered mobile network and
      metered "merged carrier wifi network" that is a specific cerrier wifi network
      which provides the same user experience as mobile.
      
      Bug: 176396812
      Test: atest -c NetworkTemplateTest
      Change-Id: I7196d62bb60844458a6c4b1d94e2baccb71e15cd
      Merged-In: I7196d62bb60844458a6c4b1d94e2baccb71e15cd
      f96f0270
    • lesl's avatar
      Support to query TYPE_WIFI usage with subscriberId · cf4a1b59
      lesl authored
      Previous the API ignores subscriberId when network type is WIFI.
      Allow caller to call querySummaryXXXX with TYPE: WIFI
      + subscriberId: IMSI to get carrier merged wifi usage which matches the wifi
      network with the given IMSI.
      
      Bug: 176396812
      Test: atest -c NetworkStatsServiceTest
      Change-Id: Ia033521a24e2bb56182d74a41bb2b39710571782
      Merged-In: Ia033521a24e2bb56182d74a41bb2b39710571782
      cf4a1b59
    • Remi NGUYEN VAN's avatar
      Move config_apf* resources to NetworkStack · be047e28
      Remi NGUYEN VAN authored
      The resources are only read by NetworkStack through their respective
      ApfCapabilities SystemApi methods.
      As the resources are being migrated out of frameworks/base resources
      anyway, move them directly to NetworkStack instead of moving them to
      ServiceConnectivityResources.
      
      Also test that the framework resources are not overlaid or modified.
      This should avoid OEM integration errors where the overlays are kept as
      in R, without overlaying the resource in the NetworkStack package.
      
      Bug: 185850634
      Test: atest CtsNetTestCases
      BYPASS_INCLUSIVE_LANGUAGE_REASON=Need to mention legacy APIs
      
      Merged-In: I7a15ddcad5af11fa307d9dbe3a77b31a1179e5b3
      (clean cherry-pick)
      
      Change-Id: I7a15ddcad5af11fa307d9dbe3a77b31a1179e5b3
      be047e28
  5. May 18, 2021
    • Paul Hu's avatar
      Register APPS_ALLOWED_ON_RESTRICTED_NETWORKS setting observer · 20615778
      Paul Hu authored
      PermissionMonitor register APPS_ALLOWED_ON_RESTRICTED_NETWORKS
      setting observer to listen setting changed callback. Then update
      or revoke permission for those apps.
      
      Bug: 185149952
      Test: atest FrameworksNetTests
      Merged-In: I4b6a21bd3f47b7bcaac36fcabf1202a5a84a4520
      (clean cherry-pick)
      
      Change-Id: I4b6a21bd3f47b7bcaac36fcabf1202a5a84a4520
      20615778
    • Paul Hu's avatar
      Read APPS_ALLOWED_ON_RESTRICTED_NETWORKS setting from PermissionMonitor · deb3f2e7
      Paul Hu authored
      Let PermissionMonitor read APPS_ALLOWED_ON_RESTRICTED_NETWORKS
      setting and grant netd system permission to uids whose package
      name is listed in setting.
      
      Bug: 185149952
      Test: atest FrameworksNetTests
      Merged-In: I856b545c0339a262abbe9d432cfda125bc82dc12
      (clean cherry-pick)
      
      Change-Id: I856b545c0339a262abbe9d432cfda125bc82dc12
      deb3f2e7
    • Chiachang Wang's avatar
    • Lorenzo Colitti's avatar
      Allow unprivileged NetworkCallbacks to see other UIDs' networks. · 86714b1f
      Lorenzo Colitti authored
      Currently, unprivileged apps can call getAllNetworks() to see
      all networks on the system, even networks that do not apply to
      them. Allow them to do this via NetworkCallbacks as well.
      
      This is the last piece of information that was only available
      through getAllNetworks, so this CL deprecates that API.
      
      Bug: 187921303
      Test: new unit tests
      Test: CTS test in other CL in topic
      Change-Id: I30f1021927d3c8eae6525116c61ff4a4acecff6d
      86714b1f
    • Chiachang Wang's avatar
      Dump only NORMAL priority information if no priority assigned · 12d32a67
      Chiachang Wang authored
      The legacy design of "dumpsys connectivity" will only dump
      information with NORMAL priority. It was updated to provide
      both NORMAL and HIGH priority information in order to support
      dump in bugreport. However, it will also affect the result
      using dumpsys connectivity.
      
      Update design to dump NORMAL priority only to align with legacy
      design.
      
      Bug: 188387185
      Test: adb shell dumpsys connectivity
      Test: adb bugreport and check the result in bugreport
      Change-Id: I6825c5038e48e3060c0c3ad1512bd584ef6d10a7
      Merged-In: I6825c5038e48e3060c0c3ad1512bd584ef6d10a7
      12d32a67
  6. May 17, 2021
  7. May 14, 2021
Loading