- Mar 18, 2021
-
-
Anthony Stange authored
Revert "Add shims for NetworkRequest" Revert submission 1626206-replaceUidRange Reason for revert: Breaking build - b/183106405 Reverted Changes: I0b79c73e8:Add shims for NetworkRequest I4bc0daf5a:Replace the usage of UidRange I4e5aec6ef:Replace the usage of UidRange I107c329d4:Expose uids related APIs in NetworkRequest and Net... Change-Id: I45e08f89533af0d6851add38fecb5c6c114615ae
-
- Mar 17, 2021
-
-
Chiachang Wang authored
NetworkRequest is moving into the incoming connectivity mainline module. The hidden setUids becomes inaccessible outside the module. Shims for support cts in different API levels will need to use it to verify the behavior of NetworkRequest. Thus, expose it to the API surface. Also, VPN uses getUids and setUids to control network capabilities. Networkcapabilities is a part of incoming connectivity mainline module but VPN is not. Thus, exposing these two methods are needed to allow VPN to continue using it. Test: make update-api Bug: 172183305 Change-Id: I107c329d4d7130d488772166eae8b5e7aaa2ff04
-
Chiachang Wang authored
UidRange is used in a shared way between ConnectivityService and VPN through the use of NetworkCapabilities. UidRange will be part of the ConnectivityService mainline but Vpn.java will stay in the framework. We need a way to replace the APIs using UidRange, or to make UidRange system API. The only really relevant surface here is NetworkCapabilities#{setUids, getUids}. The need for UidRange could be replaced by an integer Range, so replace the usage of UidRange by a integer Range in NetworkCapabilities#{setUids, getUids} and update the relevant callers. Bug: 172183305 Test: atest FrameworksNetTests CtsNetTestCasesLatestSdk Change-Id: I4e5aec6ef1ea02e038fcd7ed117a3b67b69c5cb9
-
Paul Hu authored
-
Remi NGUYEN VAN authored
-
Lucas Lin authored
-
Remi NGUYEN VAN authored
-
paulhu authored
TCP_DEFAULT_INIT_RWND setting has never been set before, CS always read the tcp receive window size from net.tcp.default_init_rwnd then set to net.tcp_def_init_rwnd. Thus, remove the unnecessary setting from CS, and the property doesn't need to set either. Because aosp/1639922 migrate the properties, the default value has been set to kernel already. Bug: 182538166 Test: atest FrameworksNetTests Change-Id: I13e175ab4dea72446af7df4a25e307e5934fa813
-
Remi NGUYEN VAN authored
This fixes a merge conflict with downstream branches due to an incomplete cherry-pick. Bug: 171540887 Test: m Change-Id: I27a8f20f1a1d83b472700648f3f5a68413a76ac3 Merged-In: I7432fe4c87cd3cab04dcb6185c9a4f3f84376549
-
lucaslin authored
Bug: 172183305 Test: m Change-Id: I2f1b44cf2a362b42f052ea5d34a5cec03d46e661
-
Lucas Lin authored
-
Chalard Jean authored
* changes: Remove per-user preference when the user is removed Expose the enterprise per-profile networking API. Implement setNetworkPreferenceForUser. Public API for per-profile network preference. Add tests for setNetworkPreferenceForUser
-
Remi NGUYEN VAN authored
-
Remi NGUYEN VAN authored
-
- Mar 16, 2021
-
-
junyulai authored
Test: m -j doc-comment-check-docs Bug: 175662146 Change-Id: Ie67dd2f4f8d973de37bc64a03908d7cbb7c2b7ad
-
junyulai authored
This is done by: 1. In requestNetwork, provide a basic permission check. 2. rematchNetworksAndRequests: no change, since non listen requests will be automatically processed to track best satisfying network. 3. applyNetworkReassignment: no change, since non-request will not be sent to factories. Test: atest ConnectivityServiceTest#testRegisterBestMatchingNetworkCallback_noIssueToFactory Test: atest ConnectivityServiceTest#testRegisterBestMatchingNetworkCallback_trackBestNetwork Bug: 175662146 Change-Id: I8cf4ab334df6812d84cdda160e9b72b6f54062af
-
Paul Hu authored
-
Chalard Jean authored
Test: new test for this Change-Id: I335e82e29ec8f4c8da9def8b40153858cfd5bacb
-
Chalard Jean authored
Also unify the listener for Oem settings, which have never been released as public API (it is slated to be released in S). Test: FrameworksNetTests Change-Id: I84ba363dd0ec03871c37b1c3a31e5557d9aa12e7
-
Chalard Jean authored
Test: FrameworksNetTests Change-Id: I8f18083b5857289892fe8adea5f5ea3f5dbe0809
-
Chalard Jean authored
This patch defines the API, but does not make it public yet as there is no implementation yet. Test: none so far Change-Id: I854a952dfe35cc80847eb62f522b1667b8e9b8a0
-
Chalard Jean authored
Test: this Change-Id: I00e2344118408da307439a0a993eb67cb17bf777
-
Lucas Lin authored
-
lucaslin authored
Context is more useful than ContentResolver, it can provide more information if we want to change the behavior in the future. Bug: 172183305 Test: atest FrameworksNetTests Change-Id: I5702c7d74b862a76558b94f1abe2c6df9eb7f097 Merged-In: I5702c7d74b862a76558b94f1abe2c6df9eb7f097
-
lucaslin authored
NETWORK_STACK_UID check was introduced by aosp/1134635, and it assumed that wifi factories/agents will be running on the network stack process, but it didn't eventually. It runs in the system server instead. So remove this check. Bug: 170598012 Test: atest FrameworksNetTests Change-Id: Ie11268738e364e252f18876f7a4a0dc064ca8b9c
-
Lucas Lin authored
-
Lucas Lin authored
-
Remi NGUYEN VAN authored
networkAttributes is a legacy configuration that is now only used to configure which legacy type networks are supported, and what the restore timer is for that network type, for the deprecated startUsingNetworkFeature API. Use a dedicated resource for the restore timers, and build supported legacy network types using hasSystemFeature for wifi, wifi p2p, bluetooth, proxy types, and TelephonyManager.isDataCapable for the mobile types. Bug: 146206136 Test: atest FrameworksNetTests Change-Id: I3a771d3de6c5e912f18d2834e3a50af797ac4991
-
Chalard Jean authored
-
Remi NGUYEN VAN authored
-
Remi NGUYEN VAN authored
-
- Mar 15, 2021
-
-
paulhu authored
Connectivity is becoming a mainline module in S but mainline modules are not allowed to use non-formal APIs. Thus, replace internal okhttp APIs to stable libcore APIs which are created for using HttpURLConnectionFactory. Bug: 182238821 Test: atest FrameworksNetTests Change-Id: I56ba1b9e6e94f9c6519c3f1c8f0c5993fccbe185
-
Lorenzo Colitti authored
-
Aaron Huang authored
* changes: Make PacProxyService be a system service Revert^2 "Refactor setCurrentProxyScriptUrl to a void method"
-
Sorin Basca authored
* changes: Using jniThrowErrnoException in android_util_Process Using jniThrowErrnoException in android_os_SharedMemory Using jniThrowErrnoException in android_net_NetworkUtils
-
lucaslin authored
Bug: 172183305 Test: N/A Change-Id: Id274295d6c8c97d3014214f875168ff968f79bb6
-
Chalard Jean authored
As attested by numerous TODOs in the code, a new way of representing network quality and policy is needed instead of an int. An int representing the quality of the network requires all parties using it to know how all other parties are using it, and implementation details about the decision algorithm. For all intents and purposes, the selection is left to individual network factories who try to achieve a desired result while piecing together all possible states of the system. As the number of such cases and desires increases, this becomes both intractable and unmaintainable. Indeed, at this time in the codebase nobody can really predict exactly how a given change in score will affect selection across the board, and it is essentially impossible to figure out the behavior of network selection by inspecting the code because the moving parts are scattered throughout the entire codebase. Having an object encapsulating policy and quality values will let us centralize the selection and make it again possible to maintain without knowledge of all behaviors of all network factories. It will also provide better guarantees of respecting policy, and allow bugfixes that were not possible before because they'd touch too many parts of the code. Test: FrameworksNetTests FrameworksWifiTests NetworkStackTests Change-Id: I3185a6412b9b659798faf0c6882699e9c63cc115
-
Frank Li authored
-
Remi NGUYEN VAN authored
-
Remi NGUYEN VAN authored
This reverts commit 62b1df44. Reason for revert: Build broken: b/182721112 Change-Id: Ibc84ec6d7900fdcf0bc14cd7036f9c08287711db
-