Skip to content
Snippets Groups Projects
  1. Oct 23, 2023
    • Jordan Silva's avatar
      Revert "[BR07.1] Expose setDataSaverEnabled from ConnectivityManager" · 457ae0f0
      Jordan Silva authored
      Revert submission 2745215-npmsbpf
      
      DroidMonitor: Potential culprit for Bug 307256512 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
      
      
      Reason for revert: 307256512
      
      Reverted changes: /q/submissionid:2745215-npmsbpf
      
      Change-Id: I27119a7484453d1369bbdf71ad2479edec7d664f
      457ae0f0
  2. Oct 19, 2023
  3. Oct 18, 2023
    • Paul Hu's avatar
      Add expired services removal flag · f3fe3333
      Paul Hu authored
      The TTL check and removal of expired services is currently only
      performed when a mDNS query is sent. This can result in expired
      services remaining in the cache if no queries are sent. To
      address this, the remaining TTL will be checked when retrieving
      services from the MdnsServiceCache. Add a new flag to enable
      the expired services removal feature. This feature will be
      implemented in subsequent changes.
      
      Bug: 265787401
      Bug: 304649384
      Test: atest FrameworksNetTests CtsNetTestCases
      Change-Id: I30f0eea568ee45d363cc02821de0921d6040f981
      f3fe3333
    • Junyu Lai's avatar
      Dump bpf program status in dumpsys · 155760b5
      Junyu Lai authored
      Sample output:
      Bpf Program Status:
        CGROUP_INET_INGRESS: 21
        CGROUP_INET_EGRESS: 22
        CGROUP_INET_SOCK_CREATE: 28
        CGROUP_INET4_BIND: 30
        CGROUP_INET6_BIND: 31
      
      Test: adb shell dumpsys connectivity
      Test: atest FrameworksNetTests:android.net.connectivity.com.android.server.ConnectivityServiceTest#testDumpDoesNotCrash
      Test: atest ConnectivityCoverageTests:android.net.connectivity.com.android.server.ConnectivityServiceTest#testDumpDoesNotCrash
      Bug: 292156770
      Change-Id: I312c90c524af12d093536156d6d5c6febd64305a
      155760b5
    • Junyu Lai's avatar
  4. Oct 17, 2023
  5. Oct 16, 2023
  6. Oct 14, 2023
  7. Oct 13, 2023
    • Patrick Rohr's avatar
    • Anton Hansson's avatar
      Fix broken documentation in Connectivity · 5ac6c0b0
      Anton Hansson authored
      EthernetManager is @SystemApi, so cannot be referenced from public
      API.
      
      Bug: 303184203
      Test: m docs
      Change-Id: Ib5cc07c89b4ecfdeae704da131ebb307816e35fa
      5ac6c0b0
    • Anton Kulakov's avatar
      Revert "Tell netd about local networks" · cc409153
      Anton Kulakov authored
      Revert submission 2777667
      
      Reason for revert: DroidMonitor-triggered revert due to breakage, bug b/305187495
      
      Reverted changes: /q/submissionid:2777667
      
      Bug: 305187495
      
      Change-Id: Icb46558d17b56f9f6fd402f1489de9ed2b8f7644
      cc409153
    • Anton Kulakov's avatar
      Revert "Add LocalNetworkConfig" · 6eea22b1
      Anton Kulakov authored
      Revert submission 2777667
      
      Reason for revert: DroidMonitor-triggered revert due to breakage, bug b/305187495
      
      Reverted changes: /q/submissionid:2777667
      
      Bug: 305187495
      
      Change-Id: Iae4ef936a4c111ae5668e539ce4cdbbb14c811f4
      6eea22b1
    • Anton Kulakov's avatar
      Revert "Simplify addRoutesToLocalNetwork calls" · 316346be
      Anton Kulakov authored
      Revert submission 2777667
      
      Reason for revert: DroidMonitor-triggered revert due to breakage, bug b/305187495
      
      Reverted changes: /q/submissionid:2777667
      
      Bug: 305187495
      
      Change-Id: I516d40b20d775e9c61b2f825bc094329d016d0c3
      316346be
    • Treehugger Robot's avatar
    • Jean Chalard's avatar
      Merge changes I3b6ee1db,I70e13303,I6fb7dfe4 into main · a6190bd6
      Jean Chalard authored
      * changes:
        Simplify addRoutesToLocalNetwork calls
        Add LocalNetworkConfig
        Tell netd about local networks
      a6190bd6
    • Paul Hu's avatar
      Add ServiceExpiredCallback · d4dcb4be
      Paul Hu authored
      This is a no-op change and refactors the design for subsequent
      TTL expiration check changes.
      - Add a ServiceExpiredCallback to notify expired services.
      - To simplify the design, pass the CacheKey to MdnsServiceCache
        methods instead.
      
      Bug: 265787401
      Test: atest FrameworksNetTests CtsNetTestCases
      Change-Id: I930a4f7baf9b8d3d0037dc6aefd717dbdd486520
      d4dcb4be
    • Hansen Kurli's avatar
      Mock Vpn.setUnderlyingNetworks() · 233ac946
      Hansen Kurli authored
      Override Vpn.setUnderlyingNetworks() to do a direct call on the
      network agent instead of relying on the Vpn class.
      
      Bug: 230548427
      Test: atest FrameworksNetTests
      Change-Id: Ib7883f8a81a22317616cae79ce57a30afdd2bed4
      233ac946
    • Hansen Kurli's avatar
      Mock Vpn.setLockdown() · 39654c33
      Hansen Kurli authored
      Call setRequireVpnForUids directly to enable lockdown instead of
      calling the real Vpn method.
      
      Bug: 230548427
      Test: atest FrameworksNetTests
      Change-Id: I91ec59f7542d145e9250a7e7a414593db3d99424
      39654c33
    • Chalard Jean's avatar
      Simplify addRoutesToLocalNetwork calls · cf70df3e
      Chalard Jean authored
      There are only three calls to this method, and two of them
      are with a list of 1 address which means it's simpler inlined.
      
      The last call will be replaced with calls to RouteController
      in a followup, meaning we addRoutesToLocalNetwork can be removed.
      
      Test: RouterAdvertisementDaemonTest
            NetdUtilsTest
      Change-Id: I3b6ee1db40f09954b336321000735a66306bf000
      cf70df3e
    • Chalard Jean's avatar
      Add LocalNetworkConfig · fa21cafc
      Chalard Jean authored
      This doesn't do anything at this patchset, but the whole
      pipe from the agent to ConnectivityService is built.
      
      LocalNetworkInfo will be the name of the public information
      sent in callbacks to clients.
      
      Test: CSLocalAgentTests
      Change-Id: I70e133031ef3b0aaf6c3e59ccc2ad895c66d339c
      fa21cafc
    • Chalard Jean's avatar
      Tell netd about local networks · 774dc3cd
      Chalard Jean authored
      This patch does the following :
      • When a network is local but the system doesn't support it,
        throw in registerNetworkAgent.
      • When a network is local, tell netd about it.
      • Add tests for the above, as well as a test for callbacks
        being sent correctly when the caps are set and not when
        they aren't and that the new keep connected flag is
        respected.
      
      Telling netd about the network being local has it add two
      routes that do not exist if the network is not local :
      • One at PRIORITY_LOCAL_NETWORK matching unmarked sockets
        and looking up the table for the interface.
      20000: from all fwmark 0x0/0x10000 lookup xxxx
      • One at PRIORITY_EXPLICIT_NETWORK matching explicitly on
        network 99, so that dnsmasq traffic and any OEM traffic
        marked for network 99 flowing there.
      16000: from all fwmark 0x10063/0x1ffff iif lo lookup xxxx
      IMPLICIT_NETWORK and EXPLICIT_NETWORK rules are installed
      by connectivity service as a matter of course whether the
      network is local or not.
      
      See commit If8729fc6f3716a580c936584b851bc38000b5de5 for
      implementation details of this mechanic.
      
      There is no need to implement anything in particular for the
      new connected reason, as the current implementation will
      already keep it connected. A new test makes sure of that.
      
      Test: FrameworksNetTests
            CtsNetTestCases
            FrameworksNetIntegrationTests
            NetworkStackTests
            NetworkStaticLibTests
            TetheringTests
            MtsTetheringTestLatestSdk
            TetheringIntegrationTests
      Change-Id: I6fb7dfe4c232eea8cac9ac268897ddb36bb794d1
      774dc3cd
    • Hansen Kurli's avatar
      Merge changes I22d67a7e,Ida4a4bc7,Ie8522862,Id55d8d6c into main · ccfc5214
      Hansen Kurli authored
      * changes:
        Ensure nri is satisfied before returning.
        Add testLockdownVpn that mocks platform VPN.
        Make variables in testLegacyLockdownVpn() final.
        Update testLegacyLockdownVpn to mock VPN.
      ccfc5214
  8. Oct 12, 2023
    • Paul Duffin's avatar
      Add additional overriding methods to signature files · b3c3f2e9
      Paul Duffin authored
      This change adds overriding methods that are essential to compile the
      stubs generated from the signature files.
      
      More information and the background for this change is available at
      go/add-overriding-one-pager.
      
      Test: m checkapi
      Bug: 299366704
      Change-Id: Idba307148fd9afa87bfb7e0c89e00d9bd97ec204
      b3c3f2e9
    • Patrick Rohr's avatar
    • Patrick Rohr's avatar
      Include both eth%d and usb%d ethernet interfaces on U+ · 11eac8e1
      Patrick Rohr authored
      Ethernet interface naming is not consistent on Linux. While some USB
      ethernet dongles show up as eth0, others might show up as usb0.
      
      This CL changes config_ethernet_iface_regex to "*" which stands for "use
      Android version specific default". The default will include both usb\d+
      and eth%d named interfaces on Android U+. Android T will continue to
      only include eth%d interfaces (note that the "+" is a new addition which
      is highly unlikely to have any actual effect, but is more technically
      correct).
      
      Bug: 304335605
      Test: TH
      Change-Id: I823be8ee390cb2b6dd41b537c72ed76f5aa9e0ea
      11eac8e1
    • Jean Chalard's avatar
      Merge changes Ic490fee6,If78047c3 into main · 10353d53
      Jean Chalard authored
      * changes:
        Add hidden constants for communicating about local network agents
        Use isAtLeast* from deps
      10353d53
Loading