Skip to content
Snippets Groups Projects
  1. Mar 17, 2021
  2. Mar 16, 2021
  3. Mar 15, 2021
    • paulhu's avatar
      Replace interal okhttp APIs · 405d8911
      paulhu authored
      Connectivity is becoming a mainline module in S but mainline
      modules are not allowed to use non-formal APIs. Thus, replace
      internal okhttp APIs to stable libcore APIs which are created for
      using HttpURLConnectionFactory.
      
      Bug: 182238821
      Test: atest FrameworksNetTests
      Change-Id: I56ba1b9e6e94f9c6519c3f1c8f0c5993fccbe185
      405d8911
    • Lorenzo Colitti's avatar
    • Aaron Huang's avatar
      Merge changes from topic "pacproxy-service" · c8e73fa9
      Aaron Huang authored
      * changes:
        Make PacProxyService be a system service
        Revert^2 "Refactor setCurrentProxyScriptUrl to a void method"
      c8e73fa9
    • Sorin Basca's avatar
      Merge changes from topic "jni-errno-exception" · 3a810d37
      Sorin Basca authored
      * changes:
        Using jniThrowErrnoException in android_util_Process
        Using jniThrowErrnoException in android_os_SharedMemory
        Using jniThrowErrnoException in android_net_NetworkUtils
      3a810d37
    • lucaslin's avatar
      Add comments to describe the value of converting hex to decimal · 0cdcea18
      lucaslin authored
      Bug: 172183305
      Test: N/A
      Change-Id: Id274295d6c8c97d3014214f875168ff968f79bb6
      0cdcea18
    • Chalard Jean's avatar
      [NS01] Add NetworkScore · 2801857f
      Chalard Jean authored
      As attested by numerous TODOs in the code, a new way of
      representing network quality and policy is needed instead
      of an int.
      
      An int representing the quality of the network requires
      all parties using it to know how all other parties are
      using it, and implementation details about the decision
      algorithm. For all intents and purposes, the selection
      is left to individual network factories who try to
      achieve a desired result while piecing together all
      possible states of the system.
      
      As the number of such cases and desires increases, this
      becomes both intractable and unmaintainable. Indeed, at
      this time in the codebase nobody can really predict exactly
      how a given change in score will affect selection across
      the board, and it is essentially impossible to figure out
      the behavior of network selection by inspecting the code
      because the moving parts are scattered throughout the
      entire codebase.
      
      Having an object encapsulating policy and quality values
      will let us centralize the selection and make it again
      possible to maintain without knowledge of all behaviors
      of all network factories. It will also provide better
      guarantees of respecting policy, and allow bugfixes that
      were not possible before because they'd touch too many
      parts of the code.
      
      Test: FrameworksNetTests FrameworksWifiTests NetworkStackTests
      Change-Id: I3185a6412b9b659798faf0c6882699e9c63cc115
      2801857f
    • Frank Li's avatar
      8ccc6abe
    • Remi NGUYEN VAN's avatar
    • Remi NGUYEN VAN's avatar
      Revert "Remove connectivity dependency on Preconditions" · 5086c295
      Remi NGUYEN VAN authored
      This reverts commit 62b1df44.
      
      Reason for revert: Build broken: b/182721112
      
      Change-Id: Ibc84ec6d7900fdcf0bc14cd7036f9c08287711db
      5086c295
    • Paul Hu's avatar
      Merge "Replace InetAddress#parseNumericAddress" · 05c16014
      Paul Hu authored
      05c16014
    • Aaron Huang's avatar
      Make PacProxyService be a system service · f9fa0b95
      Aaron Huang authored
      PacProxyInstaller class is running a thread all the time and is
      listening to intent ACTION_PAC_REFRESH so it would be better to
      make it be a system service with a manager class PacProxyManager
      which is obtained with getSystemService(PacProxyManager.class).
      Besides, rename PacProxyInstaller to PacProxyService will
      be easier to know it's the service for PacProxyManager.
      
      ConnectivityService is going to be a mainline module and it
      needs constructor of PacProxyService to be SystemApi.
      However, in current design, it needs to pass a handler and
      an int arguments to the constructor which would be difficult
      to maintain if just expose the constructor directly.
      
      So, define a listener for the event that the current PAC
      proxy has been installed so that the handler and the int
      arguments can be removed from the constructor.
      
      Bug: 177035719
      Test: FrameworksNetTests
      Change-Id: I2abff75ec59a17628ef006aad348c53fadbed076
      f9fa0b95
    • Remi NGUYEN VAN's avatar
    • lifr's avatar
      [CS15]Do not use hidden API of PlatformProperties · b885e615
      lifr authored
      ConnectivityService is going to become a mainline module, and
      it will not able to use hidden method anymore. Using PlatformProperties
      as a static library instead of hidden API.
      
      Bug: 170917042
      Test: atest FrameworksNetTests
      Merged-In: I3a3deca5d2e0f690db8c0061de2db2217376d268
      Change-Id: I3a3deca5d2e0f690db8c0061de2db2217376d268
      b885e615
    • lucaslin's avatar
      Call clearCallingIdentity when calling registerNetworkProvider in TNS · 10cb5421
      lucaslin authored
      The caller to create a TestNetworkService via
      ConnectivityManager#startOrGetTestNetworkManager should have
      passed the MANAGE_TEST_NETWORKS permission check and the caller
      doesn't need to declare the permission to pass the permission
      check of registerNetworkProvider. So call clearCallingIdentity
      when calling registerNetworkProvider in TestNetworkService.
      
      Bug: 181573283
      Test: atest CtsNetTestCases:ConnectivityManagerTest#testRequestBackgroundNetwork
      Change-Id: Ia28627dacf933d1937978ed9709b975c9a4660ce
      10cb5421
    • Remi NGUYEN VAN's avatar
      e87d4bca
    • Remi NGUYEN VAN's avatar
    • Remi NGUYEN VAN's avatar
      Add ParseException constructors to API · 94e5fff5
      Remi NGUYEN VAN authored
      ParseException constructors are used by both platform and mainline
      module code, so they can't be package-private.
      Removing dependencies on either side is not possible as the class
      itself is part of the public API, and supports APIs on both sides.
      
      Having the constructors part of the API makes the class usable by both
      sides.
      
      Fixes: 182705505
      Test: CtsNetTestCases for APIs using the exception
      Change-Id: Ia396ab2fa3afaed3cf474c8e60f72fc7f3f4fded
      94e5fff5
  4. Mar 14, 2021
    • Remi NGUYEN VAN's avatar
      Remove MessageUtils usage in VpnTransportInfo · e642d483
      Remi NGUYEN VAN authored
      MessageUtils is a hidden utility, and including a jarjared copy in
      framework-connectivity would add complexity.
      It is only used in VpnTransportInfo, where it would parse VPN constants
      when the class is loaded in each process. Considering the performance
      and maintenance cost using numerical type codes in toString() seems to
      be a better tradeoff.
      
      Bug: 177046265
      Test: m
      Change-Id: Ie71cc816f86e020b44ed1c86349b5c9204dee3cf
      e642d483
  5. Mar 12, 2021
    • paulhu's avatar
      Replace InetAddress#parseNumericAddress · 1013c81a
      paulhu authored
      -Connectivity is becoming a mainline module in S but mainline
      modules are not allowed to use non-formal APIs. Thus, replace
      non-formal API InetAddress#parseNumericAddress to
      InetAddresses#parseNumericAddress.
      - Add deprecated method legacyParseIpAndMask() for IpPrefix and
      LinkAddress. Because InetAddresses#parseNumericAddress has
      a little different behavior in some case, but these two classes
      should keep working as before. So these two classes will use
      the new deprecated method.
      
      Bug: 181756157
      Test: FrameworksNetTests
      Change-Id: I1c96b75f0b8d5e93304a39b4a8c8849964e5e810
      1013c81a
    • lucaslin's avatar
      Have a new API to get private DNS mode · 705c333a
      lucaslin authored
      - Expose PRIVATE_DNS_MODE_OFF, PRIVATE_DNS_MODE_OPPORTUNISTIC and
      PRIVATE_DNS_MODE_PROVIDER_HOSTNAME for external users.
      - Since PRIVATE_DNS_DEFAULT_MODE_FALLBACK might be changed from
      release to release, so it cannot be exposed as a system API.
      Remove PRIVATE_DNS_DEFAULT_MODE_FALLBACK and have a new API -
      getPrivateDnsMode() for users to get the private DNS mode instead.
      
      Bug: 172183305
      Test: atest FrameworksNetTests CtsNetTestCases
      Change-Id: I02a1e91b4eafb5f5df3eada1c07b99849a050c3c
      Merged-In: I02a1e91b4eafb5f5df3eada1c07b99849a050c3c
      705c333a
    • Remi NGUYEN VAN's avatar
      Remove VpnType usage in VpnTransportInfo · baf1680f
      Remi NGUYEN VAN authored
      The VpnType annotation is a hidden symbol, and should be
      kept hidden as annotations are disallowed by API guidelines.
      
      Remove its usage in VpnTransportInfo as users of annotated constants
      that build against API stubs are expected not to use the annotation.
      
      Bug: 173331190
      Test: m
      Change-Id: I171fa57f6279defad081c3cd16265d58ec55e57d
      baf1680f
    • Remi NGUYEN VAN's avatar
Loading