- Sep 29, 2023
-
-
Xiao Ma authored
sepolicy gates RTM_GETNEIGH{TBL} with a new permission nlmsg_getneigh and block access from untrusted_apps, but NetworkStackCoverageTests uses the same UID with NetworkStack module, so it still has the permission to send RTM_GETNEIGH(context: u:r:network_stack:s0<00>), which causes the test always fails. Add the same assumeFalse check for tests with network_stack context. Bug: 283346574 Test: atest NetworkStackCoverageTests Change-Id: Iaf652841bb9868783c924aa22fdf0c4f07e1e391
-
- Sep 14, 2023
-
-
Treehugger Robot authored
-
- Sep 13, 2023
-
-
Maciej Żenczykowski authored
This is based on network driver populated skb->mark magic bit. This is the bit used by netd's WakeupController. We mandated the location of this bit in U, though we haven't (yet??) mandated it being supported by all network drivers. If the driver doesn't support it, it could always be false (skb->mark should default to 0), or potentially (this is very very unlikely) be garbage. IFIRC nettrace isn't enabled on pre-U devices anyway. Test: TreeHugger Signed-off-by:
Maciej Żenczykowski <maze@google.com> Change-Id: I2b3b91315d77c08c022396253b26954593dd3f5a
-
Maciej Żenczykowski authored
Test: TreeHugger Signed-off-by:
Maciej Żenczykowski <maze@google.com> Change-Id: Iad7800387e1b84587794be93d037f712ac95fa07
-
Yuyang Huang authored
-
Paul Hu authored
-
Treehugger Robot authored
-
- Sep 12, 2023
-
-
Maciej Żenczykowski authored
-
Maciej Żenczykowski authored
(equivalent OWNERS file is already present in root directory of p/m/C) Test: N/A Signed-off-by:
Maciej Żenczykowski <maze@google.com> Change-Id: I4a4da3cd13bcf4497a210aae44618681ed43fd64
-
Maciej Żenczykowski authored
Test: TreeHugger Signed-off-by:
Maciej Żenczykowski <maze@google.com> Change-Id: I18ccf19024f0617778799f548c8707a518eefadc git-subtree-dir: clatd git-subtree-mainline: 655d0850 git-subtree-split: 20078300
-
Treehugger Robot authored
-
Yuyang Huang authored
The mDNS library need to be backported to some internal library which support minSdk 21. Therefore, updated the build rules to add the linter check. Bug: 296175311 Test: TH Change-Id: Iae0bffa315dc6de2339a05f595b13480fa7385ae
-
Yuyang Huang authored
Add end-to-end testing for testing NsdManager advertising and discovering works fine with downstream tethering interfaces. Bug: 281639507 Test: atest NsdManagerTest Change-Id: I5a66423f216cfe0c82db5128502c885980ab264b
-
Paul Hu authored
-
Paul Hu authored
The test flake is likely caused by a carrier configuration update. After the update is complete, the shell permission is dropped, which causes the test network setup to fail due to a lack of permission. The test network setup should also be protected by a synchronized lock to avoid permission lost. Bug: 296980394 Test: atest android.net.cts.ConnectivityDiagnosticsManagerTest \ --iteration 50 Change-Id: I3c7a0a92cddeb7c0f41a11b929f72714f8b22c05
-
Motomu Utsumi authored
* changes: Add java_defaults for @FlaggedApi handling Prepare api directory for udc mainline branch
-
Mike Yu authored
-
Yi Kong authored
packages/modules/Connectivity/service/native/TrafficController.cpp:58:18: error: using decl 'DumpWriter' is unused [misc-unused-using-decls,-warnings-as-errors] using netdutils::DumpWriter; ^ packages/modules/Connectivity/service/native/TrafficController.cpp:58:18: note: remove the using using netdutils::DumpWriter; ~~~~~~~~~~~~~~~~^~~~~~~~~~~ packages/modules/Connectivity/service/native/TrafficController.cpp:61:18: error: using decl 'ScopedIndent' is unused [misc-unused-using-decls,-warnings-as-errors] using netdutils::ScopedIndent; ^ packages/modules/Connectivity/service/native/TrafficController.cpp:61:18: note: remove the using using netdutils::ScopedIndent; ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ Test: presubmit Change-Id: I1871139fed31c57a5c15a8ab4f88aa7c695ff360
-
Maciej Żenczykowski authored
Test: TreeHugger Signed-off-by:
Maciej Żenczykowski <maze@google.com> Change-Id: I37c2aefe8759fdbab3078c60e0f97b57799697fc
-
Paul Hu authored
The isLegacy field of Nsd metrics should indicate whether the data was collected from the old backend or not. However, it is currently only dependent on the ENABLE_PLATFORM_MDNS_BACKEND compat change value, which is incorrect. This is because the NsdService always uses the new backend since Android U, regardless of the compat change value. Therefore, the isLegacy data should be obtained from each transaction. Bug: 287546772 Bug: 299880473 Test: atest FrameworksNetTestCases NsdManagerTest Change-Id: I156abd656b90578d710696a69ccf7dfca97a2c9c
-
- Sep 11, 2023
-
-
Igor Zaslavsky authored
Add RemoteAuthConnectionCache and RemoteAuthPlatform with support to sendMessage Design doc: go/remote-auth-manager-fishfood-design Test: built successfully. Bug: : 291333048 Change-Id: I17f73b4fb2e22924a484eeb3baa9b933ae980076
-
Jean Chalard authored
* changes: Implement ConnectivityStateMetrics sample Add base classes for common ConnectivityService tests.
-
Kangping Dong authored
-
Motomu Utsumi authored
Merge "Merge remote-tracking branch 'remotes/aosp/tmp_libs_net_move' into libs_net_move_merge" into main
-
Mike Yu authored
As connectivity pre-check was added to CtsNativeNetDnsTestCases recently, this CL is needed as well. Bug: 298886804 Test: TreeHugger Change-Id: I3c26920e8609256470cd2b8c37fc1f33f56c39fd
-
Chalard Jean authored
Test: ConnectivitySampleMetricsTest Change-Id: I0afdda023208c3f8620cb5b89add66448af596d7
-
Chalard Jean authored
This sets up what is necessary for an instrumented ConnectivityService to run. Users of this class are meant to inherit CSTest. This is still relatively basic and does not have all the instrumentation in ConnectivityServiceTest. Developers looking to extend CSTest may find some instrumentation missing ; when they add the missing instrumentation, they should consider whether it should be generic for all CSTests (and put it in base/), or whether it's local to their own test suite. This should enable faster testing as each CSTest children will only need to set up the instrumentation it actually needs. This patch also migrates a basic test to have a first user. Bug: 272685721 Test: ConnectivityServiceTest CSBasicMethodsTest Change-Id: I1c47f616af90629c9cb2a6ae89d992b19863e704
-
Kangping Dong authored
ot-daemon is a dependency of the new Thread feature. This commit add the ot-daemon binary and init rc file to the Tethering module. Note that the ot-daemon service is default disabled and versioned init rc file is used to ensure that this service won't be started before Android U. This is expected to increase the size of "com.android.tethering.capex" by around 400 KB. Manual verification: 1. on Android T (33) CF device, the ot-daemon service is not started after device boots; It reports service not found error when trying to start the ot-daemon service with adb shell command "start ot-daemon" 2. on Android U (34) CF device, the ot-daemon service is not started after device boots; It can be started with shell comamnd "start ot-daemon" but then failed because of missing sepolicy rules as expected Test: see above manual verification note Bug: 296211911 Change-Id: I222e2bbcc2ad0be2beec9f5f3406e7144d314370
-
Yuyang Huang authored
Don't get interfaceIndex if the socket is closed. Properly catch NPE instead of letting is propagating. Test: TH Change-Id: If962541e67dd6323426e46bc7a1f118786f83b9b
-
Motomu Utsumi authored
frameworks/libs/net/common -> packages/modules/Connectivity/staticlibs frameworks/libs/net/client-libs -> packages/modules/Connectivity/staticlbs/client-libs Test: TH Bug: 296014682 Change-Id: I5dc78f0c4653e20312ab3d488b1e69262dbb9840
-
Motomu Utsumi authored
-
- Sep 08, 2023
-
-
Treehugger Robot authored
-
Maciej Żenczykowski authored
-
Maciej Żenczykowski authored
Due to try_make_writable's implementation: // try to make the 1st 'len' header bytes r/w via DPA void try_make_writable(struct __sk_buff* skb, int len) { if (len > skb->len) len = skb->len; if (skb->data_end - skb->data < len) bpf_skb_pull_data(skb, len); } This *should* normally result in nothing actually being done. This is because the 'len' we request should trivially be <= skb->len (by virtue of how we construct the packet / get here), and because skb->data_end - skb->data < len was previously (to this patch) already checked below in line 251 (and thus the packet would have been dropped if it was false). However, there's a tentative theory that we could somehow end up with the entire payload in the non-linear portion of the packet, and thus need to move it into the linear header portion where we actually have direct packet access to it. Note also that we already called this in line 71, so it should be safe to add another call without causing bpf verifier unhappiness... Test: TreeHugger Bug: 298879031 Signed-off-by:
Maciej Żenczykowski <maze@google.com> Change-Id: If3531c3cf6932ac3f1d384a43d28326d17544aa3
-
Sudheer Shanka authored
-
Patrick Rohr authored
Test: none Change-Id: I0506ec660fd88e39079b2f36aed1516e27cdc0a6
-
Yuyang Huang authored
-
Paul Hu authored
-
Treehugger Robot authored
* changes: Add third_party/google_benchmark to cronet's copybara Move buildtools/third_party/libc++[abi] to third_party in Cronet's copybara Cronet Import: Add jni_zero to the list of third_parties
-
Motomu Utsumi authored
-