Skip to content
Snippets Groups Projects
  1. Jul 22, 2022
  2. Jul 21, 2022
  3. Jul 20, 2022
    • Lucas Lin's avatar
    • Treehugger Robot's avatar
      81ee9c4f
    • Remi NGUYEN VAN's avatar
      Simplify framework-t/Sources.bp · 5b546079
      Remi NGUYEN VAN authored
      Just include all files with a blob, instead of listing them separately.
      
      All files in the directory were previously referenced by
      framework-connectivity-tiramisu-updatable-sources, so this is a no-op.
      
      Bug: 217129444
      Test: m
      Change-Id: I83415b8f2a5836874c5ea2bffee45c43e03cc139
      5b546079
    • Remi NGUYEN VAN's avatar
      Use jarjar rule generator for connectivity rules · e55a88d3
      Remi NGUYEN VAN authored
      (This rolls forward part of a previous change, now that jarjar was fixed
      to not get very slow when the number of rules increases).
      
      Autogenerate connectivity jarjar rules at build time, to avoid issues
      with forgotten jarjar rules or hard-to-diagnose errors introduced by
      incorrect rules.
      
      This change causes all classes in framework-connectivity(-t) and
      service-connectivity to be jarjared into android.net.connectivity, but
      still avoids jarjaring classes in com.android.server as before, to keep
      it small.
      For many classes this differs from the original jarjar rule.
      
      Notes on implementation:
      
       - connectivity-jarjar-rules now has a subset
         framework-connectivity-jarjar-rules containing only the rules
         necessary for framework-connectivity. This is necessary because
         framework-connectivity cannot depend on rules generated based on
         service-connectivity, as there would be a dependency cycle
         (service-connectivity depends on framework-connectivity); Soong even
         crashes with a stack overflow.
      
       - framework-wifi.stubs.module_lib is added to
         framework-connectivity-pre-jarjar as it is necessary to build it (it
         is already in impl_only_libs in the defaults).
         It is unclear why framework-connectivity-pre-jarjar could build
         before that (possibly because it was only used as "lib" ?)
      
       - Fix package-private visibility; for example NattSocketKeepalive,
         TcpSocketKeepalive are not API so should be jarjared, but are used
         by ConnectivityManager which is not jarjared, so they are not in the
         same package after the change. Package-private members in the
         former 2 need to be public to be accessible. Changes in this commit
         are all that is needed, as demonstrated by followup commits that move
         the classes to a different package without further changes, and that
         enforce that no class in an API package gets jarjared.
      
       - framework-connectivity-internal-test-defaults is separated from
         framework-connectivity-test-defaults, for unit tests that need to
         access internal jarjared classes. Such tests need to use the jarjar
         rules themselves too, so this is only appropriate for connectivity
         internal unit tests.
      
      Test: atest ConnectivityCoverageTests CtsNetTestCases
      Bug: 217129444
      Change-Id: Ib1bd939b71c0171d945fc01b96195d2f620ff13b
      e55a88d3
    • Paul Hu's avatar
      Add more NsdService tests · 64f36446
      Paul Hu authored
      This is a no-op and test only change. Test the scenarios below:
      - Registration service successful and failed.
      - Discovery service failed.
      - Resolution service failed.
      - Getting an address failed.
      
      Bug: 236788977
      Test: atest FrameworksNetTests
      Change-Id: I533d0be2abfa5c1832a060b4b2d4d1dd382c5b71
      64f36446
    • Aaron Huang's avatar
      Merge "Fix style errors in NetworkStats" · b84de741
      Aaron Huang authored
      b84de741
    • Aaron Huang's avatar
      Fix style errors in NetworkStats · f7c1042a
      Aaron Huang authored
      Test: build
      Change-Id: I4366480e7a71004612d775bfa54744cc74c1fd7b
      f7c1042a
    • Aaron Huang's avatar
  4. Jul 19, 2022
  5. Jul 18, 2022
  6. Jul 16, 2022
    • Maciej Żenczykowski's avatar
      further bpf_existence_test code simplifications/clarifications · e9e77418
      Maciej Żenczykowski authored
      
      (mainly driven by the desire to make it clear this
      is about *current* mainline state and not at-T-launch state
      of things)
      
      Test: TreeHugger
      Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
      Change-Id: I928f91704f78205ffe44611a3d3abe383c4e560b
      e9e77418
    • Maciej Żenczykowski's avatar
      enable btf for offload.o & test.o · 07d3013b
      Maciej Żenczykowski authored
      
      The objdump -x visible changes between old and new versions of the
      mainline shipped .o files are really very minimal: just the inclusion
      of a new .BTF section and changes/removals of some 'l' entries from
      the symbol table.  However, it turns out a change to symbol ordering
      is incompatible with BpfLoader <v0.10 which doesn't know to skip
      non-function symbols, and as such enabling btf requires a little
      bit of gymnastics.
      
      After:
        $ adbz shell ls -l /apex/com.android.tethering/etc/bpf/*.o
        -rw-r--r-- 1 system system 118352 1969-12-31 16:00 /apex/com.android.tethering/etc/bpf/offload.o
        -rw-r--r-- 1 system system 123424 1969-12-31 16:00 /apex/com.android.tethering/etc/bpf/offload@btf.o
        -rw-r--r-- 1 system system   2232 1969-12-31 16:00 /apex/com.android.tethering/etc/bpf/test.o
        -rw-r--r-- 1 system system   6376 1969-12-31 16:00 /apex/com.android.tethering/etc/bpf/test@btf.o
      
      $ adbz shell logcat -d | egrep offload.*[.]o
      07-15 13:10:43.358     0     0 D LibBpfLoader: Loading critical for tethering ELF object /apex/com.android.tethering/etc/bpf/offload.o with license Apache 2.0
      07-15 13:10:43.359     0     0 I LibBpfLoader: BpfLoader version 0x00019 ignoring ELF object /apex/com.android.tethering/etc/bpf/offload.o with max ver 0x00019
      07-15 13:10:43.359     0     0 I bpfloader: Loaded object: /apex/com.android.tethering/etc/bpf/offload.o
      07-15 13:10:43.374     0     0 D LibBpfLoader: Loading critical for tethering ELF object /apex/com.android.tethering/etc/bpf/offload@btf.o with license Apache 2.0
      07-15 13:10:43.375     0     0 I LibBpfLoader: BpfLoader version 0x00019 processing ELF object /apex/com.android.tethering/etc/bpf/offload@btf.o with ver [0x00019,0x10000)
      07-15 13:10:43.452     0     0 D LibBpfLoader: map_fd found at 0 is 6 in /apex/com.android.tethering/etc/bpf/offload@btf.o
      ...
      
      Test: TreeHugger
      Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
      Change-Id: Id658818d1d42763358747523615b7918d312588e
      07d3013b
    • Remi NGUYEN VAN's avatar
  7. Jul 15, 2022
Loading