Skip to content
Snippets Groups Projects
  1. Apr 30, 2020
    • Anton Hansson's avatar
      Fix tethering module lib stub default · dc8e0fc1
      Anton Hansson authored
      It was using the systemapi stub defaults, but should be using the
      module_lib default.
      
      Bug: 144149403
      Test: m
      Change-Id: Iaab154d9d71900284d92d518a086fc1227c00d5c
      dc8e0fc1
    • Junyu Lai's avatar
      Merge changes I38628dad,I2467b647 into rvc-dev · 027c80d2
      Junyu Lai authored
      * changes:
        [SP18.1] add dependency object to OffloadController
        [SP18] Poll network stats in OffloadController to support data warning
      027c80d2
    • Treehugger Robot's avatar
      [SP18.1] add dependency object to OffloadController · 40092b1f
      Treehugger Robot authored
      In order to mock constant in unit test, a dependency object is
      introduced with minimum code change to achieve this.
      
      Test: atest TetheringTests
      Bug: 149467454
      Change-Id: I38628daddcb7be7c74846e78d36dc88f065b97d9
      Merged-In: I38628daddcb7be7c74846e78d36dc88f065b97d9
      (cherry picked from commit 29aee20b)
      40092b1f
    • Junyu Lai's avatar
      [SP18] Poll network stats in OffloadController to support data warning · bf6fa99b
      Junyu Lai authored
      The OEM implemented tether offload does not support
      data warning since the HAL only tells the hardware about data limit
      but not warning. However, to add such interface in HAL needs OEM to
      comply and implement in hardware.
      
      Thus, as a short-term solution, polls network statistics from HAL
      and notify upper layer when it reaches the alert quota set by
      NetworkStatsService.
      
      Note that when CPU is sleeping, the data warning of tethering offload
      will not work since the polling is also suspended.
      
      Test: manual
      Test: atest OffloadControllerTest
      Bug: 149467454
      Change-Id: I2467b64779b74cd5fec73b42fb303584f52cb1cb
      Merged-In: I2467b64779b74cd5fec73b42fb303584f52cb1cb
      (cherry picked from commit 93660e38)
      bf6fa99b
  2. Apr 28, 2020
  3. Apr 27, 2020
    • TreeHugger Robot's avatar
    • Mark Chien's avatar
      Remove Preconditions usage to stop dependecy with non-updatble class · ed50636b
      Mark Chien authored
      Stop depending on Preconditions that is not released on the same cadence
      as the module, and is maintained as part of the framework.
      
      Bug: 148636687
      Test: atest TetheringTests NetworkStackNextTests
      
      Merged-In: Id0dcec44f362f79bc8c046d722635687a7388aa2
      Change-Id: Id0dcec44f362f79bc8c046d722635687a7388aa2
      ed50636b
    • Mark Chien's avatar
      Unbreak tethering for no offload supported devices · 27cdaf67
      Mark Chien authored
      Catch NoSuchElementException to unbreak no offload devices.
      
      To consistent with fetching offload config service, retry fetcheing
      offload control service.
      b/152430668#comment4 assert that the fetch will be retried only
      if the service is installed on the device.
      
      Bug: 155026033
      Test: run TetheringCoverageTests in virtual devices(do not support
      offload)
      
      Merged-In: Ie0a32a9062c722327a27c6de13e3bb8d9588bebb
      Change-Id: Ie0a32a9062c722327a27c6de13e3bb8d9588bebb
      27cdaf67
    • Bill Yi's avatar
      Import translations. DO NOT MERGE · 8a35765b
      Bill Yi authored
      Auto-generated-cl: translation import
      Change-Id: I08496ebb9bad7c95a6e9df43ef57c55a9956c9d8
      8a35765b
  4. Apr 23, 2020
    • Paul Hu's avatar
      [TNU09] Adjust restricted notification · 0439c2d2
      Paul Hu authored
      1. Let restricted notification that can be dismissed.
      2. Only put up restricted notification when any of tethering is
         activating.
      
      Bug: 154214549
      Test: atest TetheringTests
      Change-Id: Ib980aca154036828abdab35e3bb11d42f85ff610
      Merged-In: Ib980aca154036828abdab35e3bb11d42f85ff610
      (cherry picked from commit 2eb66bdb, aosp/1290334)
      0439c2d2
    • Paul Hu's avatar
      Add TetheredClient tests · 86152672
      Paul Hu authored
      Test APIs below:
      getAddresses()
      getMacAddress()
      getTetheringType()
      AddressInfo.getAddress()
      AddressInfo.getHostname()
      AddressInfo.writeToParcel(android.os.Parcel, int)
      
      Bug: 153614365
      Bug: 153613717
      Test: atest TetheringTests
      Change-Id: Ic7cbebe54a38af5b5c4639eb7641a20de6864a26
      Merged-In: Ic7cbebe54a38af5b5c4639eb7641a20de6864a26
      (cherry picked from commit fa882fdb, aosp/1292438)
      86152672
    • Paul Hu's avatar
      Merge "Add TetheringCommonTests" into rvc-dev · 1277763d
      Paul Hu authored
      1277763d
  5. Apr 22, 2020
    • Bill Yi's avatar
      Import translations. DO NOT MERGE · 70521ef0
      Bill Yi authored
      Change-Id: I4b3a8cf8d738bf6f680258f1ebd77d894dc986cd
      Auto-generated-cl: translation import
      70521ef0
    • Paul Hu's avatar
      Add TetheringCommonTests · 1cae88f5
      Paul Hu authored
      Bug: 153614365
      Bug: 153613717
      Test: atest TetheringTests TetheringCoverageTests
      Change-Id: If7c933ec0c72943312cd37bfc66918f10a5504a9
      Merged-In: If7c933ec0c72943312cd37bfc66918f10a5504a9
      (cherry picked from commit f340f6fd, aosp/1290553)
      1cae88f5
    • Mark Chien's avatar
    • Paul Hu's avatar
    • Mark Chien's avatar
      Include NetworkStaticLibTestsLib into tethering coverage test · d0ed7dd8
      Mark Chien authored
      Bug: 148636687
      Test: atest NetworkStaticLibTests
      Test: atest TetheringCoverageTests
      Merged-In: I8cd9dbc9fe163583ff1d016c9262546949105b80
      Change-Id: I8cd9dbc9fe163583ff1d016c9262546949105b80
      d0ed7dd8
    • Paul Hu's avatar
      a7c5d570
    • Paul Hu's avatar
      [TNU08] Remove the "tethering is on" notification · 127ee592
      Paul Hu authored
      All carriers discarded the requirement to put up a standing
      notification when tethering is on. Thus, remove the "tethering
      is on" notification.
      
      Bug: 154438388
      Test: atest TetheringTests
      Change-Id: Ife3915837b6b7b83d3eaaa84b71b6409ff37b71c
      Merged-In: Ife3915837b6b7b83d3eaaa84b71b6409ff37b71c
      (cherry picked from commit 0171c07d05dd2625c6dcfd47977a701ddc2d5d36, aosp/1289107)
      127ee592
    • Treehugger Robot's avatar
      Retry the call that fetches the tethering offload HAL. · 83a814eb
      Treehugger Robot authored
      The CL that moved the initialization of the tethering offload
      config HAL from C++ to Java caused the code not to retry
      fetching the service if it is not ready when tethering is
      started. This is because the C++ version of getService() retries,
      but the Java version only retries if getService(true) is called.
      
      Make the new code retry as well.
      
      b/152430668#comment4 asserts that the fetch will be retried only
      if the service is installed on the device, so the retries should
      be attempted (and thus should not have any startup time impact)
      on devices that do not support tethering offload.
      
      Bug: 152430668
      Test: builds, boots, tethering offload works
      Merged-In: I093f127d90b2aa1b13eb0748378a24726d419472
      Change-Id: I093f127d90b2aa1b13eb0748378a24726d419472
      83a814eb
    • Paul Hu's avatar
      [TNU07] Remove unused resources · ef341599
      Paul Hu authored
      Some strings are not used, so just remove them.
      
      Bug: 154445061
      Test: atest TetheringTests
      Change-Id: Ie67f7f4d0863d58c4c5206e445c1dbdfe3f65f60
      Merged-In: Ie67f7f4d0863d58c4c5206e445c1dbdfe3f65f60
      (cherry picked from commit 59eeedc045aaaa0c7d5b97277d25f64cce254464, aosp/1289100)
      ef341599
  6. Apr 20, 2020
  7. Apr 18, 2020
  8. Apr 17, 2020
    • Chalard Jean's avatar
      [TNU06] Add roaming notification · 4580c832
      Chalard Jean authored
      Warn user of potential data charges if the backhaul is
      cellular and user is roaming.
      
      Bug: 145629001
      Test: atest TetheringTests
      Change-Id: I74b4f87c2f6aad09e05d3f2a779f880396885953
      Merged-In: I74b4f87c2f6aad09e05d3f2a779f880396885953
      (cherry picked from commit 1af69e5b8f339bde5b70886d80960ce22c847245, aosp/1237026)
      4580c832
  9. Apr 16, 2020
    • Paul Hu's avatar
      [TNU05.1] Address aosp/1237036 leftover comments · 5e9c40c0
      Paul Hu authored
      Bug: 147818698
      Test: atest TetheringTests
      Change-Id: Ife738339aeae00d2063fea6918b50204daef24fc
      Merged-In: Ife738339aeae00d2063fea6918b50204daef24fc
      (cherry picked from commit c638ae6436509df092ab8814bb5b64591878229d, aosp/1287133)
      5e9c40c0
    • Mark Chien's avatar
    • Mark Chien's avatar
      Remove sendMessage inside EntitlementManager · 30c0da71
      Mark Chien authored
      EntitlementManager and its callers(Tethering and UpstreamNetworkMonitor)
      run in the same threads.
      
      Bug: 141256482
      Test: atest TetheringTests
      Merged-In: I0a376d28b123eaab2e8d00a98a4719ce983d3bb2
      Change-Id: I0a376d28b123eaab2e8d00a98a4719ce983d3bb2
      30c0da71
    • Paul Hu's avatar
      [TNU05] Add no upstream notification · af6a2a33
      Paul Hu authored
      Reminder user of unavailable tethering status if there is no
      internet access.
      
      Bug: 147818698
      Test: atest TetheringTests
      Change-Id: Ic6557f9f7703337596100cd6a477fd7239217166
      Merged-In: Ic6557f9f7703337596100cd6a477fd7239217166
      (cherry picked from commit ac1b098acc504b60e85b3dcd22941f4e293865ae, aosp/1237036)
      af6a2a33
    • Mark Chien's avatar
      Do not stop IpServer when recieve wifi ap disabling state. · 8c98b3d3
      Mark Chien authored
      This is used to fix the race when quickly OFF/ON wifi tethering.
      When IpServer is started/stopped, there is callback update tethering
      interface status. Before this change, IpServer is stopped when wifi
      ap is disabling. Then the next startTethering may fail in wifi because
      wifi is in disabling state.
      Error pattern: WifiService: Tethering is already active.
      No unitest for this CL but it fixed the CtsTetheringTest flakty rate
      than around 30% to 0 for more than 100 runs.
      
      Bug: 153925821
      Test: atest CtsTetheringTest --iteration 100
      Merged-In: I8b65f621abe20799a3a0d410ba1f06368746ee49
      Change-Id: I8b65f621abe20799a3a0d410ba1f06368746ee49
      8c98b3d3
    • Amit Mahajan's avatar
      DO NOT MERGE Remove references of telephony-stubs. · ee27d552
      Amit Mahajan authored
      Since it's not used for now.
      
      Test: TH
      Bug: 153304048
      Merged-in: I1812818c3d49463c3840a98212bbab58a110359a
      Change-Id: I1812818c3d49463c3840a98212bbab58a110359a
      ee27d552
  10. Apr 14, 2020
    • paulhu's avatar
      Add TetheringCoverageTests · d1ebb1e3
      paulhu authored
      Bug: 148636687
      Test: atest TetheringCoverageTests
            atest TetheringTests
            atest TetheringIntegrationTests
            atest NetworkStackTests
            atest CtsTetheringTest
      Change-Id: I1f2a50f16894b05e988476520ba25baba0b60d88
      d1ebb1e3
    • Paul Hu's avatar
      13113c45
    • Paul Hu's avatar
      Update tethering notification strings · 8fae1ba0
      Paul Hu authored
      Update strings after converged with carrier.
      
      Bug: 145629001
      Bug: 147818698
      Test: atests TetheringTests
      Change-Id: I8ad34e8c93ba1547aa397a8e9c0ecc15286a2b0b
      Merged-In: I8ad34e8c93ba1547aa397a8e9c0ecc15286a2b0b
      (cherry picked from commit d4a1bd7b73991c4197b49a3ff36e7683273ae736, aosp/1284584)
      8fae1ba0
    • Lorenzo Colitti's avatar
      Don't crash when receiving an RTM_DELNEIGH or NUD_FAILED. · 6f532ba3
      Lorenzo Colitti authored
      These events don't have MAC addresses, so the code attempts to
      create an Ipv6ForwardingRule with a null MAC address. This
      crashes when attempting to get the raw MAC address bytes to send
      to netd in the TetherOffloadRuleParcel.
      
      This was not caught by unit tests because the test exercise this
      code path in a way that is not correct (by sending RTM_DELNEIGH
      and NUD_FAILED events with MAC addresses). Fix the unit tests to
      properly pass in null MAC addresses for these events.
      
      Bug: 153697068
      Test: fixed existing tests to be more realistic
      Merged-In: I26d89a81f1c448d9b4809652b079a5f5eace3924
      Change-Id: I26d89a81f1c448d9b4809652b079a5f5eace3924
      6f532ba3
    • markchien's avatar
      Change tethering file structure to respect its package name · 7dc2dcc3
      markchien authored
      Bug: 145099347
      Test: atest TetheringTests
            atest CtsTetheringTest
      Change-Id: I7401c550fbafd17a5ed2d925b5d0e17e358af467
      Merged-In: I7401c550fbafd17a5ed2d925b5d0e17e358af467
      7dc2dcc3
  11. Apr 13, 2020
    • Ashwini Oruganti's avatar
      Tethering: Add an exported flag in manifest · af37b0a7
      Ashwini Oruganti authored
      With b/150232615, we will need an explicit value set for the exported
      flag when intent filters are present, as the default behavior is
      changing for S+. This change adds the value reflecting the previous
      default to the manifest.
      
      Bug: 150232615
      Test: TH
      Change-Id: I25b55378df393cd4fb8932b7ae64f97eb9f1aa8e
      Merged-In: I25b55378df393cd4fb8932b7ae64f97eb9f1aa8e
      (cherry picked from commit 9226d6c835cd57d10a7562f18143dbaae8601b43)
      af37b0a7
    • Jiyong Park's avatar
      Mark some aidl_interface modules as unstable · 6c9c10c9
      Jiyong Park authored
      With b/152655547, all aidl_interface modules are considered as stable
      unless it is explicitly with "unstable: true". This change marks the
      aidl_interface that are not used across updatable module bounraries
      as unstable, so that the build system does not run the API
      dumping/checking on them.
      
      Bug: 152655547
      Test: m
      Change-Id: I1257c66de6dd42b2d32d47ed74cb2878f79d14fb
      6c9c10c9
  12. Apr 10, 2020
  13. Apr 09, 2020
Loading