Skip to content
Snippets Groups Projects
  1. Jun 02, 2020
    • Paul Duffin's avatar
      Switch to standard naming scheme · dfc7fb7f
      Paul Duffin authored
      Removes use of the special framework-modules naming scheme.
      
      Bug: 155164730
      Test: m java
      Exempt-From-Owner-Approval: Build cleanup.
      Change-Id: I3896d7c91e937f503b49f5df011c21ee51219652
      Merged-In: I0c31e2183353dfb5bd49f04f3455cb7b10be6866
      Merged-In: I3b78fcbcacc3df787e171d6eedeef1e51b087615
      (cherry picked from adac7d2c)
      dfc7fb7f
    • Paul Duffin's avatar
      Clean up the visibility rules for framework modules · 2a8d380f
      Paul Duffin authored
      Switching from java_library to java_sdk_library switched the meaning
      of the module name from referring to the implementation library to
      referring to the stubs. This change updates the visibility rules to
      reflect that new meaning.
      
      Visibility rules that were previously set for the java_library have
      been moved to the impl_library_visibility property and the special
      //visibility:override value has been prepended to prevent it from
      inheriting the values from the visibility property.
      
      Visibility rules set for the stubs (via stubs_library_visibility)
      property have been moved to the visibility property.
      
      Bug: 155164730
      Test: m nothing
      Exempt-From-Owner-Approval: Build cleanup
      Change-Id: Icc9bc5a9ef86cf7ba0f15c2b2a4abd596ec9f640
      Merged-In: Icc9bc5a9ef86cf7ba0f15c2b2a4abd596ec9f640
      (cherry picked from a17cf677)
      2a8d380f
    • Treehugger Robot's avatar
  2. Jun 01, 2020
  3. May 29, 2020
  4. May 28, 2020
    • paulhu's avatar
      Use Class#getSimpleName instead of KClass#getSimpleName · 086f2462
      paulhu authored
      KClass#getSimpleName need refer to kotlin-reflect.jar which need
      include it in Andorid.bp. However, it's not necessary to use
      KClass#getSimpleName but use Class#getSimpleName instead.
      
      Test: atest TetheringTests
      Bug: 157527499
      Change-Id: I49bc336a276d30152402eba926cc583bc81e8e5c
      Merged-In: I49bc336a276d30152402eba926cc583bc81e8e5c
      086f2462
    • Paul Duffin's avatar
    • Paul Duffin's avatar
      Switch framework-tethering to use java_sdk_library · 2dae2729
      Paul Duffin authored
      The names of the individual modules do not quite follow the pattern
      that java_sdk_library uses so this temporarily sets the following:
          naming_scheme: "frameworks-modules"
      
      That causes java_sdk_library to use a naming scheme that matches the
      one used by the individual modules of this. It will be cleaned up
      later.
      
      Part of the purpose of the java_sdk_library is to hide the
      implementation code and force users of the library to depend on stubs
      for a well defined API. Ideally, it would allow access to the
      implementation in those cases where it is safe, e.g. from within the
      same APEX, or from tests for the implementation. Unfortunately, due to
      limitations in the build it does not yet have enough information to
      make that decision correctly which means that any code that needs to
      compile against the implementation is broken which would prevent us
      from converting the module to java_sdk_library.
      
      However, the only way to provide the additional information to allow
      the implementation to be correctly exposed is to convert the modules
      to java_sdk_library; a cycle.
      
      In order to break that cycle the java_sdk_library creates a special
      <module>.impl target which is used directly by tests and any other code
      that needs it. Once all the modules have been converted to a
      java_sdk_library then we can resolve the limitations in the build and
      remove the direct references to <module>.impl.
      
      Test: m update-api
      Bug: 155164730
      Merged-In: If5c115f482751f9f4b5f047e9e401a18e36799ef
      Merged-In: Id1c2e848430c49a2da7402244814cd084f5da77c
      Change-Id: Id1c2e848430c49a2da7402244814cd084f5da77c
      2dae2729
    • Treehugger Robot's avatar
    • markchien's avatar
      Extend timeout for requesting tethered interface · 908518d8
      markchien authored
      Extend the timeout to lower the EthernetTetheringTest flaky.
      
      Besides, also explicitly exempt entitlement check in
      EtetherntTetheringTest because it do not test tethering upstream
      currently. Thus, the tests would not be interrupted by entitlement
      check if test SIM is entitlement required.
      
      Bug: 156713866
      Test: TetheringCoverageTests, CtsTehteringTest
      
      Change-Id: I45e8e8d737486def9d0de8943ec7f09ca0942a0b
      908518d8
  5. May 27, 2020
    • markchien's avatar
      Tethering: ensure downstream prefix do not conflict with upstream · c9daba32
      markchien authored
      - Add New class PrivateAddressCoordinator to coordinate the private
        address conflict problem.
      - Downstream prefix would be random in 192.168.0.0/24 ~
        192.168.255.0/24.
      - If new upstream prefix is conflict with existing downstream prefix,
        downstream would be kicked out and it would request a new one.
      - The last conflict upstream prefixes would be blacklist. Avoid to
      select downstream prefix which is conflict with prefixes in blacklist.
      
      Bug: 130879722
      Test: -build, flash, boot
            -atest TetheringTests
      
      Change-Id: Ib45b87bcd9eeb5da03fb7ec90b1af9ca53998cf5
      c9daba32
  6. May 26, 2020
  7. May 25, 2020
  8. May 24, 2020
    • markchien's avatar
      Adjust TTL for ipv6 tethering · d63c4f35
      markchien authored
      If upstream is cellular, set the TTL in Router Advertisements to
      "network-set TTL - 1" for carrier requirement. For other non-cellular
      upstream, set TTL as "network-set TTL + 1" to preventing arbitrary
      distinction between tethered and untethered traffic.
      
      Bug: 154776299
      Test: atest TetheringTests
      
      Change-Id: I7f2696a642f96c6aafb5613b980bf5bcdd08bbda
      d63c4f35
  9. May 20, 2020
    • markchien's avatar
      Fix TetheringServiceTest test WRITE_SETTINGS permission failure · f4394e83
      markchien authored
      AdoptShellPermissionIdentity can not pass permission check by
      Settings#checkAndNoteWriteSettingsOperation. It would compare the caller
      uid and its package name. See error below:
      1. java.lang.SecurityException:
      Specified package com.android.shell under uid 10239 but it is really 2000
      2. java.lang.SecurityException:
      uid 10245 does not have android.permission.UPDATE_APP_OPS_STATS.
      
      Override the method and test if caller hold WRITE_SETTINGS directly.
      
      Bug: 154869719
      Test: TetheringTests, TetheringCoverageTests, NetworkStackNextTests,
      NetworkStackCoverageTests
      
      Change-Id: I2a60c4d66ef30028f9663159f85464ea815248e2
      f4394e83
  10. May 19, 2020
  11. May 14, 2020
  12. May 13, 2020
  13. May 12, 2020
  14. May 11, 2020
    • Jooyung Han's avatar
      InProcessTethering: set min_sdk_version · 482af2e2
      Jooyung Han authored
      Modules contributing mainline modules (APK/APEX) should set
      min_sdk_version as well as apex_available.
      
      InProcessTethering is a part of com.android.tethering.inprocess,
      therefore min_sdk_version is set.
      
      Bug: 145796956
      Bug: 150999716
      Test: m
      Change-Id: I655211e0b9aa4bd7cb3718b6f567f0aa1a0176a5
      482af2e2
  15. May 08, 2020
Loading