Skip to content
Snippets Groups Projects
Select Git revision
  • fourteen-qpr1
  • fifteen-qpr2
  • fourteen default
  • fifteen-qpr0
  • fifteen-qpr1
  • thirteen
  • staging/fourteen
  • twelve
  • staging/thirteen
  • staging/twelve
10 results
Search by author
  • Any Author
  • Adithya R Adithya R adithya2306
  • Ali Ali ali-nasiri-80
  • Dhina17 Dhina17 Dhina17
  • electimon electimon electimon
  • Erfan Abdi Erfan Abdi erfanoabdi
  • Farzin Kazemzadeh Farzin Kazemzadeh itisFarzin
  • LMO BuildBot LMO BuildBot lmo-buildbot
  • LMO GerritBot LMO GerritBot lmo-gerritbot
  • Mohammad Hasan Keramat J Mohammad Hasan Keramat J ikeramat
  • Nick Nick nift4
10 authors
  1. Oct 13, 2023
    • Anton Kulakov's avatar
      Revert "Simplify addRoutesToLocalNetwork calls" · 316346be
      Anton Kulakov authored 
      Revert submission 2777667

Reason for revert: DroidMonitor-triggered revert due to breakage, bug b/305187495

Reverted changes: /q/submissionid:2777667

Bug: 305187495

Change-Id: I516d40b20d775e9c61b2f825bc094329d016d0c3
      316346be
    • Chalard Jean's avatar
      Simplify addRoutesToLocalNetwork calls · cf70df3e
      Chalard Jean authored 
      There are only three calls to this method, and two of them
are with a list of 1 address which means it's simpler inlined.

The last call will be replaced with calls to RouteController
in a followup, meaning we addRoutesToLocalNetwork can be removed.

Test: RouterAdvertisementDaemonTest
      NetdUtilsTest
Change-Id: I3b6ee1db40f09954b336321000735a66306bf000
      cf70df3e
  3. Oct 12, 2023
  5. Oct 08, 2023
  7. Oct 06, 2023
  9. Oct 04, 2023
  11. Oct 02, 2023
    • Maciej Żenczykowski's avatar
      BpfClassic.h - more helpers · 73df7414
      Maciej Żenczykowski authored 
      
Test: TreeHugger
Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
Change-Id: Ie0eb8895c2d887b71ba886735ad106c1118ebeac
      73df7414
    • Maciej Żenczykowski's avatar
      rename BPF2_REJECT_IF_ANY_BITS_SET -> BPF2_REJECT_IF_ANY_MASKED_BITS_SET · b900201f
      Maciej Żenczykowski authored 
      
Test: TreeHugger
Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
Change-Id: I54a189f0f7b73917aa3fd049fe2eca387aaca250
      b900201f
    • Motomu Utsumi's avatar
      Add method to read trunk stable flag · b0f48902
      Motomu Utsumi authored 
      aconfig soong modules should be used to read the trunk stable flag.
However they are not available in the mainline branch.
So this CL adds the method to check if the trunk stable flag is enabled
or not by directly reading from DeviceConfig.
It's expected that this does not work correctly if flag value is not
stored in the DeviceConfig.
But for the time being, this method can be used to keep development.
Once the mainline branch supports the aconfig soong modules, method
added by this CL must be removed and java_aconfig_library should be
used instead.

Test: adb shell device_config put android_core_networking \
Test: com.android.net.flags.test_feature true
Test: Compares the value from java_aconfig_library and DeviceConfigUtils
Change-Id: I8e35b33a3201192e940e88f96aad3b2b6685b046
      b0f48902
  13. Sep 29, 2023
    • Chalard Jean's avatar
      Address comments on aosp/2765367 · 2aa44125
      Chalard Jean authored 
      Test: comment-only change
Change-Id: I788f6e9f5fdd913d4c5077b6bb82c19664d3cd3f
      2aa44125
    • Xiao Ma's avatar
      Exclude testGetNeighborsQuery from NetworkStackCoverageTests. · 998f6b0e
      Xiao Ma authored 
      sepolicy gates RTM_GETNEIGH{TBL} with a new permission nlmsg_getneigh
and block access from untrusted_apps, but NetworkStackCoverageTests
uses the same UID with NetworkStack module, so it still has the
permission to send RTM_GETNEIGH(context: u:r:network_stack:s0<00>),
which causes the test always fails. Add the same assumeFalse check
for tests with network_stack context.

Bug: 283346574
Test: atest NetworkStackCoverageTests
Change-Id: Iaf652841bb9868783c924aa22fdf0c4f07e1e391
      998f6b0e
    • Maciej Żenczykowski's avatar
      reverse BpfMap & BpfMapRO inheritence to make sense · 7e2f53e7
      Maciej Żenczykowski authored 
      
Bug: 235590615
Bug: 235907076
Bug: 286003437
Test: TreeHugger, m droid gpuservice_unittest libtimeinstate_test bpf_benchmark bpf_module_test libbpf_load_test && mma
Signed-off-by: default avatarMaciej Żenczykowski <maze@google.com>
Change-Id: I020a898fe8b257040a100f146654d4a04b19f843
      7e2f53e7
  15. Sep 28, 2023
  17. Sep 27, 2023
    • Motomu Utsumi's avatar
      Remove defaultEnabled arg from isNetworkStackFeatureEnabled · 2359e7b5
      Motomu Utsumi authored 
      Test: NetworkStaticLibsTests
Bug: 279108992
Change-Id: Id5409158fd720efc92e1b39678e636a8a7d5a0a5
      2359e7b5
    • Motomu Utsumi's avatar
      Update the logic of isFeatureEnabled and isFeatureNotChickenedOut · ed4e7ec9
      Motomu Utsumi authored 
      If the flag value is unset or 0, isFeatureEnabled return false and
isFeatureNotChickenedOut return true.
If the flag value is -1 (force disable), both return false.
If the flag value is other values, both query the package version and
return `flagValue <= packageVersion`

Now the only difference is a default behavior when the flag is not set
or 0.
So isFeatureEnabled and isFeatureNotChickenedOut can use the same flag.

This CL also fixes the issue in rollback.
Before this CL, isFeatureNotChickenedOut did not check the module
version and could have a issue if there is a rollback.

Test: NetworkStaticLibsTests
Bug: 279108992
Change-Id: I12d6ebadff3aee7b7c614aca4eb0a34ef0db9857
      ed4e7ec9
    • Motomu Utsumi's avatar
      Remove lint-baseline in staticlibs · 195a30f0
      Motomu Utsumi authored 
      Bug: 300384860
Test: TH
Change-Id: Ic26efebc24b3f7030b6ff66579fc0f5e5d019d5f
      195a30f0
  19. Sep 21, 2023
  21. Sep 19, 2023
  23. Sep 06, 2023
  25. Sep 05, 2023
    • Motomu Utsumi's avatar
      Rename to isNetworkStackFeatureEnabled · e323c1db
      Motomu Utsumi authored 
      DeviceConfigUtils had isFeatureEnabled for NetworkStack and Tethering
which were confusing since the difference was only the arguments.
This CL renames isFeatureEnabled for NetworkStack module to
isNetworkStackFeatureEnabled to avoid confusion.

This CL also removes unnecessary arguments.

Bug: 279108992
Test: m
Change-Id: I523b98bd3754c209c64ce7d1513b5afcb36599b9
      e323c1db
    • Motomu Utsumi's avatar
      Remove unnecessary arguments from isTetheringFeatureEnabled · 6a222071
      Motomu Utsumi authored 
      Test: m
Bug: 279108992
Change-Id: Iadc1b4665c364bf754ed32e7bb53b78e555ed457
      6a222071
  27. Aug 29, 2023
    • Junyu Lai's avatar
      Make structs in StructTest accessible from Struct · e2eff036
      Junyu Lai authored 
      After link Struct statically into framework-connectivity,
the structs in StructTest are no longer accessible from Struct
because Struct is loaded by bootclasspath classloader.
Make classes and members public for accessing from Struct.

Test: atest ConnectivityCoverageTests:android.net.connectivity.com.android.net.module.util.StructTest
Bug: 297836825
Change-Id: I3b1f466f10247306c84d6cac0d7402353770fac4
      e2eff036
  29. Aug 28, 2023
  31. Aug 24, 2023
  33. Aug 23, 2023
  35. Aug 22, 2023
    • Motomu Utsumi's avatar
      Add libnetd_utils_headers cc_library_headers · 68cd7313
      Motomu Utsumi authored 
      There is a module that specifies libnetdutils/include from include_dirs
which is not recommended.
Using the cc_library_headers makes it easy to move
frameworks/libs/net to packages/modules/Connectivity.

Bug: 296014682
Test: m

Change-Id: Ia52ede9787009102ebf626fcb3b337511b0a809f
      68cd7313
  37. Aug 21, 2023