Skip to content
Snippets Groups Projects
  1. Feb 08, 2024
  2. Feb 07, 2024
  3. Feb 06, 2024
  4. Feb 05, 2024
  5. Feb 04, 2024
  6. Feb 03, 2024
  7. Feb 02, 2024
  8. Feb 01, 2024
    • Kangping Dong's avatar
    • Kangping Dong's avatar
      [Thread] restarts when ot-daemon crashes · 3deddc7b
      Kangping Dong authored
      This commit handles the ot-daemon crash by automatically restarting it
      and rejoin the network if ever joined.
      
      This also fixes the address not deleted issue in TunInterfaceContorller.
      
      Bug: 321540728
      Bug: 309792480
      Change-Id: I3ed466eb70818974a1e57f01456363bdf82915d5
      3deddc7b
    • Remi NGUYEN VAN's avatar
    • Remi NGUYEN VAN's avatar
      Initialize serviceCache before first use · 578e0dc6
      Remi NGUYEN VAN authored
      The comment that "The very first posted task is to initialize the
      service cache, so it will be always set in other tasks running on
      the handler" did not consider that if the looper was provided by the
      caller, it is possible for other tasks to run on it before the
      serviceCache is initialized. In particular, if the caller calls
      registerListener on the looper thread right after calling the
      constructor, this would be executed before the posted initialization
      task.
      
      In practice this does not happen as MdnsDiscoveryManager is created in
      the NsdService constructor, and any usage of it is on messages posted to
      the NsdService handler thread after the constructor has been called; so
      the service cache initialization does happen before any other
      MdnsDiscoveryManager task.
      
      As this is error-prone, just initialize the service cache before first
      use on the handler thread, as it is only used for
      createServiceTypeClient, which runs on the handler thread.
      
      Test: atest
      Change-Id: Ie341bb71ef327dceb4f0aa6fc2d241d6e9cbb900
      578e0dc6
    • Remi NGUYEN VAN's avatar
    • Junyu Lai's avatar
      Rename check*Permission* to has*Permission · 71b51538
      Junyu Lai authored
      The check*Permission methods are a bit error-prone because people
      can forget to check the return value and expect that they behave
      like the enforce* methods. This was pointed out before in some bugs.
      
      This change adds @CheckResult annotation to enforce linter warning
      and rename methods accordingly.
      
      Test: TH
      Fix: 279691948
      Change-Id: Ibb0df6540fe0ed40289bb190b790130daaa2f763
      71b51538
Loading