Skip to content
Snippets Groups Projects
Forked from Dhina17 / platform_frameworks_base
978 commits behind the upstream repository.
  • Caitlin Shkuratov's avatar
    b0f88b34
    [SB][Chips] Update call chip to use icon from notification. · b0f88b34
    Caitlin Shkuratov authored
    This changes updates the ongoing phone call chip to use the
    `Notification.getSmallIcon()` as the icon inside the chip, instead of
    hard-coding it to be a phone icon.
    
    This includes:
    1) For each notification, creating a new `statusBarChipIcon` in addition
       to creating the other location-specific icons (status bar, shelf,
       aod)
    2) Updating the paddings in the chip layout, since the notification icon
       is required to come with its own padding
    
    Bug: 354930838
    Flag: NONE required for imminent release
    
    Test: Start call without timer -> verify chip has icon only, icon is
    centered
    Test: Start ongoing call -> verify chip has icon and time
    Test: Chip UI at various font and display sizes
    Test: Theme changes (chip text updates to both white and black
    correctly)
    Test: Accessibility for chip
    
    Test: Enable com.android.systemui.status_bar_screen_sharing_chips flag
    -> verify call and screen chips still work okay (the paddings are off
    but general functionality still works)
    
    Test: atest OngoingCallControllerTest
    
    Change-Id: Id7ad51ad3a590e6556987cba4f2639870c422f92
    Merged-In: Id7ad51ad3a590e6556987cba4f2639870c422f92
    b0f88b34
    History
    [SB][Chips] Update call chip to use icon from notification.
    Caitlin Shkuratov authored
    This changes updates the ongoing phone call chip to use the
    `Notification.getSmallIcon()` as the icon inside the chip, instead of
    hard-coding it to be a phone icon.
    
    This includes:
    1) For each notification, creating a new `statusBarChipIcon` in addition
       to creating the other location-specific icons (status bar, shelf,
       aod)
    2) Updating the paddings in the chip layout, since the notification icon
       is required to come with its own padding
    
    Bug: 354930838
    Flag: NONE required for imminent release
    
    Test: Start call without timer -> verify chip has icon only, icon is
    centered
    Test: Start ongoing call -> verify chip has icon and time
    Test: Chip UI at various font and display sizes
    Test: Theme changes (chip text updates to both white and black
    correctly)
    Test: Accessibility for chip
    
    Test: Enable com.android.systemui.status_bar_screen_sharing_chips flag
    -> verify call and screen chips still work okay (the paddings are off
    but general functionality still works)
    
    Test: atest OngoingCallControllerTest
    
    Change-Id: Id7ad51ad3a590e6556987cba4f2639870c422f92
    Merged-In: Id7ad51ad3a590e6556987cba4f2639870c422f92
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
dimens.xml 108.72 KiB