Skip to content
Snippets Groups Projects
Forked from Dhina17 / platform_frameworks_base
Source project has a limited visibility.
  • Inseob Kim's avatar
    8541b878
    Use no_full_install: true instead of installable: false · 8541b878
    Inseob Kim authored
    So far, we have used `instalable: false` to avoid collision with the
    other modules that are installed to the same path. A typical example was
    <foo> and <foo>.microdroid. The latter is a modified version of the
    former for the inclusion of the microdroid image. They however both have
    the same instalation path (ex: system/bin) and stem (ex: foo) so that we
    can reference them using the same path regardless of whether we are in
    Android or microdroid.
    
    However, the use of `installable: false` for the purpose is actually
    incorrect, because `installable: false` also means, obviously, "this
    module shouldn't be installed". The only reason this incorrect way has
    worked is simply because packaging modules (ex: android_filesystem)
    didn't respect the property when gathering the modules.
    
    As packaging modules are now fixed to respect `installable: false`, we
    need a correct way of avoiding the collision. `no_full_install: true` is
    it.
    
    If a module has this property set to true, it is never installed to the
    full instal path like out/target/product/<partition>/... It can be
    installed only via packaging modules.
    
    Bug: 335369205
    Bug: 337993945
    Test: m droid aosp_cf_system_x86_64
    Change-Id: If9c053968bde39c3eb3b852f1df1d475161bd846
    8541b878
    History
    Use no_full_install: true instead of installable: false
    Inseob Kim authored
    So far, we have used `instalable: false` to avoid collision with the
    other modules that are installed to the same path. A typical example was
    <foo> and <foo>.microdroid. The latter is a modified version of the
    former for the inclusion of the microdroid image. They however both have
    the same instalation path (ex: system/bin) and stem (ex: foo) so that we
    can reference them using the same path regardless of whether we are in
    Android or microdroid.
    
    However, the use of `installable: false` for the purpose is actually
    incorrect, because `installable: false` also means, obviously, "this
    module shouldn't be installed". The only reason this incorrect way has
    worked is simply because packaging modules (ex: android_filesystem)
    didn't respect the property when gathering the modules.
    
    As packaging modules are now fixed to respect `installable: false`, we
    need a correct way of avoiding the collision. `no_full_install: true` is
    it.
    
    If a module has this property set to true, it is never installed to the
    full instal path like out/target/product/<partition>/... It can be
    installed only via packaging modules.
    
    Bug: 335369205
    Bug: 337993945
    Test: m droid aosp_cf_system_x86_64
    Change-Id: If9c053968bde39c3eb3b852f1df1d475161bd846
Code owners
Assign users and groups as approvers for specific file changes. Learn more.