Skip to content
Snippets Groups Projects
Forked from Dhina17 / platform_frameworks_base
Source project has a limited visibility.
  • art-benchmark-service's avatar
    5cbc582b
    Update boot image and system server profiles [M46C41P62S0PP] · 5cbc582b
    art-benchmark-service authored
    Bug: 254051423
    Bug: 324079793
    
    Test: go/art-benchmark?p=BootImageProfileId:38926&f=CandidateName:in:38933
    
    = Perf stats =
    (lower is better)
    
    Regular update to the boot image profiles which considers the latest changes in the ART module code instead of depending on the released mainline trains only. Benchmark shows a tiny improvement in App's startup time and Anon RSS+Swap and good improvement in system memory PSS and Private-dirty and almost no impact on boot Time, with a good reduction in code size.
    
                 Avg % [Confidence interval min-max %]
    App Startup:           -0.44 [-2.79, 1.9]
    App Anon RSS + Swap:   -0.83 [-1.92, 0.25]
    Memory(PSS):           -1.4 [-4.28, 1.48]
    Memory(Private-dirty): -4.48 [-13.31, 4.34]
    Boot time:              0.47 [-0.68, 1.62]
    Code size:             -0.79MB (-0.92%)
    
    Ignore-AOSP-First: Boot image profiles
    BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
    
    =Generation Strategy=
    
    method_threshold: 0.46
    image_class_threshold: 0.41
    preloaded_classes_threshold: 0.62
    priority_packages_thresholds {
      key: "service-appsearch.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "service-appsearch.jar.prof:METHOD:android"
      value: 0.032857142
    }
    priority_packages_thresholds {
      key: "service-art.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "service-art.jar.prof:METHOD:android"
      value: 0.032857142
    }
    priority_packages_thresholds {
      key: "service-connectivity.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "service-connectivity.jar.prof:METHOD:android"
      value: 0.032857142
    }
    priority_packages_thresholds {
      key: "service-wifi.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "service-wifi.jar.prof:METHOD:android"
      value: 0.032857142
    }
    priority_packages_thresholds {
      key: "services.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "services.jar.prof:METHOD:android"
      value: 0.032857142
    }
    
    =Profile stats=
    
    Data info:
    - total aggregations: 2263
    - number of (device types, builds): 169
    
    File boot-image-profile.txt
      - hot methods: 1427 added, 1398 removed
      - methods: 1427 added, 1398 removed
      - classes: 113 added, 215 removed
      - totals now: 32625 hot methods, 32625 methods, 17753 classes
      - totals before: 32596 hot methods, 32596 methods, 17855 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 684, 825, 2, 64, 21052, 10391
        com.android, 65, 89, 14, 21, 2342, 3504
        java, 590, 420, 86, 115, 7239, 2112
        android.view, 171, 223, 2, 8, 3415, 1140
        android.hardware, 2, 12, 0, 5, 484, 878
        android.animation, 59, 59, 0, 0, 413, 89
        android.app, 44, 85, 0, 15, 2936, 1178
        android.content, 56, 57, 0, 3, 1916, 641
        android.graphics, 65, 69, 0, 0, 1975, 371
        android.icu, 43, 43, 0, 0, 2048, 1485
        android.media, 3, 3, 0, 0, 792, 633
        android.net, 8, 8, 0, 6, 252, 222
        android.widget, 53, 53, 0, 0, 1404, 443
    
    File preloaded-classes
      - hot methods: 0 added, 0 removed
      - methods: 0 added, 0 removed
      - classes: 120 added, 214 removed
      - totals now: 0 hot methods, 0 methods, 17655 classes
      - totals before: 0 hot methods, 0 methods, 17749 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 0, 0, 14, 59, 0, 10339
        com.android, 0, 0, 15, 19, 0, 3480
        java, 0, 0, 80, 117, 0, 2098
        android.view, 0, 0, 1, 4, 0, 1130
        android.hardware, 0, 0, 3, 4, 0, 877
        android.app, 0, 0, 1, 17, 0, 1173
        android.content, 0, 0, 1, 3, 0, 637
        android.media, 0, 0, 0, 2, 0, 627
        android.net, 0, 0, 0, 6, 0, 222
    
    File boot-image-profile.txt
      - hot methods: 723 added, 890 removed
      - methods: 723 added, 890 removed
      - classes: 2 added, 80 removed
      - totals now: 22497 hot methods, 22497 methods, 14542 classes
      - totals before: 22664 hot methods, 22664 methods, 14620 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 683, 824, 2, 64, 20988, 10360
        com.android, 40, 66, 0, 14, 1412, 3095
        java, 0, 0, 0, 1, 2, 115
        android.view, 171, 223, 2, 8, 3415, 1140
        android.hardware, 2, 12, 0, 5, 484, 878
        android.animation, 59, 59, 0, 0, 413, 89
        android.app, 44, 85, 0, 15, 2936, 1178
        android.content, 56, 57, 0, 3, 1916, 641
        android.graphics, 65, 69, 0, 0, 1975, 371
        android.icu, 43, 43, 0, 0, 2048, 1485
        android.media, 3, 3, 0, 0, 792, 633
        android.net, 8, 8, 0, 6, 252, 222
        android.widget, 53, 53, 0, 0, 1404, 443
    
    File preloaded-classes
      - hot methods: 0 added, 0 removed
      - methods: 0 added, 0 removed
      - classes: 15 added, 72 removed
      - totals now: 0 hot methods, 0 methods, 14465 classes
      - totals before: 0 hot methods, 0 methods, 14522 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 0, 0, 14, 59, 0, 10308
        com.android, 0, 0, 1, 11, 0, 3072
        java, 0, 0, 0, 1, 0, 115
        android.view, 0, 0, 1, 4, 0, 1130
        android.hardware, 0, 0, 3, 4, 0, 877
        android.app, 0, 0, 1, 17, 0, 1173
        android.content, 0, 0, 1, 3, 0, 637
        android.media, 0, 0, 0, 2, 0, 627
        android.net, 0, 0, 0, 6, 0, 222
    
    File art-profile
      - hot methods: 2157 added, 4848 removed
      - methods: 2157 added, 4848 removed
      - classes: 0 added, 1547 removed
      - totals now: 9060 hot methods, 9060 methods, 57 classes
      - totals before: 11751 hot methods, 11751 methods, 1604 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 5, 24, 0, 22, 47, 0
        com.android, 2152, 4824, 0, 1492, 9013, 56
        android.hardware, 4, 12, 0, 8, 42, 0
        android.app, 0, 0, 0, 2, 0, 0
        android.content, 0, 1, 0, 4, 1, 0
        android.net, 1, 7, 0, 3, 4, 0
    
    InternalReferenceRawProfileId: 38926
    InternalReferenceCandidateProfileId: 38933
    
    Test: build & benchmark
    (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b6a26a57e65e2f869c35a54fa3b91e083199dc8)
    Merged-In: Icb1d1464ad947837eeb679258af67bc4f0e9ba98
    Change-Id: Icb1d1464ad947837eeb679258af67bc4f0e9ba98
    
    NOTE FOR REVIEWERS - errors occurred while applying the patch.
    PLEASE REVIEW CAREFULLY.
    Errors:
    Error applying patch in boot/boot-image-profile.txt, hunk HunkHeader[124,19->124,19]: Hunk cannot be applied
    Error applying patch in boot/preloaded-classes, hunk HunkHeader[211,7->212,6]: Hunk cannot be applied
    Error applying patch in config/boot-image-profile.txt, hunk HunkHeader[124,19->124,19]: Hunk cannot be applied
    Error applying patch in config/preloaded-classes, hunk HunkHeader[211,7->212,6]: Hunk cannot be applied
    Error applying patch in services/art-profile, hunk HunkHeader[13,7->13,6]: Hunk cannot be applied
    
    Original patch:
     From 4b6a26a5 Mon Sep 17 00:00:00 2001
    From: art-benchmark-service <art-benchmark-service@google.com>
    Date: Fri, 22 Mar 2024 09:25:24 -0700
    Subject: [PATCH] Update boot image and system server profiles [M46C41P62S0PP]
    
    Bug: 254051423
    Bug: 324079793
    
    Test: go/art-benchmark?p=BootImageProfileId:38926&f=CandidateName:in:38933
    
    = Perf stats =
    (lower is better)
    
    Regular update to the boot image profiles which considers the latest changes in the ART module code instead of depending on the released mainline trains only. Benchmark shows a tiny improvement in App's startup time and Anon RSS+Swap and good improvement in system memory PSS and Private-dirty and almost no impact on boot Time, with a good reduction in code size.
    
                 Avg % [Confidence interval min-max %]
    App Startup:           -0.44 [-2.79, 1.9]
    App Anon RSS + Swap:   -0.83 [-1.92, 0.25]
    Memory(PSS):           -1.4 [-4.28, 1.48]
    Memory(Private-dirty): -4.48 [-13.31, 4.34]
    Boot time:              0.47 [-0.68, 1.62]
    C
    [[[Original patch trimmed due to size. Decoded string size: 6329. Decoded string SHA1: 1745d06a463192644cf1206f5ecdb8152786d3ff.]]]
    
    Change-Id: I4c2c63c3361c206b3160901fa2fff3e03dcdde5d
    5cbc582b
    History
    Update boot image and system server profiles [M46C41P62S0PP]
    art-benchmark-service authored
    Bug: 254051423
    Bug: 324079793
    
    Test: go/art-benchmark?p=BootImageProfileId:38926&f=CandidateName:in:38933
    
    = Perf stats =
    (lower is better)
    
    Regular update to the boot image profiles which considers the latest changes in the ART module code instead of depending on the released mainline trains only. Benchmark shows a tiny improvement in App's startup time and Anon RSS+Swap and good improvement in system memory PSS and Private-dirty and almost no impact on boot Time, with a good reduction in code size.
    
                 Avg % [Confidence interval min-max %]
    App Startup:           -0.44 [-2.79, 1.9]
    App Anon RSS + Swap:   -0.83 [-1.92, 0.25]
    Memory(PSS):           -1.4 [-4.28, 1.48]
    Memory(Private-dirty): -4.48 [-13.31, 4.34]
    Boot time:              0.47 [-0.68, 1.62]
    Code size:             -0.79MB (-0.92%)
    
    Ignore-AOSP-First: Boot image profiles
    BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
    
    =Generation Strategy=
    
    method_threshold: 0.46
    image_class_threshold: 0.41
    preloaded_classes_threshold: 0.62
    priority_packages_thresholds {
      key: "service-appsearch.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "service-appsearch.jar.prof:METHOD:android"
      value: 0.032857142
    }
    priority_packages_thresholds {
      key: "service-art.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "service-art.jar.prof:METHOD:android"
      value: 0.032857142
    }
    priority_packages_thresholds {
      key: "service-connectivity.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "service-connectivity.jar.prof:METHOD:android"
      value: 0.032857142
    }
    priority_packages_thresholds {
      key: "service-wifi.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "service-wifi.jar.prof:METHOD:android"
      value: 0.032857142
    }
    priority_packages_thresholds {
      key: "services.jar.prof:CLASS:android"
      value: 0.029285714
    }
    priority_packages_thresholds {
      key: "services.jar.prof:METHOD:android"
      value: 0.032857142
    }
    
    =Profile stats=
    
    Data info:
    - total aggregations: 2263
    - number of (device types, builds): 169
    
    File boot-image-profile.txt
      - hot methods: 1427 added, 1398 removed
      - methods: 1427 added, 1398 removed
      - classes: 113 added, 215 removed
      - totals now: 32625 hot methods, 32625 methods, 17753 classes
      - totals before: 32596 hot methods, 32596 methods, 17855 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 684, 825, 2, 64, 21052, 10391
        com.android, 65, 89, 14, 21, 2342, 3504
        java, 590, 420, 86, 115, 7239, 2112
        android.view, 171, 223, 2, 8, 3415, 1140
        android.hardware, 2, 12, 0, 5, 484, 878
        android.animation, 59, 59, 0, 0, 413, 89
        android.app, 44, 85, 0, 15, 2936, 1178
        android.content, 56, 57, 0, 3, 1916, 641
        android.graphics, 65, 69, 0, 0, 1975, 371
        android.icu, 43, 43, 0, 0, 2048, 1485
        android.media, 3, 3, 0, 0, 792, 633
        android.net, 8, 8, 0, 6, 252, 222
        android.widget, 53, 53, 0, 0, 1404, 443
    
    File preloaded-classes
      - hot methods: 0 added, 0 removed
      - methods: 0 added, 0 removed
      - classes: 120 added, 214 removed
      - totals now: 0 hot methods, 0 methods, 17655 classes
      - totals before: 0 hot methods, 0 methods, 17749 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 0, 0, 14, 59, 0, 10339
        com.android, 0, 0, 15, 19, 0, 3480
        java, 0, 0, 80, 117, 0, 2098
        android.view, 0, 0, 1, 4, 0, 1130
        android.hardware, 0, 0, 3, 4, 0, 877
        android.app, 0, 0, 1, 17, 0, 1173
        android.content, 0, 0, 1, 3, 0, 637
        android.media, 0, 0, 0, 2, 0, 627
        android.net, 0, 0, 0, 6, 0, 222
    
    File boot-image-profile.txt
      - hot methods: 723 added, 890 removed
      - methods: 723 added, 890 removed
      - classes: 2 added, 80 removed
      - totals now: 22497 hot methods, 22497 methods, 14542 classes
      - totals before: 22664 hot methods, 22664 methods, 14620 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 683, 824, 2, 64, 20988, 10360
        com.android, 40, 66, 0, 14, 1412, 3095
        java, 0, 0, 0, 1, 2, 115
        android.view, 171, 223, 2, 8, 3415, 1140
        android.hardware, 2, 12, 0, 5, 484, 878
        android.animation, 59, 59, 0, 0, 413, 89
        android.app, 44, 85, 0, 15, 2936, 1178
        android.content, 56, 57, 0, 3, 1916, 641
        android.graphics, 65, 69, 0, 0, 1975, 371
        android.icu, 43, 43, 0, 0, 2048, 1485
        android.media, 3, 3, 0, 0, 792, 633
        android.net, 8, 8, 0, 6, 252, 222
        android.widget, 53, 53, 0, 0, 1404, 443
    
    File preloaded-classes
      - hot methods: 0 added, 0 removed
      - methods: 0 added, 0 removed
      - classes: 15 added, 72 removed
      - totals now: 0 hot methods, 0 methods, 14465 classes
      - totals before: 0 hot methods, 0 methods, 14522 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 0, 0, 14, 59, 0, 10308
        com.android, 0, 0, 1, 11, 0, 3072
        java, 0, 0, 0, 1, 0, 115
        android.view, 0, 0, 1, 4, 0, 1130
        android.hardware, 0, 0, 3, 4, 0, 877
        android.app, 0, 0, 1, 17, 0, 1173
        android.content, 0, 0, 1, 3, 0, 637
        android.media, 0, 0, 0, 2, 0, 627
        android.net, 0, 0, 0, 6, 0, 222
    
    File art-profile
      - hot methods: 2157 added, 4848 removed
      - methods: 2157 added, 4848 removed
      - classes: 0 added, 1547 removed
      - totals now: 9060 hot methods, 9060 methods, 57 classes
      - totals before: 11751 hot methods, 11751 methods, 1604 classes
    
      per package info as csv (selected):
        package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
        android, 5, 24, 0, 22, 47, 0
        com.android, 2152, 4824, 0, 1492, 9013, 56
        android.hardware, 4, 12, 0, 8, 42, 0
        android.app, 0, 0, 0, 2, 0, 0
        android.content, 0, 1, 0, 4, 1, 0
        android.net, 1, 7, 0, 3, 4, 0
    
    InternalReferenceRawProfileId: 38926
    InternalReferenceCandidateProfileId: 38933
    
    Test: build & benchmark
    (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b6a26a57e65e2f869c35a54fa3b91e083199dc8)
    Merged-In: Icb1d1464ad947837eeb679258af67bc4f0e9ba98
    Change-Id: Icb1d1464ad947837eeb679258af67bc4f0e9ba98
    
    NOTE FOR REVIEWERS - errors occurred while applying the patch.
    PLEASE REVIEW CAREFULLY.
    Errors:
    Error applying patch in boot/boot-image-profile.txt, hunk HunkHeader[124,19->124,19]: Hunk cannot be applied
    Error applying patch in boot/preloaded-classes, hunk HunkHeader[211,7->212,6]: Hunk cannot be applied
    Error applying patch in config/boot-image-profile.txt, hunk HunkHeader[124,19->124,19]: Hunk cannot be applied
    Error applying patch in config/preloaded-classes, hunk HunkHeader[211,7->212,6]: Hunk cannot be applied
    Error applying patch in services/art-profile, hunk HunkHeader[13,7->13,6]: Hunk cannot be applied
    
    Original patch:
     From 4b6a26a5 Mon Sep 17 00:00:00 2001
    From: art-benchmark-service <art-benchmark-service@google.com>
    Date: Fri, 22 Mar 2024 09:25:24 -0700
    Subject: [PATCH] Update boot image and system server profiles [M46C41P62S0PP]
    
    Bug: 254051423
    Bug: 324079793
    
    Test: go/art-benchmark?p=BootImageProfileId:38926&f=CandidateName:in:38933
    
    = Perf stats =
    (lower is better)
    
    Regular update to the boot image profiles which considers the latest changes in the ART module code instead of depending on the released mainline trains only. Benchmark shows a tiny improvement in App's startup time and Anon RSS+Swap and good improvement in system memory PSS and Private-dirty and almost no impact on boot Time, with a good reduction in code size.
    
                 Avg % [Confidence interval min-max %]
    App Startup:           -0.44 [-2.79, 1.9]
    App Anon RSS + Swap:   -0.83 [-1.92, 0.25]
    Memory(PSS):           -1.4 [-4.28, 1.48]
    Memory(Private-dirty): -4.48 [-13.31, 4.34]
    Boot time:              0.47 [-0.68, 1.62]
    C
    [[[Original patch trimmed due to size. Decoded string size: 6329. Decoded string SHA1: 1745d06a463192644cf1206f5ecdb8152786d3ff.]]]
    
    Change-Id: I4c2c63c3361c206b3160901fa2fff3e03dcdde5d
Code owners
Assign users and groups as approvers for specific file changes. Learn more.