Skip to content
Snippets Groups Projects
Forked from Dhina17 / platform_frameworks_base
Source project has a limited visibility.
  • Jiyong Park's avatar
    5863d8a8
    Move the dependency on protolog.conf.json.gz to services · 5863d8a8
    Jiyong Park authored
    The dependency is a "required" dependency, so it's not used for building
    framework-minus-apex. We just want that protolog.conf.json.gz is
    installed along with framework-minus-apex.
    
    This CL moves the source of the dependency from framework-minus-apex to
    services for two reasons:
    
    1. There's a dependency cycle:
      checked-protolog.json
      -> generate-protolog.json
      -> protolog-groups
      -> framework
      -> framework-minus-apex
      -> protolog.conf.json.gz
      -> services.core.json.gz
      -> checked-protolog.json
    
    Currently, this cycle is harmless because the installation of required
    modules is done by Make and Make is not checking cycles there. However,
    this is preventing Soong from implementing the installation of required
    modules by itself.
    
    2. services don't have such a dependency cycle, while
       framework-minus-apex and services are installed together.
    
    Bug: 321626681
    Test: check the existence of /system/etc/protolog.conf.json.gz in
    installed-files.txt
    
    Merged-In: Iefdd457e99fc61c1ce2f5a05ae59f5e12256a764
    Change-Id: Iefdd457e99fc61c1ce2f5a05ae59f5e12256a764
    5863d8a8
    History
    Move the dependency on protolog.conf.json.gz to services
    Jiyong Park authored
    The dependency is a "required" dependency, so it's not used for building
    framework-minus-apex. We just want that protolog.conf.json.gz is
    installed along with framework-minus-apex.
    
    This CL moves the source of the dependency from framework-minus-apex to
    services for two reasons:
    
    1. There's a dependency cycle:
      checked-protolog.json
      -> generate-protolog.json
      -> protolog-groups
      -> framework
      -> framework-minus-apex
      -> protolog.conf.json.gz
      -> services.core.json.gz
      -> checked-protolog.json
    
    Currently, this cycle is harmless because the installation of required
    modules is done by Make and Make is not checking cycles there. However,
    this is preventing Soong from implementing the installation of required
    modules by itself.
    
    2. services don't have such a dependency cycle, while
       framework-minus-apex and services are installed together.
    
    Bug: 321626681
    Test: check the existence of /system/etc/protolog.conf.json.gz in
    installed-files.txt
    
    Merged-In: Iefdd457e99fc61c1ce2f5a05ae59f5e12256a764
    Change-Id: Iefdd457e99fc61c1ce2f5a05ae59f5e12256a764
Code owners
Assign users and groups as approvers for specific file changes. Learn more.