-
- Downloads
Properly protect mFrameMetricsReporter
This field actually requires a special lock, mFrameMetricsReporterMutex. But there isn't a GUARDED_BY annotation for it. And even if there was, the compiler feature of -Wthread-safety was not active in this code, so this error would not have been caught. To fix this, enable the compiler annotation and add GUARDED_BY annotation to mFrameMetricsReporter. And finally, use this lock to properly protect this field. Bug: 192330836 Test: atest hwui_unit_tests Change-Id: I76950bfa01bbd7ccdc54c4e8c114430b5aeddf1a
Showing
- libs/hwui/Android.bp 1 addition, 0 deletionslibs/hwui/Android.bp
- libs/hwui/JankTracker.cpp 3 additions, 3 deletionslibs/hwui/JankTracker.cpp
- libs/hwui/JankTracker.h 1 addition, 1 deletionlibs/hwui/JankTracker.h
- libs/hwui/ProfileDataContainer.cpp 1 addition, 1 deletionlibs/hwui/ProfileDataContainer.cpp
- libs/hwui/ProfileDataContainer.h 3 additions, 2 deletionslibs/hwui/ProfileDataContainer.h
- libs/hwui/renderthread/CanvasContext.cpp 25 additions, 15 deletionslibs/hwui/renderthread/CanvasContext.cpp
- libs/hwui/renderthread/CanvasContext.h 6 additions, 2 deletionslibs/hwui/renderthread/CanvasContext.h
Loading
Please register or sign in to comment