Skip to content
Snippets Groups Projects
Commit 47818c0a authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "[BUG] audio: Misalignement of Native/Java AudioAttributes"

parents 7384a2ec a4fa0a91
No related branches found
No related tags found
No related merge requests found
......@@ -1433,6 +1433,8 @@ public final class AudioAttributes implements Parcelable {
return new String("AudioAttributes:"
+ " usage=" + usageToString()
+ " content=" + contentTypeToString()
+ (mSource != MediaRecorder.AudioSource.AUDIO_SOURCE_INVALID
? " source=" + MediaRecorder.toLogFriendlyAudioSource(mSource) : "")
+ " flags=0x" + Integer.toHexString(mFlags).toUpperCase()
+ " tags=" + mFormattedTags
+ " bundle=" + (mBundle == null ? "null" : mBundle.toString()));
......
......@@ -22,7 +22,6 @@ import android.annotation.SystemApi;
import android.annotation.TestApi;
import android.media.AudioAttributes;
import android.media.AudioSystem;
import android.media.MediaRecorder;
import android.os.Parcel;
import android.os.Parcelable;
import android.text.TextUtils;
......@@ -130,9 +129,7 @@ public final class AudioProductStrategy implements Parcelable {
return aa;
}
}
return new AudioAttributes.Builder()
.setContentType(AudioAttributes.CONTENT_TYPE_UNKNOWN)
.setUsage(AudioAttributes.USAGE_UNKNOWN).build();
return DEFAULT_ATTRIBUTES;
}
/**
......@@ -217,7 +214,7 @@ public final class AudioProductStrategy implements Parcelable {
@SystemApi
public @NonNull AudioAttributes getAudioAttributes() {
// We need a choice, so take the first one
return mAudioAttributesGroups.length == 0 ? (new AudioAttributes.Builder().build())
return mAudioAttributesGroups.length == 0 ? DEFAULT_ATTRIBUTES
: mAudioAttributesGroups[0].getAudioAttributes();
}
......@@ -358,8 +355,7 @@ public final class AudioProductStrategy implements Parcelable {
* Default attributes, with default source to be aligned with native.
*/
private static final @NonNull AudioAttributes DEFAULT_ATTRIBUTES =
new AudioAttributes.Builder().setCapturePreset(MediaRecorder.AudioSource.DEFAULT)
.build();
new AudioAttributes.Builder().build();
/**
* @hide
......@@ -429,8 +425,7 @@ public final class AudioProductStrategy implements Parcelable {
public @NonNull AudioAttributes getAudioAttributes() {
// We need a choice, so take the first one
return mAudioAttributes.length == 0 ? (new AudioAttributes.Builder().build())
: mAudioAttributes[0];
return mAudioAttributes.length == 0 ? DEFAULT_ATTRIBUTES : mAudioAttributes[0];
}
/**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment