Skip to content
Snippets Groups Projects
Commit 61e69fab authored by Vinh Tran's avatar Vinh Tran
Browse files

Remove uses of depfile in gensrcs modules

The depfile concept in Soong and Ninja isn't applicable in Bazel because Bazel requires listing the deps explicitly.

This CL removes the uses of depfile property and explictly declare the implicit deps in tool_files. The motivation behind this change is to eventually deprecate depfile (aosp/2120835) in gensrcs to ensure all gensrcs modules are convertable to Bazel.

Test: CI
Test: m framework-cppstream-protos && m framework-javastream-protos
Bug: 179452413
Change-Id: Iec6b61b4194d3f1e728449ee63b879818d9c958a
parent f9bf6544
No related branches found
No related tags found
No related merge requests found
......@@ -14,7 +14,6 @@
gensrcs {
name: "framework-javastream-protos",
depfile: true,
tools: [
"aprotoc",
......@@ -22,10 +21,13 @@ gensrcs {
"soong_zip",
],
tool_files: [
":libprotobuf-internal-protos",
],
cmd: "mkdir -p $(genDir)/$(in) " +
"&& $(location aprotoc) " +
" --plugin=$(location protoc-gen-javastream) " +
" --dependency_out=$(depfile) " +
" --javastream_out=$(genDir)/$(in) " +
" -Iexternal/protobuf/src " +
" -I . " +
......@@ -47,17 +49,19 @@ gensrcs {
gensrcs {
name: "framework-cppstream-protos",
depfile: true,
tools: [
"aprotoc",
"protoc-gen-cppstream",
],
tool_files: [
":libprotobuf-internal-protos",
],
cmd: "mkdir -p $(genDir) " +
"&& $(location aprotoc) " +
" --plugin=$(location protoc-gen-cppstream) " +
" --dependency_out=$(depfile) " +
" --cppstream_out=$(genDir) " +
" -Iexternal/protobuf/src " +
" -I . " +
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment