Fix wrong Choreographer used for setting vsyncId in cross-activity predictive back
The constructor of CrossActivityBackAnimation is not called from the wmshell.main thread. Therefore we should not set the Choreographer from the constructor. Bug: 343039961 Flag: com.android.window.flags.predictive_back_system_anims Test: Manual, i.e. logging Choreographer instances and veryfying that they're accessed from wmshell.main thread. Also verified in perfetto that traces look smooth now. (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:21b9fd55f7b50bc40a6fe9b5b6c6cd88d24b4346) Merged-In: Iead236279ea0f46acde23f16bb230ff324f453f3 Change-Id: Iead236279ea0f46acde23f16bb230ff324f453f3
Showing
- libs/WindowManager/Shell/src/com/android/wm/shell/back/CrossActivityBackAnimation.kt 5 additions, 4 deletions...c/com/android/wm/shell/back/CrossActivityBackAnimation.kt
- libs/WindowManager/Shell/src/com/android/wm/shell/back/CustomCrossActivityBackAnimation.kt 1 addition, 7 deletions...android/wm/shell/back/CustomCrossActivityBackAnimation.kt
- libs/WindowManager/Shell/src/com/android/wm/shell/back/DefaultCrossActivityBackAnimation.kt 1 addition, 5 deletions...ndroid/wm/shell/back/DefaultCrossActivityBackAnimation.kt
- libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/back/CustomCrossActivityBackAnimationTest.kt 2 additions, 5 deletions...oid/wm/shell/back/CustomCrossActivityBackAnimationTest.kt
Loading
Please register or sign in to comment